From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: [PATCH 6/8] tests/tcg: ensure system-mode gdb tests start stopped
Date: Thu, 10 Aug 2023 16:36:38 +0100 [thread overview]
Message-ID: <20230810153640.1879717-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230810153640.1879717-1-alex.bennee@linaro.org>
Without -S we run into potential races with tests starting before the
gdbstub attaches. We don't need to worry about user-mode as enabling
the gdbstub implies we wait for the initial connection.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/guest-debug/run-test.py | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tests/guest-debug/run-test.py b/tests/guest-debug/run-test.py
index c0d0075e2e..b13b27d4b1 100755
--- a/tests/guest-debug/run-test.py
+++ b/tests/guest-debug/run-test.py
@@ -69,13 +69,10 @@ def log(output, msg):
# Launch QEMU with binary
if "system" in args.qemu:
- cmd = "%s %s %s -gdb unix:path=%s,server=on" % (args.qemu,
- args.qargs,
- args.binary,
- socket_name)
+ cmd = f'{args.qemu} {args.qargs} {args.binary}' \
+ f' -S -gdb unix:path={socket_name},server=on'
else:
- cmd = "%s %s -g %s %s" % (args.qemu, args.qargs, socket_name,
- args.binary)
+ cmd = f'{args.qemu} {args.qargs} -g {socket_name} {args.binary}'
log(output, "QEMU CMD: %s" % (cmd))
inferior = subprocess.Popen(shlex.split(cmd))
--
2.39.2
next prev parent reply other threads:[~2023-08-10 15:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 15:36 [PATCH 0/8] some testing and gdbstub fixes Alex Bennée
2023-08-10 15:36 ` [PATCH 1/8] gitlab: enable ccache for many build jobs Alex Bennée
2023-08-10 15:36 ` [PATCH 2/8] tests/docker: cleanup non-verbose output Alex Bennée
2023-08-14 7:59 ` Thomas Huth
2023-08-10 15:36 ` [PATCH 3/8] tests/tcg: remove quoting for info output Alex Bennée
2023-08-10 15:36 ` [PATCH 4/8] tests: remove test-gdbstub.py Alex Bennée
2023-08-10 17:10 ` Richard Henderson
2023-08-10 15:36 ` [PATCH 5/8] tests/tcg: clean-up gdb confirm/pagination settings Alex Bennée
2023-08-10 15:47 ` Philippe Mathieu-Daudé
2023-08-10 17:08 ` Richard Henderson
2023-08-10 15:36 ` Alex Bennée [this message]
2023-08-10 15:48 ` [PATCH 6/8] tests/tcg: ensure system-mode gdb tests start stopped Philippe Mathieu-Daudé
2023-08-10 17:08 ` Richard Henderson
2023-08-10 15:36 ` [PATCH 7/8] gdbstub: more fixes for client Ctrl-C handling Alex Bennée
2023-08-10 15:56 ` Philippe Mathieu-Daudé
2023-08-10 16:26 ` Richard Henderson
2023-08-10 15:36 ` [PATCH 8/8] gdbstub: don't complain about preemptive ACK chars Alex Bennée
2023-08-10 15:50 ` Philippe Mathieu-Daudé
2023-08-10 15:58 ` [PATCH 0/8] some testing and gdbstub fixes Peter Maydell
2023-08-10 16:35 ` Alex Bennée
2023-08-10 16:43 ` Richard Henderson
2023-08-10 17:33 ` Richard Henderson
2023-08-10 16:35 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810153640.1879717-7-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=luoyonggang@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).