From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: util/async-teardown.c: is it really needed for --disable-system build?
Date: Mon, 14 Aug 2023 09:27:25 +0200 [thread overview]
Message-ID: <20230814092725.7181c072@p-imbrenda> (raw)
In-Reply-To: <97d04dd0-6182-9b61-576c-1a29f856e2c4@tls.msk.ru>
On Mon, 14 Aug 2023 10:12:35 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:
> 14.08.2023 10:01, Claudio Imbrenda wrote:
>
> > I think we could guard the offending item with CONFIG_SOFTMMU for now,
> > to immediately fix the issues you raised, and do the refactoring you
> > proposed later (e.g. next cycle).
>
> I don't think rushing for the last-minute fix is necessary in this case.
yes and no
it's a bug (which I introduced), and the quick fix seems to be
easy enough, so why not?
> It has real build problem on ia64 only which does not work for several
> releases anyway, and the linking of unnecessary pieces happened for a
> long time too.
>
> /mjt
next prev parent reply other threads:[~2023-08-14 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 9:38 util/async-teardown.c: is it really needed for --disable-system build? Michael Tokarev
2023-08-12 9:48 ` Michael Tokarev
2023-08-14 7:01 ` Claudio Imbrenda
2023-08-14 7:12 ` Michael Tokarev
2023-08-14 7:27 ` Claudio Imbrenda [this message]
2023-08-14 8:31 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814092725.7181c072@p-imbrenda \
--to=imbrenda@linux.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).