From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
peterx@redhat.com, "Juan Quintela" <quintela@redhat.com>
Subject: [PATCH for-8.2 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash
Date: Mon, 14 Aug 2023 18:19:43 -0400 [thread overview]
Message-ID: <20230814221947.353093-1-peterx@redhat.com> (raw)
Patch 1 fixes the tls-authz crashing when someone specifies "null"
parameter for tls-authz.
Patch 2 added a test case for all three tls-auth parameters specifying
"null" to make sure nothing will crash ever with 'null' passed into it.
Patch 3-4 are the proposed patches to deduplicate the three migration
parameter objects in qapi/migration.json. Note that in this version (patch
3) we used 'str' to replace 'StrOrNull' for tls-* parameters to make then
deduplicate-able.
Please review, thanks.
Peter Xu (4):
migration/qmp: Fix crash on setting tls-authz with null
tests/migration-test: Add a test for null parameter setups
migration/qapi: Replace @MigrateSetParameters with
@MigrationParameters
migration/qapi: Drop @MigrationParameter enum
qapi/migration.json | 364 +--------------------------------
migration/options.h | 47 +++++
migration/migration-hmp-cmds.c | 19 +-
migration/options.c | 191 ++++++-----------
tests/qtest/migration-test.c | 24 +++
5 files changed, 136 insertions(+), 509 deletions(-)
--
2.41.0
next reply other threads:[~2023-08-14 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 22:19 Peter Xu [this message]
2023-08-14 22:19 ` [PATCH for-8.2 1/4] migration/qmp: Fix crash on setting tls-authz with null Peter Xu
2023-08-15 12:47 ` Fabiano Rosas
2023-08-17 13:14 ` Daniel P. Berrangé
2023-08-14 22:19 ` [PATCH for-8.2 2/4] tests/migration-test: Add a test for null parameter setups Peter Xu
2023-08-15 12:46 ` Fabiano Rosas
2023-08-14 22:19 ` [PATCH for-8.2 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters Peter Xu
2023-08-23 13:26 ` Markus Armbruster
2023-08-23 15:52 ` Peter Xu
2023-08-25 17:14 ` Peter Xu
2023-08-14 22:19 ` [PATCH for-8.2 4/4] migration/qapi: Drop @MigrationParameter enum Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814221947.353093-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=lsoaresp@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).