From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33104C001DB for ; Mon, 14 Aug 2023 22:54:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVgRb-0002Yb-Rh; Mon, 14 Aug 2023 18:53:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVgQo-0002Ut-Ir; Mon, 14 Aug 2023 18:53:02 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVgQm-0003hy-KB; Mon, 14 Aug 2023 18:53:02 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37EMc9Y0025676; Mon, 14 Aug 2023 22:52:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=Q/zwCImqH2+XMheVlDC1IpvG7XtuOgsorHO45KzoNlk=; b=JgjxmCh55ljWCK5Df6z4mpm99/c8AOm3As+TD/dE5TJ/IeNxWQzGU0t3tBYmR/v0bSVz NAo0aaWOCNIEBz7ZZf30ojiIq5v2v3vo9BcpVCrdKKfR9OPt8+OkvO1o9fJpb1bKFQpB 49frSb9w7ENS894IIAiBp9aGuI3BvZpfJ8YD2BLAQ3CpvJCMVCWBIElbHah4vIyY7qhK +2dI0LTL9Rw6qhjgFujCPXN4UP1WEz0V8s04O2d7qjjHJWvExYbTzLiylmRYjg82+e8R 75LhrllIzQ/93repgFr4DBXJUPkiIA6ifRuZfI0HlFkR9WQ/W/ImUQPGxRQE6LDWtM1a 6g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sfvmk94st-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 22:52:56 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 37EMjLrc011592; Mon, 14 Aug 2023 22:52:55 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sfvmk94sk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 22:52:55 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37EKRlNe001119; Mon, 14 Aug 2023 22:52:54 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3semsy0k5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Aug 2023 22:52:54 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37EMqoo846399948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Aug 2023 22:52:51 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E3D5520043; Mon, 14 Aug 2023 22:52:50 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6ACDE20040; Mon, 14 Aug 2023 22:52:50 +0000 (GMT) Received: from li-ce58cfcc-320b-11b2-a85c-85e19b5285e0 (unknown [9.171.80.114]) by smtpav07.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 14 Aug 2023 22:52:50 +0000 (GMT) Date: Tue, 15 Aug 2023 00:52:48 +0200 From: Halil Pasic To: Thomas Huth Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Christian Borntraeger , Cornelia Huck , Halil Pasic Subject: Re: [PATCH for-8.2] hw/s390x/s390-virtio-ccw: Remove superfluous code to set the NIC model Message-ID: <20230815005248.3af4ca74.pasic@linux.ibm.com> In-Reply-To: <20230804073525.11857-1-thuth@redhat.com> References: <20230804073525.11857-1-thuth@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: j6KL-zv112iidQ7Axpn_Cr4LIx6nTppo X-Proofpoint-ORIG-GUID: sli1ixwQ1KCcrnJWoZNqQQaesYUNZtlL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-14_18,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1011 malwarescore=0 mlxlogscore=693 suspectscore=0 phishscore=0 priorityscore=1501 impostorscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308140206 Received-SPF: pass client-ip=148.163.156.1; envelope-from=pasic@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 4 Aug 2023 09:35:25 +0200 Thomas Huth wrote: > The check for nd->model being NULL was originally required, but in > commit e11f463295d95aba ("s390x/virtio: use qemu_check_nic_model()") > the corresponding code had been replaced by a call to the function > qemu_check_nic_model() - and this in turn calls qemu_find_nic_model() > which contains the same check for nd->model being NULL again. So we > can remove this from the calling site now. > > Signed-off-by: Thomas Huth Reviewed-by: Halil Pasic