qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>, <qemu-block@nongnu.org>,
	Julia Suvorova <jusual@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH 0/2] virtio-blk: use blk_io_plug_call() instead of notification BH
Date: Tue, 15 Aug 2023 08:08:03 -0400	[thread overview]
Message-ID: <20230815120805.3235166-1-stefanha@redhat.com> (raw)

Replace the seldom-used virtio-blk notification BH mechanism with
blk_io_plug(). This is part of an effort to enable the multi-queue block layer
in virtio-blk. The notification BH was not multi-queue friendly.

The blk_io_plug() mechanism improves fio rw=randread bs=4k iodepth=64 numjobs=8
IOPS by ~9% with a single IOThread and 8 vCPUs (this is not even a multi-queue
block layer configuration) compared to no completion batching. iodepth=1
decreases by ~1% but this could be noise. Benchmark details are available here:
https://gitlab.com/stefanha/virt-playbooks/-/tree/blk_io_plug-irqfd

Stefan Hajnoczi (2):
  virtio: use blk_io_plug_call() in virtio_irqfd_notify()
  virtio-blk: remove batch notification BH

 block/io_uring.c                |  6 +++++
 block/linux-aio.c               |  4 +++
 hw/block/dataplane/virtio-blk.c | 48 +--------------------------------
 hw/virtio/virtio.c              | 10 ++++++-
 4 files changed, 20 insertions(+), 48 deletions(-)

-- 
2.41.0



             reply	other threads:[~2023-08-15 12:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 12:08 Stefan Hajnoczi [this message]
2023-08-15 12:08 ` [PATCH 1/2] virtio: use blk_io_plug_call() in virtio_irqfd_notify() Stefan Hajnoczi
2023-08-16 13:36   ` Ilya Maximets
2023-08-16 15:30     ` Stefan Hajnoczi
2023-08-16 18:30       ` Ilya Maximets
2023-08-16 21:16         ` Stefan Hajnoczi
2023-08-15 12:08 ` [PATCH 2/2] virtio-blk: remove batch notification BH Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230815120805.3235166-1-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jusual@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mehta.aaru20@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).