qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
	marcandre.lureau@redhat.com, dongwon.kim@intel.com,
	kraxel@redhat.com
Subject: [PATCH for-8.1] vfio/display: Fix missing update to set backing fields
Date: Wed, 16 Aug 2023 15:55:49 -0600	[thread overview]
Message-ID: <20230816215550.1723696-1-alex.williamson@redhat.com> (raw)

The below referenced commit renames scanout_width/height to
backing_width/height, but also promotes these fields in various portions
of the egl interface.  Meanwhile vfio dmabuf support has never used the
previous scanout fields and is therefore missed in the update.  This
results in a black screen when transitioning from ramfb to dmabuf display
when using Intel vGPU with these features.

Link: https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg02726.html
Fixes: 9ac06df8b684 ("virtio-gpu-udmabuf: correct naming of QemuDmaBuf size properties")
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

This fixes a regression in dmabuf/EGL support for Intel GVT-g and
potentially the mbochs mdev driver as well.  Once validated by those
that understand dmabuf/EGL integration, I'd welcome QEMU maintainers to
take this directly for v8.1 or queue it as soon as possible for v8.1.1.

 hw/vfio/display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/vfio/display.c b/hw/vfio/display.c
index bec864f482f4..837d9e6a309e 100644
--- a/hw/vfio/display.c
+++ b/hw/vfio/display.c
@@ -243,6 +243,8 @@ static VFIODMABuf *vfio_display_get_dmabuf(VFIOPCIDevice *vdev,
     dmabuf->dmabuf_id  = plane.dmabuf_id;
     dmabuf->buf.width  = plane.width;
     dmabuf->buf.height = plane.height;
+    dmabuf->buf.backing_width = plane.width;
+    dmabuf->buf.backing_height = plane.height;
     dmabuf->buf.stride = plane.stride;
     dmabuf->buf.fourcc = plane.drm_format;
     dmabuf->buf.modifier = plane.drm_format_mod;
-- 
2.40.1



             reply	other threads:[~2023-08-16 21:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 21:55 Alex Williamson [this message]
2023-08-16 22:31 ` [PATCH for-8.1] vfio/display: Fix missing update to set backing fields Philippe Mathieu-Daudé
2023-08-17 16:28   ` Kim, Dongwon
2023-09-04 11:06     ` Marc-André Lureau
2023-09-04 14:11       ` Alex Williamson
2023-09-04 17:00         ` Marc-André Lureau
2023-09-05 15:09           ` Alex Williamson
2023-09-13 19:18             ` Alex Williamson
2023-09-22  9:38               ` Cédric Le Goater
2023-09-22  9:49                 ` Michael Tokarev
2023-09-22 11:10                   ` Cédric Le Goater
2023-10-03 17:03                 ` Michael Tokarev
2023-10-03 21:17                   ` Cédric Le Goater
  -- strict thread matches above, loose matches on Subject: below --
2023-10-14  9:09 Edmund Raile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230816215550.1723696-1-alex.williamson@redhat.com \
    --to=alex.williamson@redhat.com \
    --cc=dongwon.kim@intel.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).