qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gurchetan Singh <gurchetansingh@chromium.org>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, kraxel@redhat.com,
	akihiko.odaki@gmail.com, ray.huang@amd.com,
	alex.bennee@linaro.org, shentey@gmail.com, hi@alyssa.is,
	ernunes@redhat.com, manos.pitsidianakis@linaro.org
Subject: [PATCH v7 8/9] gfxstream + rutabaga: enable rutabaga
Date: Wed, 16 Aug 2023 19:23:21 -0700	[thread overview]
Message-ID: <20230817022322.466-9-gurchetansingh@google.com> (raw)
In-Reply-To: <20230817022322.466-1-gurchetansingh@google.com>

From: Gurchetan Singh <gurchetansingh@chromium.org>

This change enables rutabaga to receive virtio-gpu-3d hypercalls
when it is active.

Signed-off-by: Gurchetan Singh <gurchetansingh@chromium.org>
Tested-by: Alyssa Ross <hi@alyssa.is>
Tested-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
---
v3: Whitespace fix (Akihiko)

 hw/display/virtio-gpu-base.c | 3 ++-
 hw/display/virtio-gpu.c      | 5 +++--
 softmmu/qdev-monitor.c       | 3 +++
 softmmu/vl.c                 | 1 +
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c
index 4f2b0ba1f3..50c5373b65 100644
--- a/hw/display/virtio-gpu-base.c
+++ b/hw/display/virtio-gpu-base.c
@@ -223,7 +223,8 @@ virtio_gpu_base_get_features(VirtIODevice *vdev, uint64_t features,
 {
     VirtIOGPUBase *g = VIRTIO_GPU_BASE(vdev);
 
-    if (virtio_gpu_virgl_enabled(g->conf)) {
+    if (virtio_gpu_virgl_enabled(g->conf) ||
+        virtio_gpu_rutabaga_enabled(g->conf)) {
         features |= (1 << VIRTIO_GPU_F_VIRGL);
     }
     if (virtio_gpu_edid_enabled(g->conf)) {
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index 3e658f1fef..08e170e029 100644
--- a/hw/display/virtio-gpu.c
+++ b/hw/display/virtio-gpu.c
@@ -1361,8 +1361,9 @@ void virtio_gpu_device_realize(DeviceState *qdev, Error **errp)
     VirtIOGPU *g = VIRTIO_GPU(qdev);
 
     if (virtio_gpu_blob_enabled(g->parent_obj.conf)) {
-        if (!virtio_gpu_have_udmabuf()) {
-            error_setg(errp, "cannot enable blob resources without udmabuf");
+        if (!virtio_gpu_have_udmabuf() &&
+            !virtio_gpu_rutabaga_enabled(g->parent_obj.conf)) {
+            error_setg(errp, "need udmabuf or rutabaga for blob resources");
             return;
         }
 
diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index 74f4e41338..1b8005ae55 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -86,6 +86,9 @@ static const QDevAlias qdev_alias_table[] = {
     { "virtio-gpu-pci", "virtio-gpu", QEMU_ARCH_VIRTIO_PCI },
     { "virtio-gpu-gl-device", "virtio-gpu-gl", QEMU_ARCH_VIRTIO_MMIO },
     { "virtio-gpu-gl-pci", "virtio-gpu-gl", QEMU_ARCH_VIRTIO_PCI },
+    { "virtio-gpu-rutabaga-device", "virtio-gpu-rutabaga",
+      QEMU_ARCH_VIRTIO_MMIO },
+    { "virtio-gpu-rutabaga-pci", "virtio-gpu-rutabaga", QEMU_ARCH_VIRTIO_PCI },
     { "virtio-input-host-device", "virtio-input-host", QEMU_ARCH_VIRTIO_MMIO },
     { "virtio-input-host-ccw", "virtio-input-host", QEMU_ARCH_VIRTIO_CCW },
     { "virtio-input-host-pci", "virtio-input-host", QEMU_ARCH_VIRTIO_PCI },
diff --git a/softmmu/vl.c b/softmmu/vl.c
index b0b96f67fa..2f98eefdf3 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -216,6 +216,7 @@ static struct {
     { .driver = "ati-vga",              .flag = &default_vga       },
     { .driver = "vhost-user-vga",       .flag = &default_vga       },
     { .driver = "virtio-vga-gl",        .flag = &default_vga       },
+    { .driver = "virtio-vga-rutabaga",  .flag = &default_vga       },
 };
 
 static QemuOptsList qemu_rtc_opts = {
-- 
2.42.0.rc1.204.g551eb34607-goog



  parent reply	other threads:[~2023-08-17  2:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  2:23 [PATCH v7 0/9] gfxstream + rutabaga_gfx Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 1/9] virtio: Add shared memory capability Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 2/9] virtio-gpu: CONTEXT_INIT feature Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 3/9] virtio-gpu: hostmem Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 4/9] virtio-gpu: blob prep Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options Gurchetan Singh
2023-08-23 14:32   ` Mark Cave-Ayland
2023-08-24 23:47     ` Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 6/9] gfxstream + rutabaga: add initial support for gfxstream Gurchetan Singh
2023-08-18 11:58   ` Akihiko Odaki
2023-08-23 15:03   ` Mark Cave-Ayland
2023-08-24 23:50     ` Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 7/9] gfxstream + rutabaga: meson support Gurchetan Singh
2023-08-17  2:23 ` Gurchetan Singh [this message]
2023-08-18 11:58   ` [PATCH v7 8/9] gfxstream + rutabaga: enable rutabaga Akihiko Odaki
2023-08-19  1:14     ` Gurchetan Singh
2023-08-17  2:23 ` [PATCH v7 9/9] docs/system: add basic virtio-gpu documentation Gurchetan Singh
2023-08-17  5:28   ` Akihiko Odaki
2023-08-17 23:43     ` [PATCH v8 " Gurchetan Singh
2023-08-17 23:47     ` [PATCH v7 " Gurchetan Singh
2023-08-18 12:08       ` Akihiko Odaki
2023-08-19  1:17         ` Gurchetan Singh
2023-08-19  6:13           ` Akihiko Odaki
2023-08-22  0:20             ` Gurchetan Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230817022322.466-9-gurchetansingh@google.com \
    --to=gurchetansingh@chromium.org \
    --cc=akihiko.odaki@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=ernunes@redhat.com \
    --cc=hi@alyssa.is \
    --cc=kraxel@redhat.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ray.huang@amd.com \
    --cc=shentey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).