qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PATCH 02/33] linux-user: Adjust SVr4 NULL page mapping
Date: Fri, 18 Aug 2023 10:11:56 -0700	[thread overview]
Message-ID: <20230818171227.141728-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230818171227.141728-1-richard.henderson@linaro.org>

Use TARGET_PAGE_SIZE and MAP_FIXED_NOREPLACE.

We really should be attending to this earlier during
probe_guest_base, as well as better detection and
emulation of various Linux personalities.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/elfload.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index ccfbf82836..9865f5e825 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -3749,8 +3749,9 @@ int load_elf_binary(struct linux_binprm *bprm, struct image_info *info)
                and some applications "depend" upon this behavior.  Since
                we do not have the power to recompile these, we emulate
                the SVr4 behavior.  Sigh.  */
-            target_mmap(0, qemu_host_page_size, PROT_READ | PROT_EXEC,
-                        MAP_FIXED | MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+            target_mmap(0, TARGET_PAGE_SIZE, PROT_READ | PROT_EXEC,
+                        MAP_FIXED_NOREPLACE | MAP_PRIVATE | MAP_ANONYMOUS,
+                        -1, 0);
         }
 #ifdef TARGET_MIPS
         info->interp_fp_abi = interp_info.fp_abi;
-- 
2.34.1



  parent reply	other threads:[~2023-08-18 17:15 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 17:11 [PATCH 00/33] linux-user: Improve host and guest page size handling Richard Henderson
2023-08-18 17:11 ` [PATCH 01/33] accel/tcg: Remove qemu_host_page_size from page_protect/page_unprotect Richard Henderson
2023-08-18 17:11 ` Richard Henderson [this message]
2023-08-18 17:11 ` [PATCH 03/33] linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base Richard Henderson
2023-08-18 17:11 ` [PATCH 04/33] linux-user: Remove qemu_host_page_size from create_elf_tables Richard Henderson
2023-08-18 17:11 ` [PATCH 05/33] linux-user/hppa: Simplify init_guest_commpage Richard Henderson
2023-08-18 17:12 ` [PATCH 06/33] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage Richard Henderson
2023-08-18 17:12 ` [PATCH 07/33] linux-user/arm: " Richard Henderson
2023-08-18 17:12 ` [PATCH 08/33] linux-user: Remove qemu_host_page_{size, mask} from mmap.c Richard Henderson
2023-08-18 17:12 ` [PATCH 09/33] linux-user: Remove REAL_HOST_PAGE_ALIGN " Richard Henderson
2023-08-21  7:08   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 10/33] linux-user: Remove HOST_PAGE_ALIGN " Richard Henderson
2023-08-18 17:12 ` [PATCH 11/33] migration: Remove qemu_host_page_size Richard Henderson
2023-08-18 17:12 ` [PATCH 12/33] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init Richard Henderson
2023-08-18 17:12 ` [PATCH 13/33] softmmu/physmem: Remove qemu_host_page_size Richard Henderson
2023-08-18 17:12 ` [PATCH 14/33] softmmu/physmem: Remove HOST_PAGE_ALIGN Richard Henderson
2023-08-18 17:12 ` [PATCH 15/33] linux-user: Remove qemu_host_page_size from main Richard Henderson
2023-08-18 17:12 ` [PATCH 16/33] linux-user: Split out target_mmap__locked Richard Henderson
2023-08-21  6:43   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 17/33] linux-user: Move some mmap checks outside the lock Richard Henderson
2023-08-21  6:47   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 18/33] linux-user: Fix sub-host-page mmap Richard Henderson
2023-08-18 17:12 ` [PATCH 19/33] linux-user: Split out mmap_end Richard Henderson
2023-08-21  6:49   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 20/33] linux-user: Do early mmap placement only for reserved_va Richard Henderson
2023-08-18 17:12 ` [PATCH 21/33] linux-user: Split out mmap_h_eq_g Richard Henderson
2023-08-18 17:12 ` [PATCH 22/33] linux-user: Split out mmap_h_lt_g Richard Henderson
2023-08-18 17:12 ` [PATCH 23/33] linux-user: Split out mmap_h_gt_g Richard Henderson
2023-08-18 17:12 ` [PATCH 24/33] tests/tcg: Remove run-test-mmap-* Richard Henderson
2023-08-18 17:12 ` [PATCH 25/33] tests/tcg: Extend file in linux-madvise.c Richard Henderson
2023-08-21  6:54   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 26/33] linux-user: Deprecate and disable -p pagesize Richard Henderson
2023-08-21  6:58   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 27/33] cpu: Remove page_size_init Richard Henderson
2023-08-21  7:00   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 28/33] accel/tcg: Disconnect TargetPageDataNode from page size Richard Henderson
2023-08-21  7:03   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 29/33] linux-user: Allow TARGET_PAGE_BITS_VARY Richard Henderson
2023-08-18 17:12 ` [PATCH 30/33] target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only Richard Henderson
2023-08-21  7:05   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 31/33] linux-user: Bound mmap_min_addr by host page size Richard Henderson
2023-08-18 17:12 ` [PATCH 32/33] target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only Richard Henderson
2023-08-21  7:06   ` Philippe Mathieu-Daudé
2023-08-18 17:12 ` [PATCH 33/33] target/alpha: " Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818171227.141728-3-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).