From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: imp@bsdimp.com
Subject: [PATCH 3/3] bsd-user: Remove image_info.start_brk
Date: Fri, 18 Aug 2023 10:57:36 -0700 [thread overview]
Message-ID: <20230818175736.144194-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230818175736.144194-1-richard.henderson@linaro.org>
This has the same value is image_info.brk, which is also logged,
and is otherwise unused.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
bsd-user/qemu.h | 1 -
bsd-user/elfload.c | 2 +-
bsd-user/main.c | 2 --
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 898fe3e8b3..61501c321b 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -50,7 +50,6 @@ struct image_info {
abi_ulong end_code;
abi_ulong start_data;
abi_ulong end_data;
- abi_ulong start_brk;
abi_ulong brk;
abi_ulong rss;
abi_ulong start_stack;
diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c
index 2d39e59258..baf2f63d2f 100644
--- a/bsd-user/elfload.c
+++ b/bsd-user/elfload.c
@@ -811,7 +811,7 @@ int load_elf_binary(struct bsd_binprm *bprm, struct target_pt_regs *regs,
bprm->stringp, &elf_ex, load_addr,
et_dyn_addr, interp_load_addr, info);
info->load_addr = reloc_func_desc;
- info->start_brk = info->brk = elf_brk;
+ info->brk = elf_brk;
info->start_stack = bprm->p;
info->load_bias = 0;
diff --git a/bsd-user/main.c b/bsd-user/main.c
index 381bb18df8..f913cb55a7 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -553,8 +553,6 @@ int main(int argc, char **argv)
fprintf(f, "page layout changed following binary load\n");
page_dump(f);
- fprintf(f, "start_brk 0x" TARGET_ABI_FMT_lx "\n",
- info->start_brk);
fprintf(f, "end_code 0x" TARGET_ABI_FMT_lx "\n",
info->end_code);
fprintf(f, "start_code 0x" TARGET_ABI_FMT_lx "\n",
--
2.34.1
next prev parent reply other threads:[~2023-08-18 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 17:57 [PATCH 0/3] bsd-user: image_info cleanups Richard Henderson
2023-08-18 17:57 ` [PATCH 1/3] bsd-user: Remove ELF_START_MMAP and image_info.start_mmap Richard Henderson
2023-08-18 18:19 ` Warner Losh
2023-08-18 17:57 ` [PATCH 2/3] bsd-user: Remove image_info.mmap Richard Henderson
2023-08-18 18:20 ` Warner Losh
2023-08-18 17:57 ` Richard Henderson [this message]
2023-08-18 18:22 ` [PATCH 3/3] bsd-user: Remove image_info.start_brk Warner Losh
2023-08-18 21:34 ` Richard Henderson
2023-08-18 18:24 ` [PATCH 0/3] bsd-user: image_info cleanups Warner Losh
2023-08-19 10:44 ` Philippe Mathieu-Daudé
2023-08-20 4:53 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818175736.144194-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=imp@bsdimp.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).