qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, ardb@kernel.org
Subject: [PATCH v2 12/18] target/ppc: Use clmul_32* routines
Date: Fri, 18 Aug 2023 18:02:12 -0700	[thread overview]
Message-ID: <20230819010218.192706-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230819010218.192706-1-richard.henderson@linaro.org>

Use generic routines for 32-bit carry-less multiply.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/ppc/int_helper.c | 26 ++++++--------------------
 1 file changed, 6 insertions(+), 20 deletions(-)

diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
index 10e19d8c9b..ce793cf163 100644
--- a/target/ppc/int_helper.c
+++ b/target/ppc/int_helper.c
@@ -1446,28 +1446,14 @@ void helper_vpmsumh(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
     }
 }
 
-#define PMSUM(name, srcfld, trgfld, trgtyp)                   \
-void helper_##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)  \
-{                                                             \
-    int i, j;                                                 \
-    trgtyp prod[sizeof(ppc_avr_t) / sizeof(a->srcfld[0])];    \
-                                                              \
-    VECTOR_FOR_INORDER_I(i, srcfld) {                         \
-        prod[i] = 0;                                          \
-        for (j = 0; j < sizeof(a->srcfld[0]) * 8; j++) {      \
-            if (a->srcfld[i] & (1ull << j)) {                 \
-                prod[i] ^= ((trgtyp)b->srcfld[i] << j);       \
-            }                                                 \
-        }                                                     \
-    }                                                         \
-                                                              \
-    VECTOR_FOR_INORDER_I(i, trgfld) {                         \
-        r->trgfld[i] = prod[2 * i] ^ prod[2 * i + 1];         \
-    }                                                         \
+void helper_vpmsumw(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
+{
+    for (int i = 0; i < 2; ++i) {
+        uint64_t aa = a->u64[i], bb = b->u64[i];
+        r->u64[i] = clmul_32(aa, bb) ^ clmul_32(aa >> 32, bb >> 32);
+    }
 }
 
-PMSUM(vpmsumw, u32, u64, uint64_t)
-
 void helper_VPMSUMD(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
 {
     int i, j;
-- 
2.34.1



  parent reply	other threads:[~2023-08-19  1:04 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19  1:02 [PATCH v2 00/18] crypto: Provide clmul.h and host accel Richard Henderson
2023-08-19  1:02 ` [PATCH v2 01/18] crypto: Add generic 8-bit carry-less multiply routines Richard Henderson
2023-09-10 12:19   ` Ard Biesheuvel
2023-08-19  1:02 ` [PATCH v2 02/18] target/arm: Use clmul_8* routines Richard Henderson
2023-08-21  7:49   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 03/18] target/s390x: " Richard Henderson
2023-08-21 12:45   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 04/18] target/ppc: " Richard Henderson
2023-08-19  1:02 ` [PATCH v2 05/18] crypto: Add generic 16-bit carry-less multiply routines Richard Henderson
2023-09-10 12:22   ` Ard Biesheuvel
2023-08-19  1:02 ` [PATCH v2 06/18] target/arm: Use clmul_16* routines Richard Henderson
2023-08-21  7:51   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 07/18] target/s390x: " Richard Henderson
2023-08-21 12:44   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 08/18] target/ppc: " Richard Henderson
2023-08-19  1:02 ` [PATCH v2 09/18] crypto: Add generic 32-bit carry-less multiply routines Richard Henderson
2023-09-10 12:23   ` Ard Biesheuvel
2023-08-19  1:02 ` [PATCH v2 10/18] target/arm: Use clmul_32* routines Richard Henderson
2023-08-21  7:53   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 11/18] target/s390x: " Richard Henderson
2023-08-21 12:39   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` Richard Henderson [this message]
2023-08-19  1:02 ` [PATCH v2 13/18] crypto: Add generic 64-bit carry-less multiply routine Richard Henderson
2023-08-19  1:02 ` [PATCH v2 14/18] target/arm: Use clmul_64 Richard Henderson
2023-08-21 12:27   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 15/18] target/s390x: " Richard Henderson
2023-08-21 12:33   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 16/18] target/ppc: " Richard Henderson
2023-08-21 12:34   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 17/18] host/include/i386: Implement clmul.h Richard Henderson
2023-08-19  1:02 ` [PATCH v2 18/18] host/include/aarch64: " Richard Henderson
2023-08-21 14:57 ` [PATCH v2 00/18] crypto: Provide clmul.h and host accel Ard Biesheuvel
2023-08-21 15:14   ` Richard Henderson
2023-08-21 15:44     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230819010218.192706-13-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=ardb@kernel.org \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).