qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, ardb@kernel.org
Subject: [PATCH v2 16/18] target/ppc: Use clmul_64
Date: Fri, 18 Aug 2023 18:02:16 -0700	[thread overview]
Message-ID: <20230819010218.192706-17-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230819010218.192706-1-richard.henderson@linaro.org>

Use generic routine for 64-bit carry-less multiply.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/ppc/int_helper.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
index ce793cf163..432834c7d5 100644
--- a/target/ppc/int_helper.c
+++ b/target/ppc/int_helper.c
@@ -1456,20 +1456,9 @@ void helper_vpmsumw(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
 
 void helper_VPMSUMD(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
 {
-    int i, j;
-    Int128 tmp, prod[2] = {int128_zero(), int128_zero()};
-
-    for (j = 0; j < 64; j++) {
-        for (i = 0; i < ARRAY_SIZE(r->u64); i++) {
-            if (a->VsrD(i) & (1ull << j)) {
-                tmp = int128_make64(b->VsrD(i));
-                tmp = int128_lshift(tmp, j);
-                prod[i] = int128_xor(prod[i], tmp);
-            }
-        }
-    }
-
-    r->s128 = int128_xor(prod[0], prod[1]);
+    Int128 e = clmul_64(a->u64[0], b->u64[0]);
+    Int128 o = clmul_64(a->u64[1], b->u64[1]);
+    r->s128 = int128_xor(e, o);
 }
 
 #if HOST_BIG_ENDIAN
-- 
2.34.1



  parent reply	other threads:[~2023-08-19  1:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19  1:02 [PATCH v2 00/18] crypto: Provide clmul.h and host accel Richard Henderson
2023-08-19  1:02 ` [PATCH v2 01/18] crypto: Add generic 8-bit carry-less multiply routines Richard Henderson
2023-09-10 12:19   ` Ard Biesheuvel
2023-08-19  1:02 ` [PATCH v2 02/18] target/arm: Use clmul_8* routines Richard Henderson
2023-08-21  7:49   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 03/18] target/s390x: " Richard Henderson
2023-08-21 12:45   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 04/18] target/ppc: " Richard Henderson
2023-08-19  1:02 ` [PATCH v2 05/18] crypto: Add generic 16-bit carry-less multiply routines Richard Henderson
2023-09-10 12:22   ` Ard Biesheuvel
2023-08-19  1:02 ` [PATCH v2 06/18] target/arm: Use clmul_16* routines Richard Henderson
2023-08-21  7:51   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 07/18] target/s390x: " Richard Henderson
2023-08-21 12:44   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 08/18] target/ppc: " Richard Henderson
2023-08-19  1:02 ` [PATCH v2 09/18] crypto: Add generic 32-bit carry-less multiply routines Richard Henderson
2023-09-10 12:23   ` Ard Biesheuvel
2023-08-19  1:02 ` [PATCH v2 10/18] target/arm: Use clmul_32* routines Richard Henderson
2023-08-21  7:53   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 11/18] target/s390x: " Richard Henderson
2023-08-21 12:39   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 12/18] target/ppc: " Richard Henderson
2023-08-19  1:02 ` [PATCH v2 13/18] crypto: Add generic 64-bit carry-less multiply routine Richard Henderson
2023-08-19  1:02 ` [PATCH v2 14/18] target/arm: Use clmul_64 Richard Henderson
2023-08-21 12:27   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 15/18] target/s390x: " Richard Henderson
2023-08-21 12:33   ` Philippe Mathieu-Daudé
2023-08-19  1:02 ` Richard Henderson [this message]
2023-08-21 12:34   ` [PATCH v2 16/18] target/ppc: " Philippe Mathieu-Daudé
2023-08-19  1:02 ` [PATCH v2 17/18] host/include/i386: Implement clmul.h Richard Henderson
2023-08-19  1:02 ` [PATCH v2 18/18] host/include/aarch64: " Richard Henderson
2023-08-21 14:57 ` [PATCH v2 00/18] crypto: Provide clmul.h and host accel Ard Biesheuvel
2023-08-21 15:14   ` Richard Henderson
2023-08-21 15:44     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230819010218.192706-17-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=ardb@kernel.org \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).