* [PATCH] bsd-user: Add missing break after do_bsd_preadv
@ 2023-08-20 4:54 Warner Losh
2023-08-20 13:53 ` Richard Henderson
2023-08-21 7:38 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Warner Losh @ 2023-08-20 4:54 UTC (permalink / raw)
To: qemu-devel; +Cc: Kyle Evans, Warner Losh
Without it, we'd call preadv, then write with weird parameters, which is
clearly not ideal...
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
bsd-user/freebsd/os-syscall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index de36c4b71c6..c90400abecc 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -248,6 +248,7 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
case TARGET_FREEBSD_NR_preadv: /* preadv(2) */
ret = do_bsd_preadv(cpu_env, arg1, arg2, arg3, arg4, arg5, arg6);
+ break;
case TARGET_FREEBSD_NR_write: /* write(2) */
ret = do_bsd_write(arg1, arg2, arg3);
--
2.40.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bsd-user: Add missing break after do_bsd_preadv
2023-08-20 4:54 [PATCH] bsd-user: Add missing break after do_bsd_preadv Warner Losh
@ 2023-08-20 13:53 ` Richard Henderson
2023-08-21 7:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2023-08-20 13:53 UTC (permalink / raw)
To: Warner Losh, qemu-devel; +Cc: Kyle Evans
On 8/19/23 21:54, Warner Losh wrote:
> Without it, we'd call preadv, then write with weird parameters, which is
> clearly not ideal...
>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
> bsd-user/freebsd/os-syscall.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bsd-user: Add missing break after do_bsd_preadv
2023-08-20 4:54 [PATCH] bsd-user: Add missing break after do_bsd_preadv Warner Losh
2023-08-20 13:53 ` Richard Henderson
@ 2023-08-21 7:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-21 7:38 UTC (permalink / raw)
To: Warner Losh, qemu-devel; +Cc: Kyle Evans
On 20/8/23 06:54, Warner Losh wrote:
> Without it, we'd call preadv, then write with weird parameters, which is
> clearly not ideal...
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> bsd-user/freebsd/os-syscall.c | 1 +
> 1 file changed, 1 insertion(+)
Ouch.
Fixes: 770d8abae7 ("bsd-user/bsd-file.h: Meat of the write system calls")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-21 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-20 4:54 [PATCH] bsd-user: Add missing break after do_bsd_preadv Warner Losh
2023-08-20 13:53 ` Richard Henderson
2023-08-21 7:38 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).