From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Song Gao" <gaosong@loongson.cn>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
qemu-arm@nongnu.org
Subject: [PATCH 00/12] tcg: Factor hrev{32,64}_{i32,i64,tl} out
Date: Tue, 22 Aug 2023 14:40:30 +0200 [thread overview]
Message-ID: <20230822124042.54739-1-philmd@linaro.org> (raw)
This series factor the "byteswap each halfword within a
32/64-bit value" code duplication as generic helpers.
Modulo the documentation added, there is a good negative
diff-stat, so I believe this is a win from a maintainance
point of view.
I used "hrev" to follow the other bswap/hswap/rev helpers
but it isn't very descriptive, so any better name suggestion
is welcomed.
(In particular because there are other patterns I'd like to
factor out and then naming is getting worse, such 'wrev').
Philippe Mathieu-Daudé (12):
tcg/tcg-op: Factor tcg_gen_hrev32_i32() out
target/arm: Use generic hrev32_i32() in ARM REV16 and VREV16 opcodes
target/cris: Use generic hrev32_i32() in SWAPB opcode
target/rx: Use generic hrev32_i32() in REVW opcode
tcg/tcg-op: Factor tcg_gen_hrev64_i64() out
target/mips: Use generic hrev64_i64() in DSBH opcode
target/ppc: Use generic hrev64_i64() in BRH / BSWAP16x8 opcodes
target/loongarch: Use generic hrev64_i64() in REVB.4H opcode
tcg/tcg-op: Add tcg_gen_hrev32_i64() and tcg_gen_hrev_i64()
target/arm: Use generic hrev_i64() in Aarch64 REV16 opcode
target/loongarch: Use generic hrev64_i32() in REVB.2H opcode
target/mips: Use generic hrev32_tl() in WSBH opcode
docs/devel/tcg-ops.rst | 10 +++
include/tcg/tcg-op-common.h | 4 +
include/tcg/tcg-op.h | 2 +
target/arm/tcg/translate-a32.h | 1 -
target/arm/tcg/translate-a64.c | 11 +--
target/arm/tcg/translate-neon.c | 2 +-
target/arm/tcg/translate.c | 14 +---
target/cris/translate.c | 20 +----
target/mips/tcg/translate.c | 24 +-----
target/ppc/translate.c | 10 +--
target/rx/translate.c | 8 +-
tcg/tcg-op.c | 81 ++++++++++++++++++---
target/cris/translate_v10.c.inc | 2 +-
target/loongarch/insn_trans/trans_bit.c.inc | 30 +-------
target/ppc/translate/vsx-impl.c.inc | 19 +----
15 files changed, 99 insertions(+), 139 deletions(-)
--
2.41.0
next reply other threads:[~2023-08-22 12:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 12:40 Philippe Mathieu-Daudé [this message]
2023-08-22 12:40 ` [PATCH 01/12] tcg/tcg-op: Factor tcg_gen_hrev32_i32() out Philippe Mathieu-Daudé
2023-08-22 12:40 ` [PATCH 02/12] target/arm: Use generic hrev32_i32() in ARM REV16 and VREV16 opcodes Philippe Mathieu-Daudé
2023-08-22 12:40 ` [PATCH 03/12] target/cris: Use generic hrev32_i32() in SWAPB opcode Philippe Mathieu-Daudé
2023-08-22 13:27 ` Philippe Mathieu-Daudé
2023-08-22 12:40 ` [PATCH 04/12] target/rx: Use generic hrev32_i32() in REVW opcode Philippe Mathieu-Daudé
2023-08-22 12:40 ` [PATCH 05/12] tcg/tcg-op: Factor tcg_gen_hrev64_i64() out Philippe Mathieu-Daudé
2023-08-22 12:46 ` [PATCH 10/12] target/arm: Use generic hrev_i64() in Aarch64 REV16 opcode Philippe Mathieu-Daudé
2023-08-22 12:47 ` [PATCH 09/12] tcg/tcg-op: Add tcg_gen_hrev32_i64() and tcg_gen_hrev_i64() Philippe Mathieu-Daudé
2023-08-22 12:51 ` [PATCH 08/12] target/loongarch: Use generic hrev64_i64() in REVB.4H opcode Philippe Mathieu-Daudé
2023-08-22 13:28 ` Philippe Mathieu-Daudé
2023-08-22 14:02 ` Philippe Mathieu-Daudé
2023-08-22 12:52 ` [PATCH 11/12] target/loongarch: Use generic hrev64_i32() in REVB.2H opcode Philippe Mathieu-Daudé
2023-08-22 13:30 ` Philippe Mathieu-Daudé
2023-08-22 16:11 ` Philippe Mathieu-Daudé
2023-08-22 17:04 ` Richard Henderson
2023-08-22 12:53 ` [PATCH 07/12] target/ppc: Use generic hrev64_i64() in BRH / BSWAP16x8 opcodes Philippe Mathieu-Daudé
2023-08-22 19:35 ` Daniel Henrique Barboza
2023-08-25 7:38 ` Nicholas Piggin
2023-08-22 12:57 ` [PATCH 06/12] target/mips: Use generic hrev64_i64() in DSBH opcode Philippe Mathieu-Daudé
2023-08-22 12:57 ` [PATCH 12/12] target/mips: Use generic hrev32_tl() in WSBH opcode Philippe Mathieu-Daudé
2023-08-22 15:42 ` Richard Henderson
2023-08-22 16:59 ` Philippe Mathieu-Daudé
2023-08-22 15:37 ` [PATCH 00/12] tcg: Factor hrev{32,64}_{i32,i64,tl} out Richard Henderson
2023-08-25 7:58 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822124042.54739-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=gaosong@loongson.cn \
--cc=groug@kaod.org \
--cc=jiaxun.yang@flygoat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=yangxiaojuan@loongson.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).