* [PATCH] tcg: Prohibit incomplete extr[lh]_i64_i32() implementation
@ 2023-08-22 16:51 Philippe Mathieu-Daudé
2023-08-22 17:10 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-22 16:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Richard Henderson, Philippe Mathieu-Daudé
extrl_i64_i32() and extrh_i64_i32() work in pair. Backends
can not implement one without the other. Enforce that
assumption.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/tcg/tcg.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
index 0875971719..a6f51130aa 100644
--- a/include/tcg/tcg.h
+++ b/include/tcg/tcg.h
@@ -172,6 +172,9 @@ typedef uint64_t TCGRegSet;
#define TCG_TARGET_HAS_v256 0
#endif
+QEMU_BUILD_BUG_MSG(TCG_TARGET_HAS_extrl_i64_i32 != TCG_TARGET_HAS_extrh_i64_i32,
+ "Both extrl_i64_i32()/extrh_i64_i32() must exist");
+
typedef enum TCGOpcode {
#define DEF(name, oargs, iargs, cargs, flags) INDEX_op_ ## name,
#include "tcg/tcg-opc.h"
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcg: Prohibit incomplete extr[lh]_i64_i32() implementation
2023-08-22 16:51 [PATCH] tcg: Prohibit incomplete extr[lh]_i64_i32() implementation Philippe Mathieu-Daudé
@ 2023-08-22 17:10 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2023-08-22 17:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Paolo Bonzini
On 8/22/23 09:51, Philippe Mathieu-Daudé wrote:
> extrl_i64_i32() and extrh_i64_i32() work in pair. Backends
> can not implement one without the other. Enforce that
> assumption.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/tcg/tcg.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/tcg/tcg.h b/include/tcg/tcg.h
> index 0875971719..a6f51130aa 100644
> --- a/include/tcg/tcg.h
> +++ b/include/tcg/tcg.h
> @@ -172,6 +172,9 @@ typedef uint64_t TCGRegSet;
> #define TCG_TARGET_HAS_v256 0
> #endif
>
> +QEMU_BUILD_BUG_MSG(TCG_TARGET_HAS_extrl_i64_i32 != TCG_TARGET_HAS_extrh_i64_i32,
> + "Both extrl_i64_i32()/extrh_i64_i32() must exist");
Just rename them so they're the same symbol.
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-22 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-22 16:51 [PATCH] tcg: Prohibit incomplete extr[lh]_i64_i32() implementation Philippe Mathieu-Daudé
2023-08-22 17:10 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).