Re: [PATCH 04/21] block: Take AioContext lock for bdrv_append() more consistently

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Thu, Aug 17, 2023 at 02:50:03PM +0200, Kevin Wolf wrote:
> diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
> index d727a5fee8..9155547313 100644
> --- a/tests/unit/test-block-iothread.c
> +++ b/tests/unit/test-block-iothread.c
> @@ -756,11 +756,14 @@ static void test_propagate_mirror(void)
>                                    &error_abort);
>  
>      /* Start a mirror job */
> +    aio_context_acquire(main_ctx);
>      mirror_start("job0", src, target, NULL, JOB_DEFAULT, 0, 0, 0,
>                   MIRROR_SYNC_MODE_NONE, MIRROR_OPEN_BACKING_CHAIN, false,
>                   BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT,
>                   false, "filter_node", MIRROR_COPY_MODE_BACKGROUND,
>                   &error_abort);
> +    aio_context_release(main_ctx);

For other reviewers: mirror_start() isn't mentioned in the commit
description, but it calls bdrv_append() internally.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]