From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B374EE49AE for ; Tue, 22 Aug 2023 18:50:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYWRW-0007aQ-QC; Tue, 22 Aug 2023 14:49:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYWRW-0007aI-6W for qemu-devel@nongnu.org; Tue, 22 Aug 2023 14:49:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYWRU-0001Yh-8e for qemu-devel@nongnu.org; Tue, 22 Aug 2023 14:49:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692730167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g2SA7mr6MZs2XrHggPWo2N5qDllPEc/XN9frj+fX0As=; b=COJjxyNP+hNpDFYXqvvhna4CcPyvi0j2VMc2GomSByQpVQeg2T/fdIpy5YpZaDB2/u31cF 9AtFbu8op/+pQ8RfXX7RFVCDyNejGNlJLHIIrr0lWjrJm6heu+B1piZc7rxuewc6itr0oO bjIkJyJgbawFPLnTTwIuqcsCUd6lMKw= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-308-DU7ljqReO0SSfiSQb9uxJQ-1; Tue, 22 Aug 2023 14:49:22 -0400 X-MC-Unique: DU7ljqReO0SSfiSQb9uxJQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6DFF93C11CC9; Tue, 22 Aug 2023 18:49:22 +0000 (UTC) Received: from localhost (unknown [10.39.195.69]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0609E1121314; Tue, 22 Aug 2023 18:49:21 +0000 (UTC) Date: Tue, 22 Aug 2023 14:49:20 -0400 From: Stefan Hajnoczi To: Kevin Wolf Cc: qemu-block@nongnu.org, eblake@redhat.com, eesposit@redhat.com, pbonzini@redhat.com, vsementsov@yandex-team.ru, qemu-devel@nongnu.org Subject: Re: [PATCH 04/21] block: Take AioContext lock for bdrv_append() more consistently Message-ID: <20230822184920.GG727224@fedora> References: <20230817125020.208339-1-kwolf@redhat.com> <20230817125020.208339-5-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iOmxUhiH1/KXUl26" Content-Disposition: inline In-Reply-To: <20230817125020.208339-5-kwolf@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --iOmxUhiH1/KXUl26 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 17, 2023 at 02:50:03PM +0200, Kevin Wolf wrote: > diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iot= hread.c > index d727a5fee8..9155547313 100644 > --- a/tests/unit/test-block-iothread.c > +++ b/tests/unit/test-block-iothread.c > @@ -756,11 +756,14 @@ static void test_propagate_mirror(void) > &error_abort); > =20 > /* Start a mirror job */ > + aio_context_acquire(main_ctx); > mirror_start("job0", src, target, NULL, JOB_DEFAULT, 0, 0, 0, > MIRROR_SYNC_MODE_NONE, MIRROR_OPEN_BACKING_CHAIN, false, > BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT, > false, "filter_node", MIRROR_COPY_MODE_BACKGROUND, > &error_abort); > + aio_context_release(main_ctx); For other reviewers: mirror_start() isn't mentioned in the commit description, but it calls bdrv_append() internally. Reviewed-by: Stefan Hajnoczi --iOmxUhiH1/KXUl26 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmTlAzAACgkQnKSrs4Gr c8iCeAf9Ft7ZjunkAIRCgc6E/bGi+8CMhtcTxX2ZdZO6DiRUpy/zCjn1wbekicPU DZx0Wp47nWjQJg57ARLFiw8FAq3LRFDpzDL7IocNdQDq+Vx9roD/Fq5aWRD0awmt GDMiVp8tvsMcTTGFj8EAT3cLGa+Pmt/LqFMH8n8mAkDx7E4smCfQJOySngUrOQnw 02VAJ7vIMOG1Lz9qGUCAIisxErmZMfqHWCgGiFjv5olzS+zsrflgCx51Qi/I8GcJ waFHMXhPMpx/0uqj8TWGXUoRFBmXYZMgtH2rtZ5BJglHvBnqXAAzo/Da4yfuaWm7 EJBh07GLuWjrnHyaLOHIRVKWkwIcTw== =dpdn -----END PGP SIGNATURE----- --iOmxUhiH1/KXUl26--