From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: deller@gmx.de
Subject: [PATCH v3 2/3] linux-user: Exit not abort in die_with_backtrace
Date: Tue, 22 Aug 2023 13:34:14 -0700 [thread overview]
Message-ID: <20230822203415.1184491-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230822203415.1184491-1-richard.henderson@linaro.org>
This line is supposed to be unreachable, but if we're going to
have it at all, SIGABRT via abort() is subject to the same signal
peril that created this function in the first place.
We can _exit immediately without peril.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index e1cd111a1b..57fbf2f58b 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -718,7 +718,7 @@ void die_with_signal(int sig)
sigsuspend(&act.sa_mask);
/* unreachable */
- abort();
+ _exit(EXIT_FAILURE);
}
static G_NORETURN
--
2.34.1
next prev parent reply other threads:[~2023-08-22 20:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 20:34 [PATCH v3 0/3] linux-user: Detect and report host crashes Richard Henderson
2023-08-22 20:34 ` [PATCH v3 1/3] linux-user: Split out die_with_signal Richard Henderson
2023-08-22 22:08 ` Philippe Mathieu-Daudé
2023-08-22 20:34 ` Richard Henderson [this message]
2023-08-22 22:08 ` [PATCH v3 2/3] linux-user: Exit not abort in die_with_backtrace Philippe Mathieu-Daudé
2023-08-22 20:34 ` [PATCH v3 3/3] linux-user: Detect and report host crashes Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822203415.1184491-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).