[PATCH 0/2] hw/misc: small fixes for i2c-echo

[PATCH 0/2] hw/misc: small fixes for i2c-echo

[Klaus Jensen]

Add missing copyright/license note and add a Kconfig entry.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
Klaus Jensen (2):
      hw/misc/i2c-echo: add copyright/license note
      hw/misc/Kconfig: add switch for i2c-echo

 hw/misc/Kconfig     |  5 +++++
 hw/misc/i2c-echo.c  | 10 ++++++++++
 hw/misc/meson.build |  2 +-
 3 files changed, 16 insertions(+), 1 deletion(-)
---
base-commit: b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa
change-id: 20230823-i2c-echo-fixes-945c0bf059b5

Best regards,
-- 
Klaus Jensen <k.jensen@samsung.com>

[PATCH 1/2] hw/misc/i2c-echo: add copyright/license note

[Klaus Jensen]

From: Klaus Jensen <k.jensen@samsung.com>

Add missing copyright and license notice. Also add a short description
of the device.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/misc/i2c-echo.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/hw/misc/i2c-echo.c b/hw/misc/i2c-echo.c
index 5705ab5d7349..5ae3d0817ead 100644
--- a/hw/misc/i2c-echo.c
+++ b/hw/misc/i2c-echo.c
@@ -1,3 +1,13 @@
+/*
+ * Example I2C device using asynchronous I2C send.
+ *
+ * Copyright (C) 2023 Samsung Electronics Co., Ltd. All Rights Reserved.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2.  See
+ * the COPYING file in the top-level directory.
+ *
+ */
+
 #include "qemu/osdep.h"
 #include "qemu/timer.h"
 #include "qemu/main-loop.h"

-- 
2.42.0

[PATCH 2/2] hw/misc/Kconfig: add switch for i2c-echo

[Klaus Jensen]

From: Klaus Jensen <k.jensen@samsung.com>

Associate i2c-echo with TEST_DEVICES and add a dependency on I2C.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/misc/Kconfig     | 5 +++++
 hw/misc/meson.build | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
index 6996d265e4c5..9ec7a40f973a 100644
--- a/hw/misc/Kconfig
+++ b/hw/misc/Kconfig
@@ -34,6 +34,11 @@ config PCA9552
     bool
     depends on I2C
 
+config I2C_ECHO
+    bool
+    default y if TEST_DEVICES
+    depends on I2C
+
 config PL310
     bool
 
diff --git a/hw/misc/meson.build b/hw/misc/meson.build
index 892f8b91c572..fbea23f8b27f 100644
--- a/hw/misc/meson.build
+++ b/hw/misc/meson.build
@@ -132,7 +132,7 @@ system_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_rng.c'))
 
 system_ss.add(when: 'CONFIG_GRLIB', if_true: files('grlib_ahb_apb_pnp.c'))
 
-system_ss.add(when: 'CONFIG_I2C', if_true: files('i2c-echo.c'))
+system_ss.add(when: 'CONFIG_I2C_ECHO', if_true: files('i2c-echo.c'))
 
 specific_ss.add(when: 'CONFIG_AVR_POWER', if_true: files('avr_power.c'))
 

-- 
2.42.0

Re: [PATCH 1/2] hw/misc/i2c-echo: add copyright/license note

[Thomas Huth]

On 23/08/2023 10.14, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Add missing copyright and license notice. Also add a short description
> of the device.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/misc/i2c-echo.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/hw/misc/i2c-echo.c b/hw/misc/i2c-echo.c
> index 5705ab5d7349..5ae3d0817ead 100644
> --- a/hw/misc/i2c-echo.c
> +++ b/hw/misc/i2c-echo.c
> @@ -1,3 +1,13 @@
> +/*
> + * Example I2C device using asynchronous I2C send.
> + *
> + * Copyright (C) 2023 Samsung Electronics Co., Ltd. All Rights Reserved.
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.

That means GPL-2.0-only ? Please change this into GPL-2.0-or-later instead 
if possible, since according our main "LICENSE" file:

"As of July 2013, contributions under version 2 of the GNU General Public 
License (and no later version) are only accepted for the following files or 
directories: bsd-user/, linux-user/, hw/vfio/, hw/xen/xen_pt*"

While you're at it, I'd also appreciate a SPDX-License-Identifier line here.

  Thanks,
   Thomas

Re: [PATCH 2/2] hw/misc/Kconfig: add switch for i2c-echo

[Thomas Huth]

On 23/08/2023 10.14, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Associate i2c-echo with TEST_DEVICES and add a dependency on I2C.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/misc/Kconfig     | 5 +++++
>   hw/misc/meson.build | 2 +-
>   2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> index 6996d265e4c5..9ec7a40f973a 100644
> --- a/hw/misc/Kconfig
> +++ b/hw/misc/Kconfig
> @@ -34,6 +34,11 @@ config PCA9552
>       bool
>       depends on I2C
>   
> +config I2C_ECHO
> +    bool
> +    default y if TEST_DEVICES
> +    depends on I2C
> +
>   config PL310
>       bool
>   
> diff --git a/hw/misc/meson.build b/hw/misc/meson.build
> index 892f8b91c572..fbea23f8b27f 100644
> --- a/hw/misc/meson.build
> +++ b/hw/misc/meson.build
> @@ -132,7 +132,7 @@ system_ss.add(when: 'CONFIG_NRF51_SOC', if_true: files('nrf51_rng.c'))
>   
>   system_ss.add(when: 'CONFIG_GRLIB', if_true: files('grlib_ahb_apb_pnp.c'))
>   
> -system_ss.add(when: 'CONFIG_I2C', if_true: files('i2c-echo.c'))
> +system_ss.add(when: 'CONFIG_I2C_ECHO', if_true: files('i2c-echo.c'))
>   
>   specific_ss.add(when: 'CONFIG_AVR_POWER', if_true: files('avr_power.c'))

Thanks, very appreciated!

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 2/2] hw/misc/Kconfig: add switch for i2c-echo

[Philippe Mathieu-Daudé]

On 23/8/23 10:14, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Associate i2c-echo with TEST_DEVICES and add a dependency on I2C.
> 
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/misc/Kconfig     | 5 +++++
>   hw/misc/meson.build | 2 +-
>   2 files changed, 6 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>