From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: deller@gmx.de
Subject: [PATCH v4 03/10] linux-user: Use die_with_signal with abort
Date: Tue, 22 Aug 2023 22:16:08 -0700 [thread overview]
Message-ID: <20230823051615.1297706-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230823051615.1297706-1-richard.henderson@linaro.org>
Describe the convoluted way by which we can see
ERROR:../alt/accel/tcg/cpu-exec.c:532:cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu)
Bail out! ERROR:../alt/accel/tcg/cpu-exec.c:532:cpu_exec_longjmp_cleanup: assertion failed: (cpu == current_cpu)
for encountering an an abort() in qemu source.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/signal.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 57fbf2f58b..a77d003de6 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -721,6 +721,18 @@ void die_with_signal(int sig)
_exit(EXIT_FAILURE);
}
+/*
+ * The system abort() will raise SIGABRT, which will get caught and deferred
+ * by host_signal_handler. Returning into system abort will try harder.
+ * Eventually, on x86, it will execute HLT, which raises SIGSEGV. This goes
+ * back into host_signal_handler, through a different path which may longjmp
+ * back to the main loop. This often explodes.
+ */
+void abort(void)
+{
+ die_with_signal(SIGABRT);
+}
+
static G_NORETURN
void dump_core_and_abort(CPUArchState *cpu_env, int target_sig)
{
--
2.34.1
next prev parent reply other threads:[~2023-08-23 5:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 5:16 [PATCH v4 00/10] linux-user: Detect and report host crashes Richard Henderson
2023-08-23 5:16 ` [PATCH v4 01/10] linux-user: Split out die_with_signal Richard Henderson
2023-08-23 12:55 ` Philippe Mathieu-Daudé
2023-08-23 5:16 ` [PATCH v4 02/10] linux-user: Exit not abort in die_with_backtrace Richard Henderson
2023-08-23 12:55 ` Philippe Mathieu-Daudé
2023-08-23 5:16 ` Richard Henderson [this message]
2023-08-23 5:16 ` [PATCH v4 04/10] linux-user: Detect and report host crashes Richard Henderson
2023-08-23 5:16 ` [PATCH v4 05/10] linux-user: Only register handlers for core_dump_signal by default Richard Henderson
2023-08-23 5:16 ` [PATCH v4 06/10] linux-user: Map unsupported signals to an out-of-bounds value Richard Henderson
2023-08-23 5:16 ` [PATCH v4 07/10] linux-user: Remap SIGPROF when CONFIG_GPROF Richard Henderson
2023-08-23 5:16 ` [PATCH v4 08/10] linux-user: Simplify signal_init Richard Henderson
2023-08-23 5:16 ` [PATCH v4 09/10] linux-user: Split out host_sig{segv,bus}_handler Richard Henderson
2023-08-23 5:16 ` [PATCH v4 10/10] linux-user: Detect and report host SIGILL, SIGFPE, SIGTRAP Richard Henderson
2023-09-09 19:12 ` [PATCH v4 00/10] linux-user: Detect and report host crashes Richard Henderson
2023-09-12 9:45 ` Helge Deller
2023-09-12 10:34 ` Michael Tokarev
2023-09-18 14:05 ` Helge Deller
2023-09-19 7:40 ` Michael Tokarev
2023-09-19 8:00 ` Helge Deller
2023-09-19 8:26 ` Michael Tokarev
2023-09-19 8:38 ` Richard Henderson
2023-09-19 9:17 ` Helge Deller
2023-09-19 13:01 ` Michael Tokarev
2023-09-19 8:29 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823051615.1297706-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).