qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "David Hildenbrand" <david@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Thiner Logoer" <logoerthiner1@163.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
	"Jagannathan Raman" <jag.raman@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Ani Sinha" <anisinha@redhat.com>,
	"Xiao Guangrong" <xiaoguangrong.eric@gmail.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Greg Kurz" <groug@kaod.org>, "Eric Blake" <eblake@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>
Subject: [PATCH v3 11/11] machine: Improve error message when using default RAM backend id
Date: Wed, 23 Aug 2023 17:34:11 +0200	[thread overview]
Message-ID: <20230823153412.832081-12-david@redhat.com> (raw)
In-Reply-To: <20230823153412.832081-1-david@redhat.com>

For migration purposes, users might want to reuse the default RAM
backend id, but specify a different memory backend.

For example, to reuse "pc.ram" on q35, one has to set
    -machine q35,memory-backend=pc.ram
Only then, can a memory backend with the id "pc.ram" be created
manually.

Let's improve the error message.

Unfortuantely, we cannot use error_append_hint(), because the caller
passes &error_fatal.

Suggested-by: ThinerLogoer <logoerthiner1@163.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 hw/core/machine.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/core/machine.c b/hw/core/machine.c
index f0d35c6401..dbcd124d45 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -1382,7 +1382,9 @@ void machine_run_board_init(MachineState *machine, const char *mem_path, Error *
                                  machine_class->default_ram_id)) {
             error_setg(errp, "object name '%s' is reserved for the default"
                 " RAM backend, it can't be used for any other purposes."
-                " Change the object's 'id' to something else",
+                " Change the object's 'id' to something else or disable"
+                " automatic creation of the default RAM backend by setting"
+                " the 'memory-backend' machine property",
                 machine_class->default_ram_id);
             return;
         }
-- 
2.41.0



  parent reply	other threads:[~2023-08-23 15:35 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23 15:34 [PATCH v3 00/11] memory-backend-file related improvements and VM templating support David Hildenbrand
2023-08-23 15:34 ` [PATCH v3 01/11] nvdimm: Reject writing label data to ROM instead of crashing QEMU David Hildenbrand
2023-08-23 15:34 ` [PATCH v3 02/11] softmmu/physmem: Distinguish between file access mode and mmap protection David Hildenbrand
2023-08-23 20:21   ` Peter Xu
2023-08-23 15:34 ` [PATCH v3 03/11] backends/hostmem-file: Add "rom" property to support VM templating with R/O files David Hildenbrand
2023-09-01 12:50   ` Markus Armbruster
2023-08-23 15:34 ` [PATCH v3 04/11] softmmu/physmem: Remap with proper protection in qemu_ram_remap() David Hildenbrand
2023-08-23 20:21   ` Peter Xu
2023-08-29 11:18   ` Philippe Mathieu-Daudé
2023-08-23 15:34 ` [PATCH v3 05/11] softmmu/physmem: Bail out early in ram_block_discard_range() with readonly files David Hildenbrand
2023-08-23 20:21   ` Peter Xu
2023-08-23 15:34 ` [PATCH v3 06/11] softmmu/physmem: Fail creation of new files in file_ram_open() with readonly=true David Hildenbrand
2023-08-23 20:22   ` Peter Xu
2023-08-23 15:34 ` [PATCH v3 07/11] softmmu/physmem: Never return directories from file_ram_open() David Hildenbrand
2023-08-23 20:22   ` Peter Xu
2023-08-23 15:34 ` [PATCH v3 08/11] docs: Don't mention "-mem-path" in multi-process.rst David Hildenbrand
2023-08-23 15:34 ` [PATCH v3 09/11] docs: Start documenting VM templating David Hildenbrand
2023-08-29 11:25   ` Philippe Mathieu-Daudé
2023-08-23 15:34 ` [PATCH v3 10/11] softmmu/physmem: Hint that "readonly=on, rom=off" exists when opening file R/W for private mapping fails David Hildenbrand
2023-08-23 15:34 ` David Hildenbrand [this message]
2023-08-25  6:57   ` Re:[PATCH v3 11/11] machine: Improve error message when using default RAM backend id ThinerLogoer
2023-08-25  7:36     ` [PATCH " David Hildenbrand
2023-08-25  9:10       ` Markus Armbruster
2023-08-25  9:13         ` David Hildenbrand
2023-08-25  9:56           ` Markus Armbruster
2023-08-25  9:59             ` David Hildenbrand
2023-08-25 10:10               ` David Hildenbrand
2023-08-29 11:29                 ` Philippe Mathieu-Daudé
2023-09-01 12:52                 ` Markus Armbruster
2023-08-29  8:31   ` Mario Casquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823153412.832081-12-david@redhat.com \
    --to=david@redhat.com \
    --cc=anisinha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=eblake@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=elena.ufimtseva@oracle.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=jag.raman@oracle.com \
    --cc=logoerthiner1@163.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).