From: Hanna Czenczek <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Sam Li <faithilikerun@gmail.com>
Subject: [PATCH 4/5] file-posix: Simplify raw_co_prw's 'out' zone code
Date: Thu, 24 Aug 2023 17:53:43 +0200 [thread overview]
Message-ID: <20230824155345.109765-5-hreitz@redhat.com> (raw)
In-Reply-To: <20230824155345.109765-1-hreitz@redhat.com>
We duplicate the same condition three times here, pull it out to the top
level.
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
---
block/file-posix.c | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index a050682e97..aa89789737 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -2506,11 +2506,10 @@ static int coroutine_fn raw_co_prw(BlockDriverState *bs, uint64_t offset,
out:
#if defined(CONFIG_BLKZONED)
-{
- BlockZoneWps *wps = bs->wps;
- if (ret == 0) {
- if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
- bs->bl.zoned != BLK_Z_NONE) {
+ if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
+ bs->bl.zoned != BLK_Z_NONE) {
+ BlockZoneWps *wps = bs->wps;
+ if (ret == 0) {
uint64_t *wp = &wps->wp[offset / bs->bl.zone_size];
if (!BDRV_ZT_IS_CONV(*wp)) {
if (type & QEMU_AIO_ZONE_APPEND) {
@@ -2523,19 +2522,12 @@ out:
*wp = offset + bytes;
}
}
- }
- } else {
- if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
- bs->bl.zoned != BLK_Z_NONE) {
+ } else {
update_zones_wp(bs, s->fd, 0, 1);
}
- }
- if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
- bs->blk.zoned != BLK_Z_NONE) {
qemu_co_mutex_unlock(&wps->colock);
}
-}
#endif
return ret;
}
--
2.41.0
next prev parent reply other threads:[~2023-08-24 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 15:53 [PATCH 0/5] file-posix: Clean up and fix zoned checks Hanna Czenczek
2023-08-24 15:53 ` [PATCH 1/5] file-posix: Clear bs->bl.zoned on error Hanna Czenczek
2023-08-24 16:57 ` Sam Li
2023-08-24 15:53 ` [PATCH 2/5] file-posix: Check bs->bl.zoned for zone info Hanna Czenczek
2023-08-24 16:58 ` Sam Li
2023-08-24 15:53 ` [PATCH 3/5] file-posix: Fix zone update in I/O error path Hanna Czenczek
2023-08-24 17:17 ` Sam Li
2023-08-24 15:53 ` Hanna Czenczek [this message]
2023-08-24 17:18 ` [PATCH 4/5] file-posix: Simplify raw_co_prw's 'out' zone code Sam Li
2023-08-24 15:53 ` [PATCH 5/5] tests/file-io-error: New test Hanna Czenczek
2023-08-24 16:53 ` [PATCH 0/5] file-posix: Clean up and fix zoned checks Sam Li
2023-09-21 18:21 ` Michael Tokarev
2023-09-21 18:52 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824155345.109765-5-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=faithilikerun@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).