qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Yonggang Luo" <luoyonggang@gmail.com>,
	qemu-ppc@nongnu.org, "David Gibson" <david@gibson.dropbear.id.au>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	qemu-s390x@nongnu.org, "Akihiko Odaki" <akihiko.odaki@daynix.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-arm@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v2 12/12] gdbstub: move comment for gdb_register_coprocessor
Date: Thu, 24 Aug 2023 17:39:10 +0100	[thread overview]
Message-ID: <20230824163910.1737079-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230824163910.1737079-1-alex.bennee@linaro.org>

Use proper kdoc style comments for this API function.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 include/exec/gdbstub.h | 10 ++++++++++
 gdbstub/gdbstub.c      |  6 ------
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h
index 0ee39cfdd1..16a139043f 100644
--- a/include/exec/gdbstub.h
+++ b/include/exec/gdbstub.h
@@ -14,6 +14,16 @@
 /* Get or set a register.  Returns the size of the register.  */
 typedef int (*gdb_get_reg_cb)(CPUArchState *env, GByteArray *buf, int reg);
 typedef int (*gdb_set_reg_cb)(CPUArchState *env, uint8_t *buf, int reg);
+
+/**
+ * gdb_register_coprocessor() - register a supplemental set of registers
+ * @cpu - the CPU associated with registers
+ * @get_reg - get function (gdb reading)
+ * @set_reg - set function (gdb modifying)
+ * @num_regs - number of registers in set
+ * @xml - xml name of set
+ * @gpos - non-zero to append to "general" register set at @gpos
+ */
 void gdb_register_coprocessor(CPUState *cpu,
                               gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg,
                               int num_regs, const char *xml, int g_pos);
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 10fb755390..1fb0db747f 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -450,12 +450,6 @@ static int gdb_write_register(CPUState *cpu, uint8_t *mem_buf, int reg)
     return 0;
 }
 
-/* Register a supplemental set of CPU registers.  If g_pos is nonzero it
-   specifies the first register number and these registers are included in
-   a standard "g" packet.  Direction is relative to gdb, i.e. get_reg is
-   gdb reading a CPU register, and set_reg is gdb modifying a CPU register.
- */
-
 void gdb_register_coprocessor(CPUState *cpu,
                               gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg,
                               int num_regs, const char *xml, int g_pos)
-- 
2.39.2



  parent reply	other threads:[~2023-08-24 16:41 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 16:38 [PATCH v2 00/12] gdbstub and testing fixes for 8.2 Alex Bennée
2023-08-24 16:38 ` [PATCH v2 01/12] gitlab: enable ccache for many build jobs Alex Bennée
2023-08-25  7:38   ` Philippe Mathieu-Daudé
2023-08-25  7:46   ` Michael Tokarev
2023-08-25  8:11     ` Daniel P. Berrangé
2023-08-25  8:34     ` Philippe Mathieu-Daudé
2023-08-25  8:43       ` Thomas Huth
2023-08-25  9:13       ` Michael Tokarev
2023-08-24 16:39 ` [PATCH v2 02/12] tests/docker: cleanup non-verbose output Alex Bennée
2023-08-24 16:39 ` [PATCH v2 03/12] tests/tcg: remove quoting for info output Alex Bennée
2023-08-24 16:39 ` [PATCH v2 04/12] docs/style: permit inline loop variables Alex Bennée
2023-08-24 16:39 ` [PATCH v2 05/12] .gitlab-ci.d/cirrus.yml: Update FreeBSD to v13.2 Alex Bennée
2023-08-24 16:39 ` [PATCH v2 06/12] tests: remove test-gdbstub.py Alex Bennée
2023-08-24 16:39 ` [PATCH v2 07/12] tests/tcg: clean-up gdb confirm/pagination settings Alex Bennée
2023-08-24 16:39 ` [PATCH v2 08/12] gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT Alex Bennée
2023-08-24 16:39 ` [PATCH v2 09/12] gdbstub: remove unused user_ctx field Alex Bennée
2023-08-25  7:31   ` Philippe Mathieu-Daudé
2023-08-24 16:39 ` [PATCH v2 10/12] gdbstub: refactor get_feature_xml Alex Bennée
2023-08-24 19:25   ` Richard Henderson
2023-08-29 12:04     ` Alex Bennée
2023-08-24 16:39 ` [PATCH v2 11/12] gdbstub: replace global gdb_has_xml with a function Alex Bennée
2023-08-24 19:27   ` Richard Henderson
2023-08-25  7:33   ` Philippe Mathieu-Daudé
2023-08-24 16:39 ` Alex Bennée [this message]
2023-08-24 19:29   ` [PATCH v2 12/12] gdbstub: move comment for gdb_register_coprocessor Richard Henderson
2023-08-25  7:34   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230824163910.1737079-13-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=akihiko.odaki@daynix.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=groug@kaod.org \
    --cc=iii@linux.ibm.com \
    --cc=luoyonggang@gmail.com \
    --cc=npiggin@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).