From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, hreitz@redhat.com, dave@treblig.org,
thuth@redhat.com, qemu-block@nongnu.org, berrange@redhat.com,
dgilbert@redhat.com, qemu-trivial@nongnu.org
Subject: [PATCH 2/2] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test
Date: Fri, 25 Aug 2023 17:59:23 +0200 [thread overview]
Message-ID: <20230825155923.1983141-3-armbru@redhat.com> (raw)
In-Reply-To: <20230825155923.1983141-1-armbru@redhat.com>
The command always fails with "Error: Parameter 'xbzrle_cache_size'
expects a power of two no less than the target page size". The test
passes anyway. Change the argument from 1 to 64k to make the test a
bit more useful.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
tests/qtest/test-hmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
index c0d2d70689..fc9125f8bb 100644
--- a/tests/qtest/test-hmp.c
+++ b/tests/qtest/test-hmp.c
@@ -45,7 +45,7 @@ static const char *hmp_cmds[] = {
"log all",
"log none",
"memsave 0 4096 \"/dev/null\"",
- "migrate_set_parameter xbzrle-cache-size 1",
+ "migrate_set_parameter xbzrle-cache-size 64k",
"migrate_set_parameter downtime-limit 1",
"migrate_set_parameter max-bandwidth 1",
"netdev_add user,id=net1",
--
2.41.0
next prev parent reply other threads:[~2023-08-25 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:59 [PATCH 0/2] docs tests: Fix use of migrate_set_parameter Markus Armbruster
2023-08-25 15:59 ` [PATCH 1/2] " Markus Armbruster
2023-08-25 16:13 ` Thomas Huth
2023-08-25 15:59 ` Markus Armbruster [this message]
2023-08-25 16:09 ` [PATCH 2/2] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test Thomas Huth
2023-08-29 17:37 ` [PATCH 0/2] docs tests: Fix use of migrate_set_parameter Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825155923.1983141-3-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=dgilbert@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).