From: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
To: qemu-devel@nongnu.org
Cc: eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com, pbonzini@redhat.com,
berrange@redhat.com, richard.henderson@linaro.org,
laurent@vivier.eu, palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, liweiwei@iscas.ac.cn,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
qemu-riscv@nongnu.org
Subject: [RFC PATCH v2 4/6] target/riscv: Add default value for misa property
Date: Mon, 28 Aug 2023 16:45:34 +0800 [thread overview]
Message-ID: <20230828084536.231-5-zhiwei_liu@linux.alibaba.com> (raw)
In-Reply-To: <20230828084536.231-1-zhiwei_liu@linux.alibaba.com>
Before this patch,
"
qemu-system-riscv64 -device rv64-riscv-cpu,v=true,help
...
v=<bool> - Vector operations
...
"
After this patch,
"
v=<bool> - Vector operations (default: false)
"
Signed-off-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
---
target/riscv/cpu.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index c2f102fae1..38838cd2c0 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -1728,6 +1728,7 @@ static void riscv_cpu_add_misa_properties(Object *cpu_obj)
int i;
for (i = 0; i < ARRAY_SIZE(misa_ext_cfgs); i++) {
+ ObjectProperty *op;
RISCVCPUMisaExtConfig *misa_cfg = &misa_ext_cfgs[i];
int bit = misa_cfg->misa_bit;
@@ -1739,14 +1740,13 @@ static void riscv_cpu_add_misa_properties(Object *cpu_obj)
continue;
}
- object_property_add(cpu_obj, misa_cfg->name, "bool",
- cpu_get_misa_ext_cfg,
- cpu_set_misa_ext_cfg,
- NULL, (void *)misa_cfg);
+ op = object_property_add(cpu_obj, misa_cfg->name, "bool",
+ cpu_get_misa_ext_cfg,
+ cpu_set_misa_ext_cfg,
+ NULL, (void *)misa_cfg);
object_property_set_description(cpu_obj, misa_cfg->name,
misa_cfg->description);
- object_property_set_bool(cpu_obj, misa_cfg->name,
- misa_cfg->enabled, NULL);
+ object_property_set_default_bool(op, misa_cfg->enabled);
}
}
--
2.17.1
next prev parent reply other threads:[~2023-08-28 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 8:45 [RFC PATCH v2 0/6] Add API for list cpu extensions LIU Zhiwei
2023-08-28 8:45 ` [RFC PATCH v2 1/6] cpu: Add new API cpu_type_by_name LIU Zhiwei
2023-08-28 8:45 ` [RFC PATCH v2 2/6] target/riscv: Add API list_cpu_props LIU Zhiwei
2023-08-28 8:45 ` [RFC PATCH v2 3/6] softmmu/vl: Add qemu_cpu_opts QemuOptsList LIU Zhiwei
2023-08-28 8:45 ` LIU Zhiwei [this message]
2023-08-28 12:26 ` [RFC PATCH v2 4/6] target/riscv: Add default value for misa property Daniel Henrique Barboza
2023-08-28 8:45 ` [RFC PATCH v2 5/6] target/riscv: Add defalut value for string property LIU Zhiwei
2023-08-28 12:31 ` Daniel Henrique Barboza
2023-08-28 8:45 ` [RFC PATCH v2 6/6] linux-user: Move qemu_cpu_opts to cpu.c LIU Zhiwei
2023-08-28 12:35 ` Daniel Henrique Barboza
2023-08-28 13:58 ` [RFC PATCH v2 0/6] Add API for list cpu extensions Igor Mammedov
2023-08-28 15:35 ` Daniel Henrique Barboza
2023-08-29 3:02 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828084536.231-5-zhiwei_liu@linux.alibaba.com \
--to=zhiwei_liu@linux.alibaba.com \
--cc=alistair.francis@wdc.com \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=eduardo@habkost.net \
--cc=laurent@vivier.eu \
--cc=liweiwei@iscas.ac.cn \
--cc=marcel.apfelbaum@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).