qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: qemu-devel@nongnu.org
Cc: anton.kochkov@proton.me, richard.henderson@linaro.org,
	kbastian@mail.uni-paderborn.de
Subject: [PATCH v2 05/11] target/tricore: Clarify special case for FTOUZ insn
Date: Mon, 28 Aug 2023 13:26:45 +0200	[thread overview]
Message-ID: <20230828112651.522058-6-kbastian@mail.uni-paderborn.de> (raw)
In-Reply-To: <20230828112651.522058-1-kbastian@mail.uni-paderborn.de>

this is not something other ISAs do, so clarify it with a comment.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
 target/tricore/fpu_helper.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/target/tricore/fpu_helper.c b/target/tricore/fpu_helper.c
index 3aefeb776e..d0c474c5f3 100644
--- a/target/tricore/fpu_helper.c
+++ b/target/tricore/fpu_helper.c
@@ -475,6 +475,11 @@ uint32_t helper_ftouz(CPUTriCoreState *env, uint32_t arg)
         if (float32_is_any_nan(f_arg)) {
             result = 0;
         }
+    /*
+     * we need to check arg < 0.0 before rounding as TriCore needs to raise
+     * float_flag_invalid as well. For instance, when we have a negative
+     * exponent and sign, softfloat would only raise float_flat_inexact.
+     */
     } else if (float32_lt_quiet(f_arg, 0, &env->fp_status)) {
         flags = float_flag_invalid;
         result = 0;
-- 
2.41.0



  parent reply	other threads:[~2023-08-28 11:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 11:26 [PATCH v2 00/11] TriCore 1.6.2 insn and bugfixes Bastian Koppelmann
2023-08-28 11:26 ` [PATCH v2 01/11] tests/tcg/tricore: Bump cpu to tc37x Bastian Koppelmann
2023-08-28 11:26 ` [PATCH v2 02/11] target/tricore: Implement CRCN insn Bastian Koppelmann
2023-08-28 18:09   ` Richard Henderson
2023-08-28 11:26 ` [PATCH v2 03/11] target/tricore: Correctly handle FPU RM from PSW Bastian Koppelmann
2023-08-28 11:26 ` [PATCH v2 04/11] target/tricore: Implement FTOU insn Bastian Koppelmann
2023-08-28 18:10   ` Richard Henderson
2023-08-28 11:26 ` Bastian Koppelmann [this message]
2023-08-28 18:11   ` [PATCH v2 05/11] target/tricore: Clarify special case for FTOUZ insn Richard Henderson
2023-08-28 11:26 ` [PATCH v2 06/11] target/tricore: Implement ftohp insn Bastian Koppelmann
2023-08-28 18:15   ` Richard Henderson
2023-08-28 11:26 ` [PATCH v2 07/11] target/tricore: Implement hptof insn Bastian Koppelmann
2023-08-28 18:17   ` Richard Henderson
2023-08-28 11:26 ` [PATCH v2 08/11] target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0 Bastian Koppelmann
2023-08-28 12:29   ` Philippe Mathieu-Daudé
2023-08-28 11:26 ` [PATCH v2 09/11] target/tricore: Swap src and dst reg for RCRR_INSERT Bastian Koppelmann
2023-08-28 18:17   ` Richard Henderson
2023-08-28 11:26 ` [PATCH v2 10/11] target/tricore: Replace cpu_*_code with translator_* Bastian Koppelmann
2023-08-28 11:26 ` [PATCH v2 11/11] target/tricore: Fix FTOUZ being ISA v1.3.1 up Bastian Koppelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230828112651.522058-6-kbastian@mail.uni-paderborn.de \
    --to=kbastian@mail.uni-paderborn.de \
    --cc=anton.kochkov@proton.me \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).