From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>
Subject: [PULL 04/12] docs/style: permit inline loop variables
Date: Wed, 30 Aug 2023 15:53:59 +0100 [thread overview]
Message-ID: <20230830145407.3064249-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230830145407.3064249-1-alex.bennee@linaro.org>
I've already wasted enough of my time debugging aliased variables in
deeply nested loops. While not scattering variable declarations around
is a good aim I think we can make an exception for stuff used inside a
loop.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Acked-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230829161528.2707696-5-alex.bennee@linaro.org>
diff --git a/docs/devel/style.rst b/docs/devel/style.rst
index 3cfcdeb9cd..2f68b50079 100644
--- a/docs/devel/style.rst
+++ b/docs/devel/style.rst
@@ -204,7 +204,14 @@ Declarations
Mixed declarations (interleaving statements and declarations within
blocks) are generally not allowed; declarations should be at the beginning
-of blocks.
+of blocks. To avoid accidental re-use it is permissible to declare
+loop variables inside for loops:
+
+.. code-block:: c
+
+ for (int i = 0; i < ARRAY_SIZE(thing); i++) {
+ /* do something loopy */
+ }
Every now and then, an exception is made for declarations inside a
#ifdef or #ifndef block: if the code looks nicer, such declarations can
--
2.39.2
next prev parent reply other threads:[~2023-08-30 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 14:53 [PULL 00/12] testing and gdbstub updates Alex Bennée
2023-08-30 14:53 ` [PULL 01/12] gitlab: enable ccache for many build jobs Alex Bennée
2023-08-30 14:53 ` [PULL 02/12] tests/docker: cleanup non-verbose output Alex Bennée
2023-08-30 14:53 ` [PULL 03/12] tests/tcg: remove quoting for info output Alex Bennée
2023-08-30 14:53 ` Alex Bennée [this message]
2023-08-30 14:54 ` [PULL 05/12] .gitlab-ci.d/cirrus.yml: Update FreeBSD to v13.2 Alex Bennée
2023-08-30 14:54 ` [PULL 06/12] tests: remove test-gdbstub.py Alex Bennée
2023-08-30 14:54 ` [PULL 07/12] tests/tcg: clean-up gdb confirm/pagination settings Alex Bennée
2023-08-30 14:54 ` [PULL 08/12] gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT Alex Bennée
2023-08-30 14:54 ` [PULL 09/12] gdbstub: remove unused user_ctx field Alex Bennée
2023-08-30 14:54 ` [PULL 10/12] gdbstub: refactor get_feature_xml Alex Bennée
2023-08-30 14:54 ` [PULL 11/12] gdbstub: replace global gdb_has_xml with a function Alex Bennée
2023-08-30 14:54 ` [PULL 12/12] gdbstub: move comment for gdb_register_coprocessor Alex Bennée
2023-08-31 16:14 ` [PULL 00/12] testing and gdbstub updates Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830145407.3064249-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).