From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Daniel Berrange <berrange@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Leonardo Bras <leobras@redhat.com>,
farosas@suse.de, Hanna Reitz <hreitz@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,
kwolf@redhat.com, Coiby Xu <Coiby.Xu@gmail.com>,
Fam Zheng <fam@euphon.net>,
eblake@redhat.com, <qemu-block@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [PATCH v3 3/4] io: check there are no qio_channel_yield() coroutines during ->finalize()
Date: Wed, 30 Aug 2023 18:48:01 -0400 [thread overview]
Message-ID: <20230830224802.493686-4-stefanha@redhat.com> (raw)
In-Reply-To: <20230830224802.493686-1-stefanha@redhat.com>
Callers must clean up their coroutines before calling
object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
assertion to check this.
This patch is preparation for the fd handler changes that follow.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
io/channel.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/io/channel.c b/io/channel.c
index 72f0066af5..c415f3fc88 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -653,6 +653,10 @@ static void qio_channel_finalize(Object *obj)
{
QIOChannel *ioc = QIO_CHANNEL(obj);
+ /* Must not have coroutines in qio_channel_yield() */
+ assert(!ioc->read_coroutine);
+ assert(!ioc->write_coroutine);
+
g_free(ioc->name);
#ifdef _WIN32
--
2.41.0
next prev parent reply other threads:[~2023-08-30 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 22:47 [PATCH v3 0/4] io: follow coroutine AioContext in qio_channel_yield() Stefan Hajnoczi
2023-08-30 22:47 ` [PATCH v3 1/4] nbd: drop unused nbd_receive_negotiate() aio_context argument Stefan Hajnoczi
2023-08-30 22:48 ` [PATCH v3 2/4] nbd: drop unused nbd_start_negotiate() " Stefan Hajnoczi
2023-08-30 22:48 ` Stefan Hajnoczi [this message]
2023-08-30 22:48 ` [PATCH v3 4/4] io: follow coroutine AioContext in qio_channel_yield() Stefan Hajnoczi
2023-09-07 20:41 ` Eric Blake
2023-09-08 10:49 ` Stefan Hajnoczi
2023-08-31 13:31 ` [PATCH v3 0/4] " Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830224802.493686-4-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=leobras@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).