From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>
Subject: [PATCH v3 0/7] aspeed: Add blockdev support for flash device definition
Date: Thu, 31 Aug 2023 14:39:15 +0200 [thread overview]
Message-ID: <20230831123922.105200-1-clg@kaod.org> (raw)
Hello,
This is a respin of series [1] without the patches merged in 8.1.
Since I renamed a property as suggested, I though people might want to
see the result before the next aspeed PR.
It offers the capability to define all CS of all SPI controllers
without introducing new machine types, using blockdev on the command
line :
-blockdev node-name=fmc0,driver=file,filename=./flash-ast2600-evb \
-device mx66u51235f,bus=ssi.0,cs=0x0,drive=fmc0 \
-blockdev node-name=fmc1,driver=file,filename=./flash-ast2600-evb-alt \
-device mx66u51235f,bus=ssi.0,cs=0x1,drive=fmc1 \
-blockdev node-name=spi1,driver=file,filename=./ast2600-evb.pnor \
-device mx66u51235f,cs=0x0,bus=ssi.1,drive=spi1 \
With these changes, it is now possible :
- to define block backends out of order instead relying on the command
line order when using drives.
- to define *all* devices backends. Some machines support up to 8.
- to use different flash models without adding new boards. Machine
options "spi-model" and "fmc-model" could be deprecated.
- to start the machine with -nodefaults to let it fetch instructions
from the FMC0 device, as HW does. Machine option "execute-in-place"
could be deprecated.
Ultimately, we will get rid of drive_get(IF_MTD, ...) but we are not
there yet.
Thanks,
C.
[1] https://lore.kernel.org/qemu-devel/20230607043943.1837186-1-clg@kaod.org/
Changes in v3:
- renamed "addr" property to "cs"
Changes in v2:
- changed "addr" property to a uint8_t
- renamed "uart" machine option to "bmc-console"
Cédric Le Goater (7):
hw/ssi: Add a "cs" property to SSIPeripheral
hw/ssi: Introduce a ssi_get_cs() helper
aspeed/smc: Wire CS lines at reset
hw/ssi: Check for duplicate CS indexes
aspeed: Create flash devices only when defaults are enabled
m25p80: Introduce an helper to retrieve the BlockBackend of a device
aspeed: Get the BlockBackend of FMC0 from the flash device
include/hw/block/flash.h | 4 +++
include/hw/ssi/ssi.h | 5 ++++
hw/arm/aspeed.c | 19 +++++++------
hw/arm/stellaris.c | 4 ++-
hw/arm/xilinx_zynq.c | 1 +
hw/arm/xlnx-versal-virt.c | 1 +
hw/arm/xlnx-zcu102.c | 2 ++
hw/block/m25p80.c | 6 ++++
hw/microblaze/petalogix_ml605_mmu.c | 1 +
hw/ssi/aspeed_smc.c | 8 ++++++
hw/ssi/ssi.c | 43 +++++++++++++++++++++++++++++
11 files changed, 84 insertions(+), 10 deletions(-)
--
2.41.0
next reply other threads:[~2023-08-31 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 12:39 Cédric Le Goater [this message]
2023-08-31 12:39 ` [PATCH v3 1/7] hw/ssi: Add a "cs" property to SSIPeripheral Cédric Le Goater
2023-08-31 12:39 ` [PATCH v3 2/7] hw/ssi: Introduce a ssi_get_cs() helper Cédric Le Goater
2023-08-31 12:39 ` [PATCH v3 3/7] aspeed/smc: Wire CS lines at reset Cédric Le Goater
2023-08-31 12:39 ` [PATCH v3 4/7] hw/ssi: Check for duplicate CS indexes Cédric Le Goater
2023-08-31 12:39 ` [PATCH v3 5/7] aspeed: Create flash devices only when defaults are enabled Cédric Le Goater
2023-08-31 13:00 ` Joel Stanley
2023-08-31 13:22 ` Cédric Le Goater
2023-08-31 13:42 ` Joel Stanley
2023-08-31 16:55 ` Cédric Le Goater
2023-08-31 21:13 ` [PATCH v3.2 " Cédric Le Goater
2023-09-01 8:44 ` Joel Stanley
2023-08-31 12:39 ` [PATCH v3 6/7] m25p80: Introduce an helper to retrieve the BlockBackend of a device Cédric Le Goater
2023-08-31 12:39 ` [PATCH v3 7/7] aspeed: Get the BlockBackend of FMC0 from the flash device Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831123922.105200-1-clg@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).