From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3CDCC83F37 for ; Thu, 31 Aug 2023 19:27:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbnJN-0003ca-3c; Thu, 31 Aug 2023 15:26:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbnJL-0003c8-Kl for qemu-devel@nongnu.org; Thu, 31 Aug 2023 15:26:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbnJJ-0003uW-JM for qemu-devel@nongnu.org; Thu, 31 Aug 2023 15:26:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693509992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oZBIgsu/9Q8JHPWS5y+/fJ21ZwefezbfyrSqCYIGrpA=; b=FNTYmB2WH+VTvJBZUMGr4Xifv0UJygTRDh6QaSyEjp9eJdiThdPXtOS0bNESnsy0SG3Nft pKqeVTE5q/pBfseRhUnGqu6A+2bat0hpTJ/2W2SYWQEIA9qfIqWod8g+EO4NCKz8KeFnkO IpU3Jfz+RmEjFZ2lf/kZU8URj99I2b8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-gwiFUeAGNQ2HHFaa0uilvQ-1; Thu, 31 Aug 2023 15:26:29 -0400 X-MC-Unique: gwiFUeAGNQ2HHFaa0uilvQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F27088030AC; Thu, 31 Aug 2023 19:26:27 +0000 (UTC) Received: from localhost (unknown [10.39.192.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D944492C13; Thu, 31 Aug 2023 19:26:27 +0000 (UTC) Date: Thu, 31 Aug 2023 15:26:26 -0400 From: Stefan Hajnoczi To: Markus Armbruster Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com, eblake@redhat.com, vsementsov@yandex-team.ru, jsnow@redhat.com, idryomov@gmail.com, pl@kamp.de, sw@weilnetz.de, sstabellini@kernel.org, anthony.perard@citrix.com, paul@xen.org, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org, fam@euphon.net, quintela@redhat.com, peterx@redhat.com, leobras@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org, xen-devel@lists.xenproject.org, alex.bennee@linaro.org, peter.maydell@linaro.org Subject: Re: [PATCH 5/7] block/vdi: Clean up local variable shadowing Message-ID: <20230831192626.GC532982@fedora> References: <20230831132546.3525721-1-armbru@redhat.com> <20230831132546.3525721-6-armbru@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZAG2EDmh/L6KrbjK" Content-Disposition: inline In-Reply-To: <20230831132546.3525721-6-armbru@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --ZAG2EDmh/L6KrbjK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 31, 2023 at 03:25:44PM +0200, Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Tracked down with -Wshadow=3Dlocal. > Clean up: delete inner declarations when they are actually redundant, > else rename variables. >=20 > Signed-off-by: Markus Armbruster > --- > block/vdi.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi --ZAG2EDmh/L6KrbjK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmTw6WIACgkQnKSrs4Gr c8jt1Af9FbEzEqEiYZ2++01IYNbKg2fjGgZKNRFpaSRJSazW5ch2jS/28TJe2Pwp NT6kVOmB1FB3HuvXTzHST9ifgRKh5mamqnqtVre6zBCbP//mbtG2wDngEhIcaqqM qexeP3U4cHfODlv386zwdux1d/PJYM91nrUkjKoHb4dJVZfMpaiGjDkiDlpawpuQ bzO/VuHDG5qIyj4AJRzdhoYMoLE5tRadCI1jHhuGFv/rc8u38vFlpoF89W2FfJ0w fUQJ78b915zTp0ySkqZdqU2+0ZjHWUiJi0A822E6VKpXRWm/VSfhZ2vmk/ykbH2U ImrSPRecSMfh7F4RSi0SBsZauw/f7g== =bDUq -----END PGP SIGNATURE----- --ZAG2EDmh/L6KrbjK--