qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Eduardo Habkost" <eduardo@habkost.net>
Subject: [PATCH 12/13] sysemu/kvm: Restrict kvm_has_pit_state2() to x86 targets
Date: Mon,  4 Sep 2023 14:43:23 +0200	[thread overview]
Message-ID: <20230904124325.79040-13-philmd@linaro.org> (raw)
In-Reply-To: <20230904124325.79040-1-philmd@linaro.org>

kvm_has_pit_state2() is only defined for x86 targets (in
target/i386/kvm/kvm.c). Its declaration is pointless on
all other targets. Have it return a boolean.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/sysemu/kvm.h       | 1 -
 target/i386/kvm/kvm_i386.h | 1 +
 hw/i386/kvm/i8254.c        | 1 +
 target/i386/kvm/kvm.c      | 4 ++--
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index 4326b53f90..147967422f 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -221,7 +221,6 @@ int kvm_has_vcpu_events(void);
 int kvm_has_robust_singlestep(void);
 int kvm_has_debugregs(void);
 int kvm_max_nested_state_length(void);
-int kvm_has_pit_state2(void);
 int kvm_has_many_ioeventfds(void);
 int kvm_has_gsi_routing(void);
 int kvm_has_intx_set_mask(void);
diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
index d4a1239c68..76e8f952e5 100644
--- a/target/i386/kvm/kvm_i386.h
+++ b/target/i386/kvm/kvm_i386.h
@@ -33,6 +33,7 @@
 bool kvm_has_smm(void);
 bool kvm_enable_x2apic(void);
 bool kvm_hv_vpindex_settable(void);
+bool kvm_has_pit_state2(void);
 
 bool kvm_enable_sgx_provisioning(KVMState *s);
 bool kvm_hyperv_expand_features(X86CPU *cpu, Error **errp);
diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c
index 6a7383d877..a649b2b7ca 100644
--- a/hw/i386/kvm/i8254.c
+++ b/hw/i386/kvm/i8254.c
@@ -34,6 +34,7 @@
 #include "hw/timer/i8254_internal.h"
 #include "hw/qdev-properties-system.h"
 #include "sysemu/kvm.h"
+#include "target/i386/kvm/kvm_i386.h"
 #include "qom/object.h"
 
 #define KVM_PIT_REINJECT_BIT 0
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
index 639a242ad8..e5cd7cc806 100644
--- a/target/i386/kvm/kvm.c
+++ b/target/i386/kvm/kvm.c
@@ -154,9 +154,9 @@ static KVMMSRHandlers msr_handlers[KVM_MSR_FILTER_MAX_RANGES];
 static RateLimit bus_lock_ratelimit_ctrl;
 static int kvm_get_one_msr(X86CPU *cpu, int index, uint64_t *value);
 
-int kvm_has_pit_state2(void)
+bool kvm_has_pit_state2(void)
 {
-    return has_pit_state2;
+    return !!has_pit_state2;
 }
 
 bool kvm_has_smm(void)
-- 
2.41.0



  parent reply	other threads:[~2023-09-04 12:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 12:43 [PATCH 00/13] target/i386: Cleanups around KVM declarations Philippe Mathieu-Daudé
2023-09-04 12:43 ` [PATCH 01/13] hw/i386/pc: Include missing 'sysemu/tcg.h' header Philippe Mathieu-Daudé
2023-09-09 23:29   ` Richard Henderson
2023-09-04 12:43 ` [PATCH 02/13] hw/i386/pc: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2023-09-09 23:31   ` Richard Henderson
2023-09-04 12:43 ` [PATCH 03/13] hw/i386/fw_cfg: " Philippe Mathieu-Daudé
2023-09-09 23:31   ` Richard Henderson
2023-09-04 12:43 ` [PATCH 04/13] target/i386/helper: Restrict KVM declarations to system emulation Philippe Mathieu-Daudé
2023-09-09 23:31   ` Richard Henderson
2023-09-04 12:43 ` [PATCH 05/13] target/i386/cpu-sysemu: Inline kvm_apic_in_kernel() Philippe Mathieu-Daudé
2023-09-09 23:32   ` Richard Henderson
2023-09-04 12:43 ` [PATCH 06/13] target/i386: Remove unused KVM stubs Philippe Mathieu-Daudé
2023-09-04 12:43 ` [PATCH 07/13] target/i386: Allow elision of kvm_enable_x2apic() Philippe Mathieu-Daudé
2023-09-04 13:40   ` Paolo Bonzini
2023-09-04 13:43     ` Philippe Mathieu-Daudé
2023-09-04 12:43 ` [PATCH 08/13] target/i386: Allow elision of kvm_hv_vpindex_settable() Philippe Mathieu-Daudé
2023-09-04 12:43 ` [PATCH 09/13] target/i386: Restrict declarations specific to CONFIG_KVM Philippe Mathieu-Daudé
2023-09-04 12:43 ` [PATCH 10/13] sysemu/kvm: Restrict kvm_arch_get_supported_cpuid/msr() to x86 targets Philippe Mathieu-Daudé
2023-09-04 12:43 ` [PATCH 11/13] sysemu/kvm: Restrict kvm_get_apic_state() " Philippe Mathieu-Daudé
2023-09-04 12:43 ` Philippe Mathieu-Daudé [this message]
2023-09-04 12:43 ` [PATCH 13/13] sysemu/kvm: Restrict kvm_pc_setup_irq_routing() " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230904124325.79040-13-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=eduardo@habkost.net \
    --cc=kvm@vger.kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).