From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH] hw/i386: Rename kvmvapic.c -> vapic.c
Date: Tue, 5 Sep 2023 16:51:59 +0200 [thread overview]
Message-ID: <20230905145159.7898-1-philmd@linaro.org> (raw)
vAPIC isn't KVM specific, so having its name prefixed 'kvm'
is misleading. Rename it simply 'vapic'. Rename the single
function prefixed 'kvm'.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Interestingly there is a strong dependency on (Kconfig) APIC,
but I couldn't get a single x86 machine building without the
Kconfig 'APIC' key.
---
hw/i386/{kvmvapic.c => vapic.c} | 5 ++---
hw/i386/meson.build | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
rename hw/i386/{kvmvapic.c => vapic.c} (99%)
diff --git a/hw/i386/kvmvapic.c b/hw/i386/vapic.c
similarity index 99%
rename from hw/i386/kvmvapic.c
rename to hw/i386/vapic.c
index 43f8a8f679..35e3a56b35 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/vapic.c
@@ -747,8 +747,7 @@ static void do_vapic_enable(CPUState *cs, run_on_cpu_data data)
s->state = VAPIC_ACTIVE;
}
-static void kvmvapic_vm_state_change(void *opaque, bool running,
- RunState state)
+static void vapic_vm_state_change(void *opaque, bool running, RunState state)
{
MachineState *ms = MACHINE(qdev_get_machine());
VAPICROMState *s = opaque;
@@ -793,7 +792,7 @@ static int vapic_post_load(void *opaque, int version_id)
if (!s->vmsentry) {
s->vmsentry =
- qemu_add_vm_change_state_handler(kvmvapic_vm_state_change, s);
+ qemu_add_vm_change_state_handler(vapic_vm_state_change, s);
}
return 0;
}
diff --git a/hw/i386/meson.build b/hw/i386/meson.build
index cfdbfdcbcb..4909703a89 100644
--- a/hw/i386/meson.build
+++ b/hw/i386/meson.build
@@ -1,7 +1,7 @@
i386_ss = ss.source_set()
i386_ss.add(files(
'fw_cfg.c',
- 'kvmvapic.c',
+ 'vapic.c',
'e820_memory_layout.c',
'multiboot.c',
'x86.c',
--
2.41.0
next reply other threads:[~2023-09-05 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 14:51 Philippe Mathieu-Daudé [this message]
2023-11-22 14:31 ` [PATCH-for-9.0] hw/i386: Rename kvmvapic.c -> vapic.c Philippe Mathieu-Daudé
2023-11-23 10:14 ` [PATCH] " Paolo Bonzini
2023-11-23 11:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905145159.7898-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).