From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: den@openvz.org, Eric Blake <eblake@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: [PATCH 1/8] qemu-nbd: improve error message for dup2 error
Date: Wed, 6 Sep 2023 11:32:03 +0200 [thread overview]
Message-ID: <20230906093210.339585-2-den@openvz.org> (raw)
In-Reply-To: <20230906093210.339585-1-den@openvz.org>
This error is happened when we are not able to close the pipe to the
parent (to trace errors in the child process) and assign stderr to
/dev/null as required by the daemonizing convention.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Suggested-by: Eric Blake <eblake@redhat.com>
CC: Eric Blake <eblake@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
qemu-nbd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index aaccaa3318..4575e4291e 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -324,7 +324,7 @@ static void *nbd_client_thread(void *arg)
} else {
/* Close stderr so that the qemu-nbd process exits. */
if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not set stderr to /dev/null: %s",
+ error_report("Could not release pipe to parent: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
@@ -1181,7 +1181,7 @@ int main(int argc, char **argv)
if (fork_process) {
if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not set stderr to /dev/null: %s",
+ error_report("Could not release pipe to parent: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
--
2.34.1
next prev parent reply other threads:[~2023-09-06 9:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 9:32 [PATCH v3 0/8] qemu-nbd: Restore "qemu-nbd -v --fork" output Denis V. Lunev
2023-09-06 9:32 ` Denis V. Lunev [this message]
2023-09-07 20:46 ` [PATCH 1/8] qemu-nbd: improve error message for dup2 error Eric Blake
2023-09-06 9:32 ` [PATCH 2/8] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined Denis V. Lunev
2023-09-07 21:35 ` Eric Blake
2023-09-06 9:32 ` [PATCH 3/8] qemu-nbd: move srcpath into struct NbdClientOpts Denis V. Lunev
2023-09-07 21:43 ` Eric Blake
2023-09-06 9:32 ` [PATCH 4/8] qemu-nbd: put saddr into " Denis V. Lunev
2023-09-07 21:48 ` Eric Blake
2023-09-06 9:32 ` [PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper Denis V. Lunev
2023-09-07 21:54 ` Eric Blake
2023-09-06 9:32 ` [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output Denis V. Lunev
2023-09-07 21:59 ` Eric Blake
2023-09-06 9:32 ` [PATCH 7/8] qemu-nbd: document -v behavior in respect to --fork in man Denis V. Lunev
2023-09-07 22:01 ` Eric Blake
2023-09-07 22:03 ` Denis V. Lunev
2023-09-06 9:32 ` [PATCH 8/8] qemu-nbd: fix formatting in main() Denis V. Lunev
2023-09-07 22:15 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906093210.339585-2-den@openvz.org \
--to=den@openvz.org \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).