qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: den@openvz.org, Eric Blake <eblake@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: [PATCH 4/8] qemu-nbd: put saddr into into struct NbdClientOpts
Date: Wed,  6 Sep 2023 11:32:06 +0200	[thread overview]
Message-ID: <20230906093210.339585-5-den@openvz.org> (raw)
In-Reply-To: <20230906093210.339585-1-den@openvz.org>

We pass other parameters into nbd_client_thread() in this way. This patch
makes the code more consistent.

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Eric Blake <eblake@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 qemu-nbd.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/qemu-nbd.c b/qemu-nbd.c
index de6c2be590..d0f8d8bad2 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -73,7 +73,6 @@
 
 #define MBR_SIZE 512
 
-static SocketAddress *saddr;
 static int persistent = 0;
 static enum { RUNNING, TERMINATE, TERMINATED } state;
 static int shared = 1;
@@ -255,6 +254,7 @@ static int qemu_nbd_client_list(SocketAddress *saddr, QCryptoTLSCreds *tls,
 struct NbdClientOpts {
     char *device;
     char *srcpath;
+    SocketAddress *saddr;
     bool fork_process;
     bool verbose;
 };
@@ -289,7 +289,7 @@ static void *nbd_client_thread(void *arg)
 
     sioc = qio_channel_socket_new();
     if (qio_channel_socket_connect_sync(sioc,
-                                        saddr,
+                                        opts->saddr,
                                         &local_error) < 0) {
         error_report_err(local_error);
         goto out;
@@ -591,6 +591,7 @@ int main(int argc, char **argv)
         .verbose = false,
         .device = NULL,
         .srcpath = NULL,
+        .saddr = NULL,
     };
 
 #ifdef CONFIG_POSIX
@@ -892,8 +893,8 @@ int main(int argc, char **argv)
     }
 
     if (list) {
-        saddr = nbd_build_socket_address(sockpath, bindto, port);
-        return qemu_nbd_client_list(saddr, tlscreds,
+        opts.saddr = nbd_build_socket_address(sockpath, bindto, port);
+        return qemu_nbd_client_list(opts.saddr, tlscreds,
                                     tlshostname ? tlshostname : bindto);
     }
 
@@ -1024,8 +1025,8 @@ int main(int argc, char **argv)
             exit(EXIT_FAILURE);
         }
 #endif
-        saddr = nbd_build_socket_address(sockpath, bindto, port);
-        if (qio_net_listener_open_sync(server, saddr, backlog,
+        opts.saddr = nbd_build_socket_address(sockpath, bindto, port);
+        if (qio_net_listener_open_sync(server, opts.saddr, backlog,
                                        &local_err) < 0) {
             object_unref(OBJECT(server));
             error_report_err(local_err);
-- 
2.34.1



  parent reply	other threads:[~2023-09-06  9:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  9:32 [PATCH v3 0/8] qemu-nbd: Restore "qemu-nbd -v --fork" output Denis V. Lunev
2023-09-06  9:32 ` [PATCH 1/8] qemu-nbd: improve error message for dup2 error Denis V. Lunev
2023-09-07 20:46   ` Eric Blake
2023-09-06  9:32 ` [PATCH 2/8] qemu-nbd: define struct NbdClientOpts when HAVE_NBD_DEVICE is not defined Denis V. Lunev
2023-09-07 21:35   ` Eric Blake
2023-09-06  9:32 ` [PATCH 3/8] qemu-nbd: move srcpath into struct NbdClientOpts Denis V. Lunev
2023-09-07 21:43   ` Eric Blake
2023-09-06  9:32 ` Denis V. Lunev [this message]
2023-09-07 21:48   ` [PATCH 4/8] qemu-nbd: put saddr into " Eric Blake
2023-09-06  9:32 ` [PATCH 5/8] qemu-nbd: invent nbd_client_release_pipe() helper Denis V. Lunev
2023-09-07 21:54   ` Eric Blake
2023-09-06  9:32 ` [PATCH 6/8] qemu-nbd: Restore "qemu-nbd -v --fork" output Denis V. Lunev
2023-09-07 21:59   ` Eric Blake
2023-09-06  9:32 ` [PATCH 7/8] qemu-nbd: document -v behavior in respect to --fork in man Denis V. Lunev
2023-09-07 22:01   ` Eric Blake
2023-09-07 22:03     ` Denis V. Lunev
2023-09-06  9:32 ` [PATCH 8/8] qemu-nbd: fix formatting in main() Denis V. Lunev
2023-09-07 22:15   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230906093210.339585-5-den@openvz.org \
    --to=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).