From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, stefanha@gmail.com,
Alexander Ivanov <alexander.ivanov@virtuozzo.com>,
"Denis V . Lunev" <den@openvz.org>
Subject: [PULL 05/18] parallels: Add "explicit" argument to parallels_check_leak()
Date: Wed, 6 Sep 2023 17:49:38 +0200 [thread overview]
Message-ID: <20230906154942.656537-6-den@openvz.org> (raw)
In-Reply-To: <20230906154942.656537-1-den@openvz.org>
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
In the on of the next patches we need to repair leaks without changing
leaks and leaks_fixed info in res. Also we don't want to print any warning
about leaks. Add "explicit" argument to skip info changing if the argument
is false.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
block/parallels.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index 6a3d41373a..8bb5d115fc 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -488,7 +488,7 @@ parallels_check_outside_image(BlockDriverState *bs, BdrvCheckResult *res,
static int coroutine_fn GRAPH_RDLOCK
parallels_check_leak(BlockDriverState *bs, BdrvCheckResult *res,
- BdrvCheckMode fix)
+ BdrvCheckMode fix, bool explicit)
{
BDRVParallelsState *s = bs->opaque;
int64_t size;
@@ -503,10 +503,13 @@ parallels_check_leak(BlockDriverState *bs, BdrvCheckResult *res,
if (size > res->image_end_offset) {
int64_t count;
count = DIV_ROUND_UP(size - res->image_end_offset, s->cluster_size);
- fprintf(stderr, "%s space leaked at the end of the image %" PRId64 "\n",
- fix & BDRV_FIX_LEAKS ? "Repairing" : "ERROR",
- size - res->image_end_offset);
- res->leaks += count;
+ if (explicit) {
+ fprintf(stderr,
+ "%s space leaked at the end of the image %" PRId64 "\n",
+ fix & BDRV_FIX_LEAKS ? "Repairing" : "ERROR",
+ size - res->image_end_offset);
+ res->leaks += count;
+ }
if (fix & BDRV_FIX_LEAKS) {
Error *local_err = NULL;
@@ -521,7 +524,9 @@ parallels_check_leak(BlockDriverState *bs, BdrvCheckResult *res,
res->check_errors++;
return ret;
}
- res->leaks_fixed += count;
+ if (explicit) {
+ res->leaks_fixed += count;
+ }
}
}
@@ -574,7 +579,7 @@ parallels_co_check(BlockDriverState *bs, BdrvCheckResult *res,
return ret;
}
- ret = parallels_check_leak(bs, res, fix);
+ ret = parallels_check_leak(bs, res, fix, true);
if (ret < 0) {
return ret;
}
--
2.34.1
next prev parent reply other threads:[~2023-09-06 15:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 15:49 [PULL 00/18] Parallels format driver Denis V. Lunev
2023-09-06 15:49 ` [PULL 01/18] MAINTAINERS: add tree to keep parallels format driver changes Denis V. Lunev
2023-09-06 15:49 ` [PULL 02/18] parallels: Fix comments formatting inside parallels driver Denis V. Lunev
2023-09-06 15:49 ` [PULL 03/18] parallels: Incorrect data end calculation in parallels_open() Denis V. Lunev
2023-09-06 15:49 ` [PULL 04/18] parallels: Check if data_end greater than the file size Denis V. Lunev
2023-09-06 15:49 ` Denis V. Lunev [this message]
2023-09-06 15:49 ` [PULL 06/18] parallels: Add data_start field to BDRVParallelsState Denis V. Lunev
2023-09-06 15:49 ` [PULL 07/18] parallels: Add checking and repairing duplicate offsets in BAT Denis V. Lunev
2023-09-06 15:49 ` [PULL 08/18] parallels: Image repairing in parallels_open() Denis V. Lunev
2023-09-06 15:49 ` [PULL 09/18] parallels: Use bdrv_co_getlength() in parallels_check_outside_image() Denis V. Lunev
2023-09-06 15:54 ` [PULL 10/18] parallels: Add data_off check Denis V. Lunev
2023-09-06 15:54 ` [PULL 11/18] parallels: Add data_off repairing to parallels_open() Denis V. Lunev
2023-09-06 15:54 ` [PULL 12/18] iotests: Add out-of-image check test for parallels format Denis V. Lunev
2023-09-06 15:54 ` [PULL 13/18] iotests: Add leak " Denis V. Lunev
2023-09-06 15:54 ` [PULL 14/18] iotests: Add test for BAT entries duplication check Denis V. Lunev
2023-09-06 15:54 ` [PULL 15/18] iotests: Refactor tests of parallels images checks (131) Denis V. Lunev
2023-09-06 15:54 ` [PULL 16/18] iotests: Fix cluster size in parallels images tests (131) Denis V. Lunev
2023-09-06 15:54 ` [PULL 17/18] iotests: Fix test 131 after repair was added to parallels_open() Denis V. Lunev
2023-09-06 15:54 ` [PULL 18/18] iotests: Add test for data_off check Denis V. Lunev
2023-09-07 15:43 ` [PULL 00/18] Parallels format driver Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906154942.656537-6-den@openvz.org \
--to=den@openvz.org \
--cc=alexander.ivanov@virtuozzo.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).