From: Alexey Baturo <baturo.alexey@gmail.com>
Cc: baturo.alexey@gmail.com, richard.henderson@linaro.org,
palmer@dabbelt.com, Alistair.Francis@wdc.com,
zhiwei_liu@linux.alibaba.com, sagark@eecs.berkeley.edu,
kbastian@mail.uni-paderborn.de, qemu-devel@nongnu.org,
qemu-riscv@nongnu.org
Subject: [RFC v1 7/8] target/riscv: Update address modify functions to take into account pointer masking
Date: Fri, 8 Sep 2023 18:26:39 +0000 [thread overview]
Message-ID: <20230908182640.1102270-8-baturo.alexey@gmail.com> (raw)
In-Reply-To: <20230908182640.1102270-1-baturo.alexey@gmail.com>
Signed-off-by: Alexey Baturo <baturo.alexey@gmail.com>
---
target/riscv/translate.c | 21 +++++++++++++++++++--
target/riscv/vector_helper.c | 7 +++++++
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index 3434ba58b6..4aa0e2b9e1 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -581,7 +581,15 @@ static TCGv get_address(DisasContext *ctx, int rs1, int imm)
TCGv src1 = get_gpr(ctx, rs1, EXT_NONE);
tcg_gen_addi_tl(addr, src1, imm);
- if (get_address_xl(ctx) == MXL_RV32) {
+ if (ctx->pm_enabled) {
+ tcg_gen_shl_tl(addr, addr, pm_n_bits);
+ /* sign extend address by first non-masked bit otherwise zero extend */
+ if (ctx->pm_signext) {
+ tcg_gen_sar_tl(addr, addr, pm_n_bits);
+ } else {
+ tcg_gen_shr_tl(addr, addr, pm_n_bits);
+ }
+ } else if (get_address_xl(ctx) == MXL_RV32) {
tcg_gen_ext32u_tl(addr, addr);
}
@@ -595,7 +603,16 @@ static TCGv get_address_indexed(DisasContext *ctx, int rs1, TCGv offs)
TCGv src1 = get_gpr(ctx, rs1, EXT_NONE);
tcg_gen_add_tl(addr, src1, offs);
- if (get_xl(ctx) == MXL_RV32) {
+ /* sign extend address by first non-masked bit */
+ if (ctx->pm_enabled) {
+ tcg_gen_shl_tl(addr, addr, pm_n_bits);
+ /* sign extend address by first non-masked bit otherwise zero extend */
+ if (ctx->pm_signext) {
+ tcg_gen_sar_tl(addr, addr, pm_n_bits);
+ } else {
+ tcg_gen_shr_tl(addr, addr, pm_n_bits);
+ }
+ } else if (get_xl(ctx) == MXL_RV32) {
tcg_gen_ext32u_tl(addr, addr);
}
return addr;
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index af07e1067d..d3ddc2fd41 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -169,6 +169,13 @@ static inline uint32_t vext_get_total_elems(CPURISCVState *env, uint32_t desc,
static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong addr)
{
+ addr = addr << env->pm_n_bits;
+ /* sign/zero extend masked address by N-1 bit */
+ if (env->pm_signext) {
+ addr = (target_long)addr >> env->pm_n_bits;
+ } else {
+ addr = addr >> env->pm_n_bits;
+ }
return addr;
}
--
2.34.1
next prev parent reply other threads:[~2023-09-08 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 18:26 [RFC v1 0/8] RISC-V Pointer Masking update to Zjpm v0.6.1 Alexey Baturo
2023-09-08 18:26 ` [RFC v1 1/8] target/riscv: Remove obsolete pointer masking extension code Alexey Baturo
2023-09-18 1:36 ` Alistair Francis
2023-09-08 18:26 ` [RFC v1 2/8] target/riscv: Add new S{sn, mn, m}jpm extensions as part of Zjpm v0.6.1 Alexey Baturo
2023-09-18 1:44 ` Alistair Francis
2023-09-08 18:26 ` [RFC v1 3/8] target/riscv: Add new bits in CSRs for Zjpm 0.6.1 Alexey Baturo
2023-09-08 18:26 ` [RFC v1 4/8] Add enum with maximum ignored bits depending on privilege level for Zjpm v0.6.1 Alexey Baturo
2023-09-08 18:26 ` [RFC v1 5/8] target/riscv: Add pointer masking tb flags Alexey Baturo
2023-09-08 18:26 ` [RFC v1 6/8] target/riscv: Add functions to calculate current N masked bits for pointer masking Alexey Baturo
2023-09-18 1:46 ` Alistair Francis
2023-09-08 18:26 ` Alexey Baturo [this message]
2023-09-08 18:26 ` [RFC v1 8/8] target/riscv: enable updates for pointer masking variables and thus enable pointer masking extension Alexey Baturo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908182640.1102270-8-baturo.alexey@gmail.com \
--to=baturo.alexey@gmail.com \
--cc=Alistair.Francis@wdc.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sagark@eecs.berkeley.edu \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).