qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <anisinha@redhat.com>
To: david@redhat.com
Cc: pbonzini@redhat.com, mst@redhat.com,
	richard.henderson@linaro.org, philmd@linaro.org,
	Ani Sinha <anisinha@redhat.com>,
	qemu-devel@nongnu.org
Subject: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Date: Tue, 12 Sep 2023 17:36:50 +0530	[thread overview]
Message-ID: <20230912120650.371781-1-anisinha@redhat.com> (raw)

PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
guest processor and set phys_bits to 36 if PAE feature is set. This is in
addition to checking the presence of PSE36 CPUID feature for setting 36 bit
phys_bits.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 target/i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Note: Not sure what tests I should be running in order to make sure I am
not breaking any guest OSes. Usual qtests pass.

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 24ee67b42d..f3a5c99117 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
             return;
         }
 
-        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
+        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
             cpu->phys_bits = 36;
         } else {
             cpu->phys_bits = 32;
-- 
2.39.1



             reply	other threads:[~2023-09-12 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 12:06 Ani Sinha [this message]
2023-09-12 15:05 ` [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space David Hildenbrand
2023-10-18 12:05 ` Michael S. Tsirkin
2023-10-18 17:38   ` Ani Sinha
2023-10-18 17:44     ` Michael S. Tsirkin
2023-10-19  2:06       ` Ani Sinha
2023-10-20 16:52         ` Ani Sinha
2023-10-21  8:04 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912120650.371781-1-anisinha@redhat.com \
    --to=anisinha@redhat.com \
    --cc=david@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).