* [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
@ 2023-09-12 12:06 Ani Sinha
2023-09-12 15:05 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Ani Sinha @ 2023-09-12 12:06 UTC (permalink / raw)
To: david; +Cc: pbonzini, mst, richard.henderson, philmd, Ani Sinha, qemu-devel
PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
guest processor and set phys_bits to 36 if PAE feature is set. This is in
addition to checking the presence of PSE36 CPUID feature for setting 36 bit
phys_bits.
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Note: Not sure what tests I should be running in order to make sure I am
not breaking any guest OSes. Usual qtests pass.
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 24ee67b42d..f3a5c99117 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
return;
}
- if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
+ if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
cpu->phys_bits = 36;
} else {
cpu->phys_bits = 32;
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-09-12 12:06 [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space Ani Sinha
@ 2023-09-12 15:05 ` David Hildenbrand
2023-10-18 12:05 ` Michael S. Tsirkin
2023-10-21 8:04 ` Paolo Bonzini
2 siblings, 0 replies; 8+ messages in thread
From: David Hildenbrand @ 2023-09-12 15:05 UTC (permalink / raw)
To: Ani Sinha; +Cc: pbonzini, mst, richard.henderson, philmd, qemu-devel
On 12.09.23 14:06, Ani Sinha wrote:
> PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> guest processor and set phys_bits to 36 if PAE feature is set. This is in
> addition to checking the presence of PSE36 CPUID feature for setting 36 bit
> phys_bits.
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Note: Not sure what tests I should be running in order to make sure I am
> not breaking any guest OSes. Usual qtests pass.
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..f3a5c99117 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> return;
> }
>
> - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
> cpu->phys_bits = 36;
> } else {
> cpu->phys_bits = 32;
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-09-12 12:06 [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space Ani Sinha
2023-09-12 15:05 ` David Hildenbrand
@ 2023-10-18 12:05 ` Michael S. Tsirkin
2023-10-18 17:38 ` Ani Sinha
2023-10-21 8:04 ` Paolo Bonzini
2 siblings, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2023-10-18 12:05 UTC (permalink / raw)
To: Ani Sinha; +Cc: david, pbonzini, richard.henderson, philmd, qemu-devel
On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> guest processor and set phys_bits to 36 if PAE feature is set. This is in
> addition to checking the presence of PSE36 CPUID feature for setting 36 bit
> phys_bits.
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
who's applying this?
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Note: Not sure what tests I should be running in order to make sure I am
> not breaking any guest OSes. Usual qtests pass.
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..f3a5c99117 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> return;
> }
>
> - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
> cpu->phys_bits = 36;
> } else {
> cpu->phys_bits = 32;
> --
> 2.39.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-10-18 12:05 ` Michael S. Tsirkin
@ 2023-10-18 17:38 ` Ani Sinha
2023-10-18 17:44 ` Michael S. Tsirkin
0 siblings, 1 reply; 8+ messages in thread
From: Ani Sinha @ 2023-10-18 17:38 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: David Hildenbrand, Paolo Bonzini, Richard Henderson,
Philippe Mathieu-Daudé, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com> wrote:
> On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> > PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> > guest processor and set phys_bits to 36 if PAE feature is set. This is in
> > addition to checking the presence of PSE36 CPUID feature for setting 36
> bit
> > phys_bits.
> >
> > Signed-off-by: Ani Sinha <anisinha@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> who's applying this?
>
I thought it would be you? What did I miss?
> > ---
> > target/i386/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Note: Not sure what tests I should be running in order to make sure I am
> > not breaking any guest OSes. Usual qtests pass.
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 24ee67b42d..f3a5c99117 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev,
> Error **errp)
> > return;
> > }
> >
> > - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> > + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
> > cpu->phys_bits = 36;
> > } else {
> > cpu->phys_bits = 32;
> > --
> > 2.39.1
>
>
[-- Attachment #2: Type: text/html, Size: 2258 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-10-18 17:38 ` Ani Sinha
@ 2023-10-18 17:44 ` Michael S. Tsirkin
2023-10-19 2:06 ` Ani Sinha
0 siblings, 1 reply; 8+ messages in thread
From: Michael S. Tsirkin @ 2023-10-18 17:44 UTC (permalink / raw)
To: Ani Sinha
Cc: David Hildenbrand, Paolo Bonzini, Richard Henderson,
Philippe Mathieu-Daudé, qemu-devel
On Wed, Oct 18, 2023 at 11:08:11PM +0530, Ani Sinha wrote:
>
>
> On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com> wrote:
>
> On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> > PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> > guest processor and set phys_bits to 36 if PAE feature is set. This is in
> > addition to checking the presence of PSE36 CPUID feature for setting 36
> bit
> > phys_bits.
> >
> > Signed-off-by: Ani Sinha <anisinha@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> who's applying this?
>
>
> I thought it would be you? What did I miss?
I just don't play a lot with CPUID flags and might easily miss things.
Used to be Eduardo .. maybe CC him.
>
>
> > ---
> > target/i386/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Note: Not sure what tests I should be running in order to make sure I am
> > not breaking any guest OSes. Usual qtests pass.
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 24ee67b42d..f3a5c99117 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev,
> Error **errp)
> > return;
> > }
> >
> > - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> > + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
> > cpu->phys_bits = 36;
> > } else {
> > cpu->phys_bits = 32;
> > --
> > 2.39.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-10-18 17:44 ` Michael S. Tsirkin
@ 2023-10-19 2:06 ` Ani Sinha
2023-10-20 16:52 ` Ani Sinha
0 siblings, 1 reply; 8+ messages in thread
From: Ani Sinha @ 2023-10-19 2:06 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: David Hildenbrand, Paolo Bonzini, Richard Henderson,
Philippe Mathieu-Daudé, qemu-devel, Eduardo Habkost
[-- Attachment #1: Type: text/plain, Size: 1872 bytes --]
On Wed, 18 Oct, 2023, 11:14 pm Michael S. Tsirkin, <mst@redhat.com> wrote:
> On Wed, Oct 18, 2023 at 11:08:11PM +0530, Ani Sinha wrote:
> >
> >
> > On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com>
> wrote:
> >
> > On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> > > PAE mode in x86 supports 36 bit address space. Check the PAE CPUID
> on the
> > > guest processor and set phys_bits to 36 if PAE feature is set.
> This is in
> > > addition to checking the presence of PSE36 CPUID feature for
> setting 36
> > bit
> > > phys_bits.
> > >
> > > Signed-off-by: Ani Sinha <anisinha@redhat.com>
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > who's applying this?
> >
> >
> > I thought it would be you? What did I miss?
>
> I just don't play a lot with CPUID flags and might easily miss things.
> Used to be Eduardo .. maybe CC him.
>
Eduardo can you pick this up?
> >
> >
> > > ---
> > > target/i386/cpu.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Note: Not sure what tests I should be running in order to make
> sure I am
> > > not breaking any guest OSes. Usual qtests pass.
> > >
> > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > > index 24ee67b42d..f3a5c99117 100644
> > > --- a/target/i386/cpu.c
> > > +++ b/target/i386/cpu.c
> > > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState
> *dev,
> > Error **errp)
> > > return;
> > > }
> > >
> > > - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> > > + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 |
> CPUID_PAE)) {
> > > cpu->phys_bits = 36;
> > > } else {
> > > cpu->phys_bits = 32;
> > > --
> > > 2.39.1
> >
> >
>
>
[-- Attachment #2: Type: text/html, Size: 3159 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-10-19 2:06 ` Ani Sinha
@ 2023-10-20 16:52 ` Ani Sinha
0 siblings, 0 replies; 8+ messages in thread
From: Ani Sinha @ 2023-10-20 16:52 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: David Hildenbrand, Paolo Bonzini, Richard Henderson,
Philippe Mathieu-Daudé, qemu-devel, Eduardo Habkost
[-- Attachment #1: Type: text/plain, Size: 2070 bytes --]
On Thu, 19 Oct, 2023, 7:36 am Ani Sinha, <anisinha@redhat.com> wrote:
>
>
> On Wed, 18 Oct, 2023, 11:14 pm Michael S. Tsirkin, <mst@redhat.com> wrote:
>
>> On Wed, Oct 18, 2023 at 11:08:11PM +0530, Ani Sinha wrote:
>> >
>> >
>> > On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com>
>> wrote:
>> >
>> > On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
>> > > PAE mode in x86 supports 36 bit address space. Check the PAE
>> CPUID on the
>> > > guest processor and set phys_bits to 36 if PAE feature is set.
>> This is in
>> > > addition to checking the presence of PSE36 CPUID feature for
>> setting 36
>> > bit
>> > > phys_bits.
>> > >
>> > > Signed-off-by: Ani Sinha <anisinha@redhat.com>
>> >
>> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> >
>> > who's applying this?
>> >
>> >
>> > I thought it would be you? What did I miss?
>>
>> I just don't play a lot with CPUID flags and might easily miss things.
>> Used to be Eduardo .. maybe CC him.
>>
>
> Eduardo can you pick this up?
>
If Eduardo doesn't respond I'll send a PR for this.
>
>> >
>> >
>> > > ---
>> > > target/i386/cpu.c | 2 +-
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > Note: Not sure what tests I should be running in order to make
>> sure I am
>> > > not breaking any guest OSes. Usual qtests pass.
>> > >
>> > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> > > index 24ee67b42d..f3a5c99117 100644
>> > > --- a/target/i386/cpu.c
>> > > +++ b/target/i386/cpu.c
>> > > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState
>> *dev,
>> > Error **errp)
>> > > return;
>> > > }
>> > >
>> > > - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
>> > > + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 |
>> CPUID_PAE)) {
>> > > cpu->phys_bits = 36;
>> > > } else {
>> > > cpu->phys_bits = 32;
>> > > --
>> > > 2.39.1
>> >
>> >
>>
>>
[-- Attachment #2: Type: text/html, Size: 3897 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
2023-09-12 12:06 [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space Ani Sinha
2023-09-12 15:05 ` David Hildenbrand
2023-10-18 12:05 ` Michael S. Tsirkin
@ 2023-10-21 8:04 ` Paolo Bonzini
2 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2023-10-21 8:04 UTC (permalink / raw)
To: Ani Sinha, david; +Cc: mst, richard.henderson, philmd, qemu-devel
On 9/12/23 14:06, Ani Sinha wrote:
> PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> guest processor and set phys_bits to 36 if PAE feature is set. This is in
> addition to checking the presence of PSE36 CPUID feature for setting 36 bit
> phys_bits.
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> target/i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Note: Not sure what tests I should be running in order to make sure I am
> not breaking any guest OSes. Usual qtests pass.
Queued, thanks.
Paolo
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..f3a5c99117 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> return;
> }
>
> - if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> + if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
> cpu->phys_bits = 36;
> } else {
> cpu->phys_bits = 32;
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-10-21 8:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-12 12:06 [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space Ani Sinha
2023-09-12 15:05 ` David Hildenbrand
2023-10-18 12:05 ` Michael S. Tsirkin
2023-10-18 17:38 ` Ani Sinha
2023-10-18 17:44 ` Michael S. Tsirkin
2023-10-19 2:06 ` Ani Sinha
2023-10-20 16:52 ` Ani Sinha
2023-10-21 8:04 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).