From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
alex.williamson@redhat.com, clg@redhat.com,
jean-philippe@linaro.org, mst@redhat.com, pbonzini@redhat.com
Cc: peter.maydell@linaro.org, peterx@redhat.com, david@redhat.com,
philmd@linaro.org
Subject: [PATCH v2 11/12] test: Add some tests for range and resv-mem helpers
Date: Wed, 13 Sep 2023 10:01:46 +0200 [thread overview]
Message-ID: <20230913080423.523953-12-eric.auger@redhat.com> (raw)
In-Reply-To: <20230913080423.523953-1-eric.auger@redhat.com>
Add unit tests for both resv_region_list_insert() and
range_inverse_array().
Signed-off-by: Eric Auger <eric.auger@redhat.com>
---
tests/unit/test-resv-mem.c | 251 +++++++++++++++++++++++++++++++++++++
tests/unit/meson.build | 1 +
2 files changed, 252 insertions(+)
create mode 100644 tests/unit/test-resv-mem.c
diff --git a/tests/unit/test-resv-mem.c b/tests/unit/test-resv-mem.c
new file mode 100644
index 0000000000..8fc7dbf1dd
--- /dev/null
+++ b/tests/unit/test-resv-mem.c
@@ -0,0 +1,251 @@
+/*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * reserved-region/range.c unit-tests.
+ *
+ * Copyright (C) 2023, Red Hat, Inc.
+ *
+ * Author: Eric Auger <eric.auger@redhat.com>
+ */
+
+#include "qemu/osdep.h"
+#include "qemu/range.h"
+#include "exec/memory.h"
+#include "qemu/reserved-region.h"
+
+#define DEBUG 0
+
+static void print_rev_array(const char *prefix, uint32_t nr_rev,
+ Range *rev, uint32_t expected_nr_rev)
+{
+ g_assert_cmpint(nr_rev, ==, expected_nr_rev);
+#if DEBUG
+ printf("%s nr_rev=%d\n", prefix, nr_rev);
+ for (int i = 0; i < nr_rev; i++) {
+ printf("%s rev[%i] = [0x%"PRIx64",0x%"PRIx64"]\n",
+ prefix, i, range_lob(&rev[i]), range_upb(&rev[i]));
+ }
+#endif
+}
+
+static void check_range_reverse_array(void)
+{
+ Range r[10];
+ Range *rev;
+ uint32_t nr_rev;
+
+ range_set_bounds(&r[0], 0x10000, UINT64_MAX);
+ range_inverse_array(1, r, &nr_rev, &rev, 0, UINT64_MAX);
+ print_rev_array("test1", nr_rev, rev, 1);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x10000, 0xFFFFFFFFFFFF);
+ range_inverse_array(1, r, &nr_rev, &rev, 0, UINT64_MAX);
+ print_rev_array("test2", nr_rev, rev, 2);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x0, 0xFFFF);
+ range_set_bounds(&r[1], 0x10000, 0x2FFFF);
+ range_inverse_array(2, r, &nr_rev, &rev, 0, UINT64_MAX);
+ print_rev_array("test3", nr_rev, rev, 1);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x50000, 0x5FFFF);
+ range_set_bounds(&r[1], 0x60000, 0xFFFFFFFFFFFF);
+ range_inverse_array(2, r, &nr_rev, &rev, 0, UINT64_MAX);
+ print_rev_array("test4", nr_rev, rev, 2);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x0, UINT64_MAX);
+ range_inverse_array(1, r, &nr_rev, &rev, 0, UINT64_MAX);
+ print_rev_array("test5", nr_rev, rev, 0);
+ g_free(rev);
+}
+
+static void check_range_reverse_array_low_end(void)
+{
+ Range r[10];
+ Range *rev;
+ uint32_t nr_rev;
+
+ printf("%s\n", __func__);
+ range_set_bounds(&r[0], 0x0, UINT64_MAX);
+ range_inverse_array(1, r, &nr_rev, &rev, 0x10000, 0xFFFFFF);
+ print_rev_array("test1", nr_rev, rev, 0);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x0, 0xFFFF);
+ range_set_bounds(&r[1], 0x20000, 0x2FFFF);
+ range_inverse_array(2, r, &nr_rev, &rev, 0x40000, 0xFFFFFFFFFFFF);
+ print_rev_array("test2", nr_rev, rev, 1);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x0, 0xFFFF);
+ range_set_bounds(&r[1], 0x20000, 0x2FFFF);
+ range_set_bounds(&r[2], 0x1000000000000, UINT64_MAX);
+ range_inverse_array(3, r, &nr_rev, &rev, 0x40000, 0xFFFFFFFFFFFF);
+ print_rev_array("test3", nr_rev, rev, 1);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x0, 0xFFFF);
+ range_set_bounds(&r[1], 0x10000, 0x2FFFF);
+ range_set_bounds(&r[2], 0x100000000, 0x100000000FFFF);
+ range_inverse_array(3, r, &nr_rev, &rev, 0x20000, 0xFFFFFFFFFFFF);
+ print_rev_array("test4", nr_rev, rev, 1);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x2000, 0xFFFF);
+ range_set_bounds(&r[1], 0x20000, 0x2FFFF);
+ range_set_bounds(&r[2], 0x100000000, 0x1FFFFFFFF);
+ range_inverse_array(3, r, &nr_rev, &rev, 0x1000, 0xFFFFFFFFFFFF);
+ /*
+ * expects [0x1000, 0x2000] [0x10000, 0x1FFFF] [0x30000, 0xFFFFFFFF]
+ * [0x200000000, 0xFFFFFFFFFFFF]
+ */
+ print_rev_array("test4", nr_rev, rev, 4);
+ g_free(rev);
+
+ range_set_bounds(&r[0], 0x10000000 , 0x1FFFFFFF);
+ range_set_bounds(&r[1], 0x100000000, 0x1FFFFFFFF);
+ range_inverse_array(2, r, &nr_rev, &rev, 0x0, 0xFFFF);
+ /* expects [0x0, 0xFFFF] */
+ print_rev_array("test5", nr_rev, rev, 1);
+ g_free(rev);
+}
+
+static ReservedRegion *alloc_resv_mem(unsigned type, uint64_t lob, uint64_t upb)
+{
+ ReservedRegion *r;
+
+ r = g_new0(ReservedRegion, 1);
+ r->type = type;
+ range_set_bounds(&r->range, lob, upb);
+ return r;
+}
+
+static void print_resv_region_list(const char *prefix, GList *list,
+ uint32_t expected_length)
+{
+ int i = g_list_length(list);
+
+ g_assert_cmpint(i, ==, expected_length);
+#if DEBUG
+ i = 0;
+ for (GList *l = list; l; l = l->next) {
+ ReservedRegion *r = (ReservedRegion *)l->data;
+ Range *range = &r->range;
+
+ printf("%s item[%d]=[0x%x, 0x%"PRIx64", 0x%"PRIx64"]\n",
+ prefix, i++, r->type, range_lob(range), range_upb(range));
+ }
+#endif
+}
+
+static void free_resv_region(gpointer data)
+{
+ ReservedRegion *reg = (ReservedRegion *)data;
+
+ g_free(reg);
+}
+
+static void check_resv_region_list_insert(void)
+{
+ ReservedRegion *r[10];
+ GList *l = NULL;
+
+ r[0] = alloc_resv_mem(0xA, 0, 0xFFFF);
+ r[1] = alloc_resv_mem(0xA, 0x20000, 0x2FFFF);
+ l = resv_region_list_insert(l, r[0]);
+ l = resv_region_list_insert(l, r[1]);
+ print_resv_region_list("test1", l, 2);
+
+ /* adjacent on left */
+ r[2] = alloc_resv_mem(0xB, 0x0, 0xFFF);
+ l = resv_region_list_insert(l, r[2]);
+ /* adjacent on right */
+ r[3] = alloc_resv_mem(0xC, 0x21000, 0x2FFFF);
+ l = resv_region_list_insert(l, r[3]);
+ print_resv_region_list("test2", l, 4);
+
+ /* exact overlap of D into C*/
+ r[4] = alloc_resv_mem(0xD, 0x21000, 0x2FFFF);
+ l = resv_region_list_insert(l, r[4]);
+ print_resv_region_list("test3", l, 4);
+
+ /* in the middle */
+ r[5] = alloc_resv_mem(0xE, 0x22000, 0x23FFF);
+ l = resv_region_list_insert(l, r[5]);
+ print_resv_region_list("test4", l, 6);
+
+ /* overwrites several existing ones */
+ r[6] = alloc_resv_mem(0xF, 0x10000, 0x2FFFF);
+ l = resv_region_list_insert(l, r[6]);
+ print_resv_region_list("test5", l, 3);
+
+ /* contiguous at the end */
+ r[7] = alloc_resv_mem(0x0, 0x30000, 0x40000);
+ l = resv_region_list_insert(l, r[7]);
+ print_resv_region_list("test6", l, 4);
+
+ g_list_free_full(l, free_resv_region);
+ l = NULL;
+
+ r[0] = alloc_resv_mem(0x0, 0x10000, 0x1FFFF);
+ l = resv_region_list_insert(l, r[0]);
+ /* insertion before the 1st item */
+ r[1] = alloc_resv_mem(0x1, 0x0, 0xFF);
+ l = resv_region_list_insert(l, r[1]);
+ print_resv_region_list("test8", l, 2);
+
+ /* collision on the left side */
+ r[2] = alloc_resv_mem(0xA, 0x1200, 0x11FFF);
+ l = resv_region_list_insert(l, r[2]);
+ print_resv_region_list("test9", l, 3);
+
+ /* collision on the right side */
+ r[3] = alloc_resv_mem(0xA, 0x1F000, 0x2FFFF);
+ l = resv_region_list_insert(l, r[3]);
+ print_resv_region_list("test10", l, 4);
+
+ /* override everything */
+ r[4] = alloc_resv_mem(0xF, 0x0, UINT64_MAX);
+ l = resv_region_list_insert(l, r[4]);
+ print_resv_region_list("test11", l, 1);
+
+ g_list_free_full(l, free_resv_region);
+ l = NULL;
+
+ r[0] = alloc_resv_mem(0xF, 0x1000000000000, UINT64_MAX);
+ l = resv_region_list_insert(l, r[0]);
+ print_resv_region_list("test12", l, 1);
+
+ r[1] = alloc_resv_mem(0xA, 0x0, 0xFFFFFFF);
+ l = resv_region_list_insert(l, r[1]);
+ print_resv_region_list("test12", l, 2);
+
+ r[2] = alloc_resv_mem(0xB, 0x100000000, 0x1FFFFFFFF);
+ l = resv_region_list_insert(l, r[2]);
+ print_resv_region_list("test12", l, 3);
+
+ r[3] = alloc_resv_mem(0x0, 0x010000000, 0x2FFFFFFFF);
+ l = resv_region_list_insert(l, r[3]);
+ print_resv_region_list("test12", l, 3);
+
+ g_list_free_full(l, free_resv_region);
+}
+
+int main(int argc, char **argv)
+{
+ g_test_init(&argc, &argv, NULL);
+
+ g_test_add_func("/resv-mem/range_reverse_array",
+ check_range_reverse_array);
+ g_test_add_func("/resv-mem/range_reverse_array_low_end",
+ check_range_reverse_array_low_end);
+ g_test_add_func("/resv-mem/resv_region_list_insert",
+ check_resv_region_list_insert);
+
+ g_test_run();
+
+ return 0;
+}
diff --git a/tests/unit/meson.build b/tests/unit/meson.build
index 0299ef6906..3e196eda7b 100644
--- a/tests/unit/meson.build
+++ b/tests/unit/meson.build
@@ -21,6 +21,7 @@ tests = {
'test-opts-visitor': [testqapi],
'test-visitor-serialization': [testqapi],
'test-bitmap': [],
+ 'test-resv-mem': [],
# all code tested by test-x86-cpuid is inside topology.h
'test-x86-cpuid': [],
'test-cutils': [],
--
2.41.0
next prev parent reply other threads:[~2023-09-13 8:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 8:01 [PATCH v2 00/12] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space Eric Auger
2023-09-13 8:01 ` [PATCH v2 01/12] memory: Let ReservedRegion use Range Eric Auger
2023-09-13 12:43 ` Cédric Le Goater
2023-09-13 8:01 ` [PATCH v2 02/12] memory: Introduce memory_region_iommu_set_iova_ranges Eric Auger
2023-09-13 12:43 ` Cédric Le Goater
2023-09-20 7:40 ` Eric Auger
2023-09-13 8:01 ` [PATCH v2 03/12] vfio: Collect container iova range info Eric Auger
2023-09-13 12:55 ` Cédric Le Goater
2023-09-20 7:38 ` Eric Auger
2023-09-19 15:44 ` Alex Williamson
2023-09-20 7:15 ` Eric Auger
2023-09-20 7:39 ` Eric Auger
2023-09-13 8:01 ` [PATCH v2 04/12] virtio-iommu: Rename reserved_regions into prop_resv_regions Eric Auger
2023-09-13 13:01 ` Cédric Le Goater
2023-09-13 8:01 ` [PATCH v2 05/12] virtio-iommu: Introduce per IOMMUDevice reserved regions Eric Auger
2023-09-29 15:52 ` Jean-Philippe Brucker
2023-10-03 15:48 ` Eric Auger
2023-09-13 8:01 ` [PATCH v2 06/12] range: Introduce range_inverse_array() Eric Auger
2023-09-19 16:29 ` Alex Williamson
2023-09-20 7:24 ` Eric Auger
2023-09-13 8:01 ` [PATCH v2 07/12] virtio-iommu: Implement set_iova_ranges() callback Eric Auger
2023-09-29 16:15 ` Jean-Philippe Brucker
2023-10-10 14:36 ` Eric Auger
2023-09-13 8:01 ` [PATCH v2 08/12] range: Make range_compare() public Eric Auger
2023-09-13 8:01 ` [PATCH v2 09/12] util/reserved-region: Add new ReservedRegion helpers Eric Auger
2023-09-29 16:16 ` Jean-Philippe Brucker
2023-10-10 13:51 ` Eric Auger
2023-09-13 8:01 ` [PATCH v2 10/12] virtio-iommu: Consolidate host reserved regions and property set ones Eric Auger
2023-09-13 8:01 ` Eric Auger [this message]
2023-09-13 8:01 ` [PATCH v2 12/12] vfio: Remove 64-bit IOVA address space assumption Eric Auger
2023-09-19 17:22 ` Alex Williamson
2023-09-20 7:28 ` Eric Auger
2023-09-26 20:00 ` Eric Auger
2023-10-10 17:16 ` Eric Auger
2023-09-20 20:02 ` Alex Williamson
2023-10-11 17:32 ` Eric Auger
2023-09-26 8:06 ` [PATCH v2 00/12] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space YangHang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913080423.523953-12-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).