qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: qemu-devel@nongnu.org
Cc: linux-debuggers@vger.kernel.org, stephen.s.brennan@oracle.com,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Omar Sandoval" <osandov@osandov.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 qemu 0/3] Allow dump-guest-memory to output standard kdump format
Date: Wed, 13 Sep 2023 18:03:12 -0700	[thread overview]
Message-ID: <20230914010315.945705-1-stephen.s.brennan@oracle.com> (raw)

Hello all,

This is the second version of my patch series about the kdump format,
you can see the first version here [1].

The current output format for dump-guest-memory's kdump compressed
format is actually the "makedumpfile flattened" format. It was done
intentionally to allow the flexibility to write to non-seekable file
descriptors, like pipes [2], without using temporary files. Currently
libvirt uses this ability when VIR_DUMP_BYPASS_CACHE flag is set, to
avoid the dump process using page cache. The standard kdump output
format needs the page cache so that it can seek back and forth as part
of writing the dump file.

So the default kdump dump format cannot be changed to the standard
format. This patch series adds the ability to use the standard format,
and adds a QMP / HMP argument to enable it.

An open question for Daniel et al.:

Would it be possible to make flattened the default only for libvirt? I
totally agree that this would be a bad backward incompatible change
there. But for QMP / HMP commands, I think using the standard, broadly
compatible format as the default is important for user friendliness. If
a user needs to know the difference between flavors of kdump formats
like the flattened format, in order to set the correct option, then
we've already lost.

Changes from v1 to v2:
- Keep the default as the flattened format
- Add QMP / HMP arguments for "reassembled"

[1]: https://lore.kernel.org/qemu-devel/20230717163855.7383-1-stephen.s.brennan@oracle.com/
[2]: https://lore.kernel.org/qemu-devel/1390890126-17377-1-git-send-email-qiaonuohan@cn.fujitsu.com/
-> see "changes from v4 to v5" in this patch

Stephen Brennan (3):
  dump: Pass DumpState to write_ functions
  dump: Allow directly outputting reassembled kdumps
  dump: Add qmp argument "reassembled"

 dump/dump-hmp-cmds.c  |  8 +++-
 dump/dump.c           | 86 ++++++++++++++++++++++++++++++-------------
 hmp-commands.hx       |  7 +++-
 include/sysemu/dump.h |  3 +-
 qapi/dump.json        | 14 ++++++-
 5 files changed, 87 insertions(+), 31 deletions(-)

-- 
2.39.3



             reply	other threads:[~2023-09-14  1:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  1:03 Stephen Brennan [this message]
2023-09-14  1:03 ` [PATCH v2 qemu 1/3] dump: Pass DumpState to write_ functions Stephen Brennan
2023-09-14  1:03 ` [PATCH v2 qemu 2/3] dump: Allow directly outputting reassembled kdumps Stephen Brennan
2023-09-18 11:13   ` Marc-André Lureau
2023-09-14  1:03 ` [PATCH v2 qemu 3/3] dump: Add qmp argument "reassembled" Stephen Brennan
2023-09-18 11:15   ` Marc-André Lureau
2023-09-18 12:08   ` Daniel P. Berrangé
2023-09-18 17:34     ` Stephen Brennan
2023-09-18 17:43       ` Daniel P. Berrangé
2023-09-18 12:10 ` [PATCH v2 qemu 0/3] Allow dump-guest-memory to output standard kdump format Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230914010315.945705-1-stephen.s.brennan@oracle.com \
    --to=stephen.s.brennan@oracle.com \
    --cc=berrange@redhat.com \
    --cc=linux-debuggers@vger.kernel.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=osandov@osandov.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).