From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
qemu-arm@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"John Snow" <jsnow@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [PATCH 4/9] microbit: add missing qtest_quit() call
Date: Thu, 14 Sep 2023 16:54:17 +0100 [thread overview]
Message-ID: <20230914155422.426639-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230914155422.426639-1-alex.bennee@linaro.org>
From: Daniel P. Berrangé <berrange@redhat.com>
Without this call, the QEMU process is being left running which on
FreeBSD 13.2 at least, makes meson think the test is still running,
and thus execution of "make check" continues forever.
This fixes the regression introduced in:
commit a9c9bbee855877293683012942d3485d50f286af
Author: Chris Laplante <chris@laplante.io>
Date: Tue Aug 22 17:31:02 2023 +0100
qtest: microbit-test: add tests for nRF51 DETECT
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1882
Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230912184130.3056054-2-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/microbit-test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/microbit-test.c b/tests/qtest/microbit-test.c
index 2abcad8e31..72190d38f7 100644
--- a/tests/qtest/microbit-test.c
+++ b/tests/qtest/microbit-test.c
@@ -434,6 +434,8 @@ static void test_nrf51_gpio_detect(void)
g_assert_true(qtest_get_irq(qts, 0));
qtest_set_irq_in(qts, "/machine/nrf51", "unnamed-gpio-in", 3, 0);
g_assert_true(qtest_get_irq(qts, 0));
+
+ qtest_quit(qts);
}
static void timer_task(QTestState *qts, hwaddr task)
--
2.39.2
next prev parent reply other threads:[~2023-09-14 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 15:54 [PATCH 0/9] testing/next: avocado, gitlab, docker, cirrus Alex Bennée
2023-09-14 15:54 ` [PATCH 1/9] tests: update Debian images to Bookworm Alex Bennée
2023-09-14 16:10 ` Thomas Huth
2023-09-15 9:14 ` Philippe Mathieu-Daudé
2023-09-15 9:24 ` Daniel P. Berrangé
2023-09-15 10:53 ` Philippe Mathieu-Daudé
2023-09-15 11:24 ` Thomas Huth
2023-09-15 12:00 ` Daniel P. Berrangé
2023-09-14 15:54 ` [PATCH 2/9] gitlab: fix typo/spelling in comments Alex Bennée
2023-09-14 16:07 ` Thomas Huth
2023-09-14 17:21 ` Philippe Mathieu-Daudé
2023-09-14 15:54 ` [PATCH 3/9] tests/docker: Update docker-loongarch-cross toolchain Alex Bennée
2023-09-14 15:54 ` Alex Bennée [this message]
2023-09-14 15:54 ` [PATCH 5/9] qtest: kill orphaned qtest QEMU processes on FreeBSD Alex Bennée
2023-09-14 15:54 ` [PATCH 6/9] gitlab: make Cirrus CI timeout explicit Alex Bennée
2023-09-14 15:54 ` [PATCH 7/9] gitlab: make Cirrus CI jobs gating Alex Bennée
2023-09-15 9:15 ` Philippe Mathieu-Daudé
2023-09-14 15:54 ` [PATCH 8/9] tests/avocado: Fix console data loss Alex Bennée
2023-09-15 9:18 ` Philippe Mathieu-Daudé
2023-09-14 15:54 ` [PATCH 9/9] tests/avocado: Disable MIPS Malta tests due to GitLab issue #1884 Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914155422.426639-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).