From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Greg Kurz" <groug@kaod.org>, "Anton Johansson" <anjo@rev.ng>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
qemu-ppc@nongnu.org
Subject: [RFC PATCH 4/4] accel/tcg: Keep tlb_set_dirty() internal
Date: Thu, 14 Sep 2023 21:52:29 +0200 [thread overview]
Message-ID: <20230914195229.78244-5-philmd@linaro.org> (raw)
In-Reply-To: <20230914195229.78244-1-philmd@linaro.org>
Since commit 34d49937e4 ("accel/tcg: Handle atomic accesses
to notdirty memory correctly") tlb_set_dirty() is only used
(once) in the very same file it is defined... Make it static.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/exec/exec-all.h | 1 -
accel/tcg/cputlb.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index b2f5cd4c2a..59efa7bc28 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -695,7 +695,6 @@ static inline void mmap_unlock(void) {}
#define WITH_MMAP_LOCK_GUARD()
void tlb_reset_dirty(CPUState *cpu, ram_addr_t start1, ram_addr_t length);
-void tlb_set_dirty(CPUState *cpu, vaddr addr);
MemoryRegionSection *
address_space_translate_for_iotlb(CPUState *cpu, int asidx, hwaddr addr,
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index c643d66190..fe9d702f3e 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1062,7 +1062,7 @@ static inline void tlb_set_dirty1_locked(CPUTLBEntry *tlb_entry,
/* update the TLB corresponding to virtual page vaddr
so that it is no longer dirty */
-void tlb_set_dirty(CPUState *cpu, vaddr addr)
+static void tlb_set_dirty(CPUState *cpu, vaddr addr)
{
CPUArchState *env = cpu->env_ptr;
int mmu_idx;
--
2.41.0
next prev parent reply other threads:[~2023-09-14 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 19:52 [PATCH 0/4] accel/tcg: Stubs cleanups Philippe Mathieu-Daudé
2023-09-14 19:52 ` [PATCH 1/4] accel/tcg: Remove tlb_set_dirty() stub Philippe Mathieu-Daudé
2023-09-15 14:06 ` Harsh Prateek Bora
2023-09-14 19:52 ` [PATCH 2/4] accel/tcg: Remove unused tcg_flush_jmp_cache() stub Philippe Mathieu-Daudé
2023-09-15 15:12 ` Harsh Prateek Bora
2023-09-15 15:41 ` Philippe Mathieu-Daudé
2023-09-14 19:52 ` [RFC PATCH 3/4] accel/tcg: Guard tb_flush() with tcg_enabled() and remove the stub Philippe Mathieu-Daudé
2023-09-15 15:25 ` Harsh Prateek Bora
2023-09-15 15:42 ` Philippe Mathieu-Daudé
2023-09-19 6:52 ` Harsh Prateek Bora
2023-09-14 19:52 ` Philippe Mathieu-Daudé [this message]
2023-09-15 15:27 ` [RFC PATCH 4/4] accel/tcg: Keep tlb_set_dirty() internal Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914195229.78244-5-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=anjo@rev.ng \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=eduardo@habkost.net \
--cc=groug@kaod.org \
--cc=harshpb@linux.ibm.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).