From: Joe Komlodi <komlodi@google.com>
To: qemu-devel@nongnu.org
Cc: komlodi@google.com, qemu-arm@nongnu.org, peter.maydell@linaro.org
Subject: [PATCH 1/1] hw/timer/sse-timer: Add CNTFRQ reset property
Date: Thu, 14 Sep 2023 22:42:10 +0000 [thread overview]
Message-ID: <20230914224211.2184828-2-komlodi@google.com> (raw)
In-Reply-To: <20230914224211.2184828-1-komlodi@google.com>
This can have a non-zero reset value, and cause the kernel to complain
about a CNTFRQ mismatch if TF-A (or firmware in general) does not
initialize it (because it expects the value to be non-zero out of
reset).
To fix this, we'll just add an object property that people can use to
initialize the CNTFRQ reset value.
Signed-off-by: Joe Komlodi <komlodi@google.com>
---
hw/timer/sse-timer.c | 4 +++-
include/hw/timer/sse-timer.h | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/timer/sse-timer.c b/hw/timer/sse-timer.c
index e92e83747d..a727f05bac 100644
--- a/hw/timer/sse-timer.c
+++ b/hw/timer/sse-timer.c
@@ -376,7 +376,7 @@ static void sse_timer_reset(DeviceState *dev)
trace_sse_timer_reset();
timer_del(&s->timer);
- s->cntfrq = 0;
+ s->cntfrq = s->cntfrq_reset;
s->cntp_ctl = 0;
s->cntp_cval = 0;
s->cntp_aival = 0;
@@ -430,6 +430,7 @@ static const VMStateDescription sse_timer_vmstate = {
.minimum_version_id = 1,
.fields = (VMStateField[]) {
VMSTATE_TIMER(timer, SSETimer),
+ VMSTATE_UINT32(cntfrq_reset, SSETimer),
VMSTATE_UINT32(cntfrq, SSETimer),
VMSTATE_UINT32(cntp_ctl, SSETimer),
VMSTATE_UINT64(cntp_cval, SSETimer),
@@ -442,6 +443,7 @@ static const VMStateDescription sse_timer_vmstate = {
static Property sse_timer_properties[] = {
DEFINE_PROP_LINK("counter", SSETimer, counter, TYPE_SSE_COUNTER, SSECounter *),
+ DEFINE_PROP_UINT32("cntfrq-reset", SSETimer, cntfrq_reset, 0),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/include/hw/timer/sse-timer.h b/include/hw/timer/sse-timer.h
index 265ad32400..ad84c24940 100644
--- a/include/hw/timer/sse-timer.h
+++ b/include/hw/timer/sse-timer.h
@@ -43,6 +43,8 @@ struct SSETimer {
QEMUTimer timer;
Notifier counter_notifier;
+ uint32_t cntfrq_reset;
+
uint32_t cntfrq;
uint32_t cntp_ctl;
uint64_t cntp_cval;
--
2.42.0.459.ge4e396fd5e-goog
next prev parent reply other threads:[~2023-09-14 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 22:42 [PATCH 0/1] hw/arm/sse-timer: Add CNTFRQ reset property Joe Komlodi
2023-09-14 22:42 ` Joe Komlodi [this message]
2023-09-15 9:55 ` [PATCH 1/1] hw/timer/sse-timer: " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914224211.2184828-2-komlodi@google.com \
--to=komlodi@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).