* [PATCH 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 12:31 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 02/16] tests: bios-tables-test: Prepare the ACPI table change for type4 count test Zhao Liu
` (15 subsequent siblings)
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Use the different ways to calculate cores/threads per socket, so that
the new CPU topology levels won't be missed in these 2 helpes:
* machine_topo_get_cores_per_socket()
* machine_topo_get_threads_per_socket()
Test the commit a1d027be95bc3 ("machine: Add helpers to get cores/
threads per socket").
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/unit/test-smp-parse.c | 67 ++++++++++++++++++++++++++++++-------
1 file changed, 54 insertions(+), 13 deletions(-)
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index fdc39a846ca6..24972666a74d 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -394,20 +394,47 @@ static char *smp_config_to_string(const SMPConfiguration *config)
config->has_maxcpus ? "true" : "false", config->maxcpus);
}
-static char *cpu_topology_to_string(const CpuTopology *topo)
+/* Use the different calculation than machine_topo_get_threads_per_socket(). */
+static unsigned int cpu_topology_get_threads_per_socket(const CpuTopology *topo)
+{
+ /* Check the divisor to avoid invalid topology examples causing SIGFPE. */
+ if (!topo->sockets) {
+ return 0;
+ } else {
+ return topo->max_cpus / topo->sockets;
+ }
+}
+
+/* Use the different calculation than machine_topo_get_cores_per_socket(). */
+static unsigned int cpu_topology_get_cores_per_socket(const CpuTopology *topo)
+{
+ /* Check the divisor to avoid invalid topology examples causing SIGFPE. */
+ if (!topo->threads) {
+ return 0;
+ } else {
+ return cpu_topology_get_threads_per_socket(topo) / topo->threads;
+ }
+}
+
+static char *cpu_topology_to_string(const CpuTopology *topo,
+ unsigned int threads_per_socket,
+ unsigned int cores_per_socket)
{
return g_strdup_printf(
"(CpuTopology) {\n"
- " .cpus = %u,\n"
- " .sockets = %u,\n"
- " .dies = %u,\n"
- " .clusters = %u,\n"
- " .cores = %u,\n"
- " .threads = %u,\n"
- " .max_cpus = %u,\n"
+ " .cpus = %u,\n"
+ " .sockets = %u,\n"
+ " .dies = %u,\n"
+ " .clusters = %u,\n"
+ " .cores = %u,\n"
+ " .threads = %u,\n"
+ " .max_cpus = %u,\n"
+ " .threads_per_socket = %u,\n"
+ " .cores_per_socket = %u,\n"
"}",
topo->cpus, topo->sockets, topo->dies, topo->clusters,
- topo->cores, topo->threads, topo->max_cpus);
+ topo->cores, topo->threads, topo->max_cpus,
+ threads_per_socket, cores_per_socket);
}
static void check_parse(MachineState *ms, const SMPConfiguration *config,
@@ -415,14 +442,26 @@ static void check_parse(MachineState *ms, const SMPConfiguration *config,
bool is_valid)
{
g_autofree char *config_str = smp_config_to_string(config);
- g_autofree char *expect_topo_str = cpu_topology_to_string(expect_topo);
- g_autofree char *output_topo_str = NULL;
+ g_autofree char *expect_topo_str = NULL, *output_topo_str = NULL;
+ unsigned int expect_threads_per_socket, expect_cores_per_socket;
+ unsigned int ms_threads_per_socket, ms_cores_per_socket;
Error *err = NULL;
+ expect_threads_per_socket =
+ cpu_topology_get_threads_per_socket(expect_topo);
+ expect_cores_per_socket =
+ cpu_topology_get_cores_per_socket(expect_topo);
+ expect_topo_str = cpu_topology_to_string(expect_topo,
+ expect_threads_per_socket,
+ expect_cores_per_socket);
+
/* call the generic parser */
machine_parse_smp_config(ms, config, &err);
- output_topo_str = cpu_topology_to_string(&ms->smp);
+ ms_threads_per_socket = machine_topo_get_threads_per_socket(ms);
+ ms_cores_per_socket = machine_topo_get_cores_per_socket(ms);
+ output_topo_str = cpu_topology_to_string(&ms->smp, ms_threads_per_socket,
+ ms_cores_per_socket);
/* when the configuration is supposed to be valid */
if (is_valid) {
@@ -433,7 +472,9 @@ static void check_parse(MachineState *ms, const SMPConfiguration *config,
(ms->smp.clusters == expect_topo->clusters) &&
(ms->smp.cores == expect_topo->cores) &&
(ms->smp.threads == expect_topo->threads) &&
- (ms->smp.max_cpus == expect_topo->max_cpus)) {
+ (ms->smp.max_cpus == expect_topo->max_cpus) &&
+ (ms_threads_per_socket == expect_threads_per_socket) &&
+ (ms_cores_per_socket == expect_cores_per_socket)) {
return;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers
2023-08-25 3:36 ` [PATCH 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers Zhao Liu
@ 2023-09-15 12:31 ` Igor Mammedov
2023-09-19 7:18 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 12:31 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:04 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> Use the different ways to calculate cores/threads per socket, so that
> the new CPU topology levels won't be missed in these 2 helpes:
>
> * machine_topo_get_cores_per_socket()
> * machine_topo_get_threads_per_socket()
>
> Test the commit a1d027be95bc3 ("machine: Add helpers to get cores/
> threads per socket").
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/unit/test-smp-parse.c | 67 ++++++++++++++++++++++++++++++-------
> 1 file changed, 54 insertions(+), 13 deletions(-)
>
> diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
> index fdc39a846ca6..24972666a74d 100644
> --- a/tests/unit/test-smp-parse.c
> +++ b/tests/unit/test-smp-parse.c
> @@ -394,20 +394,47 @@ static char *smp_config_to_string(const SMPConfiguration *config)
> config->has_maxcpus ? "true" : "false", config->maxcpus);
> }
>
> -static char *cpu_topology_to_string(const CpuTopology *topo)
> +/* Use the different calculation than machine_topo_get_threads_per_socket(). */
> +static unsigned int cpu_topology_get_threads_per_socket(const CpuTopology *topo)
> +{
> + /* Check the divisor to avoid invalid topology examples causing SIGFPE. */
> + if (!topo->sockets) {
> + return 0;
> + } else {
> + return topo->max_cpus / topo->sockets;
> + }
> +}
> +
> +/* Use the different calculation than machine_topo_get_cores_per_socket(). */
> +static unsigned int cpu_topology_get_cores_per_socket(const CpuTopology *topo)
> +{
> + /* Check the divisor to avoid invalid topology examples causing SIGFPE. */
> + if (!topo->threads) {
> + return 0;
> + } else {
> + return cpu_topology_get_threads_per_socket(topo) / topo->threads;
> + }
> +}
> +
> +static char *cpu_topology_to_string(const CpuTopology *topo,
> + unsigned int threads_per_socket,
> + unsigned int cores_per_socket)
> {
> return g_strdup_printf(
> "(CpuTopology) {\n"
> - " .cpus = %u,\n"
> - " .sockets = %u,\n"
> - " .dies = %u,\n"
> - " .clusters = %u,\n"
> - " .cores = %u,\n"
> - " .threads = %u,\n"
> - " .max_cpus = %u,\n"
> + " .cpus = %u,\n"
> + " .sockets = %u,\n"
> + " .dies = %u,\n"
> + " .clusters = %u,\n"
> + " .cores = %u,\n"
> + " .threads = %u,\n"
> + " .max_cpus = %u,\n"
> + " .threads_per_socket = %u,\n"
> + " .cores_per_socket = %u,\n"
> "}",
> topo->cpus, topo->sockets, topo->dies, topo->clusters,
> - topo->cores, topo->threads, topo->max_cpus);
> + topo->cores, topo->threads, topo->max_cpus,
> + threads_per_socket, cores_per_socket);
> }
>
> static void check_parse(MachineState *ms, const SMPConfiguration *config,
> @@ -415,14 +442,26 @@ static void check_parse(MachineState *ms, const SMPConfiguration *config,
> bool is_valid)
> {
> g_autofree char *config_str = smp_config_to_string(config);
> - g_autofree char *expect_topo_str = cpu_topology_to_string(expect_topo);
> - g_autofree char *output_topo_str = NULL;
> + g_autofree char *expect_topo_str = NULL, *output_topo_str = NULL;
> + unsigned int expect_threads_per_socket, expect_cores_per_socket;
> + unsigned int ms_threads_per_socket, ms_cores_per_socket;
> Error *err = NULL;
>
> + expect_threads_per_socket =
> + cpu_topology_get_threads_per_socket(expect_topo);
> + expect_cores_per_socket =
> + cpu_topology_get_cores_per_socket(expect_topo);
> + expect_topo_str = cpu_topology_to_string(expect_topo,
> + expect_threads_per_socket,
> + expect_cores_per_socket);
> +
> /* call the generic parser */
> machine_parse_smp_config(ms, config, &err);
>
> - output_topo_str = cpu_topology_to_string(&ms->smp);
> + ms_threads_per_socket = machine_topo_get_threads_per_socket(ms);
> + ms_cores_per_socket = machine_topo_get_cores_per_socket(ms);
> + output_topo_str = cpu_topology_to_string(&ms->smp, ms_threads_per_socket,
> + ms_cores_per_socket);
>
> /* when the configuration is supposed to be valid */
> if (is_valid) {
> @@ -433,7 +472,9 @@ static void check_parse(MachineState *ms, const SMPConfiguration *config,
> (ms->smp.clusters == expect_topo->clusters) &&
> (ms->smp.cores == expect_topo->cores) &&
> (ms->smp.threads == expect_topo->threads) &&
> - (ms->smp.max_cpus == expect_topo->max_cpus)) {
> + (ms->smp.max_cpus == expect_topo->max_cpus) &&
> + (ms_threads_per_socket == expect_threads_per_socket) &&
> + (ms_cores_per_socket == expect_cores_per_socket)) {
> return;
> }
>
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers
2023-09-15 12:31 ` Igor Mammedov
@ 2023-09-19 7:18 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:18 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, Sep 15, 2023 at 02:31:38PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 14:31:38 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 01/16] tests: test-smp-parse: Add the test for
> cores/threads per socket helpers
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:04 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > Use the different ways to calculate cores/threads per socket, so that
> > the new CPU topology levels won't be missed in these 2 helpes:
> >
> > * machine_topo_get_cores_per_socket()
> > * machine_topo_get_threads_per_socket()
> >
> > Test the commit a1d027be95bc3 ("machine: Add helpers to get cores/
> > threads per socket").
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
Thanks!
-Zhao
>
> > ---
> > tests/unit/test-smp-parse.c | 67 ++++++++++++++++++++++++++++++-------
> > 1 file changed, 54 insertions(+), 13 deletions(-)
> >
> > diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
> > index fdc39a846ca6..24972666a74d 100644
> > --- a/tests/unit/test-smp-parse.c
> > +++ b/tests/unit/test-smp-parse.c
> > @@ -394,20 +394,47 @@ static char *smp_config_to_string(const SMPConfiguration *config)
> > config->has_maxcpus ? "true" : "false", config->maxcpus);
> > }
> >
> > -static char *cpu_topology_to_string(const CpuTopology *topo)
> > +/* Use the different calculation than machine_topo_get_threads_per_socket(). */
> > +static unsigned int cpu_topology_get_threads_per_socket(const CpuTopology *topo)
> > +{
> > + /* Check the divisor to avoid invalid topology examples causing SIGFPE. */
> > + if (!topo->sockets) {
> > + return 0;
> > + } else {
> > + return topo->max_cpus / topo->sockets;
> > + }
> > +}
> > +
> > +/* Use the different calculation than machine_topo_get_cores_per_socket(). */
> > +static unsigned int cpu_topology_get_cores_per_socket(const CpuTopology *topo)
> > +{
> > + /* Check the divisor to avoid invalid topology examples causing SIGFPE. */
> > + if (!topo->threads) {
> > + return 0;
> > + } else {
> > + return cpu_topology_get_threads_per_socket(topo) / topo->threads;
> > + }
> > +}
> > +
> > +static char *cpu_topology_to_string(const CpuTopology *topo,
> > + unsigned int threads_per_socket,
> > + unsigned int cores_per_socket)
> > {
> > return g_strdup_printf(
> > "(CpuTopology) {\n"
> > - " .cpus = %u,\n"
> > - " .sockets = %u,\n"
> > - " .dies = %u,\n"
> > - " .clusters = %u,\n"
> > - " .cores = %u,\n"
> > - " .threads = %u,\n"
> > - " .max_cpus = %u,\n"
> > + " .cpus = %u,\n"
> > + " .sockets = %u,\n"
> > + " .dies = %u,\n"
> > + " .clusters = %u,\n"
> > + " .cores = %u,\n"
> > + " .threads = %u,\n"
> > + " .max_cpus = %u,\n"
> > + " .threads_per_socket = %u,\n"
> > + " .cores_per_socket = %u,\n"
> > "}",
> > topo->cpus, topo->sockets, topo->dies, topo->clusters,
> > - topo->cores, topo->threads, topo->max_cpus);
> > + topo->cores, topo->threads, topo->max_cpus,
> > + threads_per_socket, cores_per_socket);
> > }
> >
> > static void check_parse(MachineState *ms, const SMPConfiguration *config,
> > @@ -415,14 +442,26 @@ static void check_parse(MachineState *ms, const SMPConfiguration *config,
> > bool is_valid)
> > {
> > g_autofree char *config_str = smp_config_to_string(config);
> > - g_autofree char *expect_topo_str = cpu_topology_to_string(expect_topo);
> > - g_autofree char *output_topo_str = NULL;
> > + g_autofree char *expect_topo_str = NULL, *output_topo_str = NULL;
> > + unsigned int expect_threads_per_socket, expect_cores_per_socket;
> > + unsigned int ms_threads_per_socket, ms_cores_per_socket;
> > Error *err = NULL;
> >
> > + expect_threads_per_socket =
> > + cpu_topology_get_threads_per_socket(expect_topo);
> > + expect_cores_per_socket =
> > + cpu_topology_get_cores_per_socket(expect_topo);
> > + expect_topo_str = cpu_topology_to_string(expect_topo,
> > + expect_threads_per_socket,
> > + expect_cores_per_socket);
> > +
> > /* call the generic parser */
> > machine_parse_smp_config(ms, config, &err);
> >
> > - output_topo_str = cpu_topology_to_string(&ms->smp);
> > + ms_threads_per_socket = machine_topo_get_threads_per_socket(ms);
> > + ms_cores_per_socket = machine_topo_get_cores_per_socket(ms);
> > + output_topo_str = cpu_topology_to_string(&ms->smp, ms_threads_per_socket,
> > + ms_cores_per_socket);
> >
> > /* when the configuration is supposed to be valid */
> > if (is_valid) {
> > @@ -433,7 +472,9 @@ static void check_parse(MachineState *ms, const SMPConfiguration *config,
> > (ms->smp.clusters == expect_topo->clusters) &&
> > (ms->smp.cores == expect_topo->cores) &&
> > (ms->smp.threads == expect_topo->threads) &&
> > - (ms->smp.max_cpus == expect_topo->max_cpus)) {
> > + (ms->smp.max_cpus == expect_topo->max_cpus) &&
> > + (ms_threads_per_socket == expect_threads_per_socket) &&
> > + (ms_cores_per_socket == expect_cores_per_socket)) {
> > return;
> > }
> >
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 02/16] tests: bios-tables-test: Prepare the ACPI table change for type4 count test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
2023-08-25 3:36 ` [PATCH 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 03/16] tests: bios-tables-test: Add test for smbios type4 count Zhao Liu
` (14 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 1 - 3.
List the ACPI tables that will be added to test the type 4 count.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.type4-count | 0
tests/data/acpi/q35/DSDT.type4-count | 0
tests/data/acpi/q35/FACP.type4-count | 0
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
4 files changed, 3 insertions(+)
create mode 100644 tests/data/acpi/q35/APIC.type4-count
create mode 100644 tests/data/acpi/q35/DSDT.type4-count
create mode 100644 tests/data/acpi/q35/FACP.type4-count
diff --git a/tests/data/acpi/q35/APIC.type4-count b/tests/data/acpi/q35/APIC.type4-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/DSDT.type4-count b/tests/data/acpi/q35/DSDT.type4-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/FACP.type4-count b/tests/data/acpi/q35/FACP.type4-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..0ce6f8fc72ee 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/APIC.type4-count",
+"tests/data/acpi/q35/DSDT.type4-count",
+"tests/data/acpi/q35/FACP.type4-count",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 03/16] tests: bios-tables-test: Add test for smbios type4 count
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
2023-08-25 3:36 ` [PATCH 01/16] tests: test-smp-parse: Add the test for cores/threads per socket helpers Zhao Liu
2023-08-25 3:36 ` [PATCH 02/16] tests: bios-tables-test: Prepare the ACPI table change for type4 count test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 12:54 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries for type4 count test Zhao Liu
` (13 subsequent siblings)
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
This tests the commit d79a284a44bb7 ("hw/smbios: Fix smbios_smp_sockets
calculation").
Test the count of type4 tables for multiple sockets case.
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test.c | 33 ++++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 47ba20b9579b..8679255449cf 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -97,6 +97,7 @@ typedef struct {
uint16_t smbios_core_count2;
uint8_t *required_struct_types;
int required_struct_types_len;
+ int type4_count;
QTestState *qts;
} test_data;
@@ -673,12 +674,21 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
}
}
+static void smbios_type4_count_test(test_data *data, int type4_count)
+{
+ int expected_type4_count = data->type4_count;
+
+ if (expected_type4_count) {
+ g_assert_cmpuint(type4_count, ==, expected_type4_count);
+ }
+}
+
static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
{
DECLARE_BITMAP(struct_bitmap, SMBIOS_MAX_TYPE+1) = { 0 };
SmbiosEntryPoint *ep_table = &data->smbios_ep_table;
- int i = 0, len, max_len = 0;
+ int i = 0, len, max_len = 0, type4_count = 0;
uint8_t type, prv, crt;
uint64_t addr;
@@ -704,6 +714,7 @@ static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
if (type == 4) {
smbios_cpu_test(data, addr, ep_type);
+ type4_count++;
}
/* seek to end of unformatted string area of this struct ("\0\0") */
@@ -747,6 +758,8 @@ static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
for (i = 0; i < data->required_struct_types_len; i++) {
g_assert(test_bit(data->required_struct_types[i], struct_bitmap));
}
+
+ smbios_type4_count_test(data, type4_count);
}
static void test_acpi_load_tables(test_data *data)
@@ -970,6 +983,22 @@ static void test_acpi_q35_tcg(void)
free_test_data(&data);
}
+static void test_acpi_q35_tcg_type4_count(void)
+{
+ test_data data = {
+ .machine = MACHINE_Q35,
+ .variant = ".type4-count",
+ .required_struct_types = base_required_struct_types,
+ .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
+ .type4_count = 5,
+ };
+
+ test_acpi_one("-machine smbios-entry-point-type=64 "
+ "-smp cpus=100,maxcpus=120,sockets=5,"
+ "dies=2,cores=4,threads=3", &data);
+ free_test_data(&data);
+}
+
static void test_acpi_q35_tcg_core_count2(void)
{
test_data data = {
@@ -2135,6 +2164,8 @@ int main(int argc, char *argv[])
if (has_kvm) {
qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
+ qtest_add_func("acpi/q35/type4-count",
+ test_acpi_q35_tcg_type4_count);
qtest_add_func("acpi/q35/core-count2",
test_acpi_q35_tcg_core_count2);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 03/16] tests: bios-tables-test: Add test for smbios type4 count
2023-08-25 3:36 ` [PATCH 03/16] tests: bios-tables-test: Add test for smbios type4 count Zhao Liu
@ 2023-09-15 12:54 ` Igor Mammedov
2023-09-19 7:20 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 12:54 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:06 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> This tests the commit d79a284a44bb7 ("hw/smbios: Fix smbios_smp_sockets
> calculation").
>
> Test the count of type4 tables for multiple sockets case.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> tests/qtest/bios-tables-test.c | 33 ++++++++++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 47ba20b9579b..8679255449cf 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -97,6 +97,7 @@ typedef struct {
> uint16_t smbios_core_count2;
> uint8_t *required_struct_types;
> int required_struct_types_len;
> + int type4_count;
> QTestState *qts;
> } test_data;
>
> @@ -673,12 +674,21 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> }
> }
>
> +static void smbios_type4_count_test(test_data *data, int type4_count)
> +{
> + int expected_type4_count = data->type4_count;
> +
> + if (expected_type4_count) {
> + g_assert_cmpuint(type4_count, ==, expected_type4_count);
> + }
> +}
> +
> static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
> {
> DECLARE_BITMAP(struct_bitmap, SMBIOS_MAX_TYPE+1) = { 0 };
>
> SmbiosEntryPoint *ep_table = &data->smbios_ep_table;
> - int i = 0, len, max_len = 0;
> + int i = 0, len, max_len = 0, type4_count = 0;
> uint8_t type, prv, crt;
> uint64_t addr;
>
> @@ -704,6 +714,7 @@ static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
>
> if (type == 4) {
> smbios_cpu_test(data, addr, ep_type);
> + type4_count++;
> }
>
> /* seek to end of unformatted string area of this struct ("\0\0") */
> @@ -747,6 +758,8 @@ static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
> for (i = 0; i < data->required_struct_types_len; i++) {
> g_assert(test_bit(data->required_struct_types[i], struct_bitmap));
> }
> +
> + smbios_type4_count_test(data, type4_count);
> }
>
> static void test_acpi_load_tables(test_data *data)
> @@ -970,6 +983,22 @@ static void test_acpi_q35_tcg(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_q35_tcg_type4_count(void)
> +{
> + test_data data = {
> + .machine = MACHINE_Q35,
> + .variant = ".type4-count",
> + .required_struct_types = base_required_struct_types,
> + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> + .type4_count = 5,
> + };
> +
> + test_acpi_one("-machine smbios-entry-point-type=64 "
> + "-smp cpus=100,maxcpus=120,sockets=5,"
> + "dies=2,cores=4,threads=3", &data);
I'd add to commit message an explanation why above topology was picked up
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg_core_count2(void)
> {
> test_data data = {
> @@ -2135,6 +2164,8 @@ int main(int argc, char *argv[])
> if (has_kvm) {
> qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
> qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
> + qtest_add_func("acpi/q35/type4-count",
> + test_acpi_q35_tcg_type4_count);
> qtest_add_func("acpi/q35/core-count2",
> test_acpi_q35_tcg_core_count2);
> }
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 03/16] tests: bios-tables-test: Add test for smbios type4 count
2023-09-15 12:54 ` Igor Mammedov
@ 2023-09-19 7:20 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:20 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, Sep 15, 2023 at 02:54:32PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 14:54:32 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 03/16] tests: bios-tables-test: Add test for smbios
> type4 count
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:06 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > This tests the commit d79a284a44bb7 ("hw/smbios: Fix smbios_smp_sockets
> > calculation").
> >
> > Test the count of type4 tables for multiple sockets case.
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> > tests/qtest/bios-tables-test.c | 33 ++++++++++++++++++++++++++++++++-
> > 1 file changed, 32 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index 47ba20b9579b..8679255449cf 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -97,6 +97,7 @@ typedef struct {
> > uint16_t smbios_core_count2;
> > uint8_t *required_struct_types;
> > int required_struct_types_len;
> > + int type4_count;
> > QTestState *qts;
> > } test_data;
> >
> > @@ -673,12 +674,21 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > }
> > }
> >
> > +static void smbios_type4_count_test(test_data *data, int type4_count)
> > +{
> > + int expected_type4_count = data->type4_count;
> > +
> > + if (expected_type4_count) {
> > + g_assert_cmpuint(type4_count, ==, expected_type4_count);
> > + }
> > +}
> > +
> > static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
> > {
> > DECLARE_BITMAP(struct_bitmap, SMBIOS_MAX_TYPE+1) = { 0 };
> >
> > SmbiosEntryPoint *ep_table = &data->smbios_ep_table;
> > - int i = 0, len, max_len = 0;
> > + int i = 0, len, max_len = 0, type4_count = 0;
> > uint8_t type, prv, crt;
> > uint64_t addr;
> >
> > @@ -704,6 +714,7 @@ static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
> >
> > if (type == 4) {
> > smbios_cpu_test(data, addr, ep_type);
> > + type4_count++;
> > }
> >
> > /* seek to end of unformatted string area of this struct ("\0\0") */
> > @@ -747,6 +758,8 @@ static void test_smbios_structs(test_data *data, SmbiosEntryPointType ep_type)
> > for (i = 0; i < data->required_struct_types_len; i++) {
> > g_assert(test_bit(data->required_struct_types[i], struct_bitmap));
> > }
> > +
> > + smbios_type4_count_test(data, type4_count);
> > }
> >
> > static void test_acpi_load_tables(test_data *data)
> > @@ -970,6 +983,22 @@ static void test_acpi_q35_tcg(void)
> > free_test_data(&data);
> > }
> >
> > +static void test_acpi_q35_tcg_type4_count(void)
> > +{
> > + test_data data = {
> > + .machine = MACHINE_Q35,
> > + .variant = ".type4-count",
> > + .required_struct_types = base_required_struct_types,
> > + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > + .type4_count = 5,
> > + };
> > +
> > + test_acpi_one("-machine smbios-entry-point-type=64 "
> > + "-smp cpus=100,maxcpus=120,sockets=5,"
> > + "dies=2,cores=4,threads=3", &data);
>
> I'd add to commit message an explanation why above topology was picked up
Ok. I'll. Because it defines mutiple sockets and smbios build type4 per
socket.
Thanks,
Zhao
>
> > + free_test_data(&data);
> > +}
> > +
> > static void test_acpi_q35_tcg_core_count2(void)
> > {
> > test_data data = {
> > @@ -2135,6 +2164,8 @@ int main(int argc, char *argv[])
> > if (has_kvm) {
> > qtest_add_func("acpi/q35/kvm/xapic", test_acpi_q35_kvm_xapic);
> > qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
> > + qtest_add_func("acpi/q35/type4-count",
> > + test_acpi_q35_tcg_type4_count);
> > qtest_add_func("acpi/q35/core-count2",
> > test_acpi_q35_tcg_core_count2);
> > }
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries for type4 count test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (2 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 03/16] tests: bios-tables-test: Add test for smbios type4 count Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 13:05 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 05/16] tests: bios-tables-test: Prepare the ACPI table change for type4 core " Zhao Liu
` (12 subsequent siblings)
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 5 and 6.
Changes in the tables:
FACP:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-W37791, Wed Aug 23 10:36:32 2023
+ *
+ * ACPI Data Table [FACP]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
+[004h 0004 4] Table Length : 000000F4
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : B3
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] FACS Address : 00000000
+[028h 0040 4] DSDT Address : 00000000
+[02Ch 0044 1] Model : 01
+[02Dh 0045 1] PM Profile : 00 [Unspecified]
+[02Eh 0046 2] SCI Interrupt : 0009
+[030h 0048 4] SMI Command Port : 000000B2
+[034h 0052 1] ACPI Enable Value : 02
+[035h 0053 1] ACPI Disable Value : 03
+[036h 0054 1] S4BIOS Command : 00
+[037h 0055 1] P-State Control : 00
+[038h 0056 4] PM1A Event Block Address : 00000600
+[03Ch 0060 4] PM1B Event Block Address : 00000000
+[040h 0064 4] PM1A Control Block Address : 00000604
+[044h 0068 4] PM1B Control Block Address : 00000000
+[048h 0072 4] PM2 Control Block Address : 00000000
+[04Ch 0076 4] PM Timer Block Address : 00000608
+[050h 0080 4] GPE0 Block Address : 00000620
+[054h 0084 4] GPE1 Block Address : 00000000
+[058h 0088 1] PM1 Event Block Length : 04
+[059h 0089 1] PM1 Control Block Length : 02
+[05Ah 0090 1] PM2 Control Block Length : 00
+[05Bh 0091 1] PM Timer Block Length : 04
+[05Ch 0092 1] GPE0 Block Length : 10
+[05Dh 0093 1] GPE1 Block Length : 00
+[05Eh 0094 1] GPE1 Base Offset : 00
+[05Fh 0095 1] _CST Support : 00
+[060h 0096 2] C2 Latency : 0FFF
+[062h 0098 2] C3 Latency : 0FFF
+[064h 0100 2] CPU Cache Size : 0000
+[066h 0102 2] Cache Flush Stride : 0000
+[068h 0104 1] Duty Cycle Offset : 00
+[069h 0105 1] Duty Cycle Width : 00
+[06Ah 0106 1] RTC Day Alarm Index : 00
+[06Bh 0107 1] RTC Month Alarm Index : 00
+[06Ch 0108 1] RTC Century Index : 32
+[06Dh 0109 2] Boot Flags (decoded below) : 0002
+ Legacy Devices Supported (V2) : 0
+ 8042 Present on ports 60/64 (V2) : 1
+ VGA Not Present (V4) : 0
+ MSI Not Supported (V4) : 0
+ PCIe ASPM Not Supported (V4) : 0
+ CMOS RTC Not Present (V5) : 0
+[06Fh 0111 1] Reserved : 00
+[070h 0112 4] Flags (decoded below) : 000484A5
+ WBINVD instruction is operational (V1) : 1
+ WBINVD flushes all caches (V1) : 0
+ All CPUs support C1 (V1) : 1
+ C2 works on MP system (V1) : 0
+ Control Method Power Button (V1) : 0
+ Control Method Sleep Button (V1) : 1
+ RTC wake not in fixed reg space (V1) : 0
+ RTC can wake system from S4 (V1) : 1
+ 32-bit PM Timer (V1) : 0
+ Docking Supported (V1) : 0
+ Reset Register Supported (V2) : 1
+ Sealed Case (V3) : 0
+ Headless - No Video (V3) : 0
+ Use native instr after SLP_TYPx (V3) : 0
+ PCIEXP_WAK Bits Supported (V4) : 0
+ Use Platform Timer (V4) : 1
+ RTC_STS valid on S4 wake (V4) : 0
+ Remote Power-on capable (V4) : 0
+ Use APIC Cluster Model (V4) : 1
+ Use APIC Physical Destination Mode (V4) : 0
+ Hardware Reduced (V5) : 0
+ Low Power S0 Idle (V5) : 0
+
+[074h 0116 12] Reset Register : [Generic Address Structure]
+[074h 0116 1] Space ID : 01 [SystemIO]
+[075h 0117 1] Bit Width : 08
+[076h 0118 1] Bit Offset : 00
+[077h 0119 1] Encoded Access Width : 00 [Undefined/Legacy]
+[078h 0120 8] Address : 0000000000000CF9
+
+[080h 0128 1] Value to cause reset : 0F
+[081h 0129 2] ARM Flags (decoded below) : 0000
+ PSCI Compliant : 0
+ Must use HVC for PSCI : 0
+
+[083h 0131 1] FADT Minor Revision : 00
+[084h 0132 8] FACS Address : 0000000000000000
+[08Ch 0140 8] DSDT Address : 0000000000000000
+[094h 0148 12] PM1A Event Block : [Generic Address Structure]
+[094h 0148 1] Space ID : 01 [SystemIO]
+[095h 0149 1] Bit Width : 20
+[096h 0150 1] Bit Offset : 00
+[097h 0151 1] Encoded Access Width : 00 [Undefined/Legacy]
+[098h 0152 8] Address : 0000000000000600
+
+[0A0h 0160 12] PM1B Event Block : [Generic Address Structure]
+[0A0h 0160 1] Space ID : 00 [SystemMemory]
+[0A1h 0161 1] Bit Width : 00
+[0A2h 0162 1] Bit Offset : 00
+[0A3h 0163 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0A4h 0164 8] Address : 0000000000000000
+
+[0ACh 0172 12] PM1A Control Block : [Generic Address Structure]
+[0ACh 0172 1] Space ID : 01 [SystemIO]
+[0ADh 0173 1] Bit Width : 10
+[0AEh 0174 1] Bit Offset : 00
+[0AFh 0175 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0B0h 0176 8] Address : 0000000000000604
+
+[0B8h 0184 12] PM1B Control Block : [Generic Address Structure]
+[0B8h 0184 1] Space ID : 00 [SystemMemory]
+[0B9h 0185 1] Bit Width : 00
+[0BAh 0186 1] Bit Offset : 00
+[0BBh 0187 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0BCh 0188 8] Address : 0000000000000000
+
+[0C4h 0196 12] PM2 Control Block : [Generic Address Structure]
+[0C4h 0196 1] Space ID : 00 [SystemMemory]
+[0C5h 0197 1] Bit Width : 00
+[0C6h 0198 1] Bit Offset : 00
+[0C7h 0199 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0C8h 0200 8] Address : 0000000000000000
+
+[0D0h 0208 12] PM Timer Block : [Generic Address Structure]
+[0D0h 0208 1] Space ID : 01 [SystemIO]
+[0D1h 0209 1] Bit Width : 20
+[0D2h 0210 1] Bit Offset : 00
+[0D3h 0211 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0D4h 0212 8] Address : 0000000000000608
+
+[0DCh 0220 12] GPE0 Block : [Generic Address Structure]
+[0DCh 0220 1] Space ID : 01 [SystemIO]
+[0DDh 0221 1] Bit Width : 80
+[0DEh 0222 1] Bit Offset : 00
+[0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0E0h 0224 8] Address : 0000000000000620
+
+[0E8h 0232 12] GPE1 Block : [Generic Address Structure]
+[0E8h 0232 1] Space ID : 00 [SystemMemory]
+[0E9h 0233 1] Bit Width : 00
+[0EAh 0234 1] Bit Offset : 00
+[0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0ECh 0236 8] Address : 0000000000000000
+
...
APIC:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-687791, Wed Aug 23 10:36:32 2023
+ *
+ * ACPI Data Table [APIC]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
+[004h 0004 4] Table Length : 00000430
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : C5
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] Local Apic Address : FEE00000
+[028h 0040 4] Flags (decoded below) : 00000001
+ PC-AT Compatibility : 1
+
+[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
+[02Dh 0045 1] Length : 08
+[02Eh 0046 1] Processor ID : 00
+[02Fh 0047 1] Local Apic ID : 00
+[030h 0048 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
+
+[034h 0052 1] Subtable Type : 00 [Processor Local APIC]
+[035h 0053 1] Length : 08
+[036h 0054 1] Processor ID : 01
+[037h 0055 1] Local Apic ID : 01
+[038h 0056 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
[snip]
+[3E4h 0996 1] Subtable Type : 00 [Processor Local APIC]
+[3E5h 0997 1] Length : 08
+[3E6h 0998 1] Processor ID : 77
+[3E7h 0999 1] Local Apic ID : 9E
+[3E8h 1000 4] Flags (decoded below) : 00000000
+ Processor Enabled : 0
+ Runtime Online Capable : 0
+
+[3ECh 1004 1] Subtable Type : 01 [I/O APIC]
+[3EDh 1005 1] Length : 0C
+[3EEh 1006 1] I/O Apic ID : 00
+[3EFh 1007 1] Reserved : 00
+[3F0h 1008 4] Address : FEC00000
+[3F4h 1012 4] Interrupt : 00000000
+
+[3F8h 1016 1] Subtable Type : 02 [Interrupt Source Override]
+[3F9h 1017 1] Length : 0A
+[3FAh 1018 1] Bus : 00
+[3FBh 1019 1] Source : 00
+[3FCh 1020 4] Interrupt : 00000002
+[400h 1024 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+
+[402h 1026 1] Subtable Type : 02 [Interrupt Source Override]
+[403h 1027 1] Length : 0A
+[404h 1028 1] Bus : 00
+[405h 1029 1] Source : 05
+[406h 1030 4] Interrupt : 00000005
+[40Ah 1034 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[40Ch 1036 1] Subtable Type : 02 [Interrupt Source Override]
+[40Dh 1037 1] Length : 0A
+[40Eh 1038 1] Bus : 00
+[40Fh 1039 1] Source : 09
+[410h 1040 4] Interrupt : 00000009
+[414h 1044 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[416h 1046 1] Subtable Type : 02 [Interrupt Source Override]
+[417h 1047 1] Length : 0A
+[418h 1048 1] Bus : 00
+[419h 1049 1] Source : 0A
+[41Ah 1050 4] Interrupt : 0000000A
+[41Eh 1054 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[420h 1056 1] Subtable Type : 02 [Interrupt Source Override]
+[421h 1057 1] Length : 0A
+[422h 1058 1] Bus : 00
+[423h 1059 1] Source : 0B
+[424h 1060 4] Interrupt : 0000000B
+[428h 1064 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[42Ah 1066 1] Subtable Type : 04 [Local APIC NMI]
+[42Bh 1067 1] Length : 06
+[42Ch 1068 1] Processor ID : FF
+[42Dh 1069 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+[42Fh 1071 1] Interrupt Input LINT : 01
+
...
DSDT:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembling to symbolic ASL+ operators
+ *
+ * Disassembly of /tmp/aml-8G8791, Wed Aug 23 10:36:32 2023
+ *
+ * Original Table Header:
+ * Signature "DSDT"
+ * Length 0x0000489D (18589)
+ * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
+ * Checksum 0xDB
+ * OEM ID "BOCHS "
+ * OEM Table ID "BXPC "
+ * OEM Revision 0x00000001 (1)
+ * Compiler ID "BXPC"
+ * Compiler Version 0x00000001 (1)
+ */
+DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
+{
+ Scope (\)
+ {
+ OperationRegion (DBG, SystemIO, 0x0402, One)
+ Field (DBG, ByteAcc, NoLock, Preserve)
+ {
+ DBGB, 8
+ }
+
+ Method (DBUG, 1, NotSerialized)
+ {
+ ToHexString (Arg0, Local0)
+ ToBuffer (Local0, Local0)
+ Local1 = (SizeOf (Local0) - One)
+ Local2 = Zero
+ While ((Local2 < Local1))
+ {
+ DBGB = DerefOf (Local0 [Local2])
+ Local2++
+ }
+
+ DBGB = 0x0A
+ }
+ }
+
[snip]
+
+ Processor (C000, 0x00, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (Zero))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (Zero, Arg0, Arg1, Arg2)
+ }
+ }
+
+ Processor (C001, 0x01, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (One))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (One)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (One, Arg0, Arg1, Arg2)
+ }
+ }
[snip]
+ Processor (C077, 0x77, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (0x77))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x77, 0x9E, 0x01, 0x00, 0x00, 0x00 // ..w.....
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (0x77)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (0x77, Arg0, Arg1, Arg2)
+ }
+ }
+ }
+ }
+
...
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.type4-count | Bin 0 -> 1072 bytes
tests/data/acpi/q35/DSDT.type4-count | Bin 0 -> 18589 bytes
tests/data/acpi/q35/FACP.type4-count | Bin 0 -> 244 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
4 files changed, 3 deletions(-)
diff --git a/tests/data/acpi/q35/APIC.type4-count b/tests/data/acpi/q35/APIC.type4-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..ab60a6ef065d8ce53ae93d311d3777d2d4afb9f6 100644
GIT binary patch
literal 1072
zcmXxjX)mKu7{>9_YU}A{8~a-OZpzsAwwBgf>(n~-!C>rL5ClOG1VQjwyzxDJ5<E};
zagzJ~UFYQFB<IC#bGsZ?jSxO>_Ev|p!(#Wi9Ts`1gb+$r6yp8Et0V-fRH#;?j|Meb
z)ap<tp|2h#1L{p^Fr(2AO#x^QM86>P55|BH3=GAfaQqR0!I2mejiE6Z7K`EDe+elf
zo_%BjMkQf%GRCA}Y#PR;qa_35voIkW6LT=hipjZ{l834Jm{x%4g_u!{nI)K2irM9u
zQ-MD#(OQkUHq5i*uNus+#ezC4bYhVUiyN?{2}_%?tOd*6SkZ=+?O4@`)m>=oM!N?c
zJy_F=wf$H(fc1mu975MHHjH577&eV#^8~g`V(S#Tr?G7Y+h?(34m;<uYXQ3#@%J)%
zR<LIkd)KjV1N%2|U<(Jg@y`wp?c(qrj_l*;0gfGd$3+@H!ii)2dxDdvICX~8=lJge
zXD)H}3g@oz{|(OH;=&y+-s92(E<fVR6Rtkv+KZyfr1aMhrK=5cDM3kEt*lu|di{4Y
Q$QL*>8of!Q`;?#f0%hq@0RR91
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.type4-count b/tests/data/acpi/q35/DSDT.type4-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..edc23198cdb47a981bcbc82bc8e392b815abb554 100644
GIT binary patch
literal 18589
zcmb81No*V0c804+N}`ICL`n1{%eE}fGfB;!$s#FI5@m{%JW)2O!M5a)9%Q$><G@xY
z{kn}Lc-?y4cnR_XbwdxxE&&2$nHb0>+4U|Byj2$2yloJ?UOnfWdvDb}b*~J>UQquj
zp7Wh^io+pqT{B%yPyZ%o80PO%m+V}*Cv~-G_rO2XFbvfAH<Ay`8kN`S)M(WV`2uF;
zO^9i@Nd=?F)2W$J^VdtY?`pMYzo?mWbz}aA$hY%z_0PYo%^T>nGGDhW6p``HYB^P{
ztmfN_c0LxY=JM%q@<%HetlC`pgVmXQ+K5gxRWFt8z}tI<oxT!ZpKMrLYVWinmBR1(
z{;;R};&)e`CEuO<&)aYBSpjfJz~3PJ?W^NW?X#M-yS5(rW^LJgh2iYJ_<H9zYwT`*
zEQ0scYk1`QFh7K-_{P2Hcta*#F0`x<uH7~2?S9j!t#^IH3;1#9KmNNs@M+=eZND$<
z_&2+-QCn~NcG>c6)auroFKdPY2fEkpT21wi2A|Pl)Zi@KH;lRZ9KW-&I-D*gZPs~9
zak3b*V{rqzFO}Q(Slz$aW*A{S<@oO(-@kwVuUs0DmquhFdJ<0_p18{EqFtUgL+`>?
zu<|B?h7HGOdf+DAQ+Zv^jKM?o?_nzdj};nrDwY|8J5rN{k{SAuhoNDoCT9vg#eDi|
zPsL14*yBd@K+(>O`6~O+djGz@gdX*m=CXl|${{?wVMLE5A!ai#WYzJeCVXqrRCAG?
z&vfHQolrPyn1r1`xG{}+co<%-%^Pd;VK_JMjaPH#+^e~lrqv`*@cIGI*;fGddHyg2
zi+MY1M8j41Yu1<0imYBX@%%>Y-?Qgtu{2%m7=QY@BNPZhu8GO<jKQ@DI%{-<@wnv!
zW7IMHVC0OBmH^ZT4<q*z7Dj<%E5DD$fvaO;B=DK9k41v7urShb^%*P@Tv;TT7zx!d
zUq6d<D)1W^>A3oNB)GCjFfr1}5@3-|1pyZ6xCVHnQ#_co&jwGQ4J^`eZQzkk@nF(E
z8$EqCvPj3Z(c34Ow9h6_pG}@Vo4kF3N&5_X`V4yd40`(nllIx{>9g6>XS26YFlnEb
zr%%h%r{(PvOxkD2(`U%jXUN+pn6%HZr_Zpb&#<>oFlnDHo<3VVeYSY}1e5mJ>glu9
z(`T!<PcUhpZJs{cJbku#`vjBr8S(TP@$?z-_6a8Kv)$8YyQj}~Z=Yb&K07>pc6j>i
z@b(EN?X%O<XQ!vnPH&%J(mtb}KBJyKquxHjq<wDj^tr{;=N50DVA4Lfdivbz>2s^M
zPcUhpFvj?M7JFCP=IL{rw@)x>pW8isZuj)L-P<Raw9g$ZGAZ5(cd*Emc(dEVBW-D7
zWLo%kc_O<!kzL+MFlppYPvlNd<W6rSm^8B66WQ&F?Dj^2Nh5c8B6oQrcX=bhq>;N>
zr1KuXn?*YB@w<7X^TrJ(Mmm#Zk0<9IPtHBwoM7^tK^UM(GC)Vmc}UHMsR<eqivbD-
zq~(Sm3@0fJQ0~W`M5cjJPJJdM<*x1k1=DE_1}OJ+1}JgG0m@z70SYEm;|x&lD=f?j
zRA*vhq;tk_fPx7XF<%&<+*eqlM;3_#l)E}6?Gpwl$FfKmpu`miD45Pv!~qJX(<cm2
z?#m)!fD%_6pxl+^!~qJX(<cm2?#m)!fD%_6pxl*3;s6EH=@SMh_hpeVK#403Q0~ei
zae#v9Jf1K>xi5=^0ZLqPfO1zBi31c&r%xE5+?Ped041(CK)EZ6!~qJX(<cm2?#m)!
zfD%_6pxl*3;s6EH=@SMh_hpeVK#403Q0~eiae#v9^a%r$`?5$Fpu`miD0gL%I6%R4
z`h)?>eOV+7P~wUMl)JJ>9H3x2eZm0czAO?3C~?IB%3WC`4p1<iK4E}zUls`il(^ym
z<*qCe2Pl|MpD;kVFN=f$N?dV(a#t3K0~AcBPZ*%wmqo$=C9XI?xhspr0SczmCk#;T
z%OYWb5?36c+?7S*00q<O69y>vWsxvIi7O6J?#d!@fP(4t2?Lb-vPc-9#1#i9cV&?{
zK*4nSgaOKZStJZl;)(;5yRt|epkO+E!T{yIED{DNam4}3U0Ea!P%xc7VSsX976}8C
zxZ(iit}GG<D40&4FhIc~0~9PeK*6K~6ihNeNhAzV5{UzpMB)G?kuX3>Bn(gzi35~G
z;s7O)FhEHp3{Vn@1C&JK040$yKuIJFP!fp)ltkhHC6O>d!Ezp57@%OmBgRf94p1=R
zVQ@^0bj~ddP_UeH3j-7^=iK4|1=BgVI6%RKHIS|<j8J1eyvDw)Zr~Tv?;G(?GTND+
zg75$9&7WDXmy8XodBX}t`}0$FsTsy@Dc0U<g}!Pun%PpqOXDpbvl`$wU;k{$YBNv)
zs1&QLPBg)sPdY0x;Wobh5`@&{_N`XuSFJ{~A10Im@4*JVn;I{TXj`>BoisMEgkotb
z8Evno^JU`|YU?#S(uNBf=wX+by{%d<mCd(Hq6SQl$3^y(lHL4>>?x8x#j>ZMKAJrh
z-8_4$vRc62`C1IDLW$lj-$$gkNqU>5x0Uqv2h!UjeOhVWf)%j;_qk7#^l6qpt)x$X
zAbnb-%GACW#o(q~xujFLX{f%F-XKC7m0_=xmbl0M7QXO;BX52VkE^rLF}#*aup
zO45(A^rK4p(GR2_73p(o`lgRapCjpWEPYN%pZh@i9HbB6+mV_+!qYo%9`MlsUhaHx
z(t9l0$X@dB2Vd6$r@oA>b}tS-FK9S^Y*U=}y6o`c;6sFl<Ht6|X|J<RFAhFgXgGds
zQ=Im?iF$GHaYMuLW1Hf%*TEJq4nBiuIDTwXoc6rl>czna6Aj0YZHm*Lr`x<Z__U(o
z_%SaoQV8<p|4cAf%uG8^KNH^aaM8c=I#--781Tva$3KP)Sh|j&-FZ1PneHi;($${m
zAe%gOJW{LUp}9|MR;0Eb{(7xutkqyWcEeb2{d#TA_|;t4_^<zM*nr^(BMq0=+pX3w
z;428i4fwJK3+mD8XpujTElInWkHunxM&zr1@$njS*6b<2v*2DVWy(&u7Q9J7xh-~a
zrYHC4S^fUXot`JRo<3T6vT*CEQ8De}#JG6Xv{=@t`BV6(uo->{?ZNvxEZYARw!)P+
zhtWtHJ$5lOY1;Y8vT2tJmrYoDkKs+$H2k(*NW=1e2YUMLa%Q3j+|$YF9$2@|Pv(Pl
z0}obKzxXHLEW0!S74a%XKk*pW!7r>dL^Idz>FhP%y0x}sd|^Yk%P38h@#Xc<+LGl%
zo#5J!x{vDs>VB>pP!Dk3h<cFgCe%Y*2T>1m-HdvKYYTOf>k#S`*J0E)*Da{iT(_dm
zaNUMF%XI{F9LmR<+fj@9J5Y=IJ5h`Jqo_swTTqMox1tvHZ$mBW-;P?;zXP?XzYDdf
ze<x~De>ZAT|1Q*`{@tiW{d-W0`g=epME!eFi~4&}i~9GW7WMB(E$TmjTGW3KwW$9P
zYEl1T)S~_)s73upQH%PIp%(QYM=k0<fm+mm61AxR6lzg_40NBUKaN_|pFl0@??Wx>
z??)}_A3!bYA4DzcA3`naA4V<eA3-hZKaE<{e+IRv|14@z|2fp6{`06s{TEP+`Y(d+
z7xgDmi~3WjMg2BvQGXh>s6T^R)SpEy>K{cd>d&DT_2*HG`o~a<`o~d=`X^9}`U|K<
z{gbFg{g+US`ir0kMEz5!Mg1kzqW&^!QU5e*QU45TQU7JsqW&wWMg3P%i~6sj7WH38
zE$XkJ7WL1f7WLmiE$Y9CTGU@fE$Xj<9u)P@p%(SeqZaiqpceHnq89bvLM`gQjat-y
z2eqhw3ALzy8MUbYE^1N#J=CK9`=~|z4^WHxAEFlZKSC|)uY(>E^*=@}>VJY-)c+K<
zsQ(#iQU3~RQU7z)qW%}ChnAzcM!1-pY_9B^Jr$tS2d4^Nja3iB1gPWn={5BZoGW#!
z4X(m!_e_j$)S`t3oHZYp$W&24*pwd~-D;QZ$>0at2-=gGD;>V~bz`A!F8+||SX(sf
z#$w&9)s49y3gKU_)y!`ftWTh``huF1b*vtQQMtbDTlFXm%Z1;rH?PfE?;+1`>zm!b
zzF#|aIF0KIUt*DS#>yO&_5INLfab>LHH_2+%U{>d4BQEED+{<AA`{@-ArLrkEZ`Vk
zfCQEJ=FMp=sApw<^YdJ2wl9^Z!yh=$n?GGNKAgPz@+Rk|Zu!)s=z3Q@2&Z||>MEZP
z!_bc5hb{vzw!;%UxPeb^_*ha%PPd1wpaJX2xJnUih5a7WA#BE2TE1KPJQIM>I9tH*
zgu>#08)}*?G*lHInqnrwm<*FcOad+lV2&190e;JOIX)lbgk6s1gRfFfJ(f?B`rrz?
zN`g<XF3BHINq$Q5OHx04231M$-P<Jv8dOq%k^+)6fXg#VckngZB{ejvqy|cAkfcGl
zprDfA!>&te4639?N@|p(A-KSxlHkj&OKM_EQ}C2<9yzOtlA0uG7@i<13APKlq@bnN
z6r`k}B#p37|K4XoGa)szoj0_mW=d+7q$DneDQDawB&$WO$)Y4nl2W*&rjSB}6lzsT
zAxa8Kk_}&*R8p9b!V#4erlhbWrQrgGN@^jbmUflYLP;%>lz|HxDyfx_T02xyD<!o`
zQWh?7s3iDa=ROPCqAID4lG<ESJcg?p${B}s50@0#qLLz%6p^GjE?y`kSn_a5?ORn+
zJ0-PCQUcd46cVg<xTKElDyf5#IwYwNmn;+#EOfY}&K)YLlae|msUKG>6cVg)xTI*8
zN{UiaRFVd8p+X_S@`g*=(yfxVP|_Aj8pJgUg#;@bE@|s7m9&+Two1|vE>9>VSk!Py
z+jgs@ZIrZ4l7``ei%Qx~NZZ*~O8Ty{oszao(g<9DQAs-pX~$l*rX7^DLz0rPqd_Hg
z5mHyLO6sDdE=fwk1savKlaO}qS4lf5X{RLFaKT0;brVwe0hQEEN!^l^h6^|<X%`{w
zI;fI%QPM6+%D@F3m9(3Xb{|$ryD4e6BxT_Ok4oA@NPCW`q&<|h$0a3VJvym}ka~`)
zq#jD@k)-%uowS#b_8wPBdnswJBqe%vQZFI(o={1>l+-IpefxCMK0?}eQYG!9q<xaq
zzh5WqC#3x`m9(Fd_Dj;h0iAS!kPfg<q4X7efRYYK(%?azbdZn^Ce)e^Qqn<58akwt
z4iVC!ewB2Hk`77I@L`>Fn2-(+sHDS`bXbx`j_9N#gmh$3B^{xpBa)Ons*{cq($Qg+
zbd-{gN>b{WPC7<N$3|4rF-kfnN%nD_bexcmpH@l7De1T*rBCRj6NGf)tV%jTNhc&J
zb5bXrB&3t)RMJUGIw?unQ#$DsA)Pv}l1@?5DVNkIzRr2ROTk8dcXGxqs-zet#Uv>n
z*K3LsQaq`W;*=DZq(nj|B?u{zQb`F)N=Q;)pHAu{q`tID>Z7DSN$T&{N&SS>pHWHu
zl+-Ut0|Po~fRF~@S^<2NA>XA2C}}{F1_yQ0AR!IrRMH?N4NB6`kWLyRq@lb@8lt2j
zNg5v3NyCIRJf@O{DQQ@eMn-hf2qBG3sH71}8j+;rX`OVMkWLp=(rHRMElH^}I_V4{
zotacgXDI26B-v+m(pf?}TU1GBDe0^vrO)Z4bA)tmN+q46q;ry#Ij@t>6VmyTN;*$T
z=Orn7K_^`xqzlt3=>jEPa7q2Ki#q8dAzhqNNf#;Uq9nzWItebByYF<#%PJ{JNl8gc
zq;wKoEq6(&t11aMvAF9`DM{+HbrM`CcS-g&m4y3IT#_wG{b`*9*T`K``npQOttBog
zElC3zodlOvT~cONCE+d+mz0sD!K_Y#E8{LHdqXARh7XsNm879jodg%fUDD`Hm4tgY
zT+*l{4d-+cTn~3ixtdDCZ5S>oCrKlDos=h}{G3Y4Q&L`%l4Ck)jF86WRnizGjY(2!
zTqlha()glE8mFXjNwOz&(gYz*+)_yslr$kp>4HvzjRWo(FWgp11xhMNQf5*oO%l@N
zl1iGSq)AE2UeZaI2<g(YO1eZzmt4|7tf-TUgjBq%l8Tg6l%)8SPMRX5Dfl0A-p>V7
zlr$wtiIPq#5mM=aN-9xONs{`?ItjKUxQ|`=p-L)KQdyGvr*#tS7;#C{b(J(tNz;-v
zFr$-Z2x;cAN}8dh8A%$vtdlMi(&Z;A=`tl<mZYI8I_U}_U3sRGu29kyNgBSYldcld
z)fJU=m6EPX(#SQPbd8X%Jy%KBDCwFcC9mtG>x6Xu6P0wGlCDcqs-lxBgj9K{k}8x`
zktBOoC(RPl?58SemXc;ADSbmH-5{hJf1;9ZP|^)a%G}gRHwo$HE0uJUl5R>;wyKk=
zgjD@gl~kpqs!JM-)pSygkZP}0QjL;ok`$lQNpplW_eLenQPP|wCFXU~JR!}ms-$^J
znwO-$1)a1&NDF_ak`^dwL6Z6xb<!dsE&jPmTBM{!NgBANlWq~xtuIv4ElRp2NrSg_
z(rrSz{iRB}O-Z*UY3Pnlx<g2JzEVkdDCv$Q4KL}WB|=(ytCE%|X-SesmUYrHAua!f
zN?N9*Wl2ij)k${=>F!^uq`Q=KSCUfqbkaRSy7yNq=^iEBlO+4TPP$J>_kXF9?o-lz
zNlHJ^Ne>9=!PhG30VO?<q|8H|^pKDqexs5eQqn_7%0ALbj|l0}uT;__N_ymyhGKP{
zR41hRw<@VlNp(qzKh{Z)3F+~7D(NvLJ(i@z6P@&gke>WnB|V{}Cz90nR3|+pq^Eza
zlAco1Q%UN7rjwo#(zCx&NzW+hnIsLY=%f`wTKQX*v_eTMk~H{SCp{;m=f6=&&nfA-
zBn`dLNiPWL#owu<7nJk@NYS0JX%;pBS2MAMA-4MB23p*=6e(=sJ8Ic4L9p$^V<GFG
zzicsl{4)D{OmB{wKZkz~n?X2khS|=LKfv8Thh4h`emKG~{)hdn2fH8tAI<ys{Gz{M
z_zcevegxq+E&hS^Wf*_&x#u1H638F<J@3xHg*9)UP52tvEB+t`-zwo8HE?eY>~pTH
z+5zYj7HQ$vR@iTjBw?d7-@}Z@$>wF)o;{tkU;_efm}Z-odm4KhP5AYZ%Ia94m@C4!
z0v!S;X_Jl6I_q8dUD(_X8?TSdLi%!FwWBd$LhYdYs~y3B<+EU;4p;+t54I6GBOiv!
z>dEXC8<qpGfT>Jj26h%D&|9fE(hzCD?beaZ&RN_*7b$e%qgYuDm18mZOq5KQpqr!R
z*f2NX5i<?AvR#g+4ftIX5D7>0p@7b#<*anxgB!W?r753Pv%(QOz>-wnoId5pH0X)<
zn)v^l;QwMxrSQhan{?2CZR}GS)LFb4#hYBPvf4kMN<%UH$8h|xp9p(`?G5-SY`3<I
znl+<lnDBI4G#24+ua7;d`wN$5+^9CV%1@$#RzolTXiQ}_F;Sd`Rdvn|!1;o$>#&E4
z_(rUjQS%f3C;nit_cbFY>`MhVrUAS+kNMgEv)>5zMp(>&(zNYX6M{TgJVV!wx?u);
k4HL_0D`%79y!#9|m3SZ}4*20fB#f^~_-_Ll_+6a;1CLN!@c;k-
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/FACP.type4-count b/tests/data/acpi/q35/FACP.type4-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
GIT binary patch
literal 244
zcmZ>BbPo8!z`($~*~#D8BUr&HBEVSz2pEB4AU24G0Y(N+hD|^Y6El!tgNU*~X%LSC
z$X0-fGcm9T0LA|E|L2FOWMD92VqjR>!otAF!NBm72O<iWged~jj0!*k$y^{03>bk1
YBHITON2VDSAnpK(F*YFF1LDH~0O^Si0RR91
literal 0
HcmV?d00001
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 0ce6f8fc72ee..dfb8523c8bf4 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/APIC.type4-count",
-"tests/data/acpi/q35/DSDT.type4-count",
-"tests/data/acpi/q35/FACP.type4-count",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries for type4 count test
2023-08-25 3:36 ` [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries for type4 count test Zhao Liu
@ 2023-09-15 13:05 ` Igor Mammedov
2023-09-19 7:26 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 13:05 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:07 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
copy/past mistake in subj?
shouldn't it be for 'smbios type4 count'?
> From: Zhao Liu <zhao1.liu@intel.com>
>
> Following the guidelines in tests/qtest/bios-tables-test.c, this
> is step 5 and 6.
>
> Changes in the tables:
> FACP:
>
> +/*
> + * Intel ACPI Component Architecture
> + * AML/ASL+ Disassembler version 20200925 (64-bit version)
> + * Copyright (c) 2000 - 2020 Intel Corporation
> + *
> + * Disassembly of /tmp/aml-W37791, Wed Aug 23 10:36:32 2023
> + *
> + * ACPI Data Table [FACP]
> + *
> + * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> + */
> +
> +[000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
> +[004h 0004 4] Table Length : 000000F4
> +[008h 0008 1] Revision : 03
> +[009h 0009 1] Checksum : B3
> +[00Ah 0010 6] Oem ID : "BOCHS "
> +[010h 0016 8] Oem Table ID : "BXPC "
> +[018h 0024 4] Oem Revision : 00000001
> +[01Ch 0028 4] Asl Compiler ID : "BXPC"
> +[020h 0032 4] Asl Compiler Revision : 00000001
> +
> +[024h 0036 4] FACS Address : 00000000
> +[028h 0040 4] DSDT Address : 00000000
> +[02Ch 0044 1] Model : 01
> +[02Dh 0045 1] PM Profile : 00 [Unspecified]
> +[02Eh 0046 2] SCI Interrupt : 0009
> +[030h 0048 4] SMI Command Port : 000000B2
> +[034h 0052 1] ACPI Enable Value : 02
> +[035h 0053 1] ACPI Disable Value : 03
> +[036h 0054 1] S4BIOS Command : 00
> +[037h 0055 1] P-State Control : 00
> +[038h 0056 4] PM1A Event Block Address : 00000600
> +[03Ch 0060 4] PM1B Event Block Address : 00000000
> +[040h 0064 4] PM1A Control Block Address : 00000604
> +[044h 0068 4] PM1B Control Block Address : 00000000
> +[048h 0072 4] PM2 Control Block Address : 00000000
> +[04Ch 0076 4] PM Timer Block Address : 00000608
> +[050h 0080 4] GPE0 Block Address : 00000620
> +[054h 0084 4] GPE1 Block Address : 00000000
> +[058h 0088 1] PM1 Event Block Length : 04
> +[059h 0089 1] PM1 Control Block Length : 02
> +[05Ah 0090 1] PM2 Control Block Length : 00
> +[05Bh 0091 1] PM Timer Block Length : 04
> +[05Ch 0092 1] GPE0 Block Length : 10
> +[05Dh 0093 1] GPE1 Block Length : 00
> +[05Eh 0094 1] GPE1 Base Offset : 00
> +[05Fh 0095 1] _CST Support : 00
> +[060h 0096 2] C2 Latency : 0FFF
> +[062h 0098 2] C3 Latency : 0FFF
> +[064h 0100 2] CPU Cache Size : 0000
> +[066h 0102 2] Cache Flush Stride : 0000
> +[068h 0104 1] Duty Cycle Offset : 00
> +[069h 0105 1] Duty Cycle Width : 00
> +[06Ah 0106 1] RTC Day Alarm Index : 00
> +[06Bh 0107 1] RTC Month Alarm Index : 00
> +[06Ch 0108 1] RTC Century Index : 32
> +[06Dh 0109 2] Boot Flags (decoded below) : 0002
> + Legacy Devices Supported (V2) : 0
> + 8042 Present on ports 60/64 (V2) : 1
> + VGA Not Present (V4) : 0
> + MSI Not Supported (V4) : 0
> + PCIe ASPM Not Supported (V4) : 0
> + CMOS RTC Not Present (V5) : 0
> +[06Fh 0111 1] Reserved : 00
> +[070h 0112 4] Flags (decoded below) : 000484A5
> + WBINVD instruction is operational (V1) : 1
> + WBINVD flushes all caches (V1) : 0
> + All CPUs support C1 (V1) : 1
> + C2 works on MP system (V1) : 0
> + Control Method Power Button (V1) : 0
> + Control Method Sleep Button (V1) : 1
> + RTC wake not in fixed reg space (V1) : 0
> + RTC can wake system from S4 (V1) : 1
> + 32-bit PM Timer (V1) : 0
> + Docking Supported (V1) : 0
> + Reset Register Supported (V2) : 1
> + Sealed Case (V3) : 0
> + Headless - No Video (V3) : 0
> + Use native instr after SLP_TYPx (V3) : 0
> + PCIEXP_WAK Bits Supported (V4) : 0
> + Use Platform Timer (V4) : 1
> + RTC_STS valid on S4 wake (V4) : 0
> + Remote Power-on capable (V4) : 0
> + Use APIC Cluster Model (V4) : 1
> + Use APIC Physical Destination Mode (V4) : 0
> + Hardware Reduced (V5) : 0
> + Low Power S0 Idle (V5) : 0
> +
> +[074h 0116 12] Reset Register : [Generic Address Structure]
> +[074h 0116 1] Space ID : 01 [SystemIO]
> +[075h 0117 1] Bit Width : 08
> +[076h 0118 1] Bit Offset : 00
> +[077h 0119 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[078h 0120 8] Address : 0000000000000CF9
> +
> +[080h 0128 1] Value to cause reset : 0F
> +[081h 0129 2] ARM Flags (decoded below) : 0000
> + PSCI Compliant : 0
> + Must use HVC for PSCI : 0
> +
> +[083h 0131 1] FADT Minor Revision : 00
> +[084h 0132 8] FACS Address : 0000000000000000
> +[08Ch 0140 8] DSDT Address : 0000000000000000
> +[094h 0148 12] PM1A Event Block : [Generic Address Structure]
> +[094h 0148 1] Space ID : 01 [SystemIO]
> +[095h 0149 1] Bit Width : 20
> +[096h 0150 1] Bit Offset : 00
> +[097h 0151 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[098h 0152 8] Address : 0000000000000600
> +
> +[0A0h 0160 12] PM1B Event Block : [Generic Address Structure]
> +[0A0h 0160 1] Space ID : 00 [SystemMemory]
> +[0A1h 0161 1] Bit Width : 00
> +[0A2h 0162 1] Bit Offset : 00
> +[0A3h 0163 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0A4h 0164 8] Address : 0000000000000000
> +
> +[0ACh 0172 12] PM1A Control Block : [Generic Address Structure]
> +[0ACh 0172 1] Space ID : 01 [SystemIO]
> +[0ADh 0173 1] Bit Width : 10
> +[0AEh 0174 1] Bit Offset : 00
> +[0AFh 0175 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0B0h 0176 8] Address : 0000000000000604
> +
> +[0B8h 0184 12] PM1B Control Block : [Generic Address Structure]
> +[0B8h 0184 1] Space ID : 00 [SystemMemory]
> +[0B9h 0185 1] Bit Width : 00
> +[0BAh 0186 1] Bit Offset : 00
> +[0BBh 0187 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0BCh 0188 8] Address : 0000000000000000
> +
> +[0C4h 0196 12] PM2 Control Block : [Generic Address Structure]
> +[0C4h 0196 1] Space ID : 00 [SystemMemory]
> +[0C5h 0197 1] Bit Width : 00
> +[0C6h 0198 1] Bit Offset : 00
> +[0C7h 0199 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0C8h 0200 8] Address : 0000000000000000
> +
> +[0D0h 0208 12] PM Timer Block : [Generic Address Structure]
> +[0D0h 0208 1] Space ID : 01 [SystemIO]
> +[0D1h 0209 1] Bit Width : 20
> +[0D2h 0210 1] Bit Offset : 00
> +[0D3h 0211 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0D4h 0212 8] Address : 0000000000000608
> +
> +[0DCh 0220 12] GPE0 Block : [Generic Address Structure]
> +[0DCh 0220 1] Space ID : 01 [SystemIO]
> +[0DDh 0221 1] Bit Width : 80
> +[0DEh 0222 1] Bit Offset : 00
> +[0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0E0h 0224 8] Address : 0000000000000620
> +
> +[0E8h 0232 12] GPE1 Block : [Generic Address Structure]
> +[0E8h 0232 1] Space ID : 00 [SystemMemory]
> +[0E9h 0233 1] Bit Width : 00
> +[0EAh 0234 1] Bit Offset : 00
> +[0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
> +[0ECh 0236 8] Address : 0000000000000000
> +
> ...
>
> APIC:
>
> +/*
> + * Intel ACPI Component Architecture
> + * AML/ASL+ Disassembler version 20200925 (64-bit version)
> + * Copyright (c) 2000 - 2020 Intel Corporation
> + *
> + * Disassembly of /tmp/aml-687791, Wed Aug 23 10:36:32 2023
> + *
> + * ACPI Data Table [APIC]
> + *
> + * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> + */
> +
> +[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
> +[004h 0004 4] Table Length : 00000430
> +[008h 0008 1] Revision : 03
> +[009h 0009 1] Checksum : C5
> +[00Ah 0010 6] Oem ID : "BOCHS "
> +[010h 0016 8] Oem Table ID : "BXPC "
> +[018h 0024 4] Oem Revision : 00000001
> +[01Ch 0028 4] Asl Compiler ID : "BXPC"
> +[020h 0032 4] Asl Compiler Revision : 00000001
> +
> +[024h 0036 4] Local Apic Address : FEE00000
> +[028h 0040 4] Flags (decoded below) : 00000001
> + PC-AT Compatibility : 1
> +
> +[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
> +[02Dh 0045 1] Length : 08
> +[02Eh 0046 1] Processor ID : 00
> +[02Fh 0047 1] Local Apic ID : 00
> +[030h 0048 4] Flags (decoded below) : 00000001
> + Processor Enabled : 1
> + Runtime Online Capable : 0
> +
> +[034h 0052 1] Subtable Type : 00 [Processor Local APIC]
> +[035h 0053 1] Length : 08
> +[036h 0054 1] Processor ID : 01
> +[037h 0055 1] Local Apic ID : 01
> +[038h 0056 4] Flags (decoded below) : 00000001
> + Processor Enabled : 1
> + Runtime Online Capable : 0
>
> [snip]
>
> +[3E4h 0996 1] Subtable Type : 00 [Processor Local APIC]
> +[3E5h 0997 1] Length : 08
> +[3E6h 0998 1] Processor ID : 77
> +[3E7h 0999 1] Local Apic ID : 9E
> +[3E8h 1000 4] Flags (decoded below) : 00000000
> + Processor Enabled : 0
> + Runtime Online Capable : 0
> +
> +[3ECh 1004 1] Subtable Type : 01 [I/O APIC]
> +[3EDh 1005 1] Length : 0C
> +[3EEh 1006 1] I/O Apic ID : 00
> +[3EFh 1007 1] Reserved : 00
> +[3F0h 1008 4] Address : FEC00000
> +[3F4h 1012 4] Interrupt : 00000000
> +
> +[3F8h 1016 1] Subtable Type : 02 [Interrupt Source Override]
> +[3F9h 1017 1] Length : 0A
> +[3FAh 1018 1] Bus : 00
> +[3FBh 1019 1] Source : 00
> +[3FCh 1020 4] Interrupt : 00000002
> +[400h 1024 2] Flags (decoded below) : 0000
> + Polarity : 0
> + Trigger Mode : 0
> +
> +[402h 1026 1] Subtable Type : 02 [Interrupt Source Override]
> +[403h 1027 1] Length : 0A
> +[404h 1028 1] Bus : 00
> +[405h 1029 1] Source : 05
> +[406h 1030 4] Interrupt : 00000005
> +[40Ah 1034 2] Flags (decoded below) : 000D
> + Polarity : 1
> + Trigger Mode : 3
> +
> +[40Ch 1036 1] Subtable Type : 02 [Interrupt Source Override]
> +[40Dh 1037 1] Length : 0A
> +[40Eh 1038 1] Bus : 00
> +[40Fh 1039 1] Source : 09
> +[410h 1040 4] Interrupt : 00000009
> +[414h 1044 2] Flags (decoded below) : 000D
> + Polarity : 1
> + Trigger Mode : 3
> +
> +[416h 1046 1] Subtable Type : 02 [Interrupt Source Override]
> +[417h 1047 1] Length : 0A
> +[418h 1048 1] Bus : 00
> +[419h 1049 1] Source : 0A
> +[41Ah 1050 4] Interrupt : 0000000A
> +[41Eh 1054 2] Flags (decoded below) : 000D
> + Polarity : 1
> + Trigger Mode : 3
> +
> +[420h 1056 1] Subtable Type : 02 [Interrupt Source Override]
> +[421h 1057 1] Length : 0A
> +[422h 1058 1] Bus : 00
> +[423h 1059 1] Source : 0B
> +[424h 1060 4] Interrupt : 0000000B
> +[428h 1064 2] Flags (decoded below) : 000D
> + Polarity : 1
> + Trigger Mode : 3
> +
> +[42Ah 1066 1] Subtable Type : 04 [Local APIC NMI]
> +[42Bh 1067 1] Length : 06
> +[42Ch 1068 1] Processor ID : FF
> +[42Dh 1069 2] Flags (decoded below) : 0000
> + Polarity : 0
> + Trigger Mode : 0
> +[42Fh 1071 1] Interrupt Input LINT : 01
> +
> ...
>
> DSDT:
>
> +/*
> + * Intel ACPI Component Architecture
> + * AML/ASL+ Disassembler version 20200925 (64-bit version)
> + * Copyright (c) 2000 - 2020 Intel Corporation
> + *
> + * Disassembling to symbolic ASL+ operators
> + *
> + * Disassembly of /tmp/aml-8G8791, Wed Aug 23 10:36:32 2023
> + *
> + * Original Table Header:
> + * Signature "DSDT"
> + * Length 0x0000489D (18589)
> + * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
> + * Checksum 0xDB
> + * OEM ID "BOCHS "
> + * OEM Table ID "BXPC "
> + * OEM Revision 0x00000001 (1)
> + * Compiler ID "BXPC"
> + * Compiler Version 0x00000001 (1)
> + */
> +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
> +{
> + Scope (\)
> + {
> + OperationRegion (DBG, SystemIO, 0x0402, One)
> + Field (DBG, ByteAcc, NoLock, Preserve)
> + {
> + DBGB, 8
> + }
> +
> + Method (DBUG, 1, NotSerialized)
> + {
> + ToHexString (Arg0, Local0)
> + ToBuffer (Local0, Local0)
> + Local1 = (SizeOf (Local0) - One)
> + Local2 = Zero
> + While ((Local2 < Local1))
> + {
> + DBGB = DerefOf (Local0 [Local2])
> + Local2++
> + }
> +
> + DBGB = 0x0A
> + }
> + }
> +
>
> [snip]
>
> +
> + Processor (C000, 0x00, 0x00000000, 0x00)
> + {
> + Method (_STA, 0, Serialized) // _STA: Status
> + {
> + Return (CSTA (Zero))
> + }
> +
> + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> + {
> + 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00 // ........
> + })
> + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> + {
> + COST (Zero, Arg0, Arg1, Arg2)
> + }
> + }
> +
> + Processor (C001, 0x01, 0x00000000, 0x00)
> + {
> + Method (_STA, 0, Serialized) // _STA: Status
> + {
> + Return (CSTA (One))
> + }
> +
> + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> + {
> + 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
> + })
> + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> + {
> + CEJ0 (One)
> + }
> +
> + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> + {
> + COST (One, Arg0, Arg1, Arg2)
> + }
> + }
>
> [snip]
>
> + Processor (C077, 0x77, 0x00000000, 0x00)
> + {
> + Method (_STA, 0, Serialized) // _STA: Status
> + {
> + Return (CSTA (0x77))
> + }
> +
> + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> + {
> + 0x00, 0x08, 0x77, 0x9E, 0x01, 0x00, 0x00, 0x00 // ..w.....
> + })
> + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> + {
> + CEJ0 (0x77)
> + }
> +
> + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> + {
> + COST (0x77, Arg0, Arg1, Arg2)
> + }
> + }
> + }
> + }
> +
> ...
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> tests/data/acpi/q35/APIC.type4-count | Bin 0 -> 1072 bytes
> tests/data/acpi/q35/DSDT.type4-count | Bin 0 -> 18589 bytes
> tests/data/acpi/q35/FACP.type4-count | Bin 0 -> 244 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
> 4 files changed, 3 deletions(-)
>
> diff --git a/tests/data/acpi/q35/APIC.type4-count b/tests/data/acpi/q35/APIC.type4-count
> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..ab60a6ef065d8ce53ae93d311d3777d2d4afb9f6 100644
> GIT binary patch
> literal 1072
> zcmXxjX)mKu7{>9_YU}A{8~a-OZpzsAwwBgf>(n~-!C>rL5ClOG1VQjwyzxDJ5<E};
> zagzJ~UFYQFB<IC#bGsZ?jSxO>_Ev|p!(#Wi9Ts`1gb+$r6yp8Et0V-fRH#;?j|Meb
> z)ap<tp|2h#1L{p^Fr(2AO#x^QM86>P55|BH3=GAfaQqR0!I2mejiE6Z7K`EDe+elf
> zo_%BjMkQf%GRCA}Y#PR;qa_35voIkW6LT=hipjZ{l834Jm{x%4g_u!{nI)K2irM9u
> zQ-MD#(OQkUHq5i*uNus+#ezC4bYhVUiyN?{2}_%?tOd*6SkZ=+?O4@`)m>=oM!N?c
> zJy_F=wf$H(fc1mu975MHHjH577&eV#^8~g`V(S#Tr?G7Y+h?(34m;<uYXQ3#@%J)%
> zR<LIkd)KjV1N%2|U<(Jg@y`wp?c(qrj_l*;0gfGd$3+@H!ii)2dxDdvICX~8=lJge
> zXD)H}3g@oz{|(OH;=&y+-s92(E<fVR6Rtkv+KZyfr1aMhrK=5cDM3kEt*lu|di{4Y
> Q$QL*>8of!Q`;?#f0%hq@0RR91
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.type4-count b/tests/data/acpi/q35/DSDT.type4-count
> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..edc23198cdb47a981bcbc82bc8e392b815abb554 100644
> GIT binary patch
> literal 18589
> zcmb81No*V0c804+N}`ICL`n1{%eE}fGfB;!$s#FI5@m{%JW)2O!M5a)9%Q$><G@xY
> z{kn}Lc-?y4cnR_XbwdxxE&&2$nHb0>+4U|Byj2$2yloJ?UOnfWdvDb}b*~J>UQquj
> zp7Wh^io+pqT{B%yPyZ%o80PO%m+V}*Cv~-G_rO2XFbvfAH<Ay`8kN`S)M(WV`2uF;
> zO^9i@Nd=?F)2W$J^VdtY?`pMYzo?mWbz}aA$hY%z_0PYo%^T>nGGDhW6p``HYB^P{
> ztmfN_c0LxY=JM%q@<%HetlC`pgVmXQ+K5gxRWFt8z}tI<oxT!ZpKMrLYVWinmBR1(
> z{;;R};&)e`CEuO<&)aYBSpjfJz~3PJ?W^NW?X#M-yS5(rW^LJgh2iYJ_<H9zYwT`*
> zEQ0scYk1`QFh7K-_{P2Hcta*#F0`x<uH7~2?S9j!t#^IH3;1#9KmNNs@M+=eZND$<
> z_&2+-QCn~NcG>c6)auroFKdPY2fEkpT21wi2A|Pl)Zi@KH;lRZ9KW-&I-D*gZPs~9
> zak3b*V{rqzFO}Q(Slz$aW*A{S<@oO(-@kwVuUs0DmquhFdJ<0_p18{EqFtUgL+`>?
> zu<|B?h7HGOdf+DAQ+Zv^jKM?o?_nzdj};nrDwY|8J5rN{k{SAuhoNDoCT9vg#eDi|
> zPsL14*yBd@K+(>O`6~O+djGz@gdX*m=CXl|${{?wVMLE5A!ai#WYzJeCVXqrRCAG?
> z&vfHQolrPyn1r1`xG{}+co<%-%^Pd;VK_JMjaPH#+^e~lrqv`*@cIGI*;fGddHyg2
> zi+MY1M8j41Yu1<0imYBX@%%>Y-?Qgtu{2%m7=QY@BNPZhu8GO<jKQ@DI%{-<@wnv!
> zW7IMHVC0OBmH^ZT4<q*z7Dj<%E5DD$fvaO;B=DK9k41v7urShb^%*P@Tv;TT7zx!d
> zUq6d<D)1W^>A3oNB)GCjFfr1}5@3-|1pyZ6xCVHnQ#_co&jwGQ4J^`eZQzkk@nF(E
> z8$EqCvPj3Z(c34Ow9h6_pG}@Vo4kF3N&5_X`V4yd40`(nllIx{>9g6>XS26YFlnEb
> zr%%h%r{(PvOxkD2(`U%jXUN+pn6%HZr_Zpb&#<>oFlnDHo<3VVeYSY}1e5mJ>glu9
> z(`T!<PcUhpZJs{cJbku#`vjBr8S(TP@$?z-_6a8Kv)$8YyQj}~Z=Yb&K07>pc6j>i
> z@b(EN?X%O<XQ!vnPH&%J(mtb}KBJyKquxHjq<wDj^tr{;=N50DVA4Lfdivbz>2s^M
> zPcUhpFvj?M7JFCP=IL{rw@)x>pW8isZuj)L-P<Raw9g$ZGAZ5(cd*Emc(dEVBW-D7
> zWLo%kc_O<!kzL+MFlppYPvlNd<W6rSm^8B66WQ&F?Dj^2Nh5c8B6oQrcX=bhq>;N>
> zr1KuXn?*YB@w<7X^TrJ(Mmm#Zk0<9IPtHBwoM7^tK^UM(GC)Vmc}UHMsR<eqivbD-
> zq~(Sm3@0fJQ0~W`M5cjJPJJdM<*x1k1=DE_1}OJ+1}JgG0m@z70SYEm;|x&lD=f?j
> zRA*vhq;tk_fPx7XF<%&<+*eqlM;3_#l)E}6?Gpwl$FfKmpu`miD45Pv!~qJX(<cm2
> z?#m)!fD%_6pxl+^!~qJX(<cm2?#m)!fD%_6pxl*3;s6EH=@SMh_hpeVK#403Q0~ei
> zae#v9Jf1K>xi5=^0ZLqPfO1zBi31c&r%xE5+?Ped041(CK)EZ6!~qJX(<cm2?#m)!
> zfD%_6pxl*3;s6EH=@SMh_hpeVK#403Q0~eiae#v9^a%r$`?5$Fpu`miD0gL%I6%R4
> z`h)?>eOV+7P~wUMl)JJ>9H3x2eZm0czAO?3C~?IB%3WC`4p1<iK4E}zUls`il(^ym
> z<*qCe2Pl|MpD;kVFN=f$N?dV(a#t3K0~AcBPZ*%wmqo$=C9XI?xhspr0SczmCk#;T
> z%OYWb5?36c+?7S*00q<O69y>vWsxvIi7O6J?#d!@fP(4t2?Lb-vPc-9#1#i9cV&?{
> zK*4nSgaOKZStJZl;)(;5yRt|epkO+E!T{yIED{DNam4}3U0Ea!P%xc7VSsX976}8C
> zxZ(iit}GG<D40&4FhIc~0~9PeK*6K~6ihNeNhAzV5{UzpMB)G?kuX3>Bn(gzi35~G
> z;s7O)FhEHp3{Vn@1C&JK040$yKuIJFP!fp)ltkhHC6O>d!Ezp57@%OmBgRf94p1=R
> zVQ@^0bj~ddP_UeH3j-7^=iK4|1=BgVI6%RKHIS|<j8J1eyvDw)Zr~Tv?;G(?GTND+
> zg75$9&7WDXmy8XodBX}t`}0$FsTsy@Dc0U<g}!Pun%PpqOXDpbvl`$wU;k{$YBNv)
> zs1&QLPBg)sPdY0x;Wobh5`@&{_N`XuSFJ{~A10Im@4*JVn;I{TXj`>BoisMEgkotb
> z8Evno^JU`|YU?#S(uNBf=wX+by{%d<mCd(Hq6SQl$3^y(lHL4>>?x8x#j>ZMKAJrh
> z-8_4$vRc62`C1IDLW$lj-$$gkNqU>5x0Uqv2h!UjeOhVWf)%j;_qk7#^l6qpt)x$X
> zAbnb-%GACW#o(q~xujFLX{f%F-XKC7m0_=xmbl0M7QXO;BX52VkE^rLF}#*aup
> zO45(A^rK4p(GR2_73p(o`lgRapCjpWEPYN%pZh@i9HbB6+mV_+!qYo%9`MlsUhaHx
> z(t9l0$X@dB2Vd6$r@oA>b}tS-FK9S^Y*U=}y6o`c;6sFl<Ht6|X|J<RFAhFgXgGds
> zQ=Im?iF$GHaYMuLW1Hf%*TEJq4nBiuIDTwXoc6rl>czna6Aj0YZHm*Lr`x<Z__U(o
> z_%SaoQV8<p|4cAf%uG8^KNH^aaM8c=I#--781Tva$3KP)Sh|j&-FZ1PneHi;($${m
> zAe%gOJW{LUp}9|MR;0Eb{(7xutkqyWcEeb2{d#TA_|;t4_^<zM*nr^(BMq0=+pX3w
> z;428i4fwJK3+mD8XpujTElInWkHunxM&zr1@$njS*6b<2v*2DVWy(&u7Q9J7xh-~a
> zrYHC4S^fUXot`JRo<3T6vT*CEQ8De}#JG6Xv{=@t`BV6(uo->{?ZNvxEZYARw!)P+
> zhtWtHJ$5lOY1;Y8vT2tJmrYoDkKs+$H2k(*NW=1e2YUMLa%Q3j+|$YF9$2@|Pv(Pl
> z0}obKzxXHLEW0!S74a%XKk*pW!7r>dL^Idz>FhP%y0x}sd|^Yk%P38h@#Xc<+LGl%
> zo#5J!x{vDs>VB>pP!Dk3h<cFgCe%Y*2T>1m-HdvKYYTOf>k#S`*J0E)*Da{iT(_dm
> zaNUMF%XI{F9LmR<+fj@9J5Y=IJ5h`Jqo_swTTqMox1tvHZ$mBW-;P?;zXP?XzYDdf
> ze<x~De>ZAT|1Q*`{@tiW{d-W0`g=epME!eFi~4&}i~9GW7WMB(E$TmjTGW3KwW$9P
> zYEl1T)S~_)s73upQH%PIp%(QYM=k0<fm+mm61AxR6lzg_40NBUKaN_|pFl0@??Wx>
> z??)}_A3!bYA4DzcA3`naA4V<eA3-hZKaE<{e+IRv|14@z|2fp6{`06s{TEP+`Y(d+
> z7xgDmi~3WjMg2BvQGXh>s6T^R)SpEy>K{cd>d&DT_2*HG`o~a<`o~d=`X^9}`U|K<
> z{gbFg{g+US`ir0kMEz5!Mg1kzqW&^!QU5e*QU45TQU7JsqW&wWMg3P%i~6sj7WH38
> zE$XkJ7WL1f7WLmiE$Y9CTGU@fE$Xj<9u)P@p%(SeqZaiqpceHnq89bvLM`gQjat-y
> z2eqhw3ALzy8MUbYE^1N#J=CK9`=~|z4^WHxAEFlZKSC|)uY(>E^*=@}>VJY-)c+K<
> zsQ(#iQU3~RQU7z)qW%}ChnAzcM!1-pY_9B^Jr$tS2d4^Nja3iB1gPWn={5BZoGW#!
> z4X(m!_e_j$)S`t3oHZYp$W&24*pwd~-D;QZ$>0at2-=gGD;>V~bz`A!F8+||SX(sf
> z#$w&9)s49y3gKU_)y!`ftWTh``huF1b*vtQQMtbDTlFXm%Z1;rH?PfE?;+1`>zm!b
> zzF#|aIF0KIUt*DS#>yO&_5INLfab>LHH_2+%U{>d4BQEED+{<AA`{@-ArLrkEZ`Vk
> zfCQEJ=FMp=sApw<^YdJ2wl9^Z!yh=$n?GGNKAgPz@+Rk|Zu!)s=z3Q@2&Z||>MEZP
> z!_bc5hb{vzw!;%UxPeb^_*ha%PPd1wpaJX2xJnUih5a7WA#BE2TE1KPJQIM>I9tH*
> zgu>#08)}*?G*lHInqnrwm<*FcOad+lV2&190e;JOIX)lbgk6s1gRfFfJ(f?B`rrz?
> zN`g<XF3BHINq$Q5OHx04231M$-P<Jv8dOq%k^+)6fXg#VckngZB{ejvqy|cAkfcGl
> zprDfA!>&te4639?N@|p(A-KSxlHkj&OKM_EQ}C2<9yzOtlA0uG7@i<13APKlq@bnN
> z6r`k}B#p37|K4XoGa)szoj0_mW=d+7q$DneDQDawB&$WO$)Y4nl2W*&rjSB}6lzsT
> zAxa8Kk_}&*R8p9b!V#4erlhbWrQrgGN@^jbmUflYLP;%>lz|HxDyfx_T02xyD<!o`
> zQWh?7s3iDa=ROPCqAID4lG<ESJcg?p${B}s50@0#qLLz%6p^GjE?y`kSn_a5?ORn+
> zJ0-PCQUcd46cVg<xTKElDyf5#IwYwNmn;+#EOfY}&K)YLlae|msUKG>6cVg)xTI*8
> zN{UiaRFVd8p+X_S@`g*=(yfxVP|_Aj8pJgUg#;@bE@|s7m9&+Two1|vE>9>VSk!Py
> z+jgs@ZIrZ4l7``ei%Qx~NZZ*~O8Ty{oszao(g<9DQAs-pX~$l*rX7^DLz0rPqd_Hg
> z5mHyLO6sDdE=fwk1savKlaO}qS4lf5X{RLFaKT0;brVwe0hQEEN!^l^h6^|<X%`{w
> zI;fI%QPM6+%D@F3m9(3Xb{|$ryD4e6BxT_Ok4oA@NPCW`q&<|h$0a3VJvym}ka~`)
> zq#jD@k)-%uowS#b_8wPBdnswJBqe%vQZFI(o={1>l+-IpefxCMK0?}eQYG!9q<xaq
> zzh5WqC#3x`m9(Fd_Dj;h0iAS!kPfg<q4X7efRYYK(%?azbdZn^Ce)e^Qqn<58akwt
> z4iVC!ewB2Hk`77I@L`>Fn2-(+sHDS`bXbx`j_9N#gmh$3B^{xpBa)Ons*{cq($Qg+
> zbd-{gN>b{WPC7<N$3|4rF-kfnN%nD_bexcmpH@l7De1T*rBCRj6NGf)tV%jTNhc&J
> zb5bXrB&3t)RMJUGIw?unQ#$DsA)Pv}l1@?5DVNkIzRr2ROTk8dcXGxqs-zet#Uv>n
> z*K3LsQaq`W;*=DZq(nj|B?u{zQb`F)N=Q;)pHAu{q`tID>Z7DSN$T&{N&SS>pHWHu
> zl+-Ut0|Po~fRF~@S^<2NA>XA2C}}{F1_yQ0AR!IrRMH?N4NB6`kWLyRq@lb@8lt2j
> zNg5v3NyCIRJf@O{DQQ@eMn-hf2qBG3sH71}8j+;rX`OVMkWLp=(rHRMElH^}I_V4{
> zotacgXDI26B-v+m(pf?}TU1GBDe0^vrO)Z4bA)tmN+q46q;ry#Ij@t>6VmyTN;*$T
> z=Orn7K_^`xqzlt3=>jEPa7q2Ki#q8dAzhqNNf#;Uq9nzWItebByYF<#%PJ{JNl8gc
> zq;wKoEq6(&t11aMvAF9`DM{+HbrM`CcS-g&m4y3IT#_wG{b`*9*T`K``npQOttBog
> zElC3zodlOvT~cONCE+d+mz0sD!K_Y#E8{LHdqXARh7XsNm879jodg%fUDD`Hm4tgY
> zT+*l{4d-+cTn~3ixtdDCZ5S>oCrKlDos=h}{G3Y4Q&L`%l4Ck)jF86WRnizGjY(2!
> zTqlha()glE8mFXjNwOz&(gYz*+)_yslr$kp>4HvzjRWo(FWgp11xhMNQf5*oO%l@N
> zl1iGSq)AE2UeZaI2<g(YO1eZzmt4|7tf-TUgjBq%l8Tg6l%)8SPMRX5Dfl0A-p>V7
> zlr$wtiIPq#5mM=aN-9xONs{`?ItjKUxQ|`=p-L)KQdyGvr*#tS7;#C{b(J(tNz;-v
> zFr$-Z2x;cAN}8dh8A%$vtdlMi(&Z;A=`tl<mZYI8I_U}_U3sRGu29kyNgBSYldcld
> z)fJU=m6EPX(#SQPbd8X%Jy%KBDCwFcC9mtG>x6Xu6P0wGlCDcqs-lxBgj9K{k}8x`
> zktBOoC(RPl?58SemXc;ADSbmH-5{hJf1;9ZP|^)a%G}gRHwo$HE0uJUl5R>;wyKk=
> zgjD@gl~kpqs!JM-)pSygkZP}0QjL;ok`$lQNpplW_eLenQPP|wCFXU~JR!}ms-$^J
> znwO-$1)a1&NDF_ak`^dwL6Z6xb<!dsE&jPmTBM{!NgBANlWq~xtuIv4ElRp2NrSg_
> z(rrSz{iRB}O-Z*UY3Pnlx<g2JzEVkdDCv$Q4KL}WB|=(ytCE%|X-SesmUYrHAua!f
> zN?N9*Wl2ij)k${=>F!^uq`Q=KSCUfqbkaRSy7yNq=^iEBlO+4TPP$J>_kXF9?o-lz
> zNlHJ^Ne>9=!PhG30VO?<q|8H|^pKDqexs5eQqn_7%0ALbj|l0}uT;__N_ymyhGKP{
> zR41hRw<@VlNp(qzKh{Z)3F+~7D(NvLJ(i@z6P@&gke>WnB|V{}Cz90nR3|+pq^Eza
> zlAco1Q%UN7rjwo#(zCx&NzW+hnIsLY=%f`wTKQX*v_eTMk~H{SCp{;m=f6=&&nfA-
> zBn`dLNiPWL#owu<7nJk@NYS0JX%;pBS2MAMA-4MB23p*=6e(=sJ8Ic4L9p$^V<GFG
> zzicsl{4)D{OmB{wKZkz~n?X2khS|=LKfv8Thh4h`emKG~{)hdn2fH8tAI<ys{Gz{M
> z_zcevegxq+E&hS^Wf*_&x#u1H638F<J@3xHg*9)UP52tvEB+t`-zwo8HE?eY>~pTH
> z+5zYj7HQ$vR@iTjBw?d7-@}Z@$>wF)o;{tkU;_efm}Z-odm4KhP5AYZ%Ia94m@C4!
> z0v!S;X_Jl6I_q8dUD(_X8?TSdLi%!FwWBd$LhYdYs~y3B<+EU;4p;+t54I6GBOiv!
> z>dEXC8<qpGfT>Jj26h%D&|9fE(hzCD?beaZ&RN_*7b$e%qgYuDm18mZOq5KQpqr!R
> z*f2NX5i<?AvR#g+4ftIX5D7>0p@7b#<*anxgB!W?r753Pv%(QOz>-wnoId5pH0X)<
> zn)v^l;QwMxrSQhan{?2CZR}GS)LFb4#hYBPvf4kMN<%UH$8h|xp9p(`?G5-SY`3<I
> znl+<lnDBI4G#24+ua7;d`wN$5+^9CV%1@$#RzolTXiQ}_F;Sd`Rdvn|!1;o$>#&E4
> z_(rUjQS%f3C;nit_cbFY>`MhVrUAS+kNMgEv)>5zMp(>&(zNYX6M{TgJVV!wx?u);
> k4HL_0D`%79y!#9|m3SZ}4*20fB#f^~_-_Ll_+6a;1CLN!@c;k-
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/FACP.type4-count b/tests/data/acpi/q35/FACP.type4-count
> index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
> GIT binary patch
> literal 244
> zcmZ>BbPo8!z`($~*~#D8BUr&HBEVSz2pEB4AU24G0Y(N+hD|^Y6El!tgNU*~X%LSC
> z$X0-fGcm9T0LA|E|L2FOWMD92VqjR>!otAF!NBm72O<iWged~jj0!*k$y^{03>bk1
> YBHITON2VDSAnpK(F*YFF1LDH~0O^Si0RR91
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 0ce6f8fc72ee..dfb8523c8bf4 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,4 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/q35/APIC.type4-count",
> -"tests/data/acpi/q35/DSDT.type4-count",
> -"tests/data/acpi/q35/FACP.type4-count",
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries for type4 count test
2023-09-15 13:05 ` Igor Mammedov
@ 2023-09-19 7:26 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:26 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
Hi Igor,
On Fri, Sep 15, 2023 at 03:05:10PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 15:05:10 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries
> for type4 count test
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:07 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> copy/past mistake in subj?
>
> shouldn't it be for 'smbios type4 count'?
Thanks! I just thought the subject is too long and omitted the word
"smbios", I'll correct it as:
"tests: bios-tables-test: Add ACPI table binaries for smbios type4 count test"
-Zhao
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > Following the guidelines in tests/qtest/bios-tables-test.c, this
> > is step 5 and 6.
> >
> > Changes in the tables:
> > FACP:
> >
> > +/*
> > + * Intel ACPI Component Architecture
> > + * AML/ASL+ Disassembler version 20200925 (64-bit version)
> > + * Copyright (c) 2000 - 2020 Intel Corporation
> > + *
> > + * Disassembly of /tmp/aml-W37791, Wed Aug 23 10:36:32 2023
> > + *
> > + * ACPI Data Table [FACP]
> > + *
> > + * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> > + */
> > +
> > +[000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
> > +[004h 0004 4] Table Length : 000000F4
> > +[008h 0008 1] Revision : 03
> > +[009h 0009 1] Checksum : B3
> > +[00Ah 0010 6] Oem ID : "BOCHS "
> > +[010h 0016 8] Oem Table ID : "BXPC "
> > +[018h 0024 4] Oem Revision : 00000001
> > +[01Ch 0028 4] Asl Compiler ID : "BXPC"
> > +[020h 0032 4] Asl Compiler Revision : 00000001
> > +
> > +[024h 0036 4] FACS Address : 00000000
> > +[028h 0040 4] DSDT Address : 00000000
> > +[02Ch 0044 1] Model : 01
> > +[02Dh 0045 1] PM Profile : 00 [Unspecified]
> > +[02Eh 0046 2] SCI Interrupt : 0009
> > +[030h 0048 4] SMI Command Port : 000000B2
> > +[034h 0052 1] ACPI Enable Value : 02
> > +[035h 0053 1] ACPI Disable Value : 03
> > +[036h 0054 1] S4BIOS Command : 00
> > +[037h 0055 1] P-State Control : 00
> > +[038h 0056 4] PM1A Event Block Address : 00000600
> > +[03Ch 0060 4] PM1B Event Block Address : 00000000
> > +[040h 0064 4] PM1A Control Block Address : 00000604
> > +[044h 0068 4] PM1B Control Block Address : 00000000
> > +[048h 0072 4] PM2 Control Block Address : 00000000
> > +[04Ch 0076 4] PM Timer Block Address : 00000608
> > +[050h 0080 4] GPE0 Block Address : 00000620
> > +[054h 0084 4] GPE1 Block Address : 00000000
> > +[058h 0088 1] PM1 Event Block Length : 04
> > +[059h 0089 1] PM1 Control Block Length : 02
> > +[05Ah 0090 1] PM2 Control Block Length : 00
> > +[05Bh 0091 1] PM Timer Block Length : 04
> > +[05Ch 0092 1] GPE0 Block Length : 10
> > +[05Dh 0093 1] GPE1 Block Length : 00
> > +[05Eh 0094 1] GPE1 Base Offset : 00
> > +[05Fh 0095 1] _CST Support : 00
> > +[060h 0096 2] C2 Latency : 0FFF
> > +[062h 0098 2] C3 Latency : 0FFF
> > +[064h 0100 2] CPU Cache Size : 0000
> > +[066h 0102 2] Cache Flush Stride : 0000
> > +[068h 0104 1] Duty Cycle Offset : 00
> > +[069h 0105 1] Duty Cycle Width : 00
> > +[06Ah 0106 1] RTC Day Alarm Index : 00
> > +[06Bh 0107 1] RTC Month Alarm Index : 00
> > +[06Ch 0108 1] RTC Century Index : 32
> > +[06Dh 0109 2] Boot Flags (decoded below) : 0002
> > + Legacy Devices Supported (V2) : 0
> > + 8042 Present on ports 60/64 (V2) : 1
> > + VGA Not Present (V4) : 0
> > + MSI Not Supported (V4) : 0
> > + PCIe ASPM Not Supported (V4) : 0
> > + CMOS RTC Not Present (V5) : 0
> > +[06Fh 0111 1] Reserved : 00
> > +[070h 0112 4] Flags (decoded below) : 000484A5
> > + WBINVD instruction is operational (V1) : 1
> > + WBINVD flushes all caches (V1) : 0
> > + All CPUs support C1 (V1) : 1
> > + C2 works on MP system (V1) : 0
> > + Control Method Power Button (V1) : 0
> > + Control Method Sleep Button (V1) : 1
> > + RTC wake not in fixed reg space (V1) : 0
> > + RTC can wake system from S4 (V1) : 1
> > + 32-bit PM Timer (V1) : 0
> > + Docking Supported (V1) : 0
> > + Reset Register Supported (V2) : 1
> > + Sealed Case (V3) : 0
> > + Headless - No Video (V3) : 0
> > + Use native instr after SLP_TYPx (V3) : 0
> > + PCIEXP_WAK Bits Supported (V4) : 0
> > + Use Platform Timer (V4) : 1
> > + RTC_STS valid on S4 wake (V4) : 0
> > + Remote Power-on capable (V4) : 0
> > + Use APIC Cluster Model (V4) : 1
> > + Use APIC Physical Destination Mode (V4) : 0
> > + Hardware Reduced (V5) : 0
> > + Low Power S0 Idle (V5) : 0
> > +
> > +[074h 0116 12] Reset Register : [Generic Address Structure]
> > +[074h 0116 1] Space ID : 01 [SystemIO]
> > +[075h 0117 1] Bit Width : 08
> > +[076h 0118 1] Bit Offset : 00
> > +[077h 0119 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[078h 0120 8] Address : 0000000000000CF9
> > +
> > +[080h 0128 1] Value to cause reset : 0F
> > +[081h 0129 2] ARM Flags (decoded below) : 0000
> > + PSCI Compliant : 0
> > + Must use HVC for PSCI : 0
> > +
> > +[083h 0131 1] FADT Minor Revision : 00
> > +[084h 0132 8] FACS Address : 0000000000000000
> > +[08Ch 0140 8] DSDT Address : 0000000000000000
> > +[094h 0148 12] PM1A Event Block : [Generic Address Structure]
> > +[094h 0148 1] Space ID : 01 [SystemIO]
> > +[095h 0149 1] Bit Width : 20
> > +[096h 0150 1] Bit Offset : 00
> > +[097h 0151 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[098h 0152 8] Address : 0000000000000600
> > +
> > +[0A0h 0160 12] PM1B Event Block : [Generic Address Structure]
> > +[0A0h 0160 1] Space ID : 00 [SystemMemory]
> > +[0A1h 0161 1] Bit Width : 00
> > +[0A2h 0162 1] Bit Offset : 00
> > +[0A3h 0163 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0A4h 0164 8] Address : 0000000000000000
> > +
> > +[0ACh 0172 12] PM1A Control Block : [Generic Address Structure]
> > +[0ACh 0172 1] Space ID : 01 [SystemIO]
> > +[0ADh 0173 1] Bit Width : 10
> > +[0AEh 0174 1] Bit Offset : 00
> > +[0AFh 0175 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0B0h 0176 8] Address : 0000000000000604
> > +
> > +[0B8h 0184 12] PM1B Control Block : [Generic Address Structure]
> > +[0B8h 0184 1] Space ID : 00 [SystemMemory]
> > +[0B9h 0185 1] Bit Width : 00
> > +[0BAh 0186 1] Bit Offset : 00
> > +[0BBh 0187 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0BCh 0188 8] Address : 0000000000000000
> > +
> > +[0C4h 0196 12] PM2 Control Block : [Generic Address Structure]
> > +[0C4h 0196 1] Space ID : 00 [SystemMemory]
> > +[0C5h 0197 1] Bit Width : 00
> > +[0C6h 0198 1] Bit Offset : 00
> > +[0C7h 0199 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0C8h 0200 8] Address : 0000000000000000
> > +
> > +[0D0h 0208 12] PM Timer Block : [Generic Address Structure]
> > +[0D0h 0208 1] Space ID : 01 [SystemIO]
> > +[0D1h 0209 1] Bit Width : 20
> > +[0D2h 0210 1] Bit Offset : 00
> > +[0D3h 0211 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0D4h 0212 8] Address : 0000000000000608
> > +
> > +[0DCh 0220 12] GPE0 Block : [Generic Address Structure]
> > +[0DCh 0220 1] Space ID : 01 [SystemIO]
> > +[0DDh 0221 1] Bit Width : 80
> > +[0DEh 0222 1] Bit Offset : 00
> > +[0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0E0h 0224 8] Address : 0000000000000620
> > +
> > +[0E8h 0232 12] GPE1 Block : [Generic Address Structure]
> > +[0E8h 0232 1] Space ID : 00 [SystemMemory]
> > +[0E9h 0233 1] Bit Width : 00
> > +[0EAh 0234 1] Bit Offset : 00
> > +[0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
> > +[0ECh 0236 8] Address : 0000000000000000
> > +
> > ...
> >
> > APIC:
> >
> > +/*
> > + * Intel ACPI Component Architecture
> > + * AML/ASL+ Disassembler version 20200925 (64-bit version)
> > + * Copyright (c) 2000 - 2020 Intel Corporation
> > + *
> > + * Disassembly of /tmp/aml-687791, Wed Aug 23 10:36:32 2023
> > + *
> > + * ACPI Data Table [APIC]
> > + *
> > + * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
> > + */
> > +
> > +[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
> > +[004h 0004 4] Table Length : 00000430
> > +[008h 0008 1] Revision : 03
> > +[009h 0009 1] Checksum : C5
> > +[00Ah 0010 6] Oem ID : "BOCHS "
> > +[010h 0016 8] Oem Table ID : "BXPC "
> > +[018h 0024 4] Oem Revision : 00000001
> > +[01Ch 0028 4] Asl Compiler ID : "BXPC"
> > +[020h 0032 4] Asl Compiler Revision : 00000001
> > +
> > +[024h 0036 4] Local Apic Address : FEE00000
> > +[028h 0040 4] Flags (decoded below) : 00000001
> > + PC-AT Compatibility : 1
> > +
> > +[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
> > +[02Dh 0045 1] Length : 08
> > +[02Eh 0046 1] Processor ID : 00
> > +[02Fh 0047 1] Local Apic ID : 00
> > +[030h 0048 4] Flags (decoded below) : 00000001
> > + Processor Enabled : 1
> > + Runtime Online Capable : 0
> > +
> > +[034h 0052 1] Subtable Type : 00 [Processor Local APIC]
> > +[035h 0053 1] Length : 08
> > +[036h 0054 1] Processor ID : 01
> > +[037h 0055 1] Local Apic ID : 01
> > +[038h 0056 4] Flags (decoded below) : 00000001
> > + Processor Enabled : 1
> > + Runtime Online Capable : 0
> >
> > [snip]
> >
> > +[3E4h 0996 1] Subtable Type : 00 [Processor Local APIC]
> > +[3E5h 0997 1] Length : 08
> > +[3E6h 0998 1] Processor ID : 77
> > +[3E7h 0999 1] Local Apic ID : 9E
> > +[3E8h 1000 4] Flags (decoded below) : 00000000
> > + Processor Enabled : 0
> > + Runtime Online Capable : 0
> > +
> > +[3ECh 1004 1] Subtable Type : 01 [I/O APIC]
> > +[3EDh 1005 1] Length : 0C
> > +[3EEh 1006 1] I/O Apic ID : 00
> > +[3EFh 1007 1] Reserved : 00
> > +[3F0h 1008 4] Address : FEC00000
> > +[3F4h 1012 4] Interrupt : 00000000
> > +
> > +[3F8h 1016 1] Subtable Type : 02 [Interrupt Source Override]
> > +[3F9h 1017 1] Length : 0A
> > +[3FAh 1018 1] Bus : 00
> > +[3FBh 1019 1] Source : 00
> > +[3FCh 1020 4] Interrupt : 00000002
> > +[400h 1024 2] Flags (decoded below) : 0000
> > + Polarity : 0
> > + Trigger Mode : 0
> > +
> > +[402h 1026 1] Subtable Type : 02 [Interrupt Source Override]
> > +[403h 1027 1] Length : 0A
> > +[404h 1028 1] Bus : 00
> > +[405h 1029 1] Source : 05
> > +[406h 1030 4] Interrupt : 00000005
> > +[40Ah 1034 2] Flags (decoded below) : 000D
> > + Polarity : 1
> > + Trigger Mode : 3
> > +
> > +[40Ch 1036 1] Subtable Type : 02 [Interrupt Source Override]
> > +[40Dh 1037 1] Length : 0A
> > +[40Eh 1038 1] Bus : 00
> > +[40Fh 1039 1] Source : 09
> > +[410h 1040 4] Interrupt : 00000009
> > +[414h 1044 2] Flags (decoded below) : 000D
> > + Polarity : 1
> > + Trigger Mode : 3
> > +
> > +[416h 1046 1] Subtable Type : 02 [Interrupt Source Override]
> > +[417h 1047 1] Length : 0A
> > +[418h 1048 1] Bus : 00
> > +[419h 1049 1] Source : 0A
> > +[41Ah 1050 4] Interrupt : 0000000A
> > +[41Eh 1054 2] Flags (decoded below) : 000D
> > + Polarity : 1
> > + Trigger Mode : 3
> > +
> > +[420h 1056 1] Subtable Type : 02 [Interrupt Source Override]
> > +[421h 1057 1] Length : 0A
> > +[422h 1058 1] Bus : 00
> > +[423h 1059 1] Source : 0B
> > +[424h 1060 4] Interrupt : 0000000B
> > +[428h 1064 2] Flags (decoded below) : 000D
> > + Polarity : 1
> > + Trigger Mode : 3
> > +
> > +[42Ah 1066 1] Subtable Type : 04 [Local APIC NMI]
> > +[42Bh 1067 1] Length : 06
> > +[42Ch 1068 1] Processor ID : FF
> > +[42Dh 1069 2] Flags (decoded below) : 0000
> > + Polarity : 0
> > + Trigger Mode : 0
> > +[42Fh 1071 1] Interrupt Input LINT : 01
> > +
> > ...
> >
> > DSDT:
> >
> > +/*
> > + * Intel ACPI Component Architecture
> > + * AML/ASL+ Disassembler version 20200925 (64-bit version)
> > + * Copyright (c) 2000 - 2020 Intel Corporation
> > + *
> > + * Disassembling to symbolic ASL+ operators
> > + *
> > + * Disassembly of /tmp/aml-8G8791, Wed Aug 23 10:36:32 2023
> > + *
> > + * Original Table Header:
> > + * Signature "DSDT"
> > + * Length 0x0000489D (18589)
> > + * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
> > + * Checksum 0xDB
> > + * OEM ID "BOCHS "
> > + * OEM Table ID "BXPC "
> > + * OEM Revision 0x00000001 (1)
> > + * Compiler ID "BXPC"
> > + * Compiler Version 0x00000001 (1)
> > + */
> > +DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
> > +{
> > + Scope (\)
> > + {
> > + OperationRegion (DBG, SystemIO, 0x0402, One)
> > + Field (DBG, ByteAcc, NoLock, Preserve)
> > + {
> > + DBGB, 8
> > + }
> > +
> > + Method (DBUG, 1, NotSerialized)
> > + {
> > + ToHexString (Arg0, Local0)
> > + ToBuffer (Local0, Local0)
> > + Local1 = (SizeOf (Local0) - One)
> > + Local2 = Zero
> > + While ((Local2 < Local1))
> > + {
> > + DBGB = DerefOf (Local0 [Local2])
> > + Local2++
> > + }
> > +
> > + DBGB = 0x0A
> > + }
> > + }
> > +
> >
> > [snip]
> >
> > +
> > + Processor (C000, 0x00, 0x00000000, 0x00)
> > + {
> > + Method (_STA, 0, Serialized) // _STA: Status
> > + {
> > + Return (CSTA (Zero))
> > + }
> > +
> > + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> > + {
> > + 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00 // ........
> > + })
> > + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> > + {
> > + COST (Zero, Arg0, Arg1, Arg2)
> > + }
> > + }
> > +
> > + Processor (C001, 0x01, 0x00000000, 0x00)
> > + {
> > + Method (_STA, 0, Serialized) // _STA: Status
> > + {
> > + Return (CSTA (One))
> > + }
> > +
> > + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> > + {
> > + 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
> > + })
> > + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> > + {
> > + CEJ0 (One)
> > + }
> > +
> > + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> > + {
> > + COST (One, Arg0, Arg1, Arg2)
> > + }
> > + }
> >
> > [snip]
> >
> > + Processor (C077, 0x77, 0x00000000, 0x00)
> > + {
> > + Method (_STA, 0, Serialized) // _STA: Status
> > + {
> > + Return (CSTA (0x77))
> > + }
> > +
> > + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> > + {
> > + 0x00, 0x08, 0x77, 0x9E, 0x01, 0x00, 0x00, 0x00 // ..w.....
> > + })
> > + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> > + {
> > + CEJ0 (0x77)
> > + }
> > +
> > + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> > + {
> > + COST (0x77, Arg0, Arg1, Arg2)
> > + }
> > + }
> > + }
> > + }
> > +
> > ...
> >
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> > tests/data/acpi/q35/APIC.type4-count | Bin 0 -> 1072 bytes
> > tests/data/acpi/q35/DSDT.type4-count | Bin 0 -> 18589 bytes
> > tests/data/acpi/q35/FACP.type4-count | Bin 0 -> 244 bytes
> > tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
> > 4 files changed, 3 deletions(-)
> >
> > diff --git a/tests/data/acpi/q35/APIC.type4-count b/tests/data/acpi/q35/APIC.type4-count
> > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..ab60a6ef065d8ce53ae93d311d3777d2d4afb9f6 100644
> > GIT binary patch
> > literal 1072
> > zcmXxjX)mKu7{>9_YU}A{8~a-OZpzsAwwBgf>(n~-!C>rL5ClOG1VQjwyzxDJ5<E};
> > zagzJ~UFYQFB<IC#bGsZ?jSxO>_Ev|p!(#Wi9Ts`1gb+$r6yp8Et0V-fRH#;?j|Meb
> > z)ap<tp|2h#1L{p^Fr(2AO#x^QM86>P55|BH3=GAfaQqR0!I2mejiE6Z7K`EDe+elf
> > zo_%BjMkQf%GRCA}Y#PR;qa_35voIkW6LT=hipjZ{l834Jm{x%4g_u!{nI)K2irM9u
> > zQ-MD#(OQkUHq5i*uNus+#ezC4bYhVUiyN?{2}_%?tOd*6SkZ=+?O4@`)m>=oM!N?c
> > zJy_F=wf$H(fc1mu975MHHjH577&eV#^8~g`V(S#Tr?G7Y+h?(34m;<uYXQ3#@%J)%
> > zR<LIkd)KjV1N%2|U<(Jg@y`wp?c(qrj_l*;0gfGd$3+@H!ii)2dxDdvICX~8=lJge
> > zXD)H}3g@oz{|(OH;=&y+-s92(E<fVR6Rtkv+KZyfr1aMhrK=5cDM3kEt*lu|di{4Y
> > Q$QL*>8of!Q`;?#f0%hq@0RR91
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.type4-count b/tests/data/acpi/q35/DSDT.type4-count
> > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..edc23198cdb47a981bcbc82bc8e392b815abb554 100644
> > GIT binary patch
> > literal 18589
> > zcmb81No*V0c804+N}`ICL`n1{%eE}fGfB;!$s#FI5@m{%JW)2O!M5a)9%Q$><G@xY
> > z{kn}Lc-?y4cnR_XbwdxxE&&2$nHb0>+4U|Byj2$2yloJ?UOnfWdvDb}b*~J>UQquj
> > zp7Wh^io+pqT{B%yPyZ%o80PO%m+V}*Cv~-G_rO2XFbvfAH<Ay`8kN`S)M(WV`2uF;
> > zO^9i@Nd=?F)2W$J^VdtY?`pMYzo?mWbz}aA$hY%z_0PYo%^T>nGGDhW6p``HYB^P{
> > ztmfN_c0LxY=JM%q@<%HetlC`pgVmXQ+K5gxRWFt8z}tI<oxT!ZpKMrLYVWinmBR1(
> > z{;;R};&)e`CEuO<&)aYBSpjfJz~3PJ?W^NW?X#M-yS5(rW^LJgh2iYJ_<H9zYwT`*
> > zEQ0scYk1`QFh7K-_{P2Hcta*#F0`x<uH7~2?S9j!t#^IH3;1#9KmNNs@M+=eZND$<
> > z_&2+-QCn~NcG>c6)auroFKdPY2fEkpT21wi2A|Pl)Zi@KH;lRZ9KW-&I-D*gZPs~9
> > zak3b*V{rqzFO}Q(Slz$aW*A{S<@oO(-@kwVuUs0DmquhFdJ<0_p18{EqFtUgL+`>?
> > zu<|B?h7HGOdf+DAQ+Zv^jKM?o?_nzdj};nrDwY|8J5rN{k{SAuhoNDoCT9vg#eDi|
> > zPsL14*yBd@K+(>O`6~O+djGz@gdX*m=CXl|${{?wVMLE5A!ai#WYzJeCVXqrRCAG?
> > z&vfHQolrPyn1r1`xG{}+co<%-%^Pd;VK_JMjaPH#+^e~lrqv`*@cIGI*;fGddHyg2
> > zi+MY1M8j41Yu1<0imYBX@%%>Y-?Qgtu{2%m7=QY@BNPZhu8GO<jKQ@DI%{-<@wnv!
> > zW7IMHVC0OBmH^ZT4<q*z7Dj<%E5DD$fvaO;B=DK9k41v7urShb^%*P@Tv;TT7zx!d
> > zUq6d<D)1W^>A3oNB)GCjFfr1}5@3-|1pyZ6xCVHnQ#_co&jwGQ4J^`eZQzkk@nF(E
> > z8$EqCvPj3Z(c34Ow9h6_pG}@Vo4kF3N&5_X`V4yd40`(nllIx{>9g6>XS26YFlnEb
> > zr%%h%r{(PvOxkD2(`U%jXUN+pn6%HZr_Zpb&#<>oFlnDHo<3VVeYSY}1e5mJ>glu9
> > z(`T!<PcUhpZJs{cJbku#`vjBr8S(TP@$?z-_6a8Kv)$8YyQj}~Z=Yb&K07>pc6j>i
> > z@b(EN?X%O<XQ!vnPH&%J(mtb}KBJyKquxHjq<wDj^tr{;=N50DVA4Lfdivbz>2s^M
> > zPcUhpFvj?M7JFCP=IL{rw@)x>pW8isZuj)L-P<Raw9g$ZGAZ5(cd*Emc(dEVBW-D7
> > zWLo%kc_O<!kzL+MFlppYPvlNd<W6rSm^8B66WQ&F?Dj^2Nh5c8B6oQrcX=bhq>;N>
> > zr1KuXn?*YB@w<7X^TrJ(Mmm#Zk0<9IPtHBwoM7^tK^UM(GC)Vmc}UHMsR<eqivbD-
> > zq~(Sm3@0fJQ0~W`M5cjJPJJdM<*x1k1=DE_1}OJ+1}JgG0m@z70SYEm;|x&lD=f?j
> > zRA*vhq;tk_fPx7XF<%&<+*eqlM;3_#l)E}6?Gpwl$FfKmpu`miD45Pv!~qJX(<cm2
> > z?#m)!fD%_6pxl+^!~qJX(<cm2?#m)!fD%_6pxl*3;s6EH=@SMh_hpeVK#403Q0~ei
> > zae#v9Jf1K>xi5=^0ZLqPfO1zBi31c&r%xE5+?Ped041(CK)EZ6!~qJX(<cm2?#m)!
> > zfD%_6pxl*3;s6EH=@SMh_hpeVK#403Q0~eiae#v9^a%r$`?5$Fpu`miD0gL%I6%R4
> > z`h)?>eOV+7P~wUMl)JJ>9H3x2eZm0czAO?3C~?IB%3WC`4p1<iK4E}zUls`il(^ym
> > z<*qCe2Pl|MpD;kVFN=f$N?dV(a#t3K0~AcBPZ*%wmqo$=C9XI?xhspr0SczmCk#;T
> > z%OYWb5?36c+?7S*00q<O69y>vWsxvIi7O6J?#d!@fP(4t2?Lb-vPc-9#1#i9cV&?{
> > zK*4nSgaOKZStJZl;)(;5yRt|epkO+E!T{yIED{DNam4}3U0Ea!P%xc7VSsX976}8C
> > zxZ(iit}GG<D40&4FhIc~0~9PeK*6K~6ihNeNhAzV5{UzpMB)G?kuX3>Bn(gzi35~G
> > z;s7O)FhEHp3{Vn@1C&JK040$yKuIJFP!fp)ltkhHC6O>d!Ezp57@%OmBgRf94p1=R
> > zVQ@^0bj~ddP_UeH3j-7^=iK4|1=BgVI6%RKHIS|<j8J1eyvDw)Zr~Tv?;G(?GTND+
> > zg75$9&7WDXmy8XodBX}t`}0$FsTsy@Dc0U<g}!Pun%PpqOXDpbvl`$wU;k{$YBNv)
> > zs1&QLPBg)sPdY0x;Wobh5`@&{_N`XuSFJ{~A10Im@4*JVn;I{TXj`>BoisMEgkotb
> > z8Evno^JU`|YU?#S(uNBf=wX+by{%d<mCd(Hq6SQl$3^y(lHL4>>?x8x#j>ZMKAJrh
> > z-8_4$vRc62`C1IDLW$lj-$$gkNqU>5x0Uqv2h!UjeOhVWf)%j;_qk7#^l6qpt)x$X
> > zAbnb-%GACW#o(q~xujFLX{f%F-XKC7m0_=xmbl0M7QXO;BX52VkE^rLF}#*aup
> > zO45(A^rK4p(GR2_73p(o`lgRapCjpWEPYN%pZh@i9HbB6+mV_+!qYo%9`MlsUhaHx
> > z(t9l0$X@dB2Vd6$r@oA>b}tS-FK9S^Y*U=}y6o`c;6sFl<Ht6|X|J<RFAhFgXgGds
> > zQ=Im?iF$GHaYMuLW1Hf%*TEJq4nBiuIDTwXoc6rl>czna6Aj0YZHm*Lr`x<Z__U(o
> > z_%SaoQV8<p|4cAf%uG8^KNH^aaM8c=I#--781Tva$3KP)Sh|j&-FZ1PneHi;($${m
> > zAe%gOJW{LUp}9|MR;0Eb{(7xutkqyWcEeb2{d#TA_|;t4_^<zM*nr^(BMq0=+pX3w
> > z;428i4fwJK3+mD8XpujTElInWkHunxM&zr1@$njS*6b<2v*2DVWy(&u7Q9J7xh-~a
> > zrYHC4S^fUXot`JRo<3T6vT*CEQ8De}#JG6Xv{=@t`BV6(uo->{?ZNvxEZYARw!)P+
> > zhtWtHJ$5lOY1;Y8vT2tJmrYoDkKs+$H2k(*NW=1e2YUMLa%Q3j+|$YF9$2@|Pv(Pl
> > z0}obKzxXHLEW0!S74a%XKk*pW!7r>dL^Idz>FhP%y0x}sd|^Yk%P38h@#Xc<+LGl%
> > zo#5J!x{vDs>VB>pP!Dk3h<cFgCe%Y*2T>1m-HdvKYYTOf>k#S`*J0E)*Da{iT(_dm
> > zaNUMF%XI{F9LmR<+fj@9J5Y=IJ5h`Jqo_swTTqMox1tvHZ$mBW-;P?;zXP?XzYDdf
> > ze<x~De>ZAT|1Q*`{@tiW{d-W0`g=epME!eFi~4&}i~9GW7WMB(E$TmjTGW3KwW$9P
> > zYEl1T)S~_)s73upQH%PIp%(QYM=k0<fm+mm61AxR6lzg_40NBUKaN_|pFl0@??Wx>
> > z??)}_A3!bYA4DzcA3`naA4V<eA3-hZKaE<{e+IRv|14@z|2fp6{`06s{TEP+`Y(d+
> > z7xgDmi~3WjMg2BvQGXh>s6T^R)SpEy>K{cd>d&DT_2*HG`o~a<`o~d=`X^9}`U|K<
> > z{gbFg{g+US`ir0kMEz5!Mg1kzqW&^!QU5e*QU45TQU7JsqW&wWMg3P%i~6sj7WH38
> > zE$XkJ7WL1f7WLmiE$Y9CTGU@fE$Xj<9u)P@p%(SeqZaiqpceHnq89bvLM`gQjat-y
> > z2eqhw3ALzy8MUbYE^1N#J=CK9`=~|z4^WHxAEFlZKSC|)uY(>E^*=@}>VJY-)c+K<
> > zsQ(#iQU3~RQU7z)qW%}ChnAzcM!1-pY_9B^Jr$tS2d4^Nja3iB1gPWn={5BZoGW#!
> > z4X(m!_e_j$)S`t3oHZYp$W&24*pwd~-D;QZ$>0at2-=gGD;>V~bz`A!F8+||SX(sf
> > z#$w&9)s49y3gKU_)y!`ftWTh``huF1b*vtQQMtbDTlFXm%Z1;rH?PfE?;+1`>zm!b
> > zzF#|aIF0KIUt*DS#>yO&_5INLfab>LHH_2+%U{>d4BQEED+{<AA`{@-ArLrkEZ`Vk
> > zfCQEJ=FMp=sApw<^YdJ2wl9^Z!yh=$n?GGNKAgPz@+Rk|Zu!)s=z3Q@2&Z||>MEZP
> > z!_bc5hb{vzw!;%UxPeb^_*ha%PPd1wpaJX2xJnUih5a7WA#BE2TE1KPJQIM>I9tH*
> > zgu>#08)}*?G*lHInqnrwm<*FcOad+lV2&190e;JOIX)lbgk6s1gRfFfJ(f?B`rrz?
> > zN`g<XF3BHINq$Q5OHx04231M$-P<Jv8dOq%k^+)6fXg#VckngZB{ejvqy|cAkfcGl
> > zprDfA!>&te4639?N@|p(A-KSxlHkj&OKM_EQ}C2<9yzOtlA0uG7@i<13APKlq@bnN
> > z6r`k}B#p37|K4XoGa)szoj0_mW=d+7q$DneDQDawB&$WO$)Y4nl2W*&rjSB}6lzsT
> > zAxa8Kk_}&*R8p9b!V#4erlhbWrQrgGN@^jbmUflYLP;%>lz|HxDyfx_T02xyD<!o`
> > zQWh?7s3iDa=ROPCqAID4lG<ESJcg?p${B}s50@0#qLLz%6p^GjE?y`kSn_a5?ORn+
> > zJ0-PCQUcd46cVg<xTKElDyf5#IwYwNmn;+#EOfY}&K)YLlae|msUKG>6cVg)xTI*8
> > zN{UiaRFVd8p+X_S@`g*=(yfxVP|_Aj8pJgUg#;@bE@|s7m9&+Two1|vE>9>VSk!Py
> > z+jgs@ZIrZ4l7``ei%Qx~NZZ*~O8Ty{oszao(g<9DQAs-pX~$l*rX7^DLz0rPqd_Hg
> > z5mHyLO6sDdE=fwk1savKlaO}qS4lf5X{RLFaKT0;brVwe0hQEEN!^l^h6^|<X%`{w
> > zI;fI%QPM6+%D@F3m9(3Xb{|$ryD4e6BxT_Ok4oA@NPCW`q&<|h$0a3VJvym}ka~`)
> > zq#jD@k)-%uowS#b_8wPBdnswJBqe%vQZFI(o={1>l+-IpefxCMK0?}eQYG!9q<xaq
> > zzh5WqC#3x`m9(Fd_Dj;h0iAS!kPfg<q4X7efRYYK(%?azbdZn^Ce)e^Qqn<58akwt
> > z4iVC!ewB2Hk`77I@L`>Fn2-(+sHDS`bXbx`j_9N#gmh$3B^{xpBa)Ons*{cq($Qg+
> > zbd-{gN>b{WPC7<N$3|4rF-kfnN%nD_bexcmpH@l7De1T*rBCRj6NGf)tV%jTNhc&J
> > zb5bXrB&3t)RMJUGIw?unQ#$DsA)Pv}l1@?5DVNkIzRr2ROTk8dcXGxqs-zet#Uv>n
> > z*K3LsQaq`W;*=DZq(nj|B?u{zQb`F)N=Q;)pHAu{q`tID>Z7DSN$T&{N&SS>pHWHu
> > zl+-Ut0|Po~fRF~@S^<2NA>XA2C}}{F1_yQ0AR!IrRMH?N4NB6`kWLyRq@lb@8lt2j
> > zNg5v3NyCIRJf@O{DQQ@eMn-hf2qBG3sH71}8j+;rX`OVMkWLp=(rHRMElH^}I_V4{
> > zotacgXDI26B-v+m(pf?}TU1GBDe0^vrO)Z4bA)tmN+q46q;ry#Ij@t>6VmyTN;*$T
> > z=Orn7K_^`xqzlt3=>jEPa7q2Ki#q8dAzhqNNf#;Uq9nzWItebByYF<#%PJ{JNl8gc
> > zq;wKoEq6(&t11aMvAF9`DM{+HbrM`CcS-g&m4y3IT#_wG{b`*9*T`K``npQOttBog
> > zElC3zodlOvT~cONCE+d+mz0sD!K_Y#E8{LHdqXARh7XsNm879jodg%fUDD`Hm4tgY
> > zT+*l{4d-+cTn~3ixtdDCZ5S>oCrKlDos=h}{G3Y4Q&L`%l4Ck)jF86WRnizGjY(2!
> > zTqlha()glE8mFXjNwOz&(gYz*+)_yslr$kp>4HvzjRWo(FWgp11xhMNQf5*oO%l@N
> > zl1iGSq)AE2UeZaI2<g(YO1eZzmt4|7tf-TUgjBq%l8Tg6l%)8SPMRX5Dfl0A-p>V7
> > zlr$wtiIPq#5mM=aN-9xONs{`?ItjKUxQ|`=p-L)KQdyGvr*#tS7;#C{b(J(tNz;-v
> > zFr$-Z2x;cAN}8dh8A%$vtdlMi(&Z;A=`tl<mZYI8I_U}_U3sRGu29kyNgBSYldcld
> > z)fJU=m6EPX(#SQPbd8X%Jy%KBDCwFcC9mtG>x6Xu6P0wGlCDcqs-lxBgj9K{k}8x`
> > zktBOoC(RPl?58SemXc;ADSbmH-5{hJf1;9ZP|^)a%G}gRHwo$HE0uJUl5R>;wyKk=
> > zgjD@gl~kpqs!JM-)pSygkZP}0QjL;ok`$lQNpplW_eLenQPP|wCFXU~JR!}ms-$^J
> > znwO-$1)a1&NDF_ak`^dwL6Z6xb<!dsE&jPmTBM{!NgBANlWq~xtuIv4ElRp2NrSg_
> > z(rrSz{iRB}O-Z*UY3Pnlx<g2JzEVkdDCv$Q4KL}WB|=(ytCE%|X-SesmUYrHAua!f
> > zN?N9*Wl2ij)k${=>F!^uq`Q=KSCUfqbkaRSy7yNq=^iEBlO+4TPP$J>_kXF9?o-lz
> > zNlHJ^Ne>9=!PhG30VO?<q|8H|^pKDqexs5eQqn_7%0ALbj|l0}uT;__N_ymyhGKP{
> > zR41hRw<@VlNp(qzKh{Z)3F+~7D(NvLJ(i@z6P@&gke>WnB|V{}Cz90nR3|+pq^Eza
> > zlAco1Q%UN7rjwo#(zCx&NzW+hnIsLY=%f`wTKQX*v_eTMk~H{SCp{;m=f6=&&nfA-
> > zBn`dLNiPWL#owu<7nJk@NYS0JX%;pBS2MAMA-4MB23p*=6e(=sJ8Ic4L9p$^V<GFG
> > zzicsl{4)D{OmB{wKZkz~n?X2khS|=LKfv8Thh4h`emKG~{)hdn2fH8tAI<ys{Gz{M
> > z_zcevegxq+E&hS^Wf*_&x#u1H638F<J@3xHg*9)UP52tvEB+t`-zwo8HE?eY>~pTH
> > z+5zYj7HQ$vR@iTjBw?d7-@}Z@$>wF)o;{tkU;_efm}Z-odm4KhP5AYZ%Ia94m@C4!
> > z0v!S;X_Jl6I_q8dUD(_X8?TSdLi%!FwWBd$LhYdYs~y3B<+EU;4p;+t54I6GBOiv!
> > z>dEXC8<qpGfT>Jj26h%D&|9fE(hzCD?beaZ&RN_*7b$e%qgYuDm18mZOq5KQpqr!R
> > z*f2NX5i<?AvR#g+4ftIX5D7>0p@7b#<*anxgB!W?r753Pv%(QOz>-wnoId5pH0X)<
> > zn)v^l;QwMxrSQhan{?2CZR}GS)LFb4#hYBPvf4kMN<%UH$8h|xp9p(`?G5-SY`3<I
> > znl+<lnDBI4G#24+ua7;d`wN$5+^9CV%1@$#RzolTXiQ}_F;Sd`Rdvn|!1;o$>#&E4
> > z_(rUjQS%f3C;nit_cbFY>`MhVrUAS+kNMgEv)>5zMp(>&(zNYX6M{TgJVV!wx?u);
> > k4HL_0D`%79y!#9|m3SZ}4*20fB#f^~_-_Ll_+6a;1CLN!@c;k-
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/FACP.type4-count b/tests/data/acpi/q35/FACP.type4-count
> > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
> > GIT binary patch
> > literal 244
> > zcmZ>BbPo8!z`($~*~#D8BUr&HBEVSz2pEB4AU24G0Y(N+hD|^Y6El!tgNU*~X%LSC
> > z$X0-fGcm9T0LA|E|L2FOWMD92VqjR>!otAF!NBm72O<iWged~jj0!*k$y^{03>bk1
> > YBHITON2VDSAnpK(F*YFF1LDH~0O^Si0RR91
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 0ce6f8fc72ee..dfb8523c8bf4 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,4 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/q35/APIC.type4-count",
> > -"tests/data/acpi/q35/DSDT.type4-count",
> > -"tests/data/acpi/q35/FACP.type4-count",
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 05/16] tests: bios-tables-test: Prepare the ACPI table change for type4 core count test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (3 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 04/16] tests: bios-tables-test: Add ACPI table binaries for type4 count test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 06/16] tests: bios-tables-test: Add test for smbios type4 core count Zhao Liu
` (11 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 1 - 3.
List the ACPI tables that will be added to test the type 4 core count
field.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.core-count | 0
tests/data/acpi/q35/DSDT.core-count | 0
tests/data/acpi/q35/FACP.core-count | 0
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
4 files changed, 3 insertions(+)
create mode 100644 tests/data/acpi/q35/APIC.core-count
create mode 100644 tests/data/acpi/q35/DSDT.core-count
create mode 100644 tests/data/acpi/q35/FACP.core-count
diff --git a/tests/data/acpi/q35/APIC.core-count b/tests/data/acpi/q35/APIC.core-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/DSDT.core-count b/tests/data/acpi/q35/DSDT.core-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/FACP.core-count b/tests/data/acpi/q35/FACP.core-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..b9bc1961309a 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/APIC.core-count",
+"tests/data/acpi/q35/DSDT.core-count",
+"tests/data/acpi/q35/FACP.core-count",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 06/16] tests: bios-tables-test: Add test for smbios type4 core count
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (4 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 05/16] tests: bios-tables-test: Prepare the ACPI table change for type4 core " Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 13:03 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 07/16] tests: bios-tables-test: Add ACPI table binaries for type4 core count test Zhao Liu
` (10 subsequent siblings)
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
This tests the commit 196ea60a734c3 ("hw/smbios: Fix core count in
type4").
Test the core count field of type4 table for multiple sockets/dies case.
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 8679255449cf..a35c753a3a00 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -999,6 +999,23 @@ static void test_acpi_q35_tcg_type4_count(void)
free_test_data(&data);
}
+static void test_acpi_q35_tcg_core_count(void)
+{
+ test_data data = {
+ .machine = MACHINE_Q35,
+ .variant = ".core-count",
+ .required_struct_types = base_required_struct_types,
+ .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
+ .smbios_core_count = 9,
+ .smbios_core_count2 = 9,
+ };
+
+ test_acpi_one("-machine smbios-entry-point-type=64 "
+ "-smp 54,sockets=2,dies=3,cores=3,threads=3",
+ &data);
+ free_test_data(&data);
+}
+
static void test_acpi_q35_tcg_core_count2(void)
{
test_data data = {
@@ -2166,6 +2183,8 @@ int main(int argc, char *argv[])
qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
qtest_add_func("acpi/q35/type4-count",
test_acpi_q35_tcg_type4_count);
+ qtest_add_func("acpi/q35/core-count",
+ test_acpi_q35_tcg_core_count);
qtest_add_func("acpi/q35/core-count2",
test_acpi_q35_tcg_core_count2);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 06/16] tests: bios-tables-test: Add test for smbios type4 core count
2023-08-25 3:36 ` [PATCH 06/16] tests: bios-tables-test: Add test for smbios type4 core count Zhao Liu
@ 2023-09-15 13:03 ` Igor Mammedov
2023-09-19 7:21 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 13:03 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:09 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> This tests the commit 196ea60a734c3 ("hw/smbios: Fix core count in
> type4").
>
> Test the core count field of type4 table for multiple sockets/dies case.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> tests/qtest/bios-tables-test.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 8679255449cf..a35c753a3a00 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -999,6 +999,23 @@ static void test_acpi_q35_tcg_type4_count(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_q35_tcg_core_count(void)
> +{
> + test_data data = {
> + .machine = MACHINE_Q35,
> + .variant = ".core-count",
> + .required_struct_types = base_required_struct_types,
> + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> + .smbios_core_count = 9,
> + .smbios_core_count2 = 9,
> + };
> +
> + test_acpi_one("-machine smbios-entry-point-type=64 "
> + "-smp 54,sockets=2,dies=3,cores=3,threads=3",
ditto as for 3/16
It's not obvious why this topology is used and how it correlates to smbios_core_*
so describe setup in commit message
> + &data);
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg_core_count2(void)
> {
> test_data data = {
> @@ -2166,6 +2183,8 @@ int main(int argc, char *argv[])
> qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
> qtest_add_func("acpi/q35/type4-count",
> test_acpi_q35_tcg_type4_count);
> + qtest_add_func("acpi/q35/core-count",
> + test_acpi_q35_tcg_core_count);
> qtest_add_func("acpi/q35/core-count2",
> test_acpi_q35_tcg_core_count2);
> }
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 06/16] tests: bios-tables-test: Add test for smbios type4 core count
2023-09-15 13:03 ` Igor Mammedov
@ 2023-09-19 7:21 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:21 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, Sep 15, 2023 at 03:03:07PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 15:03:07 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 06/16] tests: bios-tables-test: Add test for smbios
> type4 core count
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:09 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > This tests the commit 196ea60a734c3 ("hw/smbios: Fix core count in
> > type4").
> >
> > Test the core count field of type4 table for multiple sockets/dies case.
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> > tests/qtest/bios-tables-test.c | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index 8679255449cf..a35c753a3a00 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -999,6 +999,23 @@ static void test_acpi_q35_tcg_type4_count(void)
> > free_test_data(&data);
> > }
> >
> > +static void test_acpi_q35_tcg_core_count(void)
> > +{
> > + test_data data = {
> > + .machine = MACHINE_Q35,
> > + .variant = ".core-count",
> > + .required_struct_types = base_required_struct_types,
> > + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > + .smbios_core_count = 9,
> > + .smbios_core_count2 = 9,
> > + };
> > +
> > + test_acpi_one("-machine smbios-entry-point-type=64 "
> > + "-smp 54,sockets=2,dies=3,cores=3,threads=3",
>
> ditto as for 3/16
> It's not obvious why this topology is used and how it correlates to smbios_core_*
> so describe setup in commit message
Ok. I'll.
Thanks,
Zhao
>
> > + &data);
> > + free_test_data(&data);
> > +}
> > +
> > static void test_acpi_q35_tcg_core_count2(void)
> > {
> > test_data data = {
> > @@ -2166,6 +2183,8 @@ int main(int argc, char *argv[])
> > qtest_add_func("acpi/q35/kvm/dmar", test_acpi_q35_kvm_dmar);
> > qtest_add_func("acpi/q35/type4-count",
> > test_acpi_q35_tcg_type4_count);
> > + qtest_add_func("acpi/q35/core-count",
> > + test_acpi_q35_tcg_core_count);
> > qtest_add_func("acpi/q35/core-count2",
> > test_acpi_q35_tcg_core_count2);
> > }
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 07/16] tests: bios-tables-test: Add ACPI table binaries for type4 core count test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (5 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 06/16] tests: bios-tables-test: Add test for smbios type4 core count Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 08/16] tests: bios-tables-test: Prepare the ACPI table change for type4 core count2 test Zhao Liu
` (9 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 5 and 6.
Changes in the tables:
FACP:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-Y6WW91, Wed Aug 23 15:43:43 2023
+ *
+ * ACPI Data Table [FACP]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
+[004h 0004 4] Table Length : 000000F4
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : B3
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] FACS Address : 00000000
+[028h 0040 4] DSDT Address : 00000000
+[02Ch 0044 1] Model : 01
+[02Dh 0045 1] PM Profile : 00 [Unspecified]
+[02Eh 0046 2] SCI Interrupt : 0009
+[030h 0048 4] SMI Command Port : 000000B2
+[034h 0052 1] ACPI Enable Value : 02
+[035h 0053 1] ACPI Disable Value : 03
+[036h 0054 1] S4BIOS Command : 00
+[037h 0055 1] P-State Control : 00
+[038h 0056 4] PM1A Event Block Address : 00000600
+[03Ch 0060 4] PM1B Event Block Address : 00000000
+[040h 0064 4] PM1A Control Block Address : 00000604
+[044h 0068 4] PM1B Control Block Address : 00000000
+[048h 0072 4] PM2 Control Block Address : 00000000
+[04Ch 0076 4] PM Timer Block Address : 00000608
+[050h 0080 4] GPE0 Block Address : 00000620
+[054h 0084 4] GPE1 Block Address : 00000000
+[058h 0088 1] PM1 Event Block Length : 04
+[059h 0089 1] PM1 Control Block Length : 02
+[05Ah 0090 1] PM2 Control Block Length : 00
+[05Bh 0091 1] PM Timer Block Length : 04
+[05Ch 0092 1] GPE0 Block Length : 10
+[05Dh 0093 1] GPE1 Block Length : 00
+[05Eh 0094 1] GPE1 Base Offset : 00
+[05Fh 0095 1] _CST Support : 00
+[060h 0096 2] C2 Latency : 0FFF
+[062h 0098 2] C3 Latency : 0FFF
+[064h 0100 2] CPU Cache Size : 0000
+[066h 0102 2] Cache Flush Stride : 0000
+[068h 0104 1] Duty Cycle Offset : 00
+[069h 0105 1] Duty Cycle Width : 00
+[06Ah 0106 1] RTC Day Alarm Index : 00
+[06Bh 0107 1] RTC Month Alarm Index : 00
+[06Ch 0108 1] RTC Century Index : 32
+[06Dh 0109 2] Boot Flags (decoded below) : 0002
+ Legacy Devices Supported (V2) : 0
+ 8042 Present on ports 60/64 (V2) : 1
+ VGA Not Present (V4) : 0
+ MSI Not Supported (V4) : 0
+ PCIe ASPM Not Supported (V4) : 0
+ CMOS RTC Not Present (V5) : 0
+[06Fh 0111 1] Reserved : 00
+[070h 0112 4] Flags (decoded below) : 000484A5
+ WBINVD instruction is operational (V1) : 1
+ WBINVD flushes all caches (V1) : 0
+ All CPUs support C1 (V1) : 1
+ C2 works on MP system (V1) : 0
+ Control Method Power Button (V1) : 0
+ Control Method Sleep Button (V1) : 1
+ RTC wake not in fixed reg space (V1) : 0
+ RTC can wake system from S4 (V1) : 1
+ 32-bit PM Timer (V1) : 0
+ Docking Supported (V1) : 0
+ Reset Register Supported (V2) : 1
+ Sealed Case (V3) : 0
+ Headless - No Video (V3) : 0
+ Use native instr after SLP_TYPx (V3) : 0
+ PCIEXP_WAK Bits Supported (V4) : 0
+ Use Platform Timer (V4) : 1
+ RTC_STS valid on S4 wake (V4) : 0
+ Remote Power-on capable (V4) : 0
+ Use APIC Cluster Model (V4) : 1
+ Use APIC Physical Destination Mode (V4) : 0
+ Hardware Reduced (V5) : 0
+ Low Power S0 Idle (V5) : 0
+
+[074h 0116 12] Reset Register : [Generic Address Structure]
+[074h 0116 1] Space ID : 01 [SystemIO]
+[075h 0117 1] Bit Width : 08
+[076h 0118 1] Bit Offset : 00
+[077h 0119 1] Encoded Access Width : 00 [Undefined/Legacy]
+[078h 0120 8] Address : 0000000000000CF9
+
+[080h 0128 1] Value to cause reset : 0F
+[081h 0129 2] ARM Flags (decoded below) : 0000
+ PSCI Compliant : 0
+ Must use HVC for PSCI : 0
+
+[083h 0131 1] FADT Minor Revision : 00
+[084h 0132 8] FACS Address : 0000000000000000
+[08Ch 0140 8] DSDT Address : 0000000000000000
+[094h 0148 12] PM1A Event Block : [Generic Address Structure]
+[094h 0148 1] Space ID : 01 [SystemIO]
+[095h 0149 1] Bit Width : 20
+[096h 0150 1] Bit Offset : 00
+[097h 0151 1] Encoded Access Width : 00 [Undefined/Legacy]
+[098h 0152 8] Address : 0000000000000600
+
+[0A0h 0160 12] PM1B Event Block : [Generic Address Structure]
+[0A0h 0160 1] Space ID : 00 [SystemMemory]
+[0A1h 0161 1] Bit Width : 00
+[0A2h 0162 1] Bit Offset : 00
+[0A3h 0163 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0A4h 0164 8] Address : 0000000000000000
+
+[0ACh 0172 12] PM1A Control Block : [Generic Address Structure]
+[0ACh 0172 1] Space ID : 01 [SystemIO]
+[0ADh 0173 1] Bit Width : 10
+[0AEh 0174 1] Bit Offset : 00
+[0AFh 0175 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0B0h 0176 8] Address : 0000000000000604
+
+[0B8h 0184 12] PM1B Control Block : [Generic Address Structure]
+[0B8h 0184 1] Space ID : 00 [SystemMemory]
+[0B9h 0185 1] Bit Width : 00
+[0BAh 0186 1] Bit Offset : 00
+[0BBh 0187 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0BCh 0188 8] Address : 0000000000000000
+
+[0C4h 0196 12] PM2 Control Block : [Generic Address Structure]
+[0C4h 0196 1] Space ID : 00 [SystemMemory]
+[0C5h 0197 1] Bit Width : 00
+[0C6h 0198 1] Bit Offset : 00
+[0C7h 0199 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0C8h 0200 8] Address : 0000000000000000
+
+[0D0h 0208 12] PM Timer Block : [Generic Address Structure]
+[0D0h 0208 1] Space ID : 01 [SystemIO]
+[0D1h 0209 1] Bit Width : 20
+[0D2h 0210 1] Bit Offset : 00
+[0D3h 0211 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0D4h 0212 8] Address : 0000000000000608
+
+[0DCh 0220 12] GPE0 Block : [Generic Address Structure]
+[0DCh 0220 1] Space ID : 01 [SystemIO]
+[0DDh 0221 1] Bit Width : 80
+[0DEh 0222 1] Bit Offset : 00
+[0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0E0h 0224 8] Address : 0000000000000620
+
+[0E8h 0232 12] GPE1 Block : [Generic Address Structure]
+[0E8h 0232 1] Space ID : 00 [SystemMemory]
+[0E9h 0233 1] Bit Width : 00
+[0EAh 0234 1] Bit Offset : 00
+[0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0ECh 0236 8] Address : 0000000000000000
...
APIC:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-FFXW91, Wed Aug 23 15:43:43 2023
+ *
+ * ACPI Data Table [APIC]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
+[004h 0004 4] Table Length : 00000220
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : 3C
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] Local Apic Address : FEE00000
+[028h 0040 4] Flags (decoded below) : 00000001
+ PC-AT Compatibility : 1
+
+[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
+[02Dh 0045 1] Length : 08
+[02Eh 0046 1] Processor ID : 00
+[02Fh 0047 1] Local Apic ID : 00
+[030h 0048 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
[snip]
+[1D4h 0468 1] Subtable Type : 00 [Processor Local APIC]
+[1D5h 0469 1] Length : 08
+[1D6h 0470 1] Processor ID : 35
+[1D7h 0471 1] Local Apic ID : 6A
+[1D8h 0472 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
+
+[1DCh 0476 1] Subtable Type : 01 [I/O APIC]
+[1DDh 0477 1] Length : 0C
+[1DEh 0478 1] I/O Apic ID : 00
+[1DFh 0479 1] Reserved : 00
+[1E0h 0480 4] Address : FEC00000
+[1E4h 0484 4] Interrupt : 00000000
+
+[1E8h 0488 1] Subtable Type : 02 [Interrupt Source Override]
+[1E9h 0489 1] Length : 0A
+[1EAh 0490 1] Bus : 00
+[1EBh 0491 1] Source : 00
+[1ECh 0492 4] Interrupt : 00000002
+[1F0h 0496 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+
+[1F2h 0498 1] Subtable Type : 02 [Interrupt Source Override]
+[1F3h 0499 1] Length : 0A
+[1F4h 0500 1] Bus : 00
+[1F5h 0501 1] Source : 05
+[1F6h 0502 4] Interrupt : 00000005
+[1FAh 0506 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[1FCh 0508 1] Subtable Type : 02 [Interrupt Source Override]
+[1FDh 0509 1] Length : 0A
+[1FEh 0510 1] Bus : 00
+[1FFh 0511 1] Source : 09
+[200h 0512 4] Interrupt : 00000009
+[204h 0516 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[206h 0518 1] Subtable Type : 02 [Interrupt Source Override]
+[207h 0519 1] Length : 0A
+[208h 0520 1] Bus : 00
+[209h 0521 1] Source : 0A
+[20Ah 0522 4] Interrupt : 0000000A
+[20Eh 0526 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[210h 0528 1] Subtable Type : 02 [Interrupt Source Override]
+[211h 0529 1] Length : 0A
+[212h 0530 1] Bus : 00
+[213h 0531 1] Source : 0B
+[214h 0532 4] Interrupt : 0000000B
+[218h 0536 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[21Ah 0538 1] Subtable Type : 04 [Local APIC NMI]
+[21Bh 0539 1] Length : 06
+[21Ch 0540 1] Processor ID : FF
+[21Dh 0541 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+[21Fh 0543 1] Interrupt Input LINT : 01
...
DSDT:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembling to symbolic ASL+ operators
+ *
+ * Disassembly of /tmp/aml-9ZXW91, Wed Aug 23 15:43:43 2023
+ *
+ * Original Table Header:
+ * Signature "DSDT"
+ * Length 0x00003271 (12913)
+ * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
+ * Checksum 0xAF
+ * OEM ID "BOCHS "
+ * OEM Table ID "BXPC "
+ * OEM Revision 0x00000001 (1)
+ * Compiler ID "BXPC"
+ * Compiler Version 0x00000001 (1)
+ */
+DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
+{
+ Scope (\)
+ {
+ OperationRegion (DBG, SystemIO, 0x0402, One)
+ Field (DBG, ByteAcc, NoLock, Preserve)
+ {
+ DBGB, 8
+ }
+
+ Method (DBUG, 1, NotSerialized)
+ {
+ ToHexString (Arg0, Local0)
+ ToBuffer (Local0, Local0)
+ Local1 = (SizeOf (Local0) - One)
+ Local2 = Zero
+ While ((Local2 < Local1))
+ {
+ DBGB = DerefOf (Local0 [Local2])
+ Local2++
+ }
+
+ DBGB = 0x0A
+ }
+ }
[snip]
+ Device (\_SB.CPUS)
+ {
+ Name (_HID, "ACPI0010" /* Processor Container Device */) // _HID: Hardware ID
+ Name (_CID, EisaId ("PNP0A05") /* Generic Container Device */) // _CID: Compatible ID
+ Method (CTFY, 2, NotSerialized)
+ {
+ If ((Arg0 == Zero))
+ {
+ Notify (C000, Arg1)
+ }
+
+ If ((Arg0 == One))
+ {
+ Notify (C001, Arg1)
+ }
[snip]
+ If ((Arg0 == 0x35))
+ {
+ Notify (C035, Arg1)
+ }
+ }
[snip]
+ Processor (C000, 0x00, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (Zero))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (Zero, Arg0, Arg1, Arg2)
+ }
+ }
+
+ Processor (C001, 0x01, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (One))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (One)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (One, Arg0, Arg1, Arg2)
+ }
+ }
[snip]
+ Processor (C035, 0x35, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (0x35))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x35, 0x6A, 0x01, 0x00, 0x00, 0x00 // ..5j....
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (0x35)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (0x35, Arg0, Arg1, Arg2)
+ }
+ }
...
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.core-count | Bin 0 -> 544 bytes
tests/data/acpi/q35/DSDT.core-count | Bin 0 -> 12913 bytes
tests/data/acpi/q35/FACP.core-count | Bin 0 -> 244 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
4 files changed, 3 deletions(-)
diff --git a/tests/data/acpi/q35/APIC.core-count b/tests/data/acpi/q35/APIC.core-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..d9d7ca9a896159791f6e74842d02786dc2608cb3 100644
GIT binary patch
literal 544
zcmXxh*-pYh7(n5_rLA2+0RaKGf`EYgcISn(YQP%{E<vx<s8OHNNAXF}nVvYw%y*`l
zOq$Ff8O5O~k~xj8<KayhO_MlO!w?bOT9Kbwsw;wqfu@NW3oRRM2OSsZJam2Z^5_>Z
zC}OsRxiZdIaG{F%8W!qUO#f5d#RmIQ6U!~Ev~j6})h^b0SnuQV8LkX)HNv%XT))8Z
z5*tHoj&S1&TM4$u*qPwwEq3p)caQxkZav`kBknxm?lbPa;QlKfyy4+H9(~~PC!Tz1
jjjVpV@0ngrUrimlY+ISr<$3?*s{?!sg0w8>S6%T3A7&l_
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.core-count b/tests/data/acpi/q35/DSDT.core-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..a24b04cbdbf09383b933a42a2a15182545543a87 100644
GIT binary patch
literal 12913
zcmb80O>A4)b;s}HheSP+5=BwpvPH|1Eq{unB-_)XMaV}|k}b+KDbGww1EeHRDtQ8g
z&5VIK0|T}ONG1jfbVi+^OU*z5x=UBx)<8GyZgw4@t1i09HVEQXl>fQ+J-&1AlY!U^
z>YT@Oe&?J=^8I=5qsz_m_CFMauzp**@2oeor4Q>)7XK_E1ljaAwGnwFS})3_wYC)x
zMXc7#xU}(5ie;{sOAptqf7$Q+y3_gemmO=TD|Ww4eZ9NW{rrp0uArc&yItERBXw`2
z-7K|RhZ{q6XCoJDuWytS#qaD`tnDZ(9BV(^D2vQyfBSyZiM;w)IOPxW$6L{({oxTi
z)vEpP@*ihse(>uLJ}tifoB#RItB>sn0t)yW!{6mDJ#;?n*ylUPsjrR>tml+2pUWSQ
ze03zBR>xBGOt(WvzDcM<gvy_MoVgdRl$*8W@vWmLqB|V6MCW+wE7ibvxBvV9o2x&s
zeL4QS+T?#awUf?q|JMh0=%mxNUw+XM0taS}p4k1}bTlNAqJy*WV<C3BJL<{S;hl1$
z=*Y>F^{sl&$>jy6Z#0Kz?U`SW3z48xPXGSx^z`&UlqpirL~1j0lTIF;xYmoh)7-Y=
zuM>8x^)f|{gX0ggcqnIEFPfFRc&Yv?VMp*<k>iwdmAiPNv{h?Z@$Xa`IZkQoVJ%zV
zD1Vr3S*1<qp2#fJoyy%%>mqrlr`>&u=svR!1Tk8d>F|ljTq`2ytSDl2>7nDsb~2@b
zx;&rdzIQsIIBQfyo<KZUVizyN^P^pHw41=WITg=$texjO&n&y&Kf%Wf+SxY%-CgxE
z#OfPPRb&!v{I$CK<fRVZx9I$)oZrd!X1%dpPv86GMLHgdqt@ouy^2t_1-mNJ2|8|v
z;H-I07|yy#CnM+&FQbZcJ<3Ahpn6W`A=Gmz6MPvPl9`BgJ<9Y#LqcXERA$1ZOmrh-
z!!pzBAS@`;3k|DGgvv~~l<8H8$V{(;h|KgtBP!Et9xk6Vs?8adnO<mAWqQrS<#YCF
zbN0zhFSJje6E2^#Uz@XEo3me^6E2@Krp+1C=8Wlc!sT-gXmbu|a}MZp!sT<?+MKpF
zr>)Nkm(Lm3=8S7|#`QVj@;MXQoC$5tggz%+K4(&!GpWs))aQiD=N#1L9Mt9<)aQiD
z=N!`J9Ma|-(&vQB=S*pHrnEUz`kZk2oWt6j!`hs~`kZk2oM~;&v^Hm2pA#;hb3~hS
zM4NL&pA#;hGo#I!(dNwPbHe3wj%ss`YIBb2bHe3wj%jm_X>*S0bHe3wLdMiJOJ0@6
zwK>Q2IpOj-C$u>yv^gjAIpOj-CuL^Qy%J8!%#wStn^c*O?^0&jjh)gmr?ku|Jrgd^
zoYpd@wajTf6E4r3(K2VW%o#lsF3&utWuDVA&*_<PdFFYU>0RT`%S`VYe_myJ7jC$e
z=_$#qR&!RXIjh%%t7^s|phYI2Yt0RmmSSqbMqyV#;h?N?!f?Ez5Kt8--$a(6EU!Nc
zMOA1|K;e3$K|ockC!j2p1XP9g1Qag1@dQ-Gx*pX8)l*E$^v)OwC|q<TV<Dg_*7e*O
zWhM!z3iVt*Cj?YsWhMlag_3~6^;D4r6s|WX1XRV!Ob93oB>`2TvL*>ATyIVYsEU=D
z5KtCM0;)n~CJ889Z%zoPij|oVP!>u8szPNZ2`F6e^@M<`SeXd{WuYXXDpY2YfWr0W
zgn+78nF#@9p(LOxRA!QZ!u95afT~!T2?1rHB%mr(W|Dxy_2z_ts#uu`0cD{ipej^m
zl7PbX=7fN%SeXd{WuYXXDpY2YfWr0Wgn+78nF#@9p(LOxRA!QZ!u95afT~!T2?1rH
zB%mr(W|Dxy_2z_ts#uu`0cD{ipej^ml7PbX=7fN%SeXd{WuYXXDpY2YfWr0Wgn+78
znF#@9p(LOxRA!QZ!u95afT~!T2?1rHB%mr(W|Dxy_2z_ts#uu`0cD{ipej^ml7PbX
z=7fN%SeXd{WuYXXDpY2YfWr0Wgn+78nF#@9p(LOxRA!QZ!u95afT~!T2?1rHB%mr(
zW|Dxy_2z_ts#uu`0cD{ipej^ml7PbX=7fO4V*(0~3n*MJpm3RhvP=jl%OnA1nIxbr
z69URIA)qXi1e9fxfU-;oD9eO^vP=?CmPrE2G9jQW69URINkCa92`I~ifWq@$T?i;V
zykhcXl7Pa+%iy_`>782$C_L}nLO|hp=avK%u6J%pK;dE!WU37b6~~DqxmZ1+1?e|^
z^rx5^*?55U|M9?Q_KSUSVh^0y@yyD`1E(<n*=^*82krQ;`ow_TN_Zw-(J?!U$Bpi1
z`}U9^3!p}>b-39NoiBPjF^M6y{}My#=J1$3@~c5H5QahtT!RI!rsA2%47HovMR7tc
z)Ef_qnc;SMqbZ(~ZNHF5hG;{BBAkZw$J@<D(|Wb<_CV$7xLdtsRJY!tdWlsp$?7Ha
z$E%kzXIC$^4r?^K+Ka(1lsmf}dWZ53EAPnij#1uuOL@mFUp9ufu><xOpZhW^UzX*|
zM)~qv%9q{p6|;Qg9m-c&`HC!GG0IooQoiDrubSnf?@+$V%2#Fis!_iBmhx4%{F+(5
z?;XmovGQxO{F+gI?Jeck-16&Y`Tln(zs}09%kt|+`SrJyUq|@}U5?E1DOKLPc;Kr6
zKJIFBQa_gIlOK8fq0hC8Ge5@mu#Us`g#b<+I};c9T&8s#zC;9Y>e!jMz~^j4$Kjhr
z0H=<fi3@ygGCB@lHv%|y>`YwXb1<so@Es(8Q^(H41>V<VIu2h<0yuT-OkCi7I<DjJ
zZ6$zH$8=n(7E{~*mDqZ{vhBV7EL`$v)4%m%y}n%&_~!lHpW*^r*D3Nx-mh$xv-L)~
zoz2{m%G0GIoh}{P`FY1qb&eBX9(BY~2m7%n;&|}OqaE?jI|=cBe~6wy93g46y*_LY
z{sK!7f(tCxu%Vu5uhrG-m@GQ=ja)8wOQim>C3k^ahwJvErLec*UT;*IUb{9f5@<K+
z)E{QofAVSf$4~!0`_qp;`N`9t?tS!$Xjx8u^Pc;uN!s?B^?l;|gq3)P@o-(orv3K`
zJJEW%NKR2?oqA=<ayGV_meZ)cZ(-{_M-Np?gdL|=#`b=iBEwFzvYADAxwxIhzV*h|
zMyxC7VC(Qz-FhT%4WJ{{r8`ePM}4RpE744C(b=y4Fm!Am?TcSHnD&57i_HANar|iC
z4v}3@c9`sCWk<+fQFfH<Rb}^)eM{N>WZzbHjO;tg9w7TYW!q#Il^rL$r0fLQj<S<v
zmz6z8c177kWLK4)f}KbE)blXeZvSbr-Tp_&cKgqe?e;%Pw%h+0*>3;iWV`)OknQ$A
zNw(Yn6xnY7(`38-&yel*e~xUo|MO(K{m+u^_Me4aaQnYNw%h+4*>3+A$#(mnC)@3R
zfo!+`OJuwKUnbk_f01mr|0`s>{a+>9?f)9tZvWTGcKg3Uw%h+rvfcid$aeeB!CrRz
z&y(%;Um)A<f0=Bz{}r;`{#VIfJ;<#0;igq_pmp)lQiOlX=+i@Yoy@~{r+4W-+>!YN
zeSW(35bibwp4q&2(#h1K^qG3MLY9dF;Y@yJZOmypTd}u{5p%XGAEZO4U9s1-9)DX&
zA3e6Z;&IpNbj8lMwZuOib*!)V>|2<uyJyyv6PpKdNjM(=+B}Mj!rpI=2aa~^Q`GrQ
z_pIlS=L4sXt~%YlFQ~~K@pK1meRKPGH4rAROSp9G+2L;B%-~7nJ>8?bzLki&?MuL2
zu}7DiJrro=&mJzoLO)M;&pyw!0q1^mJMotDeD>QVz{kn!9-MJ*x^~DsN}*58gE-A+
zcGvp+4lYhP5*I-?74gQ7ozUAGm)}}(dpK^#1oq8nHI^B~eeLZy4I}msp0qx%M39=7
z3pFhji=bYrWy#cd+ZBhL#W0q{tP`eyjZdnP^gE!{Opg-^Nlv22u|xRE==EcVe9|)R
zB$_0sbdMB{n4~Z#g?-WrwALhHjnN}Tq9!TANfDp4O3P4VIxH7@q-dW>igHraC*8uv
zsY!yU_egy)lhnsaeLm?nHd0LzzQp%P{c;J8w}kh~+5Mc<@00G}4Puh;vxpukW}7|5
zI4S0n-jm;Q^moAkBMqcX(f}t7_@p8&`i(PgGm<@Ql59@0eNu_G4h&M9k>Y8S6z8P4
zPjc|}&?F@oDUmTr2~JA*q%t;YO;VDPlA|Um$w^6{RKdorNg8CN!7-CG$Vr1fsfvwU
zlZ5ZDy?4RTgh?9Wq@f-upQF{AamKN}>yc8ECMm^9DW8<5MVdjv(ym7uo-#?poHXo{
z3bZ~mNLbbNNNM@ABmQYgb5hzTEz{D>AYnn*BaK`zdm7=S5uda|t1^RxwOo&snKMZl
zPRjVCRa%f4BrM~4q|tekG|EY%KIs;%#S9Wwa6Qu4f=L?Vq%og#o0ee)35&NLY5bB&
z8t0^OpL7Qs%O+`pktP;R(gY_>_@wu+(QJ|?8ENv0Nt)!ONuN~2om-PM#Yj_EP0|!6
zP5Gn}Hlj_^G$T#_z$8s`(zH)<urY0tW*BLvXp&|)X~rj&u~BW3&N0%tl1VzpN#}f0
z1sm5U={zHyFPo(EoOIqNRk4w6l4cocwqlZIIcc^>D&(?3QkIdjSOMdW%ak+ANm-wi
zzYru{V5AG{Cg}nvUGPbTxgcqdk>)l`(i|tv`K0BGLDEG=x_H+lUF4*TK51n>NSbG)
z`MOD(=cIX`w7L)^Eilr;1CzACNee#d)}<in5+hw|n50Xbbjc^(z8oZ7W~9s8Ch0OK
zUG_<L7K5ZkMp}Gmk`_5>(I>rkB}lr$NLSuBNmn@OicczD4U(=h($x=5(p65n>XS;>
zf~0GVbnS;G=^7_p^GVM2An7_IUH?0ibe)r~`=s)XAn67p-RPL48=Q2*Csl3+NjDkk
z=8j3a$w@bTQgtavT4JQ7U6ZuLNlQJ_vb&tq)>8Pva!)yPk4;jJlX5;OpAYtwXQcc`
zCMnNJd7o4$1W5%(D*VVK6*#Hjla`l*q-920-Zx3hoV4tdR#t+f6-HV)Fi9(%wBnOi
zSA(QgMp}Jhl2$os6{O5GHbSwf+pgpa!ri{5O;OsTN!3QxE~)%=uiO&88@K=ci=+st
zCB-R~x7MsTi8l!=hT~R3u7dxFr{5%ceiA<h7UK8vr`l?jjC-S}r)q&CL`Y~q;*Q~W
z%D<I!3GuJmGq3UM?mww#UjOYYe7;pRH&$*I(2tzevd}v!XdeN4*R4Y*f;rVM=;iOo
zi`cwY`_gorZAfFweY<F5u|=EUazi@Xm+iCgi}Kdt-AH}C-jEyH1_USRjLq#J>viIF
z!kWNl`jtm0-&}5|`y#Yk0ehvLjz#Q{jZF!7tMm+wk@{=@WoRAVtbX9An;*#smD)q>
zq7*3F=r|QkMQIB?RhfPyf1_QSqF1qX7;ols?O3~5ZeW_L&D<U3;1#n3zQs55Wr5$S
z!zg&hG8vdW)2#Zzv$Q$C(RdKDJ9Z-FL}ZcH%fDI*QyGe+XDzyCjr;2lO7!5+LpdgJ
zYvMtL>?%F1(ZhPIb+~e`R7NxEKRAT3cS19{w<0F&(KV|hI>N%+?Xh@_zjGn^s?OK$
zKkQ`<VMW8TVs><n{v$x^u&`O*#uY@dBRF5U9fAEK7Mrq@Yu3-gKMTiVb1x*h;M}kE
za-xVnJLgUKO<2U{QZi?uvF-G_iK7m^g(SKwy26Uh35(hpYF3Nxc@GJkN;*(-4}@_b
Pm7vcgZUt5Fe;xh|kQQ*J
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/FACP.core-count b/tests/data/acpi/q35/FACP.core-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
GIT binary patch
literal 244
zcmZ>BbPo8!z`($~*~#D8BUr&HBEVSz2pEB4AU24G0Y(N+hD|^Y6El!tgNU*~X%LSC
z$X0-fGcm9T0LA|E|L2FOWMD92VqjR>!otAF!NBm72O<iWged~jj0!*k$y^{03>bk1
YBHITON2VDSAnpK(F*YFF1LDH~0O^Si0RR91
literal 0
HcmV?d00001
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index b9bc1961309a..dfb8523c8bf4 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/APIC.core-count",
-"tests/data/acpi/q35/DSDT.core-count",
-"tests/data/acpi/q35/FACP.core-count",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 08/16] tests: bios-tables-test: Prepare the ACPI table change for type4 core count2 test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (6 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 07/16] tests: bios-tables-test: Add ACPI table binaries for type4 core count test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 09/16] tests: bios-tables-test: Extend core count2 test to cover general topology Zhao Liu
` (8 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 1 - 3.
List the ACPI tables that will be changed about the type 4 core count2
test case.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..0f95d1344b2c 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,3 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/APIC.core-count2",
+"tests/data/acpi/q35/DSDT.core-count2",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 09/16] tests: bios-tables-test: Extend core count2 test to cover general topology
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (7 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 08/16] tests: bios-tables-test: Prepare the ACPI table change for type4 core count2 test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 13:11 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 10/16] tests: bios-tables-test: Update ACPI table binaries for core count2 test Zhao Liu
` (7 subsequent siblings)
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Currently, this case just covers the topology with only core and smt
levels, and doesn't consider more topology layers between socket and
core.
To cover the fixed case in the commit 196ea60a734c3 ("hw/smbios: Fix
core count in type4"), add the "die" level in "-smp" as the more
general topology case.
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index a35c753a3a00..8cba1d8126f2 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1024,10 +1024,12 @@ static void test_acpi_q35_tcg_core_count2(void)
.required_struct_types = base_required_struct_types,
.required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
.smbios_core_count = 0xFF,
- .smbios_core_count2 = 275,
+ .smbios_core_count2 = 260,
};
- test_acpi_one("-machine smbios-entry-point-type=64 -smp 275", &data);
+ test_acpi_one("-machine smbios-entry-point-type=64 "
+ "-smp 260,dies=2,cores=130,threads=1",
+ &data);
free_test_data(&data);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 09/16] tests: bios-tables-test: Extend core count2 test to cover general topology
2023-08-25 3:36 ` [PATCH 09/16] tests: bios-tables-test: Extend core count2 test to cover general topology Zhao Liu
@ 2023-09-15 13:11 ` Igor Mammedov
2023-09-19 7:14 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 13:11 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:12 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> Currently, this case just covers the topology with only core and smt
> levels, and doesn't consider more topology layers between socket and
> core.
>
> To cover the fixed case in the commit 196ea60a734c3 ("hw/smbios: Fix
> core count in type4"), add the "die" level in "-smp" as the more
> general topology case.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>
PS:
I'd still explain in commit message relations between
-smp and .smbios_core_count2
> ---
> tests/qtest/bios-tables-test.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index a35c753a3a00..8cba1d8126f2 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1024,10 +1024,12 @@ static void test_acpi_q35_tcg_core_count2(void)
> .required_struct_types = base_required_struct_types,
> .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> .smbios_core_count = 0xFF,
> - .smbios_core_count2 = 275,
> + .smbios_core_count2 = 260,
> };
>
> - test_acpi_one("-machine smbios-entry-point-type=64 -smp 275", &data);
> + test_acpi_one("-machine smbios-entry-point-type=64 "
> + "-smp 260,dies=2,cores=130,threads=1",
> + &data);
> free_test_data(&data);
> }
>
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 09/16] tests: bios-tables-test: Extend core count2 test to cover general topology
2023-09-15 13:11 ` Igor Mammedov
@ 2023-09-19 7:14 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:14 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, Sep 15, 2023 at 03:11:57PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 15:11:57 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 09/16] tests: bios-tables-test: Extend core count2 test
> to cover general topology
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:12 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > Currently, this case just covers the topology with only core and smt
> > levels, and doesn't consider more topology layers between socket and
> > core.
> >
> > To cover the fixed case in the commit 196ea60a734c3 ("hw/smbios: Fix
> > core count in type4"), add the "die" level in "-smp" as the more
> > general topology case.
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
Thanks!
>
> PS:
> I'd still explain in commit message relations between
> -smp and .smbios_core_count2
Ok.
-Zhao
>
> > ---
> > tests/qtest/bios-tables-test.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index a35c753a3a00..8cba1d8126f2 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -1024,10 +1024,12 @@ static void test_acpi_q35_tcg_core_count2(void)
> > .required_struct_types = base_required_struct_types,
> > .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > .smbios_core_count = 0xFF,
> > - .smbios_core_count2 = 275,
> > + .smbios_core_count2 = 260,
> > };
> >
> > - test_acpi_one("-machine smbios-entry-point-type=64 -smp 275", &data);
> > + test_acpi_one("-machine smbios-entry-point-type=64 "
> > + "-smp 260,dies=2,cores=130,threads=1",
> > + &data);
> > free_test_data(&data);
> > }
> >
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 10/16] tests: bios-tables-test: Update ACPI table binaries for core count2 test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (8 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 09/16] tests: bios-tables-test: Extend core count2 test to cover general topology Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 11/16] tests: bios-tables-test: Prepare the ACPI table change for type4 thread count test Zhao Liu
` (6 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Change the core count2 from 275 to 260.
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 5 and 6.
Changes in the tables:
APIC:
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20200925 (64-bit version)
* Copyright (c) 2000 - 2020 Intel Corporation
*
- * Disassembly of tests/data/acpi/q35/APIC.core-count2, Wed Aug 23 16:29:51 2023
+ * Disassembly of /tmp/aml-KQDX91, Wed Aug 23 16:29:51 2023
*
* ACPI Data Table [APIC]
*
* Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
*/
[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
-[004h 0004 4] Table Length : 000009AE
+[004h 0004 4] Table Length : 00000CA6
[008h 0008 1] Revision : 03
-[009h 0009 1] Checksum : CE
+[009h 0009 1] Checksum : FA
[00Ah 0010 6] Oem ID : "BOCHS "
[010h 0016 8] Oem Table ID : "BXPC "
[018h 0024 4] Oem Revision : 00000001
[01Ch 0028 4] Asl Compiler ID : "BXPC"
[020h 0032 4] Asl Compiler Revision : 00000001
[024h 0036 4] Local Apic Address : FEE00000
[028h 0040 4] Flags (decoded below) : 00000001
PC-AT Compatibility : 1
[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
[02Dh 0045 1] Length : 08
[02Eh 0046 1] Processor ID : 00
[02Fh 0047 1] Local Apic ID : 00
[030h 0048 4] Flags (decoded below) : 00000001
Processor Enabled : 1
@@ -1051,1256 +1051,1136 @@
[42Ch 1068 1] Subtable Type : 00 [Processor Local APIC]
[42Dh 1069 1] Length : 08
[42Eh 1070 1] Processor ID : 80
[42Fh 1071 1] Local Apic ID : 80
[430h 1072 4] Flags (decoded below) : 00000001
Processor Enabled : 1
Runtime Online Capable : 0
[434h 1076 1] Subtable Type : 00 [Processor Local APIC]
[435h 1077 1] Length : 08
[436h 1078 1] Processor ID : 81
[437h 1079 1] Local Apic ID : 81
[438h 1080 4] Flags (decoded below) : 00000001
Processor Enabled : 1
Runtime Online Capable : 0
-[43Ch 1084 1] Subtable Type : 00 [Processor Local APIC]
-[43Dh 1085 1] Length : 08
-[43Eh 1086 1] Processor ID : 82
-[43Fh 1087 1] Local Apic ID : 82
-[440h 1088 4] Flags (decoded below) : 00000001
- Processor Enabled : 1
- Runtime Online Capable : 0
-
-[444h 1092 1] Subtable Type : 00 [Processor Local APIC]
-[445h 1093 1] Length : 08
-[446h 1094 1] Processor ID : 83
-[447h 1095 1] Local Apic ID : 83
-[448h 1096 4] Flags (decoded below) : 00000001
- Processor Enabled : 1
- Runtime Online Capable : 0
[snip]
-
-[964h 2404 1] Subtable Type : 01 [I/O APIC]
-[965h 2405 1] Length : 0C
-[966h 2406 1] I/O Apic ID : 00
-[967h 2407 1] Reserved : 00
-[968h 2408 4] Address : FEC00000
-[96Ch 2412 4] Interrupt : 00000000
-
-[970h 2416 1] Subtable Type : 02 [Interrupt Source Override]
-[971h 2417 1] Length : 0A
-[972h 2418 1] Bus : 00
-[973h 2419 1] Source : 00
-[974h 2420 4] Interrupt : 00000002
-[978h 2424 2] Flags (decoded below) : 0000
+[43Ch 1084 1] Subtable Type : 09 [Processor Local x2APIC]
+[43Dh 1085 1] Length : 10
+[43Eh 1086 2] Reserved : 0000
+[440h 1088 4] Processor x2Apic ID : 00000100
+[444h 1092 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+[448h 1096 4] Processor UID : 00000082
+
+[44Ch 1100 1] Subtable Type : 09 [Processor Local x2APIC]
+[44Dh 1101 1] Length : 10
+[44Eh 1102 2] Reserved : 0000
+[450h 1104 4] Processor x2Apic ID : 00000101
+[454h 1108 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+[458h 1112 4] Processor UID : 00000083
+
[snip]
+
+[C68h 3176 1] Subtable Type : 02 [Interrupt Source Override]
+[C69h 3177 1] Length : 0A
+[C6Ah 3178 1] Bus : 00
+[C6Bh 3179 1] Source : 00
+[C6Ch 3180 4] Interrupt : 00000002
+[C70h 3184 2] Flags (decoded below) : 0000
Polarity : 0
Trigger Mode : 0
-[97Ah 2426 1] Subtable Type : 02 [Interrupt Source Override]
-[97Bh 2427 1] Length : 0A
-[97Ch 2428 1] Bus : 00
-[97Dh 2429 1] Source : 05
-[97Eh 2430 4] Interrupt : 00000005
-[982h 2434 2] Flags (decoded below) : 000D
+[C72h 3186 1] Subtable Type : 02 [Interrupt Source Override]
+[C73h 3187 1] Length : 0A
+[C74h 3188 1] Bus : 00
+[C75h 3189 1] Source : 05
+[C76h 3190 4] Interrupt : 00000005
+[C7Ah 3194 2] Flags (decoded below) : 000D
Polarity : 1
Trigger Mode : 3
-[984h 2436 1] Subtable Type : 02 [Interrupt Source Override]
-[985h 2437 1] Length : 0A
-[986h 2438 1] Bus : 00
-[987h 2439 1] Source : 09
-[988h 2440 4] Interrupt : 00000009
-[98Ch 2444 2] Flags (decoded below) : 000D
+[C7Ch 3196 1] Subtable Type : 02 [Interrupt Source Override]
+[C7Dh 3197 1] Length : 0A
+[C7Eh 3198 1] Bus : 00
+[C7Fh 3199 1] Source : 09
+[C80h 3200 4] Interrupt : 00000009
+[C84h 3204 2] Flags (decoded below) : 000D
Polarity : 1
Trigger Mode : 3
-[98Eh 2446 1] Subtable Type : 02 [Interrupt Source Override]
-[98Fh 2447 1] Length : 0A
-[990h 2448 1] Bus : 00
-[991h 2449 1] Source : 0A
-[992h 2450 4] Interrupt : 0000000A
-[996h 2454 2] Flags (decoded below) : 000D
+[C86h 3206 1] Subtable Type : 02 [Interrupt Source Override]
+[C87h 3207 1] Length : 0A
+[C88h 3208 1] Bus : 00
+[C89h 3209 1] Source : 0A
+[C8Ah 3210 4] Interrupt : 0000000A
+[C8Eh 3214 2] Flags (decoded below) : 000D
Polarity : 1
Trigger Mode : 3
-[998h 2456 1] Subtable Type : 02 [Interrupt Source Override]
-[999h 2457 1] Length : 0A
-[99Ah 2458 1] Bus : 00
-[99Bh 2459 1] Source : 0B
-[99Ch 2460 4] Interrupt : 0000000B
-[9A0h 2464 2] Flags (decoded below) : 000D
+[C90h 3216 1] Subtable Type : 02 [Interrupt Source Override]
+[C91h 3217 1] Length : 0A
+[C92h 3218 1] Bus : 00
+[C93h 3219 1] Source : 0B
+[C94h 3220 4] Interrupt : 0000000B
+[C98h 3224 2] Flags (decoded below) : 000D
Polarity : 1
Trigger Mode : 3
-[9A2h 2466 1] Subtable Type : 0A [Local x2APIC NMI]
-[9A3h 2467 1] Length : 0C
-[9A4h 2468 2] Flags (decoded below) : 0000
+[C9Ah 3226 1] Subtable Type : 0A [Local x2APIC NMI]
+[C9Bh 3227 1] Length : 0C
+[C9Ch 3228 2] Flags (decoded below) : 0000
Polarity : 0
Trigger Mode : 0
-[9A6h 2470 4] Processor UID : FFFFFFFF
-[9AAh 2474 1] Interrupt Input LINT : 01
-[9ABh 2475 3] Reserved : 000000
+[C9Eh 3230 4] Processor UID : FFFFFFFF
+[CA2h 3234 1] Interrupt Input LINT : 01
+[CA3h 3235 3] Reserved : 000000
...
DSDT:
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20200925 (64-bit version)
* Copyright (c) 2000 - 2020 Intel Corporation
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of tests/data/acpi/q35/DSDT.core-count2, Wed Aug 23 16:29:51 2023
+ * Disassembly of /tmp/aml-6DDX91, Wed Aug 23 16:29:51 2023
*
* Original Table Header:
* Signature "DSDT"
- * Length 0x00007EEF (32495)
+ * Length 0x000083EA (33770)
* Revision 0x01 **** 32-bit table (V1), no 64-bit math support
- * Checksum 0x52
+ * Checksum 0x01
* OEM ID "BOCHS "
* OEM Table ID "BXPC "
* OEM Revision 0x00000001 (1)
* Compiler ID "BXPC"
* Compiler Version 0x00000001 (1)
*/
DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
{
Scope (\)
{
OperationRegion (DBG, SystemIO, 0x0402, One)
Field (DBG, ByteAcc, NoLock, Preserve)
{
DBGB, 8
}
@@ -4196,107 +4196,32 @@
}
If ((Arg0 == 0x0101))
{
Notify (C101, Arg1)
}
If ((Arg0 == 0x0102))
{
Notify (C102, Arg1)
}
If ((Arg0 == 0x0103))
{
Notify (C103, Arg1)
}
-
- If ((Arg0 == 0x0104))
- {
- Notify (C104, Arg1)
- }
-
- If ((Arg0 == 0x0105))
- {
- Notify (C105, Arg1)
- }
-
- If ((Arg0 == 0x0106))
- {
- Notify (C106, Arg1)
- }
-
[snip]
- If ((Arg0 == 0x0112))
- {
- Notify (C112, Arg1)
- }
}
Method (CSTA, 1, Serialized)
{
Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)
\_SB.PCI0.PRES.CSEL = Arg0
Local0 = Zero
If ((\_SB.PCI0.PRES.CPEN == One))
{
Local0 = 0x0F
}
Release (\_SB.PCI0.PRES.CPLK)
Return (Local0)
}
@@ -4306,33 +4231,33 @@
\_SB.PCI0.PRES.CSEL = Arg0
\_SB.PCI0.PRES.CEJ0 = One
Release (\_SB.PCI0.PRES.CPLK)
}
Method (CSCN, 0, Serialized)
{
Acquire (\_SB.PCI0.PRES.CPLK, 0xFFFF)
Name (CNEW, Package (0xFF) {})
Local3 = Zero
Local4 = One
While ((Local4 == One))
{
Local4 = Zero
Local0 = One
Local1 = Zero
- While (((Local0 == One) && (Local3 < 0x0113)))
+ While (((Local0 == One) && (Local3 < 0x0104)))
{
Local0 = Zero
\_SB.PCI0.PRES.CSEL = Local3
\_SB.PCI0.PRES.CCMD = Zero
If ((\_SB.PCI0.PRES.CDAT < Local3))
{
Break
}
If ((Local1 == 0xFF))
{
Local4 = One
Break
}
Local3 = \_SB.PCI0.PRES.CDAT
@@ -7220,3281 +7145,3281 @@
Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
{
0x00, 0x08, 0x81, 0x81, 0x01, 0x00, 0x00, 0x00 // ........
})
Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
{
CEJ0 (0x81)
}
Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
{
COST (0x81, Arg0, Arg1, Arg2)
}
}
- Processor (C082, 0x82, 0x00000000, 0x00)
+ Device (C082)
{
+ Name (_HID, "ACPI0007" /* Processor Device */) // _HID: Hardware ID
+ Name (_UID, 0x82) // _UID: Unique ID
Method (_STA, 0, Serialized) // _STA: Status
{
Return (CSTA (0x82))
}
- Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ Name (_MAT, Buffer (0x10) // _MAT: Multiple APIC Table Entry
{
- 0x00, 0x08, 0x82, 0x82, 0x01, 0x00, 0x00, 0x00 // ........
+ /* 0000 */ 0x09, 0x10, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, // ........
+ /* 0008 */ 0x01, 0x00, 0x00, 0x00, 0x82, 0x00, 0x00, 0x00 // ........
})
Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
{
CEJ0 (0x82)
}
Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
{
COST (0x82, Arg0, Arg1, Arg2)
}
}
- Processor (C083, 0x83, 0x00000000, 0x00)
+ Device (C083)
{
+ Name (_HID, "ACPI0007" /* Processor Device */) // _HID: Hardware ID
+ Name (_UID, 0x83) // _UID: Unique ID
Method (_STA, 0, Serialized) // _STA: Status
{
Return (CSTA (0x83))
}
- Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ Name (_MAT, Buffer (0x10) // _MAT: Multiple APIC Table Entry
{
- 0x00, 0x08, 0x83, 0x83, 0x01, 0x00, 0x00, 0x00 // ........
+ /* 0000 */ 0x09, 0x10, 0x00, 0x00, 0x01, 0x01, 0x00, 0x00, // ........
+ /* 0008 */ 0x01, 0x00, 0x00, 0x00, 0x83, 0x00, 0x00, 0x00 // ........
})
Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
{
CEJ0 (0x83)
}
Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
{
COST (0x83, Arg0, Arg1, Arg2)
}
}
- Processor (C084, 0x84, 0x00000000, 0x00)
+ Device (C084)
{
+ Name (_HID, "ACPI0007" /* Processor Device */) // _HID: Hardware ID
+ Name (_UID, 0x84) // _UID: Unique ID
Method (_STA, 0, Serialized) // _STA: Status
{
Return (CSTA (0x84))
}
- Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ Name (_MAT, Buffer (0x10) // _MAT: Multiple APIC Table Entry
{
- 0x00, 0x08, 0x84, 0x84, 0x01, 0x00, 0x00, 0x00 // ........
+ /* 0000 */ 0x09, 0x10, 0x00, 0x00, 0x02, 0x01, 0x00, 0x00, // ........
+ /* 0008 */ 0x01, 0x00, 0x00, 0x00, 0x84, 0x00, 0x00, 0x00 // ........
})
Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
{
CEJ0 (0x84)
}
Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
{
COST (0x84, Arg0, Arg1, Arg2)
}
}
[snip]
- Processor (C0FE, 0xFE, 0x00000000, 0x00)
+ Device (C0FE)
{
+ Name (_HID, "ACPI0007" /* Processor Device */) // _HID: Hardware ID
+ Name (_UID, 0xFE) // _UID: Unique ID
Method (_STA, 0, Serialized) // _STA: Status
{
Return (CSTA (0xFE))
}
- Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ Name (_MAT, Buffer (0x10) // _MAT: Multiple APIC Table Entry
{
- 0x00, 0x08, 0xFE, 0xFE, 0x01, 0x00, 0x00, 0x00 // ........
+ /* 0000 */ 0x09, 0x10, 0x00, 0x00, 0x7C, 0x01, 0x00, 0x00, // ....|...
+ /* 0008 */ 0x01, 0x00, 0x00, 0x00, 0xFE, 0x00, 0x00, 0x00 // ........
})
Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
{
CEJ0 (0xFE)
}
Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
{
COST (0xFE, Arg0, Arg1, Arg2)
}
}
...
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.core-count2 | Bin 2478 -> 3238 bytes
tests/data/acpi/q35/DSDT.core-count2 | Bin 32495 -> 33770 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 2 --
3 files changed, 2 deletions(-)
diff --git a/tests/data/acpi/q35/APIC.core-count2 b/tests/data/acpi/q35/APIC.core-count2
index f5da2eb1e8a93d961b39f665f2e8b02acf1aeb3c..4f2428443430b7da8321e9edd816219deb7929a2 100644
GIT binary patch
literal 3238
zcmXxmby$@L7>4l=5IyGriroq-c6Un%f(43!4Ju%FCoFWS>+W#f-LAWJ9j?3EZMyH~
zdB%0*{(jUSTwd=(R#8FDzT_ZCIGkOWlV6;cT~d^j7QV#=LBKN&f<s4Y8VLe5E>4Y)
zR}&J{TD8=~M74HpwN4#15>ca3H5OBolGNm6H6=x@TUV`DPfbl#>(^HsG*BBhR2wx?
z8#h*)G*O#2Rhu<an>SZmv`|~NR9m%DTenu*v{Bo(RrPxbBI)UJyLM{(_G*U?YDR|I
zv7_3lliInn+NF!ywX52#o7%m*+M|csv!~jtm)g6x+NY1&x3Ai-pW45_I$(f0aG*M9
zkUDs<I%J4Cbf`LPm^ys8I%0%6a-=$Hl$x2TW@V|_*=mmdpF~EFmUDB}ygYTx7&Sj%
zEhtdOj#bBvQ^${2CrnT$PE-pE)uJMG(j;~AWVN_hoiat8I#r!EO`SenEh$lF%ur{}
zRA<dnXU|sW%u(mgRp-r9OH0+VGIjoZb-@C4;X<{%T&<{3D=XDSi`2!7)g?>RrAyUi
z%hct|)fFq$l`GX%tJKx2)irC>wQJRN>(uq@)eRfejT_ZXo7Byl)h%1pty|S?+tlsb
z)g3$3ojcX4Dz&<rMpMIg;RDad*m3r;HV1;wA7^tY@bNYW1Mjjq9C)|Q0l_EO91?t@
z%|XE@*&G&pvdw|Pr`Q}Ce5%dC!Fy~D58i8YfbeNHhX|i;bCB>EHirqHX>*|PSvH3X
zpKWun@HsYz3!iIq!0>rChYX)@bI|YwHir#gXmjB3MK*^HUu<*m@Fg~f4_|6?0P$ru
zhY(+Gr`cE7>GqX22QqvGSJ@m&e6`KN#QW?F`x=`A%IB}OIi&bHn}dq4w>hl%2Aczm
zZ?rkI_$Hf!i*L3$y!aNI1B`FAImGxjn}dvRw>ixC4x0mw@3cA8_%54+jqkQO-1r`w
z1CH;tIpp|0n}d$;w>j+i0h<GlAGA62_#vBvj~})<{P+=@0l@ohh5$cmXWEb1S@z>L
z0};N0Cv1iSKWQ@<_$fQre%j8npRpMdzW!O8LBY@23=4kVW?=9OHbaA7v>6=ylFjho
zmu&_JzhW~)_*I)h!mrs36Mo%hpzr~kp~44k1`EGoGhFyhn*qab*$f$e+h)-4J2u0H
z-?bSy{GQFw;rDF@4}V}YeE36~0mO%Fh7f;bm)alOW%egF0~x-8Pi=-0e`Yh7_;b75
z{=%-XzqBjuuWSZ2d<9?I3@iS|W?=ERHbaZQvl(3cz0L6AA8ZB~|7bJB_$Qk|#y{H(
zGycV9pz*IZLydp48EpK!&2ZyCYz7?vX*1;bFPlNfhi!%(|7|ny_#d00$N$<4K0abI
z{P?KN9{`wl>^*-7V0Io?+3Y;7wrh4inQz?Bj}GEv;XfXDN=yu!!c#Q*|5Ggd0(~qg
Qspcsbe)rMvE&PGOe_jvc0RR91
literal 2478
zcmXZeWl$DT6oBC+KKO#RP*m&=4D137us{*TMz9O9Td}*lI}y7Jv9Q1{3{VuiJJ3D6
zcW3rK=bgE`Kkn?0^$7~_i#2JQO`>n0pMP*Z-_RhxeEMajX`0NUrln+LYSc8evO;TX
zw6Q^3TQnHZ&JOME(P%`I3C(7-SkS=%9Ualh37wtM#RXkm(ajCBWWlUiF<Umwo*i@K
zKzDb{nG<v6LJtqjog4Gy!Mu6V(-S!t&6qzwU7!FKEQo~)Vd279qzD!*ip7dy@#0vb
z1ePp`rAlGx(paVpmMx23URbUimM@PLDqzKm=<SV_Dq-cySfvV9t%}vEVfE@*qXyQj
ziM48B?b=wU4*K|@uP^%XofzxZrR&wh`t`9v1N8UDfB<aR5F0hZ#*MK_6KvWP0|PNA
z2%9y-=FKrU7+bW!kPvLy5?i&x&`@mM8r!tNwr#OpJ8a(`J9NN~9Wg8nJ9WbFaEyq+
z&YiJK7wp;<yLH3v-LXdx?Aa50^}^o0u}>fD+ZQ7vv0p!oio*W=alil^I1mR7!oh=a
z$PgSl6o(DN;lpvn2pl;QM~%YKqjAg_96J`HqjB6g96uf>Ou&f~andB5JQ=4<!KqVm
z+BBR#9cRqInKN<LESx<X=gh&mb8+50oIf8IEWm{eanT}Nycm}(!KF)a*)m+d99OKs
zl`C=8DqOu9*Q~*{YjNE=T)!SSY`~2hanmN;ycxG_!L3_y+cw<39b;l}#}15*#hp8G
z*Dl<>8~5zNy?b%rKHR?_4;;XQ2l3D$JbW0B9KoYU@z^muejHDnz>_C2E)Gwf!uWVR
zeHzc4!Lw)a+&Mgd9upGq!Ueo|5iecB%a`%W6--RTq$Iq06|Y^x>(}wd4ZL|1Z{5P%
zxAD#$yn7e#-NXC$F*z9@Jivz!@zEoE{1{VGFf|pQJi(_=F)a<BJ;UeEF+Ck$yug<)
z@zpDQ{TkoA!MAVm-8+2$9zT4*k00^VC;a>wzkI>3U-8>F{Qez({J@_-@z*c>{Tu)M
z!M}eoBSSQ~XxcwrnMG-d%su)dZKYb2wpJ}l+o%?$ZB>iX2GydpooZ3qUbQG~R4q!I
zREyGP)uOaTwJ7bNT9kHFElNA77Nwn4i_$KtMQK;nqO_apOda&|(&92?wKnUw3^ExE
cx{flL^j|P0v%Z1JV#%D$`qTgPOMjvEANV#K5C8xG
diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
index b47891ec10be131a59bf404242241c054ac902f8..3a0cb8c581c8cc630a2ec21712b7f8b75fcad1c8 100644
GIT binary patch
delta 7005
zcmZA0cUaYR6vuHcmD)`M6Dpcop=68FRGPxQSQ+I2Hwg|D$rMA)wuyop<*2xEptuoH
zapMFxZrr$095})Kguios=lOl^^YGliczw_J`#aCO<dLm7(cSJ0b%qtkySdqHnf8i4
z?g?>J%_q}6KALiUeBHm>ly%joe&wv9npJESpSH!iMaFibUbVckJpBA>RUFW;g2TVT
zClndy?K{A$N<?T_V5Kxi`LBIIrHCH_!>U%Zdp_&wR(`he=Qe;Mo750h$58R0;z8L&
z#nU`hbqzHT)Id<~q6X4!Ri7Ga5U4?*o)R^PzG`aTu-+5pkpL=z`uFj+CD35~uli5^
zD<l#AD-q6qM$S$w{}5i4BZ3?I+Z^RT_Czm_h$f+7&pFC}?1|CcV%qWdq#J#`-R*;u
zn|XQ4_p2Z$45rtbnYRlt-ZTW}4uQE9MGc`Yssar)6x2{ql|&7t#j1h~H4M}+P|u1Q
zM)y@Y3^g3oa8Pzp!^zp)e3#QuBS4J+^_-{?G*VUY6Xh`y)JR&~&)YVV4mYn+LB4E6
z+>0Se@J~r_bQL)|$z@eZ)>S3xssd<3T=}X-QPWV})$?-1DC!<6ZwmO>c++SYJQ@aj
zh#F1HRdH9zpprp(ib_rnGe>b&1c(4t6-3ln6=yXD)EH1Nh#Es<RB={gL5&4fP1IOA
zsmjR8cO0m3pu9wlBfl2ryEwBHP${6iMWwjxF2%aL6wB_6%*NBS7P`9^<%sdLMhA0e
z6JYQJ82pl`2~?q_d0p;oBB+U=UKTZxnyTW?CV`p+%16{Bny899n+$3)s8>WyrgN&e
zvnimafO=Kb6#B50`7Wa~->IOcf_hEVRO;7Cx(lEu-K7Fb1@yY0RF~bQT6dSKy9?y*
zrqT6Qy1O^zh-p;0wcIw4yPFP!r^DbkMNOxcs<^uupk{!oE@}o%Q^n!U1T_;>4N)_x
zSQUqt1}Y8ITcXmaZX5Gm9NsKYvp~HqY8L&Yio=@?YBs2MM9rqHsyMuKQ0bt2MWwqe
zFWtJlbj$LL@a9m%wz|BUa>N`8Z)-l1!<!3(=fdDxqUO?URUF<tQ1d|fiJC{(RdIOp
zLCpvCuBiF+Sv&KF9Nq#@3qaKtwSWey;_w!NS_tYrQ449eDh_WEs70XO7qy694wvu(
zjqox6WdQm>P=?FyGOWAH(A@=bc#CONxbE&lIbty_2$wGt#NlPa;7l0&k*G{6RmI^g
z0ks5_zo;eD@F#N?hnEE^3)IJ=vS_F(4sR)_rJz0$wUiF1;_#M%S_Z0)sAcp<d-H}I
z-f~dOLDdztoT626c-f$`L47JJ+huv#*5zeemS=>wf=;#9<<*lTR?tHo%;Bws!7E{K
zeNii^QH1$O4sR8xRiGM(T1BH&ad@jitp*h!YBe2I#o?_1wFcB@qSnwmk>(9KytSa#
zg8E$4TI!*S!&?Vx9jGrvt)mr@5?+uIUJjrfKwk>VaoJstb$2<sI|qlip8PxL?!J;E
z)>B9ad832F+W><%z~HY%ZJ=?gIJ}LZHiBv>Y9pOe#o=uNwFy+9s7+M6qj^IPZ!@UP
zpn^ngrrxSJye*)%fO3f1LhDp<c)6f*K{-X`Ql(Dj4LQ6#P<fz&Mdi6HFVDKXJj?Qo
z@U~L_PP)8Ca>Q1etb;kcZ7_Hn4E{#cHoBmS!`lvOJE(6(Z72WE<|8@09iVoA`cBji
z`a>0mw-eM(P>n_Hq|K^0yj`Gnf%;z5E_y!7ydj6T8`N%4A)<Cu>nI7&VT6|tC?C)d
zg7RH<mv7x&zV6P+;q9S4QM$Vy<%m6W#k{SP!`lmk_rl;NqV`g~F7ievhqn*ZK2S|X
z?W6vxIK2I!_Je9BYCmmP#o-+QbpTXzQ3uGYt9e5X?;xmyph86*r1q*fyhET4feI6K
zh~}u`@CrZ`fNCMCz-4&_*5wsgmS==_n5swX@><Ffhv|!G^N}3h5g2>~2DcJ*gc4M7
zct=4U1=U*AQQD)5!#f7*7^pU)j?pXK%o}oe$3Yzj)mGGT>a2>xI|1qhsCJ@G&>~eF
z-bqj=L4}JtNq4(Rcupg{LO_LpeiBsZvb#d-?h18x!5rQxijC3TwU;AK(eN1gGQk|)
zX&8JO21kfGO@~x*cxOPJ0Tn6g3|0TxoW<dt1$7ow2T^A!Miqy54%9hN9Yvj^rK&i*
z^PtXy>LltsJyylxT>y0fRA*5a=-ck*yEwceP(`4kL>0L#ugJQ*BFplO@GjE&?z+4#
za>PYCu7f$eOECBn4DKrG64m_0ye@}V45}DZw5Vc=RmI_526Y)!H&K^ql`0PJ3aBff
zVnkh`r+b(;<nXS7x(e!NQCI0lRUF<mP}e|p7j=!s_mJ>{jqpkUl>quhP>IX#O02sp
z(cLxT@UD|*Pu*P)IpR9K-&5Y$h{L-9gKxm#o}zA0UsW95O;9&M#frK~>s4`hw?N$j
z)l1YZvd5Y?<nV5Tx((`AQMV~f6^C~R)E!W9qVCXCRUBR^s8Ue9MU~P;RUBR!s4`G}
zM3uQLugto<GRyLe@a|G%FI`?=IpQw;)yw=e9Ns+`d=CcyCh8vLs^akOgSro@pQ!uf
z`KvjL!+QYg0jS?aJ)pL#IJ}3T9)kKq)I&;B#o;{y^$66Tq8`yTRUF=9P>(_VCF(IX
ph->5iw~Z*SqwOCmjf=AVOX0nvZ2f6t`R{+^*Qa(?$e%Nx`XBpVSA+ln
delta 7056
zcmZYDc~DjN6~J*03Oso1!Zc1N({Y@{rcS5tJ(l<0bUK~4HeDh`u|}<1j8RN%v^J(T
zMiWs%al_-jf}p5~im0f#;l3m8yW+kf?mMP;`~7mRhd;P;=6&w>{_gqn-pLJZY=S6%
z2Y*)M@Q@H_UlA42GBm$6wrE)qn)e>=Zuvpz-)buxS~{ag6h>n|YjYUmv)fX$wINI!
z()1x*8`AY5LK~d=V9^GbK16DRTOXpd!J`jWZSd+tv^MzkAx0hA+5GwxtNj$vhd6Br
z>O;Ib*lqfdpbd6?NYn;LcGAb;z7AQQ$gZu?^XnG4?8Eo4^M|LQMWv&Sw@pmW$IX2<
zmt$mz`iBMWk}TFJONeFUNWiu2T79JdoRXvcoD|bT30X?iTvU#w$0wew1Wo7U0RAFF
z=+seMk0N^1D8Qjor;X-%G|{6+1D=yQeGJ!Qh#oTr@DG0%CvoO-olA6XF5m*GU3pyR
z5uKL@2$`bo9?SJuqQ{N}?48-lSg>cDrm-l~Sn#-UfV*VOo6lqUB$l5K*rvUBv~N7u
z<B1+W9&oJG{s~-9AbP?Cz`IfhCUQNI=!p{nKj|P&5}d^KB%&ux0$eGy+cuf&$wW_{
z449B*wB7ast_z4RC;%LsWh~h3n4)Q{$TAi@WeVU48B0MPLlQ#-baoVvPMym2RHCO&
z1)L>y+BB}G5j|}h;A^SVr*l1>=;_k|yZu9)#5sfO8AQ*R0k~Ca*G#Tw5<PP!V5?4|
z?ViQ;ETU)40?g?o7VMd=X{_mFEO_>8!0R&Rox@{uNNmm=z(0K|9_^dU^<1Lo&IMd5
zwSOMh^N5}|5763Kv;*_Go=^1r`G5nY4ldw&0nrN<0M-iau@!P%NOWN#puLN65|6!z
z>ms6yiU6^Tv0#s5p{B8}i?QH^3jv?XSV}RE6_Z$TF<_^z;?b!kT$d1CQUbU^>a;~%
zFCu!;BEVn%Q?%0;bG?}8#ft&Im)cp%bt%!MrGS^Db}iw03DHZI0D8KKlem|1y_D#s
zO96|!i3NL>X&URh84F&v3^1&_h<VF+tc=9U$^iRH?OV?Ea-x?n2izyMzntrGqRYzx
z+x8GA39R6H1<@;308WrPxRUFYM6X;4*eJBuwu<XjM6X%}nAy`fiPv7ibp_EC6@ZmJ
zjRkuht2K=edm0N~y&5pNmx!fQ@>nH_RaOFiD|PA`uGbK~W)0vOsngbSy_V>;YXN`%
znK()MI<D6dy>1=gJgJ>kTvriYRR#Ey)UNehuP1u_dca=2#Yx;7xZXhYh7Eu_dW!{n
zHfkE-b7R39Hv)d}xrlkId90ems;dEWrS@&&dK1x`HUZw2+P|6W%|vhB4EWbR;v|7B
zTyG(I%ND?Lse@a&-b(b=t$=Y~7;T?z8`s;2-nI>Jkks}Xu4{;{sR2Cpg|T3tW4op?
zp|7#v?b`v<`ie)V?BKB-B(`G*;0&o#cXGXx=$$(OUrL>}i|buP@7e{}wVyai`fjdw
z6TN#k;AW|vd$`_1^qxI{zseSE*Iuso61{gX;Ez(f_i??C=zaSDuV#w{d-iJ@TlF^<
zynjDnpuc#u_W+L_Ah81n086Fz9pw5T(FYF#Mt&*U{zF_JBKpuFz%Qi^9On8k(T5KM
z9+Em(%XKZ$wY7l1`^q?p-*$xSBSarL0$3omy^iZTqU-7aAAe;m*zY*1X|xY87JT$5
zV8;RC(J9Ax>==n1I|f)Kb?R}hj}v|TIAF_viFVovu1^qs;soG#Qm3Ef`XtdOPXb<$
z+IfoWQ$(LS1^CCW#YtSJxjs$w>C=EkQoGM^eTL{WX8@ZG6bts8)iinr8Vf#q7O>Ai
z@o4Wk9y>>3=gtA{k=l2j>+?jPKM(lPAkp?;;Q9j57cKziOC7k#^+lpDUIc8AI(Uie
zOGIC~1eoz}<0JvwWv(w1efctAh1B+XuIq`euLo=~*jRADaYfUZIoMe6l`DYX3>J@0
zxyoZ#N$l!Xz*ADEUgP>2(buj4y8k2EY1g^FPW1KbfODiyzrpnlqHo*)Y?9h}lk1yA
z-@FOf;~Q}j*DbDZ5q;|xV2#x7+g#r!`u1(W)<eXCJ$E#Xy@nVIzH<j~^bqlA?_D0d
zOJaBL0^XF`caQ6PMBlpy_~&m$+uy)-1JMl)fMrq#?sI*g===8pWBx1J!A7ndiEeBJ
z{95Rs?E%*hh<@+@uuf|GL#`hZ{qP}R%1~p$LB}Ia<Dj9&f*(BsoHo=rXfWk5k3A-_
z$BzM@OP%_J>nB7%c>>t^f1;iCl<TKNKYa>VEp_@cuAdS8>>1$u--)*KIoHpLe*PSA
zgw(DVT)!at#S6fCsogKReo6Gpmw>)uV!@tQn#Lc884G^(3UJXdaZvAT9(zq<uU`X3
zd@r=`4cBjoe)9$}TWWt3*G)t>H31%wI`Ee3w?w~v3;5gNokM>L!Mx$0;qrDCd^Ef}
z#%5UX(-GYv6stz`foAyr55KW=9qA8OKSN_tMpCBoO*$#|=Z~?<s7G5w#Ye`6gfs``
zySDOV^{RZd4gAFhKINZ!SA36*4p~;8`mZ_k%kFPvu`naKy*12S4Kr86jH-I2Rpl;H
z4I|Zb^|0-&;pS|(IU8<d)ho>^cady3$vX9HggF~w&PEtn^-8nKT_hVpvMx27XtkKL
z7Uc_OW^!B0I~hfhjD=*}dM47GiBvvqwoh&w`A$YrBoj$89{nYw%$X?jOGX(lsb1+z
zDtD1=6v=w^tks;gnzL3Tt6phVxr=12B<s_&(dKNlIU8+c)ho>^cadx~$@=wdj5!-)
z&c+y7^-8nKT_hVrvH?9CYtF`+v#~~2z0$057s<wwY*5d}nX_@`Y@Cr*uQaRNMY3@}
zXYDpMn`n(UXXBL*zgfv`<KM|Bie%zR#;#`)%$Wq`i*U!}wh8ZK6h$%#B;!ysL2IHp
ZlW2a)MB^pZD}71jE|N{G^!-rU?ElXEg<t>x
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 0f95d1344b2c..dfb8523c8bf4 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,3 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/APIC.core-count2",
-"tests/data/acpi/q35/DSDT.core-count2",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 11/16] tests: bios-tables-test: Prepare the ACPI table change for type4 thread count test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (9 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 10/16] tests: bios-tables-test: Update ACPI table binaries for core count2 test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 12/16] tests: bios-tables-test: Add test for smbios type4 thread count Zhao Liu
` (5 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 1 - 3.
List the ACPI tables that will be added to test the thread count field
of smbios type4 table.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.thread-count | 0
tests/data/acpi/q35/DSDT.thread-count | 0
tests/data/acpi/q35/FACP.thread-count | 0
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
4 files changed, 3 insertions(+)
create mode 100644 tests/data/acpi/q35/APIC.thread-count
create mode 100644 tests/data/acpi/q35/DSDT.thread-count
create mode 100644 tests/data/acpi/q35/FACP.thread-count
diff --git a/tests/data/acpi/q35/APIC.thread-count b/tests/data/acpi/q35/APIC.thread-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/DSDT.thread-count b/tests/data/acpi/q35/DSDT.thread-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/FACP.thread-count b/tests/data/acpi/q35/FACP.thread-count
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..4d139d7f6b7e 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/APIC.thread-count",
+"tests/data/acpi/q35/DSDT.thread-count",
+"tests/data/acpi/q35/FACP.thread-count",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 12/16] tests: bios-tables-test: Add test for smbios type4 thread count
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (10 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 11/16] tests: bios-tables-test: Prepare the ACPI table change for type4 thread count test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 13:19 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 13/16] tests: bios-tables-test: Add ACPI table binaries for type4 thread count test Zhao Liu
` (4 subsequent siblings)
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
type4").
Add this test to cover 2 cases:
1. Test thread count field with multiple sockets and multiple dies to
confirm this field could correctly calculate threads per sockets.
2. Confirm that field calculation could correctly recognize the
difference between "-smp maxcpus" and "-smp cpus".
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 8cba1d8126f2..26474d376633 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -95,6 +95,7 @@ typedef struct {
uint16_t smbios_cpu_curr_speed;
uint8_t smbios_core_count;
uint16_t smbios_core_count2;
+ uint8_t smbios_thread_count;
uint8_t *required_struct_types;
int required_struct_types_len;
int type4_count;
@@ -640,6 +641,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
SmbiosEntryPointType ep_type)
{
uint8_t core_count, expected_core_count = data->smbios_core_count;
+ uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
uint16_t speed, expected_speed[2];
uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
int offset[2];
@@ -663,6 +665,13 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
g_assert_cmpuint(core_count, ==, expected_core_count);
}
+ thread_count = qtest_readb(data->qts,
+ addr + offsetof(struct smbios_type_4, thread_count));
+
+ if (expected_thread_count) {
+ g_assert_cmpuint(thread_count, ==, expected_thread_count);
+ }
+
if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
core_count2 = qtest_readw(data->qts,
addr + offsetof(struct smbios_type_4, core_count2));
@@ -1033,6 +1042,22 @@ static void test_acpi_q35_tcg_core_count2(void)
free_test_data(&data);
}
+static void test_acpi_q35_tcg_thread_count(void)
+{
+ test_data data = {
+ .machine = MACHINE_Q35,
+ .variant = ".thread-count",
+ .required_struct_types = base_required_struct_types,
+ .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
+ .smbios_thread_count = 27,
+ };
+
+ test_acpi_one("-machine smbios-entry-point-type=64 "
+ "-smp cpus=15,maxcpus=54,sockets=2,dies=3,cores=3,threads=3",
+ &data);
+ free_test_data(&data);
+}
+
static void test_acpi_q35_tcg_bridge(void)
{
test_data data = {};
@@ -2189,6 +2214,8 @@ int main(int argc, char *argv[])
test_acpi_q35_tcg_core_count);
qtest_add_func("acpi/q35/core-count2",
test_acpi_q35_tcg_core_count2);
+ qtest_add_func("acpi/q35/thread-count",
+ test_acpi_q35_tcg_thread_count);
}
qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
#ifdef CONFIG_POSIX
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 12/16] tests: bios-tables-test: Add test for smbios type4 thread count
2023-08-25 3:36 ` [PATCH 12/16] tests: bios-tables-test: Add test for smbios type4 thread count Zhao Liu
@ 2023-09-15 13:19 ` Igor Mammedov
2023-09-19 7:13 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 13:19 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:15 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
> type4").
>
> Add this test to cover 2 cases:
> 1. Test thread count field with multiple sockets and multiple dies to
> confirm this field could correctly calculate threads per sockets.
>
> 2. Confirm that field calculation could correctly recognize the
> difference between "-smp maxcpus" and "-smp cpus".
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Acked-by: Igor Mammedov <imammedo@redhat.com>
PS:
add to commit message an explanation how -smp maps into
smbios_thread_count
> ---
> tests/qtest/bios-tables-test.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 8cba1d8126f2..26474d376633 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -95,6 +95,7 @@ typedef struct {
> uint16_t smbios_cpu_curr_speed;
> uint8_t smbios_core_count;
> uint16_t smbios_core_count2;
> + uint8_t smbios_thread_count;
> uint8_t *required_struct_types;
> int required_struct_types_len;
> int type4_count;
> @@ -640,6 +641,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> SmbiosEntryPointType ep_type)
> {
> uint8_t core_count, expected_core_count = data->smbios_core_count;
> + uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
> uint16_t speed, expected_speed[2];
> uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
> int offset[2];
> @@ -663,6 +665,13 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> g_assert_cmpuint(core_count, ==, expected_core_count);
> }
>
> + thread_count = qtest_readb(data->qts,
> + addr + offsetof(struct smbios_type_4, thread_count));
> +
> + if (expected_thread_count) {
> + g_assert_cmpuint(thread_count, ==, expected_thread_count);
> + }
> +
> if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
> core_count2 = qtest_readw(data->qts,
> addr + offsetof(struct smbios_type_4, core_count2));
> @@ -1033,6 +1042,22 @@ static void test_acpi_q35_tcg_core_count2(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_q35_tcg_thread_count(void)
> +{
> + test_data data = {
> + .machine = MACHINE_Q35,
> + .variant = ".thread-count",
> + .required_struct_types = base_required_struct_types,
> + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> + .smbios_thread_count = 27,
> + };
> +
> + test_acpi_one("-machine smbios-entry-point-type=64 "
> + "-smp cpus=15,maxcpus=54,sockets=2,dies=3,cores=3,threads=3",
> + &data);
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg_bridge(void)
> {
> test_data data = {};
> @@ -2189,6 +2214,8 @@ int main(int argc, char *argv[])
> test_acpi_q35_tcg_core_count);
> qtest_add_func("acpi/q35/core-count2",
> test_acpi_q35_tcg_core_count2);
> + qtest_add_func("acpi/q35/thread-count",
> + test_acpi_q35_tcg_thread_count);
> }
> qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
> #ifdef CONFIG_POSIX
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 12/16] tests: bios-tables-test: Add test for smbios type4 thread count
2023-09-15 13:19 ` Igor Mammedov
@ 2023-09-19 7:13 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:13 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, Sep 15, 2023 at 03:19:02PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 15:19:02 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 12/16] tests: bios-tables-test: Add test for smbios
> type4 thread count
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:15 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
> > type4").
> >
> > Add this test to cover 2 cases:
> > 1. Test thread count field with multiple sockets and multiple dies to
> > confirm this field could correctly calculate threads per sockets.
> >
> > 2. Confirm that field calculation could correctly recognize the
> > difference between "-smp maxcpus" and "-smp cpus".
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>
> Acked-by: Igor Mammedov <imammedo@redhat.com>
Thanks!
>
> PS:
> add to commit message an explanation how -smp maps into
> smbios_thread_count
Ok.
-Zhao
>
> > ---
> > tests/qtest/bios-tables-test.c | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index 8cba1d8126f2..26474d376633 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -95,6 +95,7 @@ typedef struct {
> > uint16_t smbios_cpu_curr_speed;
> > uint8_t smbios_core_count;
> > uint16_t smbios_core_count2;
> > + uint8_t smbios_thread_count;
> > uint8_t *required_struct_types;
> > int required_struct_types_len;
> > int type4_count;
> > @@ -640,6 +641,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > SmbiosEntryPointType ep_type)
> > {
> > uint8_t core_count, expected_core_count = data->smbios_core_count;
> > + uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
> > uint16_t speed, expected_speed[2];
> > uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
> > int offset[2];
> > @@ -663,6 +665,13 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > g_assert_cmpuint(core_count, ==, expected_core_count);
> > }
> >
> > + thread_count = qtest_readb(data->qts,
> > + addr + offsetof(struct smbios_type_4, thread_count));
> > +
> > + if (expected_thread_count) {
> > + g_assert_cmpuint(thread_count, ==, expected_thread_count);
> > + }
> > +
> > if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
> > core_count2 = qtest_readw(data->qts,
> > addr + offsetof(struct smbios_type_4, core_count2));
> > @@ -1033,6 +1042,22 @@ static void test_acpi_q35_tcg_core_count2(void)
> > free_test_data(&data);
> > }
> >
> > +static void test_acpi_q35_tcg_thread_count(void)
> > +{
> > + test_data data = {
> > + .machine = MACHINE_Q35,
> > + .variant = ".thread-count",
> > + .required_struct_types = base_required_struct_types,
> > + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > + .smbios_thread_count = 27,
> > + };
> > +
> > + test_acpi_one("-machine smbios-entry-point-type=64 "
> > + "-smp cpus=15,maxcpus=54,sockets=2,dies=3,cores=3,threads=3",
> > + &data);
> > + free_test_data(&data);
> > +}
> > +
> > static void test_acpi_q35_tcg_bridge(void)
> > {
> > test_data data = {};
> > @@ -2189,6 +2214,8 @@ int main(int argc, char *argv[])
> > test_acpi_q35_tcg_core_count);
> > qtest_add_func("acpi/q35/core-count2",
> > test_acpi_q35_tcg_core_count2);
> > + qtest_add_func("acpi/q35/thread-count",
> > + test_acpi_q35_tcg_thread_count);
> > }
> > qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
> > #ifdef CONFIG_POSIX
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 13/16] tests: bios-tables-test: Add ACPI table binaries for type4 thread count test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (11 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 12/16] tests: bios-tables-test: Add test for smbios type4 thread count Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 14/16] tests: bios-tables-test: Prepare the ACPI table change for type4 thread count2 test Zhao Liu
` (3 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 5 and 6.
Changes in the tables:
FACP:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-1NP791, Wed Aug 23 21:51:31 2023
+ *
+ * ACPI Data Table [FACP]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
+[004h 0004 4] Table Length : 000000F4
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : B3
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] FACS Address : 00000000
+[028h 0040 4] DSDT Address : 00000000
+[02Ch 0044 1] Model : 01
+[02Dh 0045 1] PM Profile : 00 [Unspecified]
+[02Eh 0046 2] SCI Interrupt : 0009
+[030h 0048 4] SMI Command Port : 000000B2
+[034h 0052 1] ACPI Enable Value : 02
+[035h 0053 1] ACPI Disable Value : 03
+[036h 0054 1] S4BIOS Command : 00
+[037h 0055 1] P-State Control : 00
+[038h 0056 4] PM1A Event Block Address : 00000600
+[03Ch 0060 4] PM1B Event Block Address : 00000000
+[040h 0064 4] PM1A Control Block Address : 00000604
+[044h 0068 4] PM1B Control Block Address : 00000000
+[048h 0072 4] PM2 Control Block Address : 00000000
+[04Ch 0076 4] PM Timer Block Address : 00000608
+[050h 0080 4] GPE0 Block Address : 00000620
+[054h 0084 4] GPE1 Block Address : 00000000
+[058h 0088 1] PM1 Event Block Length : 04
+[059h 0089 1] PM1 Control Block Length : 02
+[05Ah 0090 1] PM2 Control Block Length : 00
+[05Bh 0091 1] PM Timer Block Length : 04
+[05Ch 0092 1] GPE0 Block Length : 10
+[05Dh 0093 1] GPE1 Block Length : 00
+[05Eh 0094 1] GPE1 Base Offset : 00
+[05Fh 0095 1] _CST Support : 00
+[060h 0096 2] C2 Latency : 0FFF
+[062h 0098 2] C3 Latency : 0FFF
+[064h 0100 2] CPU Cache Size : 0000
+[066h 0102 2] Cache Flush Stride : 0000
+[068h 0104 1] Duty Cycle Offset : 00
+[069h 0105 1] Duty Cycle Width : 00
+[06Ah 0106 1] RTC Day Alarm Index : 00
+[06Bh 0107 1] RTC Month Alarm Index : 00
+[06Ch 0108 1] RTC Century Index : 32
+[06Dh 0109 2] Boot Flags (decoded below) : 0002
+ Legacy Devices Supported (V2) : 0
+ 8042 Present on ports 60/64 (V2) : 1
+ VGA Not Present (V4) : 0
+ MSI Not Supported (V4) : 0
+ PCIe ASPM Not Supported (V4) : 0
+ CMOS RTC Not Present (V5) : 0
+[06Fh 0111 1] Reserved : 00
+[070h 0112 4] Flags (decoded below) : 000484A5
+ WBINVD instruction is operational (V1) : 1
+ WBINVD flushes all caches (V1) : 0
+ All CPUs support C1 (V1) : 1
+ C2 works on MP system (V1) : 0
+ Control Method Power Button (V1) : 0
+ Control Method Sleep Button (V1) : 1
+ RTC wake not in fixed reg space (V1) : 0
+ RTC can wake system from S4 (V1) : 1
+ 32-bit PM Timer (V1) : 0
+ Docking Supported (V1) : 0
+ Reset Register Supported (V2) : 1
+ Sealed Case (V3) : 0
+ Headless - No Video (V3) : 0
+ Use native instr after SLP_TYPx (V3) : 0
+ PCIEXP_WAK Bits Supported (V4) : 0
+ Use Platform Timer (V4) : 1
+ RTC_STS valid on S4 wake (V4) : 0
+ Remote Power-on capable (V4) : 0
+ Use APIC Cluster Model (V4) : 1
+ Use APIC Physical Destination Mode (V4) : 0
+ Hardware Reduced (V5) : 0
+ Low Power S0 Idle (V5) : 0
+
+[074h 0116 12] Reset Register : [Generic Address Structure]
+[074h 0116 1] Space ID : 01 [SystemIO]
+[075h 0117 1] Bit Width : 08
+[076h 0118 1] Bit Offset : 00
+[077h 0119 1] Encoded Access Width : 00 [Undefined/Legacy]
+[078h 0120 8] Address : 0000000000000CF9
+
+[080h 0128 1] Value to cause reset : 0F
+[081h 0129 2] ARM Flags (decoded below) : 0000
+ PSCI Compliant : 0
+ Must use HVC for PSCI : 0
+
+[083h 0131 1] FADT Minor Revision : 00
+[084h 0132 8] FACS Address : 0000000000000000
+[08Ch 0140 8] DSDT Address : 0000000000000000
+[094h 0148 12] PM1A Event Block : [Generic Address Structure]
+[094h 0148 1] Space ID : 01 [SystemIO]
+[095h 0149 1] Bit Width : 20
+[096h 0150 1] Bit Offset : 00
+[097h 0151 1] Encoded Access Width : 00 [Undefined/Legacy]
+[098h 0152 8] Address : 0000000000000600
+
+[0A0h 0160 12] PM1B Event Block : [Generic Address Structure]
+[0A0h 0160 1] Space ID : 00 [SystemMemory]
+[0A1h 0161 1] Bit Width : 00
+[0A2h 0162 1] Bit Offset : 00
+[0A3h 0163 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0A4h 0164 8] Address : 0000000000000000
+
+[0ACh 0172 12] PM1A Control Block : [Generic Address Structure]
+[0ACh 0172 1] Space ID : 01 [SystemIO]
+[0ADh 0173 1] Bit Width : 10
+[0AEh 0174 1] Bit Offset : 00
+[0AFh 0175 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0B0h 0176 8] Address : 0000000000000604
+
+[0B8h 0184 12] PM1B Control Block : [Generic Address Structure]
+[0B8h 0184 1] Space ID : 00 [SystemMemory]
+[0B9h 0185 1] Bit Width : 00
+[0BAh 0186 1] Bit Offset : 00
+[0BBh 0187 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0BCh 0188 8] Address : 0000000000000000
+
+[0C4h 0196 12] PM2 Control Block : [Generic Address Structure]
+[0C4h 0196 1] Space ID : 00 [SystemMemory]
+[0C5h 0197 1] Bit Width : 00
+[0C6h 0198 1] Bit Offset : 00
+[0C7h 0199 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0C8h 0200 8] Address : 0000000000000000
+
+[0D0h 0208 12] PM Timer Block : [Generic Address Structure]
+[0D0h 0208 1] Space ID : 01 [SystemIO]
+[0D1h 0209 1] Bit Width : 20
+[0D2h 0210 1] Bit Offset : 00
+[0D3h 0211 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0D4h 0212 8] Address : 0000000000000608
+
+[0DCh 0220 12] GPE0 Block : [Generic Address Structure]
+[0DCh 0220 1] Space ID : 01 [SystemIO]
+[0DDh 0221 1] Bit Width : 80
+[0DEh 0222 1] Bit Offset : 00
+[0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0E0h 0224 8] Address : 0000000000000620
+
+[0E8h 0232 12] GPE1 Block : [Generic Address Structure]
+[0E8h 0232 1] Space ID : 00 [SystemMemory]
+[0E9h 0233 1] Bit Width : 00
+[0EAh 0234 1] Bit Offset : 00
+[0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0ECh 0236 8] Address : 0000000000000000
...
APIC:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-2JP791, Wed Aug 23 21:51:31 2023
+ *
+ * ACPI Data Table [APIC]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
+[004h 0004 4] Table Length : 00000220
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : 63
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] Local Apic Address : FEE00000
+[028h 0040 4] Flags (decoded below) : 00000001
+ PC-AT Compatibility : 1
+
+[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
+[02Dh 0045 1] Length : 08
+[02Eh 0046 1] Processor ID : 00
+[02Fh 0047 1] Local Apic ID : 00
+[030h 0048 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
+
+[034h 0052 1] Subtable Type : 00 [Processor Local APIC]
+[035h 0053 1] Length : 08
+[036h 0054 1] Processor ID : 01
+[037h 0055 1] Local Apic ID : 01
+[038h 0056 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
[snip]
+[1D4h 0468 1] Subtable Type : 00 [Processor Local APIC]
+[1D5h 0469 1] Length : 08
+[1D6h 0470 1] Processor ID : 35
+[1D7h 0471 1] Local Apic ID : 6A
+[1D8h 0472 4] Flags (decoded below) : 00000000
+ Processor Enabled : 0
+ Runtime Online Capable : 0
+
+[1DCh 0476 1] Subtable Type : 01 [I/O APIC]
+[1DDh 0477 1] Length : 0C
+[1DEh 0478 1] I/O Apic ID : 00
+[1DFh 0479 1] Reserved : 00
+[1E0h 0480 4] Address : FEC00000
+[1E4h 0484 4] Interrupt : 00000000
+
+[1E8h 0488 1] Subtable Type : 02 [Interrupt Source Override]
+[1E9h 0489 1] Length : 0A
+[1EAh 0490 1] Bus : 00
+[1EBh 0491 1] Source : 00
+[1ECh 0492 4] Interrupt : 00000002
+[1F0h 0496 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+
+[1F2h 0498 1] Subtable Type : 02 [Interrupt Source Override]
+[1F3h 0499 1] Length : 0A
+[1F4h 0500 1] Bus : 00
+[1F5h 0501 1] Source : 05
+[1F6h 0502 4] Interrupt : 00000005
+[1FAh 0506 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[1FCh 0508 1] Subtable Type : 02 [Interrupt Source Override]
+[1FDh 0509 1] Length : 0A
+[1FEh 0510 1] Bus : 00
+[1FFh 0511 1] Source : 09
+[200h 0512 4] Interrupt : 00000009
+[204h 0516 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[206h 0518 1] Subtable Type : 02 [Interrupt Source Override]
+[207h 0519 1] Length : 0A
+[208h 0520 1] Bus : 00
+[209h 0521 1] Source : 0A
+[20Ah 0522 4] Interrupt : 0000000A
+[20Eh 0526 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[210h 0528 1] Subtable Type : 02 [Interrupt Source Override]
+[211h 0529 1] Length : 0A
+[212h 0530 1] Bus : 00
+[213h 0531 1] Source : 0B
+[214h 0532 4] Interrupt : 0000000B
+[218h 0536 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[21Ah 0538 1] Subtable Type : 04 [Local APIC NMI]
+[21Bh 0539 1] Length : 06
+[21Ch 0540 1] Processor ID : FF
+[21Dh 0541 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+[21Fh 0543 1] Interrupt Input LINT : 01
...
DSDT:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembling to symbolic ASL+ operators
+ *
+ * Disassembly of /tmp/aml-00O791, Wed Aug 23 21:51:31 2023
+ *
+ * Original Table Header:
+ * Signature "DSDT"
+ * Length 0x00003271 (12913)
+ * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
+ * Checksum 0xAF
+ * OEM ID "BOCHS "
+ * OEM Table ID "BXPC "
+ * OEM Revision 0x00000001 (1)
+ * Compiler ID "BXPC"
+ * Compiler Version 0x00000001 (1)
+ */
+DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
+{
+ Scope (\)
+ {
+ OperationRegion (DBG, SystemIO, 0x0402, One)
+ Field (DBG, ByteAcc, NoLock, Preserve)
+ {
+ DBGB, 8
+ }
+
+ Method (DBUG, 1, NotSerialized)
+ {
+ ToHexString (Arg0, Local0)
+ ToBuffer (Local0, Local0)
+ Local1 = (SizeOf (Local0) - One)
+ Local2 = Zero
+ While ((Local2 < Local1))
+ {
+ DBGB = DerefOf (Local0 [Local2])
+ Local2++
+ }
+
+ DBGB = 0x0A
+ }
+ }
[snip]
+ Processor (C000, 0x00, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (Zero))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (Zero, Arg0, Arg1, Arg2)
+ }
+ }
+
+ Processor (C001, 0x01, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (One))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (One)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (One, Arg0, Arg1, Arg2)
+ }
+ }
[snip]
+ Processor (C035, 0x35, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (0x35))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x35, 0x6A, 0x01, 0x00, 0x00, 0x00 // ..5j....
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (0x35)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (0x35, Arg0, Arg1, Arg2)
+ }
+ }
...
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.thread-count | Bin 0 -> 544 bytes
tests/data/acpi/q35/DSDT.thread-count | Bin 0 -> 12913 bytes
tests/data/acpi/q35/FACP.thread-count | Bin 0 -> 244 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
4 files changed, 3 deletions(-)
diff --git a/tests/data/acpi/q35/APIC.thread-count b/tests/data/acpi/q35/APIC.thread-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..c27e87fcf1c04a2e75f9a20f2bc6a28f19aadf66 100644
GIT binary patch
literal 544
zcmXxe*-pYh7(n4^X=@iyb^*5m0Ri{zURpKajdcxrrJx3VN*;wLL1%j6B=dhKlgVWI
z@i3C65UELc8x0<0IEo{wmLY`DtrcRvNOXlj!$8x-l!ca!wu6p~OCGvDdRg>y800Zs
z#7qg7%eYcWzTsx8n5$u4Vxf-329}ywZsBShD;=zMvDU-23taExMu?l2xOIi{8tVgW
z3~~Dgn=!WTuzim^kJx#_?lbmAxch>8uekq)2k&?|#-k5B{=}0nJe}g%H=h4!jkKP#
eg`TFbwhmpkt<321y#Mmm1<ryXDa-j)Py7K+#~uLy
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.thread-count b/tests/data/acpi/q35/DSDT.thread-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..a24b04cbdbf09383b933a42a2a15182545543a87 100644
GIT binary patch
literal 12913
zcmb80O>A4)b;s}HheSP+5=BwpvPH|1Eq{unB-_)XMaV}|k}b+KDbGww1EeHRDtQ8g
z&5VIK0|T}ONG1jfbVi+^OU*z5x=UBx)<8GyZgw4@t1i09HVEQXl>fQ+J-&1AlY!U^
z>YT@Oe&?J=^8I=5qsz_m_CFMauzp**@2oeor4Q>)7XK_E1ljaAwGnwFS})3_wYC)x
zMXc7#xU}(5ie;{sOAptqf7$Q+y3_gemmO=TD|Ww4eZ9NW{rrp0uArc&yItERBXw`2
z-7K|RhZ{q6XCoJDuWytS#qaD`tnDZ(9BV(^D2vQyfBSyZiM;w)IOPxW$6L{({oxTi
z)vEpP@*ihse(>uLJ}tifoB#RItB>sn0t)yW!{6mDJ#;?n*ylUPsjrR>tml+2pUWSQ
ze03zBR>xBGOt(WvzDcM<gvy_MoVgdRl$*8W@vWmLqB|V6MCW+wE7ibvxBvV9o2x&s
zeL4QS+T?#awUf?q|JMh0=%mxNUw+XM0taS}p4k1}bTlNAqJy*WV<C3BJL<{S;hl1$
z=*Y>F^{sl&$>jy6Z#0Kz?U`SW3z48xPXGSx^z`&UlqpirL~1j0lTIF;xYmoh)7-Y=
zuM>8x^)f|{gX0ggcqnIEFPfFRc&Yv?VMp*<k>iwdmAiPNv{h?Z@$Xa`IZkQoVJ%zV
zD1Vr3S*1<qp2#fJoyy%%>mqrlr`>&u=svR!1Tk8d>F|ljTq`2ytSDl2>7nDsb~2@b
zx;&rdzIQsIIBQfyo<KZUVizyN^P^pHw41=WITg=$texjO&n&y&Kf%Wf+SxY%-CgxE
z#OfPPRb&!v{I$CK<fRVZx9I$)oZrd!X1%dpPv86GMLHgdqt@ouy^2t_1-mNJ2|8|v
z;H-I07|yy#CnM+&FQbZcJ<3Ahpn6W`A=Gmz6MPvPl9`BgJ<9Y#LqcXERA$1ZOmrh-
z!!pzBAS@`;3k|DGgvv~~l<8H8$V{(;h|KgtBP!Et9xk6Vs?8adnO<mAWqQrS<#YCF
zbN0zhFSJje6E2^#Uz@XEo3me^6E2@Krp+1C=8Wlc!sT-gXmbu|a}MZp!sT<?+MKpF
zr>)Nkm(Lm3=8S7|#`QVj@;MXQoC$5tggz%+K4(&!GpWs))aQiD=N#1L9Mt9<)aQiD
z=N!`J9Ma|-(&vQB=S*pHrnEUz`kZk2oWt6j!`hs~`kZk2oM~;&v^Hm2pA#;hb3~hS
zM4NL&pA#;hGo#I!(dNwPbHe3wj%ss`YIBb2bHe3wj%jm_X>*S0bHe3wLdMiJOJ0@6
zwK>Q2IpOj-C$u>yv^gjAIpOj-CuL^Qy%J8!%#wStn^c*O?^0&jjh)gmr?ku|Jrgd^
zoYpd@wajTf6E4r3(K2VW%o#lsF3&utWuDVA&*_<PdFFYU>0RT`%S`VYe_myJ7jC$e
z=_$#qR&!RXIjh%%t7^s|phYI2Yt0RmmSSqbMqyV#;h?N?!f?Ez5Kt8--$a(6EU!Nc
zMOA1|K;e3$K|ockC!j2p1XP9g1Qag1@dQ-Gx*pX8)l*E$^v)OwC|q<TV<Dg_*7e*O
zWhM!z3iVt*Cj?YsWhMlag_3~6^;D4r6s|WX1XRV!Ob93oB>`2TvL*>ATyIVYsEU=D
z5KtCM0;)n~CJ889Z%zoPij|oVP!>u8szPNZ2`F6e^@M<`SeXd{WuYXXDpY2YfWr0W
zgn+78nF#@9p(LOxRA!QZ!u95afT~!T2?1rHB%mr(W|Dxy_2z_ts#uu`0cD{ipej^m
zl7PbX=7fN%SeXd{WuYXXDpY2YfWr0Wgn+78nF#@9p(LOxRA!QZ!u95afT~!T2?1rH
zB%mr(W|Dxy_2z_ts#uu`0cD{ipej^ml7PbX=7fN%SeXd{WuYXXDpY2YfWr0Wgn+78
znF#@9p(LOxRA!QZ!u95afT~!T2?1rHB%mr(W|Dxy_2z_ts#uu`0cD{ipej^ml7PbX
z=7fN%SeXd{WuYXXDpY2YfWr0Wgn+78nF#@9p(LOxRA!QZ!u95afT~!T2?1rHB%mr(
zW|Dxy_2z_ts#uu`0cD{ipej^ml7PbX=7fO4V*(0~3n*MJpm3RhvP=jl%OnA1nIxbr
z69URIA)qXi1e9fxfU-;oD9eO^vP=?CmPrE2G9jQW69URINkCa92`I~ifWq@$T?i;V
zykhcXl7Pa+%iy_`>782$C_L}nLO|hp=avK%u6J%pK;dE!WU37b6~~DqxmZ1+1?e|^
z^rx5^*?55U|M9?Q_KSUSVh^0y@yyD`1E(<n*=^*82krQ;`ow_TN_Zw-(J?!U$Bpi1
z`}U9^3!p}>b-39NoiBPjF^M6y{}My#=J1$3@~c5H5QahtT!RI!rsA2%47HovMR7tc
z)Ef_qnc;SMqbZ(~ZNHF5hG;{BBAkZw$J@<D(|Wb<_CV$7xLdtsRJY!tdWlsp$?7Ha
z$E%kzXIC$^4r?^K+Ka(1lsmf}dWZ53EAPnij#1uuOL@mFUp9ufu><xOpZhW^UzX*|
zM)~qv%9q{p6|;Qg9m-c&`HC!GG0IooQoiDrubSnf?@+$V%2#Fis!_iBmhx4%{F+(5
z?;XmovGQxO{F+gI?Jeck-16&Y`Tln(zs}09%kt|+`SrJyUq|@}U5?E1DOKLPc;Kr6
zKJIFBQa_gIlOK8fq0hC8Ge5@mu#Us`g#b<+I};c9T&8s#zC;9Y>e!jMz~^j4$Kjhr
z0H=<fi3@ygGCB@lHv%|y>`YwXb1<so@Es(8Q^(H41>V<VIu2h<0yuT-OkCi7I<DjJ
zZ6$zH$8=n(7E{~*mDqZ{vhBV7EL`$v)4%m%y}n%&_~!lHpW*^r*D3Nx-mh$xv-L)~
zoz2{m%G0GIoh}{P`FY1qb&eBX9(BY~2m7%n;&|}OqaE?jI|=cBe~6wy93g46y*_LY
z{sK!7f(tCxu%Vu5uhrG-m@GQ=ja)8wOQim>C3k^ahwJvErLec*UT;*IUb{9f5@<K+
z)E{QofAVSf$4~!0`_qp;`N`9t?tS!$Xjx8u^Pc;uN!s?B^?l;|gq3)P@o-(orv3K`
zJJEW%NKR2?oqA=<ayGV_meZ)cZ(-{_M-Np?gdL|=#`b=iBEwFzvYADAxwxIhzV*h|
zMyxC7VC(Qz-FhT%4WJ{{r8`ePM}4RpE744C(b=y4Fm!Am?TcSHnD&57i_HANar|iC
z4v}3@c9`sCWk<+fQFfH<Rb}^)eM{N>WZzbHjO;tg9w7TYW!q#Il^rL$r0fLQj<S<v
zmz6z8c177kWLK4)f}KbE)blXeZvSbr-Tp_&cKgqe?e;%Pw%h+0*>3;iWV`)OknQ$A
zNw(Yn6xnY7(`38-&yel*e~xUo|MO(K{m+u^_Me4aaQnYNw%h+4*>3+A$#(mnC)@3R
zfo!+`OJuwKUnbk_f01mr|0`s>{a+>9?f)9tZvWTGcKg3Uw%h+rvfcid$aeeB!CrRz
z&y(%;Um)A<f0=Bz{}r;`{#VIfJ;<#0;igq_pmp)lQiOlX=+i@Yoy@~{r+4W-+>!YN
zeSW(35bibwp4q&2(#h1K^qG3MLY9dF;Y@yJZOmypTd}u{5p%XGAEZO4U9s1-9)DX&
zA3e6Z;&IpNbj8lMwZuOib*!)V>|2<uyJyyv6PpKdNjM(=+B}Mj!rpI=2aa~^Q`GrQ
z_pIlS=L4sXt~%YlFQ~~K@pK1meRKPGH4rAROSp9G+2L;B%-~7nJ>8?bzLki&?MuL2
zu}7DiJrro=&mJzoLO)M;&pyw!0q1^mJMotDeD>QVz{kn!9-MJ*x^~DsN}*58gE-A+
zcGvp+4lYhP5*I-?74gQ7ozUAGm)}}(dpK^#1oq8nHI^B~eeLZy4I}msp0qx%M39=7
z3pFhji=bYrWy#cd+ZBhL#W0q{tP`eyjZdnP^gE!{Opg-^Nlv22u|xRE==EcVe9|)R
zB$_0sbdMB{n4~Z#g?-WrwALhHjnN}Tq9!TANfDp4O3P4VIxH7@q-dW>igHraC*8uv
zsY!yU_egy)lhnsaeLm?nHd0LzzQp%P{c;J8w}kh~+5Mc<@00G}4Puh;vxpukW}7|5
zI4S0n-jm;Q^moAkBMqcX(f}t7_@p8&`i(PgGm<@Ql59@0eNu_G4h&M9k>Y8S6z8P4
zPjc|}&?F@oDUmTr2~JA*q%t;YO;VDPlA|Um$w^6{RKdorNg8CN!7-CG$Vr1fsfvwU
zlZ5ZDy?4RTgh?9Wq@f-upQF{AamKN}>yc8ECMm^9DW8<5MVdjv(ym7uo-#?poHXo{
z3bZ~mNLbbNNNM@ABmQYgb5hzTEz{D>AYnn*BaK`zdm7=S5uda|t1^RxwOo&snKMZl
zPRjVCRa%f4BrM~4q|tekG|EY%KIs;%#S9Wwa6Qu4f=L?Vq%og#o0ee)35&NLY5bB&
z8t0^OpL7Qs%O+`pktP;R(gY_>_@wu+(QJ|?8ENv0Nt)!ONuN~2om-PM#Yj_EP0|!6
zP5Gn}Hlj_^G$T#_z$8s`(zH)<urY0tW*BLvXp&|)X~rj&u~BW3&N0%tl1VzpN#}f0
z1sm5U={zHyFPo(EoOIqNRk4w6l4cocwqlZIIcc^>D&(?3QkIdjSOMdW%ak+ANm-wi
zzYru{V5AG{Cg}nvUGPbTxgcqdk>)l`(i|tv`K0BGLDEG=x_H+lUF4*TK51n>NSbG)
z`MOD(=cIX`w7L)^Eilr;1CzACNee#d)}<in5+hw|n50Xbbjc^(z8oZ7W~9s8Ch0OK
zUG_<L7K5ZkMp}Gmk`_5>(I>rkB}lr$NLSuBNmn@OicczD4U(=h($x=5(p65n>XS;>
zf~0GVbnS;G=^7_p^GVM2An7_IUH?0ibe)r~`=s)XAn67p-RPL48=Q2*Csl3+NjDkk
z=8j3a$w@bTQgtavT4JQ7U6ZuLNlQJ_vb&tq)>8Pva!)yPk4;jJlX5;OpAYtwXQcc`
zCMnNJd7o4$1W5%(D*VVK6*#Hjla`l*q-920-Zx3hoV4tdR#t+f6-HV)Fi9(%wBnOi
zSA(QgMp}Jhl2$os6{O5GHbSwf+pgpa!ri{5O;OsTN!3QxE~)%=uiO&88@K=ci=+st
zCB-R~x7MsTi8l!=hT~R3u7dxFr{5%ceiA<h7UK8vr`l?jjC-S}r)q&CL`Y~q;*Q~W
z%D<I!3GuJmGq3UM?mww#UjOYYe7;pRH&$*I(2tzevd}v!XdeN4*R4Y*f;rVM=;iOo
zi`cwY`_gorZAfFweY<F5u|=EUazi@Xm+iCgi}Kdt-AH}C-jEyH1_USRjLq#J>viIF
z!kWNl`jtm0-&}5|`y#Yk0ehvLjz#Q{jZF!7tMm+wk@{=@WoRAVtbX9An;*#smD)q>
zq7*3F=r|QkMQIB?RhfPyf1_QSqF1qX7;ols?O3~5ZeW_L&D<U3;1#n3zQs55Wr5$S
z!zg&hG8vdW)2#Zzv$Q$C(RdKDJ9Z-FL}ZcH%fDI*QyGe+XDzyCjr;2lO7!5+LpdgJ
zYvMtL>?%F1(ZhPIb+~e`R7NxEKRAT3cS19{w<0F&(KV|hI>N%+?Xh@_zjGn^s?OK$
zKkQ`<VMW8TVs><n{v$x^u&`O*#uY@dBRF5U9fAEK7Mrq@Yu3-gKMTiVb1x*h;M}kE
za-xVnJLgUKO<2U{QZi?uvF-G_iK7m^g(SKwy26Uh35(hpYF3Nxc@GJkN;*(-4}@_b
Pm7vcgZUt5Fe;xh|kQQ*J
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/FACP.thread-count b/tests/data/acpi/q35/FACP.thread-count
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
GIT binary patch
literal 244
zcmZ>BbPo8!z`($~*~#D8BUr&HBEVSz2pEB4AU24G0Y(N+hD|^Y6El!tgNU*~X%LSC
z$X0-fGcm9T0LA|E|L2FOWMD92VqjR>!otAF!NBm72O<iWged~jj0!*k$y^{03>bk1
YBHITON2VDSAnpK(F*YFF1LDH~0O^Si0RR91
literal 0
HcmV?d00001
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 4d139d7f6b7e..dfb8523c8bf4 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/APIC.thread-count",
-"tests/data/acpi/q35/DSDT.thread-count",
-"tests/data/acpi/q35/FACP.thread-count",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 14/16] tests: bios-tables-test: Prepare the ACPI table change for type4 thread count2 test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (12 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 13/16] tests: bios-tables-test: Add ACPI table binaries for type4 thread count test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-08-25 3:36 ` [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2 Zhao Liu
` (2 subsequent siblings)
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 1 - 3.
List the ACPI tables that will be added to test the thread count2 field
of smbios type4 table.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.thread-count2 | 0
tests/data/acpi/q35/DSDT.thread-count2 | 0
tests/data/acpi/q35/FACP.thread-count2 | 0
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
4 files changed, 3 insertions(+)
create mode 100644 tests/data/acpi/q35/APIC.thread-count2
create mode 100644 tests/data/acpi/q35/DSDT.thread-count2
create mode 100644 tests/data/acpi/q35/FACP.thread-count2
diff --git a/tests/data/acpi/q35/APIC.thread-count2 b/tests/data/acpi/q35/APIC.thread-count2
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/DSDT.thread-count2 b/tests/data/acpi/q35/DSDT.thread-count2
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/data/acpi/q35/FACP.thread-count2 b/tests/data/acpi/q35/FACP.thread-count2
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8bf4..d17d80e21ab9 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/APIC.thread-count2",
+"tests/data/acpi/q35/DSDT.thread-count2",
+"tests/data/acpi/q35/FACP.thread-count2",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (13 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 14/16] tests: bios-tables-test: Prepare the ACPI table change for type4 thread count2 test Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-15 13:29 ` Igor Mammedov
2023-08-25 3:36 ` [PATCH 16/16] tests: bios-tables-test: Add ACPI table binaries for type4 thread count2 test Zhao Liu
2023-09-01 9:55 ` [PATCH 00/16] tests: Add CPU topology related smbios test cases Michael Tokarev
16 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
type4").
Add this test to cover 2 cases:
1. Test thread count2 field with multiple sockets and multiple dies to
confirm this field could correctly calculate threads per sockets.
2. Confirm that field calculation could correctly recognize the
difference between "-smp maxcpus" and "-smp cpus".
Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/qtest/bios-tables-test.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 26474d376633..1b0c27e95d26 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -96,6 +96,7 @@ typedef struct {
uint8_t smbios_core_count;
uint16_t smbios_core_count2;
uint8_t smbios_thread_count;
+ uint16_t smbios_thread_count2;
uint8_t *required_struct_types;
int required_struct_types_len;
int type4_count;
@@ -644,6 +645,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
uint16_t speed, expected_speed[2];
uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
+ uint16_t thread_count2, expected_thread_count2 = data->smbios_thread_count2;
int offset[2];
int i;
@@ -673,6 +675,8 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
}
if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
+ uint64_t thread_count2_addr;
+
core_count2 = qtest_readw(data->qts,
addr + offsetof(struct smbios_type_4, core_count2));
@@ -680,6 +684,15 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
if (expected_core_count == 0xFF && expected_core_count2) {
g_assert_cmpuint(core_count2, ==, expected_core_count2);
}
+
+ thread_count2_addr = addr +
+ offsetof(struct smbios_type_4, thread_count2);
+ thread_count2 = qtest_readw(data->qts, thread_count2_addr);
+
+ /* Thread Count has reached its limit, checking Thread Count 2 */
+ if (expected_thread_count == 0xFF && expected_thread_count2) {
+ g_assert_cmpuint(thread_count2, ==, expected_thread_count2);
+ }
}
}
@@ -1050,6 +1063,7 @@ static void test_acpi_q35_tcg_thread_count(void)
.required_struct_types = base_required_struct_types,
.required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
.smbios_thread_count = 27,
+ .smbios_thread_count2 = 27,
};
test_acpi_one("-machine smbios-entry-point-type=64 "
@@ -1058,6 +1072,23 @@ static void test_acpi_q35_tcg_thread_count(void)
free_test_data(&data);
}
+static void test_acpi_q35_tcg_thread_count2(void)
+{
+ test_data data = {
+ .machine = MACHINE_Q35,
+ .variant = ".thread-count2",
+ .required_struct_types = base_required_struct_types,
+ .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
+ .smbios_thread_count = 0xFF,
+ .smbios_thread_count2 = 260,
+ };
+
+ test_acpi_one("-machine smbios-entry-point-type=64 "
+ "-smp cpus=210,maxcpus=520,sockets=2,dies=2,cores=65,threads=2",
+ &data);
+ free_test_data(&data);
+}
+
static void test_acpi_q35_tcg_bridge(void)
{
test_data data = {};
@@ -2216,6 +2247,8 @@ int main(int argc, char *argv[])
test_acpi_q35_tcg_core_count2);
qtest_add_func("acpi/q35/thread-count",
test_acpi_q35_tcg_thread_count);
+ qtest_add_func("acpi/q35/thread-count2",
+ test_acpi_q35_tcg_thread_count2);
}
qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
#ifdef CONFIG_POSIX
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2
2023-08-25 3:36 ` [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2 Zhao Liu
@ 2023-09-15 13:29 ` Igor Mammedov
2023-09-19 7:12 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 13:29 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Fri, 25 Aug 2023 11:36:18 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
> type4").
>
> Add this test to cover 2 cases:
> 1. Test thread count2 field with multiple sockets and multiple dies to
> confirm this field could correctly calculate threads per sockets.
>
> 2. Confirm that field calculation could correctly recognize the
> difference between "-smp maxcpus" and "-smp cpus".
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> tests/qtest/bios-tables-test.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index 26474d376633..1b0c27e95d26 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -96,6 +96,7 @@ typedef struct {
> uint8_t smbios_core_count;
> uint16_t smbios_core_count2;
> uint8_t smbios_thread_count;
> + uint16_t smbios_thread_count2;
> uint8_t *required_struct_types;
> int required_struct_types_len;
> int type4_count;
> @@ -644,6 +645,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
> uint16_t speed, expected_speed[2];
> uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
> + uint16_t thread_count2, expected_thread_count2 = data->smbios_thread_count2;
> int offset[2];
> int i;
>
> @@ -673,6 +675,8 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> }
>
> if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
> + uint64_t thread_count2_addr;
> +
> core_count2 = qtest_readw(data->qts,
> addr + offsetof(struct smbios_type_4, core_count2));
>
> @@ -680,6 +684,15 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> if (expected_core_count == 0xFF && expected_core_count2) {
> g_assert_cmpuint(core_count2, ==, expected_core_count2);
> }
> +
> + thread_count2_addr = addr +
> + offsetof(struct smbios_type_4, thread_count2);
> + thread_count2 = qtest_readw(data->qts, thread_count2_addr);
I'd mimic the same code style as used for core_count2 and avoid introducing an extra variable
> +
> + /* Thread Count has reached its limit, checking Thread Count 2 */
> + if (expected_thread_count == 0xFF && expected_thread_count2) {
> + g_assert_cmpuint(thread_count2, ==, expected_thread_count2);
> + }
> }
> }
>
> @@ -1050,6 +1063,7 @@ static void test_acpi_q35_tcg_thread_count(void)
> .required_struct_types = base_required_struct_types,
> .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> .smbios_thread_count = 27,
> + .smbios_thread_count2 = 27,
> };
>
> test_acpi_one("-machine smbios-entry-point-type=64 "
> @@ -1058,6 +1072,23 @@ static void test_acpi_q35_tcg_thread_count(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_q35_tcg_thread_count2(void)
> +{
> + test_data data = {
> + .machine = MACHINE_Q35,
> + .variant = ".thread-count2",
> + .required_struct_types = base_required_struct_types,
> + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> + .smbios_thread_count = 0xFF,
> + .smbios_thread_count2 = 260,
> + };
> +
> + test_acpi_one("-machine smbios-entry-point-type=64 "
> + "-smp cpus=210,maxcpus=520,sockets=2,dies=2,cores=65,threads=2",
> + &data);
explain in commit message why abive -smp ==
> + .smbios_thread_count = 0xFF,
> + .smbios_thread_count2 = 260,
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg_bridge(void)
> {
> test_data data = {};
> @@ -2216,6 +2247,8 @@ int main(int argc, char *argv[])
> test_acpi_q35_tcg_core_count2);
> qtest_add_func("acpi/q35/thread-count",
> test_acpi_q35_tcg_thread_count);
> + qtest_add_func("acpi/q35/thread-count2",
> + test_acpi_q35_tcg_thread_count2);
> }
> qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
> #ifdef CONFIG_POSIX
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2
2023-09-15 13:29 ` Igor Mammedov
@ 2023-09-19 7:12 ` Zhao Liu
2023-09-19 8:01 ` Igor Mammedov
0 siblings, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 7:12 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
Hi Igor,
On Fri, Sep 15, 2023 at 03:29:07PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 15:29:07 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 15/16] tests: bios-tables-test: Add test for smbios
> type4 thread count2
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 25 Aug 2023 11:36:18 +0800
> Zhao Liu <zhao1.liu@linux.intel.com> wrote:
>
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
> > type4").
> >
> > Add this test to cover 2 cases:
> > 1. Test thread count2 field with multiple sockets and multiple dies to
> > confirm this field could correctly calculate threads per sockets.
> >
> > 2. Confirm that field calculation could correctly recognize the
> > difference between "-smp maxcpus" and "-smp cpus".
> >
> > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> > tests/qtest/bios-tables-test.c | 33 +++++++++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index 26474d376633..1b0c27e95d26 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -96,6 +96,7 @@ typedef struct {
> > uint8_t smbios_core_count;
> > uint16_t smbios_core_count2;
> > uint8_t smbios_thread_count;
> > + uint16_t smbios_thread_count2;
> > uint8_t *required_struct_types;
> > int required_struct_types_len;
> > int type4_count;
> > @@ -644,6 +645,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
> > uint16_t speed, expected_speed[2];
> > uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
> > + uint16_t thread_count2, expected_thread_count2 = data->smbios_thread_count2;
> > int offset[2];
> > int i;
> >
> > @@ -673,6 +675,8 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > }
> >
> > if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
> > + uint64_t thread_count2_addr;
> > +
> > core_count2 = qtest_readw(data->qts,
> > addr + offsetof(struct smbios_type_4, core_count2));
> >
> > @@ -680,6 +684,15 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > if (expected_core_count == 0xFF && expected_core_count2) {
> > g_assert_cmpuint(core_count2, ==, expected_core_count2);
> > }
> > +
> > + thread_count2_addr = addr +
> > + offsetof(struct smbios_type_4, thread_count2);
> > + thread_count2 = qtest_readw(data->qts, thread_count2_addr);
>
> I'd mimic the same code style as used for core_count2 and avoid introducing an extra variable
I'm not sure about the style of this case, since the code line is still
too long, so which style should I pick? ;-)
thread_count2 = qtest_readw(data->qts,
addr + offsetof(struct smbios_type_4,
thread_count2));
or,
thread_count2 = qtest_readw(data->qts,
addr + offsetof(struct smbios_type_4,
thread_count2));
>
> > +
> > + /* Thread Count has reached its limit, checking Thread Count 2 */
> > + if (expected_thread_count == 0xFF && expected_thread_count2) {
> > + g_assert_cmpuint(thread_count2, ==, expected_thread_count2);
> > + }
> > }
> > }
> >
> > @@ -1050,6 +1063,7 @@ static void test_acpi_q35_tcg_thread_count(void)
> > .required_struct_types = base_required_struct_types,
> > .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > .smbios_thread_count = 27,
> > + .smbios_thread_count2 = 27,
> > };
> >
> > test_acpi_one("-machine smbios-entry-point-type=64 "
> > @@ -1058,6 +1072,23 @@ static void test_acpi_q35_tcg_thread_count(void)
> > free_test_data(&data);
> > }
> >
> > +static void test_acpi_q35_tcg_thread_count2(void)
> > +{
> > + test_data data = {
> > + .machine = MACHINE_Q35,
> > + .variant = ".thread-count2",
> > + .required_struct_types = base_required_struct_types,
> > + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > + .smbios_thread_count = 0xFF,
> > + .smbios_thread_count2 = 260,
> > + };
> > +
> > + test_acpi_one("-machine smbios-entry-point-type=64 "
> > + "-smp cpus=210,maxcpus=520,sockets=2,dies=2,cores=65,threads=2",
> > + &data);
>
> explain in commit message why abive -smp ==
Ok, this is used to test if we could correctly distinguish smp.cpus and smp.maxcpus.
Thanks,
Zhao
> > + .smbios_thread_count = 0xFF,
> > + .smbios_thread_count2 = 260,
>
>
> > + free_test_data(&data);
> > +}
> > +
> > static void test_acpi_q35_tcg_bridge(void)
> > {
> > test_data data = {};
> > @@ -2216,6 +2247,8 @@ int main(int argc, char *argv[])
> > test_acpi_q35_tcg_core_count2);
> > qtest_add_func("acpi/q35/thread-count",
> > test_acpi_q35_tcg_thread_count);
> > + qtest_add_func("acpi/q35/thread-count2",
> > + test_acpi_q35_tcg_thread_count2);
> > }
> > qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
> > #ifdef CONFIG_POSIX
>
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2
2023-09-19 7:12 ` Zhao Liu
@ 2023-09-19 8:01 ` Igor Mammedov
0 siblings, 0 replies; 38+ messages in thread
From: Igor Mammedov @ 2023-09-19 8:01 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael S . Tsirkin, Ani Sinha, Eduardo Habkost, Marcel Apfelbaum,
Philippe Mathieu-Daudé, Yanan Wang, qemu-devel,
Michael Tokarev, Zhenyu Wang, Zhao Liu
On Tue, 19 Sep 2023 15:12:13 +0800
Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> Hi Igor,
>
> On Fri, Sep 15, 2023 at 03:29:07PM +0200, Igor Mammedov wrote:
> > Date: Fri, 15 Sep 2023 15:29:07 +0200
> > From: Igor Mammedov <imammedo@redhat.com>
> > Subject: Re: [PATCH 15/16] tests: bios-tables-test: Add test for smbios
> > type4 thread count2
> > X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
> >
> > On Fri, 25 Aug 2023 11:36:18 +0800
> > Zhao Liu <zhao1.liu@linux.intel.com> wrote:
> >
> > > From: Zhao Liu <zhao1.liu@intel.com>
> > >
> > > This tests the commit 7298fd7de5551 ("hw/smbios: Fix thread count in
> > > type4").
> > >
> > > Add this test to cover 2 cases:
> > > 1. Test thread count2 field with multiple sockets and multiple dies to
> > > confirm this field could correctly calculate threads per sockets.
> > >
> > > 2. Confirm that field calculation could correctly recognize the
> > > difference between "-smp maxcpus" and "-smp cpus".
> > >
> > > Suggested-by: Igor Mammedov <imammedo@redhat.com>
> > > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > > ---
> > > tests/qtest/bios-tables-test.c | 33 +++++++++++++++++++++++++++++++++
> > > 1 file changed, 33 insertions(+)
> > >
> > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > > index 26474d376633..1b0c27e95d26 100644
> > > --- a/tests/qtest/bios-tables-test.c
> > > +++ b/tests/qtest/bios-tables-test.c
> > > @@ -96,6 +96,7 @@ typedef struct {
> > > uint8_t smbios_core_count;
> > > uint16_t smbios_core_count2;
> > > uint8_t smbios_thread_count;
> > > + uint16_t smbios_thread_count2;
> > > uint8_t *required_struct_types;
> > > int required_struct_types_len;
> > > int type4_count;
> > > @@ -644,6 +645,7 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > > uint8_t thread_count, expected_thread_count = data->smbios_thread_count;
> > > uint16_t speed, expected_speed[2];
> > > uint16_t core_count2, expected_core_count2 = data->smbios_core_count2;
> > > + uint16_t thread_count2, expected_thread_count2 = data->smbios_thread_count2;
> > > int offset[2];
> > > int i;
> > >
> > > @@ -673,6 +675,8 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > > }
> > >
> > > if (ep_type == SMBIOS_ENTRY_POINT_TYPE_64) {
> > > + uint64_t thread_count2_addr;
> > > +
> > > core_count2 = qtest_readw(data->qts,
> > > addr + offsetof(struct smbios_type_4, core_count2));
> > >
> > > @@ -680,6 +684,15 @@ static void smbios_cpu_test(test_data *data, uint32_t addr,
> > > if (expected_core_count == 0xFF && expected_core_count2) {
> > > g_assert_cmpuint(core_count2, ==, expected_core_count2);
> > > }
> > > +
> > > + thread_count2_addr = addr +
> > > + offsetof(struct smbios_type_4, thread_count2);
> > > + thread_count2 = qtest_readw(data->qts, thread_count2_addr);
> >
> > I'd mimic the same code style as used for core_count2 and avoid introducing an extra variable
>
> I'm not sure about the style of this case, since the code line is still
> too long, so which style should I pick? ;-)
>
> thread_count2 = qtest_readw(data->qts,
> addr + offsetof(struct smbios_type_4,
> thread_count2));
>
> or,
> thread_count2 = qtest_readw(data->qts,
> addr + offsetof(struct smbios_type_4,
> thread_count2));
this one
>
>
> >
> > > +
> > > + /* Thread Count has reached its limit, checking Thread Count 2 */
> > > + if (expected_thread_count == 0xFF && expected_thread_count2) {
> > > + g_assert_cmpuint(thread_count2, ==, expected_thread_count2);
> > > + }
> > > }
> > > }
> > >
> > > @@ -1050,6 +1063,7 @@ static void test_acpi_q35_tcg_thread_count(void)
> > > .required_struct_types = base_required_struct_types,
> > > .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > > .smbios_thread_count = 27,
> > > + .smbios_thread_count2 = 27,
> > > };
> > >
> > > test_acpi_one("-machine smbios-entry-point-type=64 "
> > > @@ -1058,6 +1072,23 @@ static void test_acpi_q35_tcg_thread_count(void)
> > > free_test_data(&data);
> > > }
> > >
> > > +static void test_acpi_q35_tcg_thread_count2(void)
> > > +{
> > > + test_data data = {
> > > + .machine = MACHINE_Q35,
> > > + .variant = ".thread-count2",
> > > + .required_struct_types = base_required_struct_types,
> > > + .required_struct_types_len = ARRAY_SIZE(base_required_struct_types),
> > > + .smbios_thread_count = 0xFF,
> > > + .smbios_thread_count2 = 260,
> > > + };
> > > +
> > > + test_acpi_one("-machine smbios-entry-point-type=64 "
> > > + "-smp cpus=210,maxcpus=520,sockets=2,dies=2,cores=65,threads=2",
> > > + &data);
> >
> > explain in commit message why abive -smp ==
>
> Ok, this is used to test if we could correctly distinguish smp.cpus and smp.maxcpus.
>
> Thanks,
> Zhao
>
> > > + .smbios_thread_count = 0xFF,
> > > + .smbios_thread_count2 = 260,
> >
> >
> > > + free_test_data(&data);
> > > +}
> > > +
> > > static void test_acpi_q35_tcg_bridge(void)
> > > {
> > > test_data data = {};
> > > @@ -2216,6 +2247,8 @@ int main(int argc, char *argv[])
> > > test_acpi_q35_tcg_core_count2);
> > > qtest_add_func("acpi/q35/thread-count",
> > > test_acpi_q35_tcg_thread_count);
> > > + qtest_add_func("acpi/q35/thread-count2",
> > > + test_acpi_q35_tcg_thread_count2);
> > > }
> > > qtest_add_func("acpi/q35/viot", test_acpi_q35_viot);
> > > #ifdef CONFIG_POSIX
> >
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* [PATCH 16/16] tests: bios-tables-test: Add ACPI table binaries for type4 thread count2 test
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (14 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 15/16] tests: bios-tables-test: Add test for smbios type4 thread count2 Zhao Liu
@ 2023-08-25 3:36 ` Zhao Liu
2023-09-01 9:55 ` [PATCH 00/16] tests: Add CPU topology related smbios test cases Michael Tokarev
16 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-08-25 3:36 UTC (permalink / raw)
To: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel
Cc: Michael Tokarev, Zhenyu Wang, Zhao Liu
From: Zhao Liu <zhao1.liu@intel.com>
Following the guidelines in tests/qtest/bios-tables-test.c, this
is step 5 and 6.
Changes in the tables:
FACP:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-WOA191, Wed Aug 23 22:29:53 2023
+ *
+ * ACPI Data Table [FACP]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "FACP" [Fixed ACPI Description Table (FADT)]
+[004h 0004 4] Table Length : 000000F4
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : B3
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] FACS Address : 00000000
+[028h 0040 4] DSDT Address : 00000000
+[02Ch 0044 1] Model : 01
+[02Dh 0045 1] PM Profile : 00 [Unspecified]
+[02Eh 0046 2] SCI Interrupt : 0009
+[030h 0048 4] SMI Command Port : 000000B2
+[034h 0052 1] ACPI Enable Value : 02
+[035h 0053 1] ACPI Disable Value : 03
+[036h 0054 1] S4BIOS Command : 00
+[037h 0055 1] P-State Control : 00
+[038h 0056 4] PM1A Event Block Address : 00000600
+[03Ch 0060 4] PM1B Event Block Address : 00000000
+[040h 0064 4] PM1A Control Block Address : 00000604
+[044h 0068 4] PM1B Control Block Address : 00000000
+[048h 0072 4] PM2 Control Block Address : 00000000
+[04Ch 0076 4] PM Timer Block Address : 00000608
+[050h 0080 4] GPE0 Block Address : 00000620
+[054h 0084 4] GPE1 Block Address : 00000000
+[058h 0088 1] PM1 Event Block Length : 04
+[059h 0089 1] PM1 Control Block Length : 02
+[05Ah 0090 1] PM2 Control Block Length : 00
+[05Bh 0091 1] PM Timer Block Length : 04
+[05Ch 0092 1] GPE0 Block Length : 10
+[05Dh 0093 1] GPE1 Block Length : 00
+[05Eh 0094 1] GPE1 Base Offset : 00
+[05Fh 0095 1] _CST Support : 00
+[060h 0096 2] C2 Latency : 0FFF
+[062h 0098 2] C3 Latency : 0FFF
+[064h 0100 2] CPU Cache Size : 0000
+[066h 0102 2] Cache Flush Stride : 0000
+[068h 0104 1] Duty Cycle Offset : 00
+[069h 0105 1] Duty Cycle Width : 00
+[06Ah 0106 1] RTC Day Alarm Index : 00
+[06Bh 0107 1] RTC Month Alarm Index : 00
+[06Ch 0108 1] RTC Century Index : 32
+[06Dh 0109 2] Boot Flags (decoded below) : 0002
+ Legacy Devices Supported (V2) : 0
+ 8042 Present on ports 60/64 (V2) : 1
+ VGA Not Present (V4) : 0
+ MSI Not Supported (V4) : 0
+ PCIe ASPM Not Supported (V4) : 0
+ CMOS RTC Not Present (V5) : 0
+[06Fh 0111 1] Reserved : 00
+[070h 0112 4] Flags (decoded below) : 000484A5
+ WBINVD instruction is operational (V1) : 1
+ WBINVD flushes all caches (V1) : 0
+ All CPUs support C1 (V1) : 1
+ C2 works on MP system (V1) : 0
+ Control Method Power Button (V1) : 0
+ Control Method Sleep Button (V1) : 1
+ RTC wake not in fixed reg space (V1) : 0
+ RTC can wake system from S4 (V1) : 1
+ 32-bit PM Timer (V1) : 0
+ Docking Supported (V1) : 0
+ Reset Register Supported (V2) : 1
+ Sealed Case (V3) : 0
+ Headless - No Video (V3) : 0
+ Use native instr after SLP_TYPx (V3) : 0
+ PCIEXP_WAK Bits Supported (V4) : 0
+ Use Platform Timer (V4) : 1
+ RTC_STS valid on S4 wake (V4) : 0
+ Remote Power-on capable (V4) : 0
+ Use APIC Cluster Model (V4) : 1
+ Use APIC Physical Destination Mode (V4) : 0
+ Hardware Reduced (V5) : 0
+ Low Power S0 Idle (V5) : 0
+
+[074h 0116 12] Reset Register : [Generic Address Structure]
+[074h 0116 1] Space ID : 01 [SystemIO]
+[075h 0117 1] Bit Width : 08
+[076h 0118 1] Bit Offset : 00
+[077h 0119 1] Encoded Access Width : 00 [Undefined/Legacy]
+[078h 0120 8] Address : 0000000000000CF9
+
+[080h 0128 1] Value to cause reset : 0F
+[081h 0129 2] ARM Flags (decoded below) : 0000
+ PSCI Compliant : 0
+ Must use HVC for PSCI : 0
+
+[083h 0131 1] FADT Minor Revision : 00
+[084h 0132 8] FACS Address : 0000000000000000
+[08Ch 0140 8] DSDT Address : 0000000000000000
+[094h 0148 12] PM1A Event Block : [Generic Address Structure]
+[094h 0148 1] Space ID : 01 [SystemIO]
+[095h 0149 1] Bit Width : 20
+[096h 0150 1] Bit Offset : 00
+[097h 0151 1] Encoded Access Width : 00 [Undefined/Legacy]
+[098h 0152 8] Address : 0000000000000600
+
+[0A0h 0160 12] PM1B Event Block : [Generic Address Structure]
+[0A0h 0160 1] Space ID : 00 [SystemMemory]
+[0A1h 0161 1] Bit Width : 00
+[0A2h 0162 1] Bit Offset : 00
+[0A3h 0163 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0A4h 0164 8] Address : 0000000000000000
+
+[0ACh 0172 12] PM1A Control Block : [Generic Address Structure]
+[0ACh 0172 1] Space ID : 01 [SystemIO]
+[0ADh 0173 1] Bit Width : 10
+[0AEh 0174 1] Bit Offset : 00
+[0AFh 0175 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0B0h 0176 8] Address : 0000000000000604
+
+[0B8h 0184 12] PM1B Control Block : [Generic Address Structure]
+[0B8h 0184 1] Space ID : 00 [SystemMemory]
+[0B9h 0185 1] Bit Width : 00
+[0BAh 0186 1] Bit Offset : 00
+[0BBh 0187 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0BCh 0188 8] Address : 0000000000000000
+
+[0C4h 0196 12] PM2 Control Block : [Generic Address Structure]
+[0C4h 0196 1] Space ID : 00 [SystemMemory]
+[0C5h 0197 1] Bit Width : 00
+[0C6h 0198 1] Bit Offset : 00
+[0C7h 0199 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0C8h 0200 8] Address : 0000000000000000
+
+[0D0h 0208 12] PM Timer Block : [Generic Address Structure]
+[0D0h 0208 1] Space ID : 01 [SystemIO]
+[0D1h 0209 1] Bit Width : 20
+[0D2h 0210 1] Bit Offset : 00
+[0D3h 0211 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0D4h 0212 8] Address : 0000000000000608
+
+[0DCh 0220 12] GPE0 Block : [Generic Address Structure]
+[0DCh 0220 1] Space ID : 01 [SystemIO]
+[0DDh 0221 1] Bit Width : 80
+[0DEh 0222 1] Bit Offset : 00
+[0DFh 0223 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0E0h 0224 8] Address : 0000000000000620
+
+[0E8h 0232 12] GPE1 Block : [Generic Address Structure]
+[0E8h 0232 1] Space ID : 00 [SystemMemory]
+[0E9h 0233 1] Bit Width : 00
+[0EAh 0234 1] Bit Offset : 00
+[0EBh 0235 1] Encoded Access Width : 00 [Undefined/Legacy]
+[0ECh 0236 8] Address : 0000000000000000
...
APIC:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembly of /tmp/aml-UMA191, Wed Aug 23 22:29:53 2023
+ *
+ * ACPI Data Table [APIC]
+ *
+ * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue
+ */
+
+[000h 0000 4] Signature : "APIC" [Multiple APIC Description Table (MADT)]
+[004h 0004 4] Table Length : 00001CE6
+[008h 0008 1] Revision : 03
+[009h 0009 1] Checksum : CA
+[00Ah 0010 6] Oem ID : "BOCHS "
+[010h 0016 8] Oem Table ID : "BXPC "
+[018h 0024 4] Oem Revision : 00000001
+[01Ch 0028 4] Asl Compiler ID : "BXPC"
+[020h 0032 4] Asl Compiler Revision : 00000001
+
+[024h 0036 4] Local Apic Address : FEE00000
+[028h 0040 4] Flags (decoded below) : 00000001
+ PC-AT Compatibility : 1
+
+[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
+[02Dh 0045 1] Length : 08
+[02Eh 0046 1] Processor ID : 00
+[02Fh 0047 1] Local Apic ID : 00
+[030h 0048 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
+
+[034h 0052 1] Subtable Type : 00 [Processor Local APIC]
+[035h 0053 1] Length : 08
+[036h 0054 1] Processor ID : 01
+[037h 0055 1] Local Apic ID : 01
+[038h 0056 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
[snip]
+[434h 1076 1] Subtable Type : 00 [Processor Local APIC]
+[435h 1077 1] Length : 08
+[436h 1078 1] Processor ID : 81
+[437h 1079 1] Local Apic ID : 81
+[438h 1080 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+ Runtime Online Capable : 0
+
+[43Ch 1084 1] Subtable Type : 09 [Processor Local x2APIC]
+[43Dh 1085 1] Length : 10
+[43Eh 1086 2] Reserved : 0000
+[440h 1088 4] Processor x2Apic ID : 00000100
+[444h 1092 4] Flags (decoded below) : 00000001
+ Processor Enabled : 1
+[448h 1096 4] Processor UID : 00000082
[snip]
+[1C8Ch 7308 1] Subtable Type : 09 [Processor Local x2APIC]
+[1C8Dh 7309 1] Length : 10
+[1C8Eh 7310 2] Reserved : 0000
+[1C90h 7312 4] Processor x2Apic ID : 00000381
+[1C94h 7316 4] Flags (decoded below) : 00000000
+ Processor Enabled : 0
+[1C98h 7320 4] Processor UID : 00000207
+
+[1C9Ch 7324 1] Subtable Type : 01 [I/O APIC]
+[1C9Dh 7325 1] Length : 0C
+[1C9Eh 7326 1] I/O Apic ID : 00
+[1C9Fh 7327 1] Reserved : 00
+[1CA0h 7328 4] Address : FEC00000
+[1CA4h 7332 4] Interrupt : 00000000
+
+[1CA8h 7336 1] Subtable Type : 02 [Interrupt Source Override]
+[1CA9h 7337 1] Length : 0A
+[1CAAh 7338 1] Bus : 00
+[1CABh 7339 1] Source : 00
+[1CACh 7340 4] Interrupt : 00000002
+[1CB0h 7344 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+
+[1CB2h 7346 1] Subtable Type : 02 [Interrupt Source Override]
+[1CB3h 7347 1] Length : 0A
+[1CB4h 7348 1] Bus : 00
+[1CB5h 7349 1] Source : 05
+[1CB6h 7350 4] Interrupt : 00000005
+[1CBAh 7354 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[1CBCh 7356 1] Subtable Type : 02 [Interrupt Source Override]
+[1CBDh 7357 1] Length : 0A
+[1CBEh 7358 1] Bus : 00
+[1CBFh 7359 1] Source : 09
+[1CC0h 7360 4] Interrupt : 00000009
+[1CC4h 7364 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[1CC6h 7366 1] Subtable Type : 02 [Interrupt Source Override]
+[1CC7h 7367 1] Length : 0A
+[1CC8h 7368 1] Bus : 00
+[1CC9h 7369 1] Source : 0A
+[1CCAh 7370 4] Interrupt : 0000000A
+[1CCEh 7374 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[1CD0h 7376 1] Subtable Type : 02 [Interrupt Source Override]
+[1CD1h 7377 1] Length : 0A
+[1CD2h 7378 1] Bus : 00
+[1CD3h 7379 1] Source : 0B
+[1CD4h 7380 4] Interrupt : 0000000B
+[1CD8h 7384 2] Flags (decoded below) : 000D
+ Polarity : 1
+ Trigger Mode : 3
+
+[1CDAh 7386 1] Subtable Type : 0A [Local x2APIC NMI]
+[1CDBh 7387 1] Length : 0C
+[1CDCh 7388 2] Flags (decoded below) : 0000
+ Polarity : 0
+ Trigger Mode : 0
+[1CDEh 7390 4] Processor UID : FFFFFFFF
+[1CE2h 7394 1] Interrupt Input LINT : 01
+[1CE3h 7395 3] Reserved : 000000
...
DSDT:
+/*
+ * Intel ACPI Component Architecture
+ * AML/ASL+ Disassembler version 20200925 (64-bit version)
+ * Copyright (c) 2000 - 2020 Intel Corporation
+ *
+ * Disassembling to symbolic ASL+ operators
+ *
+ * Disassembly of /tmp/aml-LWJ191, Wed Aug 23 22:29:53 2023
+ *
+ * Original Table Header:
+ * Signature "DSDT"
+ * Length 0x0000F8B7 (63671)
+ * Revision 0x01 **** 32-bit table (V1), no 64-bit math support
+ * Checksum 0xB7
+ * OEM ID "BOCHS "
+ * OEM Table ID "BXPC "
+ * OEM Revision 0x00000001 (1)
+ * Compiler ID "BXPC"
+ * Compiler Version 0x00000001 (1)
+ */
+DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC ", 0x00000001)
+{
+ Scope (\)
+ {
+ OperationRegion (DBG, SystemIO, 0x0402, One)
+ Field (DBG, ByteAcc, NoLock, Preserve)
+ {
+ DBGB, 8
+ }
+
+ Method (DBUG, 1, NotSerialized)
+ {
+ ToHexString (Arg0, Local0)
+ ToBuffer (Local0, Local0)
+ Local1 = (SizeOf (Local0) - One)
+ Local2 = Zero
+ While ((Local2 < Local1))
+ {
+ DBGB = DerefOf (Local0 [Local2])
+ Local2++
+ }
+
+ DBGB = 0x0A
+ }
+ }
[snip]
+ Processor (C000, 0x00, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (Zero))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (Zero, Arg0, Arg1, Arg2)
+ }
+ }
+
+ Processor (C001, 0x01, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (One))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (One)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (One, Arg0, Arg1, Arg2)
+ }
+ }
[snip]
+ Processor (C081, 0x81, 0x00000000, 0x00)
+ {
+ Method (_STA, 0, Serialized) // _STA: Status
+ {
+ Return (CSTA (0x81))
+ }
+
+ Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
+ {
+ 0x00, 0x08, 0x81, 0x81, 0x01, 0x00, 0x00, 0x00 // ........
+ })
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
+ {
+ CEJ0 (0x81)
+ }
+
+ Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
+ {
+ COST (0x81, Arg0, Arg1, Arg2)
+ }
+ }
...
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
tests/data/acpi/q35/APIC.thread-count2 | Bin 0 -> 7398 bytes
tests/data/acpi/q35/DSDT.thread-count2 | Bin 0 -> 63671 bytes
tests/data/acpi/q35/FACP.thread-count2 | Bin 0 -> 244 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
4 files changed, 3 deletions(-)
diff --git a/tests/data/acpi/q35/APIC.thread-count2 b/tests/data/acpi/q35/APIC.thread-count2
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..2c6ab5d96c275f8e4872ff91ce3006f992ef3c36 100644
GIT binary patch
literal 7398
zcmXxoWpotg7DnMOKp+Y34hin=9^BpC-QA_`?(XjHrQT9^_m;Z5!JW<7Hw*gC!%TiO
zbe%oZ!qG$e?XQ(m(S3bK^&31czwhMH{qi$kSt%tRvnhRa;Lzrz6q}V5Tck*A(W0@%
zip6GU#}+RhTcSj4PEKrYZfss&Y{`<brAoz?E*)E@Ol;Y*vE|CemM<S$p+aoMim{a{
z#a6ByTct{D)vB@8s>N2X9$TYEY|WanwQ9xIt{q#aPHf$}vGH?BIRypbdi7%K*N<(`
zAhuz{*hY<F8#j(^(j>NN)7WOsVw*RQZP6mOWy{!BtzuiZj&0K>wr$(kcI{%@w~y`6
zA+}@3*iM~dJ9m!l(j~TQ*Vt~|V!L;b?a?E)XV2JPy<&U!j_uPYwy-d^Z{OH{@!v^K
z|Nh|t17Zgbj2$#6cJScXAwyz^4vif)EOz+t*byUQM~;jgH7a)W=-4r1V#kh+9XBp^
z{P@@j6JjS$jGZ(ocJk!dDN|ynPK}*5Eq40!*cmfoXU>eBH7j=Z?ASSTV&~3{oi{Ib
z{`}Yl3t|^8j9s)ScJboaB}-zLE{$EbEOz<w*cB^cSFVg*wJLV?>ew}FV%M&XUAHcF
z{rcDq8)7$ZjNP;;cJt=gEn8x@ZjIfxEq43%*d04!ckYbcwJUb_?$|wh*xYiNe`Fr;
z_%NNN57!(Bo<Bl!DDaV*gMp9I91eW6=78X1G=~Hqt2rq6IL%?f$7>D@K0$M6@QIp(
zgHO^N9(=Oq0O3<KhX|jlIY{_4&0)f)YYr4XLvyI`nVN%z&(a(&e75F*;d3;H44<nx
zX!tzMVZ-NZ4jjHfbLjAenuCWg(i}c~vE~5cOEiZNU#j!<Wx7CLt~rpIU+D_Xp~P2e
z4ko@zH`G^a4k*uGqdBDbTFpVl*J%zbzFu=+@eP_oi*M8%Tzr$}@Zy^_2N>U?ImGx@
z%|XVuX$~{KU2~xE9hyUp@6;S@e3#~M<GVEn9N(ik<oI6ALC5!L4m-YIbKvm<nnRBt
z)Es>Lkmm5?hcyAfdo>}zkLW)7QC+AX(*z>(D?P3W1%5&k4E&@Xpr6tM_0yV=@cL&o
zLBabpVZqO80)wB^ga$va2@ZZi6CV7cCP4TlO^EQzI)aqaD>}lI(yKZGmC|cELY30%
zI)atb8#=<3(wjO0meN}~LYC6oI)awcJ37La(z`kWm(qJWLYLC}I)azd2Rg!+(uX<%
zn0W`NBZMh^tY`DX$b5a0`ArYz=udS7GNsRSgfgYibp$h|{d$4l|Ak(tztoHLS2}{4
z($_k|n$kBq0-MseIzpS$cRGTb()T*To6-+D0-Vy1IzpV%Pdb8}($6}=oYF5k0-e&Y
zIzpY&Z#sgV((gLLozfpV0-n;JIzpb(Upj)G(%(A5p3*-$0-w^qIzpe)e>#Gn(g7Xe
zPwAkJHvk!Ae(wDJ#v6eQ^=|(@=seHw(RBXM`-38x@6CMCd7P!QbrD@$7u6+nF-_<B
z{%lR>adA!OaS2W5agL_*I9JnooTuqLE~)7}E~V)_F0JW2E~Du@F01K0E~n`{F0bi4
zuAu2WuBhoeuB7QauB_=iuA=EYuBz!guBPccuCD1kuA%8XuBqufuBG#JZC#-2Xgbg9
z>uNfW^EI8v1)9#|db*LWuN&(In$Gk3hMLafMw-s!#+uIKCYsLUrkc*<W}439=9<pq
z7MjlEmYUAvR+`S^)|$@aHk!`kwwli4cAC!P_L|P)4w}y6j+)NnPMXf+&YI5SE}G8c
zuA0u{Zko>H?wZcy9=eb2sS9;4P3L)iZ%yZMA5G_Rp{Db=ucq_3pB|+9YdX*K12mn-
z12vt;gEXDTgEgJULo}VoLp7bp!!(`8!!@19BQ%}IBQ>4Jqcokzqcxq!V>F$|V>O+}
z<20Se<29Yf6EvO26E&U3lQf;jlQo^kQ#75&Q#GB((=?sO)AejUL(kDOHJ#`6voxK@
zvo)Q^b2OdDb2XjE^E92u^EI8v3pAa_3pJg`i!`0bi#46cOEjIwOEsOx%QT(G%Qc<H
zD>R+QD>a?Rt2CX*t2Ld+Yc!q5Yc-w6>olFm>ouLn8#JBA8#SHBn>3xrn>C%sTQr@=
zTQ!}>+ccfW+x2d}L(_Sl->DDNyY%6Dw?0De(MRf3G~OQ^rL*+Wx`;kT7uCn=V){6p
zt&i8m^$EI!K2hiBlXR{=S?B3fbV+@xE~QV?rS<8$j6Oq`)o1E*`Yc^upRFtCb96<0
zuCAod)0Or4x{AI)SJfBlYWgBwU0<wg=u31>eW|XcFVnU4<+_f(Lf6$->U@2bF3?x&
zdiok&Utg;m=<9SteZ6j^Z_thPjk<}xNjKFu>t^~E-CW<QTj<+#OMSa;rSH(K^_{wn
zzDu{&ck6cg9^GEwt2^lXbVq%^?xY{ko%Msdi+)IV)eq}#dav%TAJIMZqq?VlO!v}{
z>)!ea-A6yE3-wdFuYOwh)6eMsdY>MkpVb5Pb9#_|UJuqU=pp(=JygG>hv}E~aQ%uN
zp<mS_^=o>ReqE2&Z|E`lO+8k>rN`;F^?3b`o}k~=6ZLy~l73%L)*t98`a?Zcf261B
zkM(r@iJqZ9)id>HdY1lN&({0(9Q}o!tH0Fq^jCVm{#q~4-{^(<TfInsrx)w*^%DJq
zUaEi8%k)orx&B$N(7))F`d7V5|E5>#-}M^(hhD4y)a&$LdcFQzZ_xkfjrw1`N&lxe
z>jQd=KB%|ql<D@N_Xj#lZ`XW|=lLC)&+&)eA80<u<6WB1@p!l9b3ERo`5d2BiuVS4
t`Ck*MNM7bQ4|tTFo!Qbn%FX@%qrA)u;?GK!JoG3p^W6tCUzvZA^gm{Z!4Lod
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.thread-count2 b/tests/data/acpi/q35/DSDT.thread-count2
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..cd542c4b5cdd79eb5c6f4054e07bd6a11c3c8657 100644
GIT binary patch
literal 63671
zcmb8&2Y8fK(>L(lG{Po8fY4iLqN0#OC{{L`3Iswz)1V2xDv_cTQHla$H)1cS*n97a
zy({+Kd+&;scjoNup8uTt_+8)gT<?o#Huuc$%my-Kb04;}u5`kkJ42!Hoh9R9m34U~
zQ)*&)^uKT@6yi1iH>WCXYN&oqX-P#xI4dPBT)#HUtm&7M%-p?7OD0x?&zakJR%7GR
zjg8@HO`++R=4_cht!e$H#_1uxXxa3pNQ4(TquV#sl{D0^t7=mdtIE%8sH`f@j_!zL
zW;Vp)tJKVfiB+Yc+%YX0#?{5rHZKUpN+%a=9h=@fw{81KPJQ*;MZfpzKJu)|OQYNO
ze|`4m1(7tmppgEXN&hWs;$Iq9HAZ?iZp}HPd0u!mr<;!zY;Au=v-xoRu^j$LQzJie
zNp}1pE>*B?LGI}EveLThR$GTQ&kr@VO$~<{w{|@vzJVRXp8B+|cxCnJoxZB>@<^<D
zTjSOiTjoVlwly|I)^2JHh3J9q&GREIn%bqOgj$6f=~-A93QcR87XM)Vy5Xg@(U|GH
zRn6F%{8)ZLh`O(>YuhW*ePgFkD4U;h{@+czcI|pFz6|B82<42)9mG!_KXLVIYGQR0
z!dct1BboJUb2y06;}i4fm(slYHFag9=u`D%b|j5HR~*Dj^2<ii2TI0P*M_rp#M3y4
zm5iNOomW#;Iwh|@Trws$I+WYLCRR2orM@pmyLL6r<tv(2gy)60M*RSOcv~oUV3cxv
zS8=T-{-sf_ZOkocS!15h(v1J<38iO^5%UDnFX7O1`ZTO=o*rtRo=wlquF&df;c2U<
ztq4b2*e7^vfA#D;1)8SEKMk2RRk89=ZgvCxH{3Lrqnve<!u<T^#J)1WH*0Dq)U+GD
zWKFxQv@Ej5j2>im$`8E)TWK=Eox`6jUUFR0=9X?OLVL{^-*fzfK~~q6=HcKW6gi
z(nQFaRNq{iVlwGki8wQHX-dds(xoPoLe8Y!m}^r_W?~1aA<j%(ni|ifOHC$)oS9J4
zOlD#SX(lsqX<9rpv3Uxy&veyiy2(sjnjX(gY@R~wGeh;6VKNh!X6QaC#6DZ7K3k|h
zTj)M1#6B}spP8!9Ox-7i*k?=CXG_&*OWh}h*k?rb8Bu*kbe|MrpINHUEY)Y0?vq07
zGh6kUt@_N?eNu>hwo-kzQhm14eNu>hwpM+%R(-bCeNu>hwo!eyQGK@2eNu>h=BPe%
zRG&GzPYSWmwyMvzs?WB%PYSWmcB;>Is?T=1PYSWm_NveJs?YYiPYSWmT-9f;>N8jO
zNg?*xLG{@|_1Qu9Ng?*xQT5qT_1RJPNg?)0V=VqP%Y0Spr26cn`=k*2?5z6itorP%
z`=k*2>|!#b@|CcQ$t;mCc3t9`F&lDbsa)GtWp-7WU3DgfnAuHbc2k+%bS8zE*<EFJ
zSDD>)CWV;ULuK|*nLTtSg_zmXWG24G_cWP_ukk(OnTapl6mn)_lJrt$FJ<=9CWUb`
zlLlxM253cH713sxhG|W(3{VP)jR&a|Bv2Zl@$1ZQqHu__68j4i8ox9-Kq*YLMguf{
zZDN4Jr9436mnH`&g|wT*0F7TO5t~#sF)=wa@r>~RrI2=HuB8DQzg8mY(PZ)fjbEAw
zu}>PH@v<h91}I$01C+wVROA6lVWLkOpz&)>CJj)ylm}@1Qe*M}r7+Pa4bb?tCX)sz
zT*?D9eyPdi0ZL(_Pa2@{YfUB%P`H!_X#7%>$pe(a#OIR+X#84}Ndpuv<pCPM)MWAi
zr7+Pa4bb?tCX)szT*?D9eyPdi0ZL(_Pa2@{YfUB%P`H!_X#7%>$pe(aM4vQ3<JX!@
z8lZ3~5779fCX)v!g^50CfX1&inKVG*QXZi3OHC#ZPzn=$(g2NLYcgqo!lgVw<CmID
z9-tH^`lJCGzt&{Z0EJ6=fW|L1nLI!#O!P?uG=8ngqyY+-@&JurYBG6%QkdwI259_R
zlSu;<F699lztm*%0HrX|Ck@c}wI-7WC|t?|G=8bc<N-=yqE8y2@oP;c4N$n02Wb3K
zlgR^=!bG1mK;ze%Od6nYDG$*2r6!XHD20hWX@JJBHJLO(;Zh!;@k>o64^RpdebNAp
zUu!aHfWoCbK;xI1Odg;VCi<iS8o$<L(g1}^d4R?*HJLm>DNOW912lfE$)o`am+}CO
zUurUWfKr&~lLjb7FhD870ZJhbPzqsyLM9DR$m9VEnLI!tlLjbc(g1}_9-xrP0~9i8
zfI=n>P{`x~3Yk1WA(I9uWYPeIOdg<+$paKJX@F9c`0UaErHDRb=E>v%N+Eq35+P?M
zo?9BA6eXTp8lV&<o?9NE6egZq9-tJ`Yam@4XoQBgW;dH}R=4ptq?csyf1<hVtH#s!
z|65zGimaI%+7@ZKEs~Wxq-uPuwk3_-+WfYyBUvY8gj$-H5>|vZ^J9^8`n9TQ)!ay%
z5U;3EZGQc_F)e7$M-#8aWVeaG{*p;_UE7Y4_9wIswM?Z66{4@fA^K_>S`o@^(@-}d
z8rsHNsHq(v&28IIT2&WX&Fjb-^GF+hL4&V|)tb0dLtSlMc=KG@1M~d2=p~LG{vY%b
z&`XS7Li<C#B-gK()UT`N-s7*u(5q0=dnDz5;A6nY3?Fm&*njXb;Y*$7BlHT`|MzoW
z3Vf;IOC7%SKloDN%UnL~f8fi2FEf0Z!<YRBUnYFH%cuVjd^zythA(&c^8et=g|Be=
zjQ@eJ0KUTT6%JqVAAE)Il`h}nf8Z;DuQYt6!&m+XUrBr#e>rmboH(EO;z55kpg->M
z7bo>&xf$k<JpG6NTuV9kk8z}}E=PY~2$YLI<}DZabJ<RpqrXH1%Ece^mJ9qjYp=`E
z-z);<;*WXD1^(RR>T>kgjX=5hW8QLsKL;IjIr=+Dpj`YhZ@Iwl>yEk{{lz3uF8-Le
zT;TU<CtZ&Iwh|~8e@vIlsm_eQ{9l$?SyMJ4@!Ky<U-I}x|N1qRH4~~s^f&Jv|7L~g
zrRyAy+fOPRTbfr>TiTG9JJd{`CVr%`i65G_vN4j=xHbFq=EhKSBfTEGEwr`u>CMwZ
zXHLrwefVqoHX4pJ()i`|wvpBw=vxpj9-?p7=mquMhKic_=do2ZR#TOqpFcE|vwnN4
z_#P`GQwOIeUU09eEvrjxH$q<|XuGXqH52nH7cFgCxNJ_|;#o@;En7Te){;<tI94-e
zwEU@Q6^T@Y-^hL=JDk0O+M}=Q^rHP6*^%t}wYzf=4dumZ%EpFcRb%VIvD)fMVS4F3
zpMNP2hf-s)>QZ`nza3wh8mlWClSh}AMknOa>(*6ct1_EH{9ygMHMh5#YJN08JBsg8
z`YFigeZ+sTlAe3YS>f1(@`F;gMw;h_HpHmidAtnsvS8lUtme6q6kZp`*QvZNim%gn
zJtV$P=XG&>ox$s&@pTJc4~wrec|AP7ZprHr@pXjP(fB%x*Cp|FHm_sxbt_(%#@DTR
zT^3)r;dOa@okQya+CJ~OEw5$&?RYKwZ_jJle=e_O{~dTO`|rqW*?%Wq%l<p_TK3<C
z*Rubvyq5iU<F)L+JFjK`J$Nnq@5yV~e=lCk{_|*EDEsftYuSGvUd#Ub@>=%akJqyQ
z{=Am`@5XD{{{UXg{&(lK?0*kl%l`M|wd{W&uVw#x@mlu3H?L*?gLp0bAIxjne?F~?
zWd8-cmi-s<TJ~SWYuW!0Ud#TAc`f@N%4^yGFkZ|4hx1zYKZ4h?|9yBZ``?$>vj6>f
zE&Jb}*RuZucrE)skk_*Rk+dEn`;YQk_Fuwl*?)}Jvj0+E%l^xFE&DI$wd}uw*Ruag
zUd#TgcrE)M#cSFBXkN?y$M9PAU(IXT|5#qj{>SlJ_FqHmV%h(AUd#S#c`f^|<F)L6
z0<UHN6L~HBpTuj~|72dv{-^L-_J0tsW&a2BTJ~ShYuW!)Ud#Ru;kE4lP+rUa8+a}I
zZ>055+5a?N%l@bHTJ}GK*Rubayq5jX;<fC5Hm_y>b9gQLpUZ36|2$sH{^#>r_P>DF
zvj2s=mi-^bYuW$dyq5hh;<fC*iPpnp|3~mz_P?0dvi~K#mi;f~wd{WxuVw#7@>=$P
z6t89f%XuyPU%_kH|4LrV{#Wr@_J1_5W&f*rE&D%)*Rua(c`f^2L+jzP|Fyi9{jcM-
z?0-G4W&g+VTK0cDuVw!mcrE+i$ZOgECSJ?_PvEuee>1OT|0nWV_J0zuW&bDhTK0bm
zuVw$I@>=$P8m&jj{!iz%?Eeg2%l?~rE&D%{*RuaDyq5i+#cSFB*}RthpTld}|GB)D
z{h!Bc+5h>xmi=GAYuW#Wyq5i6#B16A#k`jNZ>4oq_J0YlW&fA*TK0b#uVw$+crE+C
zoY%7dD|jvYzmnIo|EqW{`@fpkvj1y%E&IQg*RucXcrE+Cp4YPf8+a}IzmeCn|C?xC
zBKyCY*RuaxcrE+CmDjTW+juSezn#~z|2uds`@fUdvj4kyE&IQl*Rub6crE+Cm)ElY
z`*<z;zn|B#{|9(2`+tzvvj6S0j>-NX;<fDmVP4DrAK|s^|50Ac{vYGD?Ei6I%l@C>
zwe0^%Ud#TU;<fDmX<p0zpW(Ia|5;wk{-5Ku?EiUQ%l=>Bwd{WftxIM9FY;RU{}Qid
z|1a}e_Wug6W&f}8TK4}MuVw$Q^IG=*2CrrRZ}M99{}!)h|8MhJ_WusAW&iK;TK4}Q
zuVw%5^IG=*0j<kq{~z*N_Wu#DW&a=ZTK4}5uVw$A@>=%)8LwskpYvMw{{^pQ|6lT2
z_Wu>HW&dCETK4}9uVw$=@>=%)9j|5o-}74b{{yYdW&c0&TK4}FuVw!~^IG=*3$JDW
zzw%o4{~NDm|G)EE_P>+Yvj0DLE&KnI*Rub=crE+?o7b}ce|RnX|CiUY|6RPM{bx7N
zrJsXrh!ybP|2YVofI8qH#RSv>2dO5Y9ymxd0X4xvx(TQY4l+zYZE(=S1k?uynI@n{
zIB01C>V$)c38)ngvP?j|aFA^RYKDVWCZKLOXl(*&hl4gIkbZJF;BN@{BW+C}{j@WI
z^wZu1(oe1lq@NBZkbXLvK>F!q0_mr-38bGcCXjx*nn3#LW&-J_y9uP99wv}}dYVA`
z>16`xCyxXE27&wOZ35}1j|rroz9x`<`k6rb>2Ct*XEzf_KLbo4{p@Z6>1PiUNI!d;
zK>8VI0_kTj6G%UMn?U**WCH1DunDA}d=B^<2JWZ81kz8T38bGQ6G%TpOd$Ofn?U**
zY69tJm<gnx;U<uNMwmeQ*~bLZ&%P#*e)cng^s~PSq@M#!ApIO@0_kTY2mB2L_Y*aN
z^iyI2=_h6a>8I2L(odNQq@QvVNIw-OkbWvnApKOCK>8VF0_kV838bGfCXjxrO(6Y@
zHG%Xq&IHm=4F~)U1@|-F1kz8f38bGo6G%T3Od$PCG=cOp$pq5RWD`g~Q%oTJ9ApCN
z=U@{^KlLV%ex{m0`Z>e|($AqLkbW9WApJCQz~5kSKhsPg{Y*E3^fSW*($7p2NI$bo
zApOiXf%G%S1kw+`cv8UMXs|QS1k%rZ6G%S`Od$O%G=cPUm<gnx!%ZOlEHZ)g)5HOP
z!@<rGCXjv>n?U+mVgl)BsR^W?WhRh*jx>SvbCe0BpXDZyepZ-3`dMiL>1UM*q@SZr
zApNX1f%J2X38bH6O(6ZO;efvZ;eOVdK>Ar{0_kVH38bInOd$OnZvyFOg9)UcjV6$O
zHkm;BIl%<d&t?-yKPQ?%`Z>u2($C2zkbX`vf%J2#38bIXIN)zcxS!KaApM+S0_msO
z1k%r$CXjx%m_YhD%LLNT*(Q*F&M|@XbFK-bpYu#0{hV(C>E{9yNIw^vK>E4J1k%sN
zCXjx%a=_o9a6gxrK>E4V1k%rCCXjx%nLzrv+yv6k6(*2=t~7!4bCn6CpQ}wE{aj-L
z>E~J#NI%z^K>E4f1k%q9CXjw^G=cPU69@ba3-@!g38bG}Od$Q-Y69u!HWNrcx0^uv
zxx)m~&z&Zae(o}X^mDffq@R0CApP8H0_o>I6G%Vzn?U+`zy#9IgC>xEwsXMWz;Hhg
znLzq^*aXtgBPNi39yNjV^Oy;wpT|ug{XAg;>E}rkNIy@RK>B&w1k%qlCXjxfHG%Z=
zoC&0#=S?8}ykG+9X9oxT4Gs76q6ws*mrNl2ylevL=M@u3Kd+iV`gzR+($DKAkbd4U
zf%NmH38bI5Od$QdZ35}%9TP}D@0vjRdCvsW&-*5jem>xUzro>tJ~V;!^N|UppN~x-
z{d{5q>E}}uNI##MK>GRI1k%qJCXjx<G=cQ<l?kMuuT3ERd}9LX=UWp<Ki`=^`uW}j
z($5bZ@Haf%&yOaMett56^z*X`q@Q0*ApQJm0_o>B6G%V5n?U;6X#(lz4--f~f0{u0
z`O5^-&)+7He*Q6m^z*L?q@P_TkbXib8)AjY?|)1n{iK*c`bjl`^pj=+=_lO;(ocp7
zq@NZh7&b4rGJ{TKL|fMPojN!Te~iRG9^zva?!)w>oF+bK((HbKe?Zg}X+y^;0v{PO
zdRt>|bvpmh=zoL4ZYiqZt)E-jF;*8FoB1DYWX8spO>UR6t0^?2DLnJi@^;NL!%d-?
zP2t9-(6md(W}nvF7~V1?D>H>!YntJrre*g*`k~j>PFvhZ>Bn9(F5lX+d0J!_L6<lA
zKEAbI;JM?Ut2NEo#JijpS~iXLb;+=;#evJrPu}QfV>2SDO@XI|K1g}XX7IVDvb6ZY
zCN4NVG=qPhHiLlr0)KOXTC|^K)BR6$b<5bex(V6;@kIN7zXa;jlh-uQ^V~E=Qrt)R
z()sR#^fY^SSHFHZ{q!xLe|#F^V>9$SJ98WV{-z%=R!1ka&5C4(=+02S-zc{=o!pv`
z#m$7~&YNGqzATMW3(T!ZDwS^YNv4LwCN--;e*BpqhB9GOrjpAP(yhI0(9dWSJK+0u
zl66v2Or7jxok$AZ6p`3ZB*j)LqO&q?CHgsZvQjD?`!cO2b`(j)N~yNe5c+AdTZ!(X
zNmfcrb1S7`r8HZqm~XUlx}zInl9kfa-Ad_LDcx2YO1B2PmFUOT$x0a+Zlw&Ylwm6k
zqg#dDN_3k_vQmo{ZlxAjsfDdHoPLA2mFVDKvQlQITPYJOW!g$3%+K-l?}C<4sinE`
zjeeUZKX)y$QcGJY%D1&S&v*nXMI!E=B3LP6E0yrgaZaTys6;Pv@rPkgSy(B{R*KOL
z5N@SxsFZC^2x6sdtdwmlmC~)qZlzXGsZ}d?Ppz<0D_g0IZcTP8wT4QqTf3E7W2M%%
zQaRnK>{g;XG?Kpy+O%;iwZTell9dYb`Tiv58K*m#l9h6D+)6oEDaTeS;M<U#N_6v5
zvQpc&Zl$(ZsjaP4$af$)mFT{uWTkfP+)C}RQaf9zh;Ke}D$y-V$x7|pyOr8wrS`Vc
z5WerosYG`xB`f9Tx|MRVQm(C3%(omlmFPyLWTg%r+)5p=QU_aUDBo@5RHA#7l9f7k
zbSrhlN*!&bVSJ;JQ;BX*N>=LB$*t50D|ND!hSROnZl%spsdHzyQfI8x*;X1sw^F;6
zx<I8aUEE4tuu>OWDN1LP+)7=cQrE6-rLI`1tF2T*w_3ZEx<RFG-P}suuu?Z$DMq(m
zyOp{_rS9F`O5L$icU!5HZpC&h^?*t}dbpK(V5J_mQW@Qv?N;gum3sDcEA_-mJ#D3O
zx>eh))C(&0>g87Ig_U|GD;4JF1uNx2rT8Ix{5qb8mGW$*g5JSOy`fU?-tL}yW2N4<
zQemH9r9M!pPan5ZAFR~JRx0Wntkf4O_3i6c>Wh{7+Db$E1uOM~O8xq|mHJ_&ezsC^
z|6ry5P^o`^w^Dzs)ZbPbx?8Z)Zcu5r-P}sMVWr({rC|etl?Fhi0R!Ah1F+HnTWR?2
z!AiSBrQLUTEA5VzcDI#A>=CTA2UOZ)54X}DSZNPiDY|E{(w<Oh&pq8rdt#+MZKaZd
z!Ab+6(!hakrGZ#!psf_!D_ChSsI=E!Zl%4j(q6Vw>E6LgdqbtY_jW7ojg|JcmC6PM
zD-D85g9f>k24ST^wo>`vV5PxOY4BjT(qODKI9aJkzMWIwOVK~ck(`|Q`EI3rtdwsn
z6%+*bQ~;F<%y)nIm979Q71&CJg~3XNP^qxc-BTe}Dzue~ih`Ajpi)thTd4>u71>Hd
zh6F1Ofl5P$xRr)rr6IObadEIxF;prpb}JQQrD9uY=+I!Lp-^e)P`A=htTfbC8a6Cg
zX&6)*Hq5Ow3@Z(@m4*)wRvHeKh7Wfu4aZ8uZKV+-f|W)<r4b|CN+Yn+2wN$-Pq5NH
zP-&li+)DdkrG0Frl6`}f_JvCO?(0_C7c1>+E5-H;R@x6L?YEy>X+NyApRH87f3VX2
zP-*}D-AemorTuNCvIByZ4uDDr9N<<u04p6}E0rG@taKn$I`BZZ(t%j%z+|N%`6Gjs
zMna{LBi%|PvC>FesURAxM2BCJU+JPzw^9@<MQx?Rl3*n|_mZqsQsP$P<7mm(pGs_{
zqFAsJ9eGJsikW|U3BP9Y$+Bdnn5{IVG+2pFyCf@>mb!c5Lt@EFrM6OWS+EivkVsZ4
zD|0LHd9P%pGFxeAd9V_laY<Gxr}GW;O&h!#!bi7~mC9|UVHLqjbi5^5siMNI#HX;5
zl`3qd;g!Kkbh0H`sj||o#0RR9l`3te5mmuTRZyv_%B@s|m8xu|=%`?&QBY~rD7Vrm
ztTf72Dj6NDG#V<69_>~djg>~*O0hA)N@JkXm@#gpF<5DgtyEeatVBnElFxW`wOgqg
zD^=S{Wn+Vt#zLjBW8F$)vC>#useD|p(m1FzZk$_b999~atW=y|6RcDNm1=6-N;O!i
z##SmAAFMPUDvclSRvM3$#@kATwZTfYP^q@otyGJZYHg*Wx?m+bT$KFW)z!I`>abFs
ztu$mpuo9j9N>-XM!L2j_D^0MKiYEpuO@vAlC%Tm;Vx@_;($Go4N|T_{q)Be2Nmyx;
ztu$<Mu+n6xG<mXHX);!tY%2|)609@@DovT<R+@s9rr1g&4hmK}2r3<PkXz{>taOmA
z6g@at>0qdI@WF1SgR#=Vwo*xbuu?r#s;_q|)nlc4TPZd*SZOL$nmX03G!-jNwUtT_
z3067;Djjl&Tj>z2bcn4~c4)BDp-}12L)}V;Vx>cErSgVgr3R?f(BM{Tz)B6tN<;G-
zgOwVgQe&fAsSztR+DZk}f|aI0rD@aLO4G2?G+U`~da%-Ts5E`LTWLC0nr<r<%?MVS
z0hMOVa4XHgN;7PwAv1%OW<sTzGu=uvvC>Risd!ef(k!SnYnEGS7FL>ND-E3;tTY=c
z&7SR6nvIoa+e*Xc1S`#fN^|D8mF8fjIkwX9xxq?vq0-#BZl$?cX|Am_VqUP)Jg78p
zo?B@iR+?ukMdt@A&4)_!=ew2WW2O1FQpti~r3FxF!2-9^0<5&aR*EeQR$2&^7Sg|D
zssHY~5GyUTl}Zl_RyqtS9d?*o=`gHxn5|THc(BspQ0ef)-AadJrNeEd@<qW)i=fh?
zMQ)`<SZPtR(y;udV5KIg)YRlwYQjoQwo<_n!AeI!r6Z1TD;<HAj<A&q7Y8dXhDwVU
zyOkDWrNy>V(UM@LB~WR}61UP4thB^d8nQH4X(?1%y40<-6e}&Ym5P@ID=mXc%a*y7
zmSLr3w$jiegO!eiN=F{)Ryq<Z9ce2KJ1SV|D5!MQQEsK9u+mYs((vWMO3R_r^5t%&
z<ydLCtu$gqu+j>sv|@!@X$4kVVJk&f1}m+EN-I~ol~!V<m9|pJs$iv6P-)dFx6&%C
zw8~bB9UZK6G*mkJXt&bQSm|h6sdRO)(rT!*dbL|=HC9?}E0rA+taJ=iI_4O+(lJ=+
z7+b0Q*kGk&q0+I(x|NQ_O2;NE4bNW_th5Fyty$w%T7#9=*h&R!gO%1orL}9_N^7yw
zTCTKiWCoporPspgpUh7Da}~ov=3k<StW&SyuZvfve=WNu-yuPzx%xW#e|)`V9SZBL
zK(CQ|g!M{TuY|A&>m6Y|3hS*vubq2@<CJim68NSr?%_B`I1Yv5tU#}+dxYbaaJ&-u
zW-k_wcZB0nINl2MTDwQspo9%d;G4i$*x(2oP}pDvdJWzqY*fNVCGgE*ENpayjVNri
z0=+ix5jH7dlM?u*F%~vC!X^|pS%F@&_XsB_;RGe{&15W`;0Pz6aDo-+Ra}p-SqYn!
zz&Dw(u-Oqdqp;Zu^y;ohI8g~FDuHi4W8p+cI1z;ttw68(dW4gdaFP=ErZg5#a)gsm
zILQk1YOqH*SqUdAfp1o0;bccR8HJOrK(7*egj1AoiW2xHHWp5Cgi}yB#R~N5u}3&n
z38yN7Z*F7ZR7W@!g;SHl2>RKlM>tIhrzwGNdSl@<M>q|I)2u*06ZHtEE8%n{@Xc^6
zobCvxqj0(v{PW=qC7hvz91+fNgfmb$!wUZS(5!@JCGgF2+(WY?G^5aL1^;|FQwe7(
zp`8e4I>MPKoM{FBeAuFdElOxF!WKu^g2EOn_~*k}N;pdid=nl&OJ_O4Sty)k1^;|F
zTM1_?p@Rr#JHpv0oNWdFd^kr5=O}@1+T$M1afEYFIL8Y9`Eafh&Q${6%*VpHj&Lpt
z=UTx(AI?+4c}n1${8%{85za&5JS+I;!}&@$UkQBk9}DL@!ucqiZw3E+xIhUPD1mPZ
zWZ?owxB!I<tl*yy7b@XGCGgFHEL`Xa7ou>X75wwzA|+g;1ip!og^L{FA`~vNf`2|-
ztb~h|z&97NaIqs?jKal9A?lwGTa~a?34GHb3tJswD+*h!;GYkdDB%(%@Xd%UT;d3q
zpm2#5{PW>bC0we6JP|H+giBGl)C&IjaG4S=Q$lYME^~y-P`Jzr{`s&?3EPywH#O4#
zg|<1uHWap5!9O1^SHk5=;F}#;xZDvgN8xfS_~*kFO1MG^d=n%KS2)5IC|qF$|9rSo
z30EqizX(@4!j&joX$Aj$xJn6EDS>aA<Q}eagsV`v$_oDZaJ3SyRs!El$->o+a5V~7
zTfsjcu2I4@O5mF;S-8d#u0i1%EBNQbwMw{F34HS<3)ecrwJ2O`1^;}wP6^j3fp5xW
z;W|gS4u$Ki;GYlIE8%)2@XeYmT<-|iqj0?y{PW=kCETC{zKN5C8yw*V6mGDBe?Hu(
zgd3H>H+Qmdqa)mi!i`Cx#6KTyQo>D2;F~^KxXBT2Lg6MW_~*mTO1N1Gd^0EuH#@@3
zDBNrX|9rSb3AZSLZxUtU7Du=Rg<GuPpAWYx;Z`N^&7&;b>Ik=@aH|#k^Wion+@^#=
z5pHvY+fca83jX<UyAp0!LXil!JHqWK+-?Q`e7HjicPN2xLgi=a4oA2Hg*&X^pAUB`
z;Z7wKi*TnS+=;@SR`Ab<yOeO368NT7?%^&+xC@25tl*yycPrs;CGgFxEZpq~ccXB(
z75wwz9wpqP1is0Yg?k*~9u)4ef`2~TtAu-%z&F3LaIYiWi^9ED@Xv?)lyILC_@-DE
z?sJ6uP`J+u{`qjf67E+5-z>|*{f=-y3in&VKOY`Y!UIa+n`l{hz!4rm;Q=f7=fi_a
zcu)y^b1e%GI>Lh}JeU+>{`s(73EP#xH{G(Z-4V8<u-yv&`S6eu9#R6|jLX79j_?o)
z4_U!KA0Af1!%7$_!o!a6FbWS_!9O1!QNklih>GxtBRqn_BUbRwhewt0s1o?5Ui!b#
zqmJ+>3XfXBKOY`b!edI{n|)b$%n=?#;V~=t=fmSlcw7m56EF*pJHq2AJZ=U5e0V|$
zPbi^GgeM%~2^5~Nf`2|dse~t$P%grgj_@Q3Pg=o0AD&XeQ%c~QiTPQ2$`PJI;VCQl
z=fl%Vcv=a3lQ9cVJHpc_JZ%O4e0W9)&nSU!K4#$=M|cK>XRP3#56>#$StamI$t*nU
z2+yMMtQGw8;W;Hdrv$!PnT6*Z;W-qZvx0v<Jg<c3mB2SKv+%qlJdeWjR`Ab<7nJaV
z68Pq37G7|K7f^U1DU|x>!wx0vPy*ld%)$;w*nz?hEBNQbi%NJ=34Aj&3okmtizvKk
z1^;|_NeM40fp3y#;U!0S35A!e;GYjKE8%4&@XgaKyzB@sqwum7{PW=zCA^}9S`l7x
zgjY~_#R~rU@TwACRRZ5^%{{#82(O~>sule6;WZ_^rUbqTn}ydL;WZRqvx0v<ysm`T
zl`v6+*B#+?6kfN2e?GjSgg2DHH*IqdZ#cpmD7;|>|9p5;32!QaZ{}v<O-FbWg*UC>
zpAT;-;VmWbP2McL<p^(~@Rk+)^WkkJysZSj`J08e9pP;h-nN2&KD?uZca*?4g|qOE
zBfNvcJ67<|hj*3mt`hiWaTeZngm+PR*9!jm@SYOhQv%;a&cb_+@E!{9S;0Ra-dDo=
zO5mHzS$N+O-bdm6q)_Ic4<9Ju110cH=PZ2S2p^#EfffAo;X@^Ss06+lorMn_;X@QY
zw1R&=e58brl+Y-`M~?6j3Lja)KOa6;!pBOOCc?*#@G%M>TfsjcK2gFaO5mH?>Hk8X
zIKn3=d}0OveE3uepDKZGc4y&JNB9(lPp#me51%RFGbQj%@GN}h2%n+wnHBu=;d3Q?
zu7p`4eC`OJqwu*E{PW=pC48ZT*&=-52w$M^g%$ks;Y%fasf0NqeCY^ZqVS~^{PW=}
zC48j>zR8~cFZ7ioe1*bSR`Ab<ua)q%68PqO7QS|buTl8g3jX=<jS{|50^gL+!Z(ia
z4GP~_!9O3qRl>JQ;G6YX_|_4=Md4d3_~*lSO88C*d=ozl-#Nl}D12uH|9tpf3EwM$
zZ|-N|dq?;lh3}I>xqm+VpoAZkz&HJ~@Pi}#fWi+}@Xv=ImGGky_%HwqKRUvXDEw#z
z|9tpK2|p=;4+*gFlOz0u!cSK4&xfCt@Us&5@Bj-xJHpQ>{A>mPeE3BPzbJtZ6|nG&
zBm9EGFIMo+hhLTOs}lII0Smu6!mlX&Y6bs%_)Q7FDS;0mu<)BB{D#7BR`Ab<-<9yY
z5|)YZyCeLL!tYk_&xf5#*r^0Qw7@;=bcCHK?6iV^KK!ACKa{|S8Cdwk5&l5o4=ecR
z!=Fm{Qwe;?frURE;ZGF)w1R&={H27yl)#4{Soq5k{zBm|EBNQb-%9vf34ADmg})u)
zZxsHvf`2~zqlAByz=tJR_{S0cLE#@O_~*mFO88d^e29XDe;wgp6#lh>e?II|!Y(E7
z;R+UZIl?X!b{U~GgWvAOclRm16%74LtI2;%l|p6ku?sf%7urhV-_zu*oa8@^K#^6v
zGlJe@Mk!&f@R1Bw_#^=;lm$u{6z`m%H?L7jidNQ$!lwyPp)62RK=IBBdRH8!q-tfY
zD14#-70Lo76%_BhptsvmN}5(eDe-5FPZgj-S)inW;++}vK0ZoG*GgEFbVs2qP|`v1
z&JB8lAf;qzB}J4BN1-fGGC=Xp4tnPyrL@pWswgcSg|a|t0g88i&|4ZQB~vSDqVOpL
z{Jc;WD4C#mX9&Gll2Te~C0!IgX@Cl4fzlF`sQ1r)L@N=kWQfA24N##hP$HmsX9@ko
zx2l&ct+Wt@PaL2^S)gQr;+-e-woyvS)=H)*eChxd$^s=D6z@!-_oGruE3LE?g-;%!
zLRp}+0>wL5=#8$F(poDKQTX%$DwG9EYf!wih2B9+DQ&cpB?_NFK!vhEX=9ZF|9r{O
zN{&{tMd4Ejs8ALtIiUFGOIxk9)k-T-_#^@<lm$v#Q2g_yomSdurL`!08UYo`0;L@&
z{`t~gEA6$?Mif4gfC^=S(jFB5e96^Hu2ynH;Zq5yP!=e;p!nxY2d#9_N?TF*WCALb
z1xg1{{PU%wRyt~>ohW=d0Ts#ur6VZ*`O--%owU+k6h5JV3T1)P2^9Z)>8zE`TFDiK
zPbr{6S)g<V#Xn!VXr+r*I*7t26;PopP`ZE;_0E^BTIs5lj-v2s1ym>tl&+xo=Sw%O
zbkj;FQTW6HDwG9EH&FcZrMp(TYo)U&d};v|$^xZ3DE|4<Ln}SB(nS<Lxqu2~fzksM
z|9t7Gm7ZGZDhi)oK!vhE=?RK|zVy;cFRgSFg-<Y`LRp~nvPz+UzT{~oPb=L;$#WFS
z0woU=|9t7KmEKzEAxdvYp)62(gW{hreYDa?D?LTw(+v2GQ5GnDK=IF)zFO(4m0qIo
zi3U_C3zWW~_~%PMt@P7Mo+x~(0Ts#ur5`B%`O;r2{k76t6h7I23T1)P9~A$5*-b0E
zX{C=SyEzJFfwCJY{`oRMD+9FBSCj#cLRp{;0L4FFcGt@8TInYWpK`!wjIu!49Tfk3
z*+VOPXr;d>e9{3G$^vB%P@>-XvZq$|)XHw6@M#BBC<~N5LGjO*fm#`;l>wsgi3e0D
z3zUJN_~*-BTG>l0yNkl79#EkyQ1$}FKVSCN%HCSpLli#wfC^=SvNtIH`7%f=gS4`z
zD17<>70Lo-5GelnGFU5vwK7l?J^_IWWq~r-Dn<VJV%~|!zCM<(mAypaQxK?77AX0k
z_~%Q3?xjF0dyB#+AyA<#Pzpft&zC~26l!IVD0~_M70Lpo5ETD>Dbh-jRtAg0Cn8Xx
zEKrI-@z0kbS{b61d{OvR1S*sT$`DZe^QBlT#aby4g-=GHLRp{`gW{hrL$xwgEBu~U
z1cdl>1S*sT%1}`J^JSP;hH0fp6h0w=3T1&Z3>5!-8LpM#S{Wh=pOQd@vOpOQihsV0
z(8>s{6pO+qB~YO(P)2|f_0E@lw6c#@hKj<cB~YO(Q1$`EKVSCM%D!3|CJLXJK!vhE
z*%uW5eA!Pc`)OskD12%H70Lo-KT!PhWq+;guayy^@W}~OC<~PRLGjO*1GI90R`wBv
zPfwsiS)d#MihsTwsFee?vacw7f&vxF0_8xf4DrvGky;t4mHk8+=_r&1%1BWB^Cha4
zs8;qDCF&@Y1xgeY|9mOYN{Lnu5QR@u;4?;9pp<~(pD!`3#I$mtD14#<70Lo728w^a
zlxn3^D<ehWQx&LC7AU2l_~%QRR?4&z6@^b$ph8)ol!4-(FXdV(*Gh>fe7XV^$^xYv
z6#smw&`O0?Vxm+y3T1&(0g8XVRBEMCE2X0FDGTg{vOuW>#Xn!Fv{I#&GEw-X1uB#U
zN);$k?|d1hl~GzL7llt-ph8)oi~_|!Uq)+Xv{oua;S(3AP!=eoLGjO*F<Kd;l}b_g
z)CDS(1<Dvu{PU$+E7e-55`|A*ph8)oRD<H5FJrYbRx6`K;nNqWP!=d-LGjO*aatLt
zmC>T`2@F&y3zTtIDfZ8o8m-i5WsE3%3Ii3&0;L8N|9ly*mGN4s7KKk@ph8)oj0eR(
zUuv~dtCg{$@M#QGC<~NYQ2g_yPAhd<87B&#$Uud%K&b=8KVK$jWr9{}MB!5zs8ALt
z6F~9Lmx)@LsFm@e@W~8RC<~N{p!ny@B&|%+O06h-Is+BT0%Z~?{`oRlE0eWSCkmg?
zK!vhEnGA}5zD&`|6s=4Ug->aqLRp|p0mVOG4${g&TA3&cpVUBwvOqZql&E*U9ITat
zwK7Q*KCOWYWr1=qDE|3Uua$bOOcsStY@k9}pwxrnpD$CjGF2;6MB!5#s8ALtQ$g|1
zmqWC2h*k~~g->pvLRp|30*ZgW9IBN=wQ{g1e0l>F$^zw3Q2g_yK`RYfsTYM$aG*k2
zpfp%zsDHjRYNb&tQ$=ZX6v_gn5fuM?nWmL#S~*0NX^ui!piBeBKVPP6Wx7@l6@^c8
z;4?;9piBqFKVN2OWrkK7MBx)1s8ALtGeGgrmzi3bsg*`i_*4fflm*I6Q2g^{mR4qI
zWtu2_vI7;$0%aB`{`oRnE3>sST@*gufeK}TG8+{Ce3_$_Ia-+^3ZL*mg|a}I1B!pX
z%+<<Vt;`gKPkEq1S)j}X#Xn!>X=R>PW{JWlJy4-6Q09RW_0E_1TA8nv*`n}i4^$`%
zl=-0e=gR`EEYQjvQTW6MDwGAv0#N+(WuaCUYGtk{eCh)g$^vB}DE|3!m{tzc$~;l{
z<OeF01<GNd_~*;vS~*-R^F`s)AE;0kD2IdMpD&BFvPdfnMBx)4s8ALti>xxtKVO=(
z(xjDzqVOpYR45CSCQ$tI<p`}Dp_Ri#;gcY!P!=dhfa0Goi?y;?D~F51r$JDmEKnAM
z;-4=|w6a7ii$viQA*fImC`&-`&zGfIS*n#LQTS8{DwGAvQc(Q!Wtmo%Y2^q}_+$tw
zlm*H%Q2g`dNUa>HmBpg)=@3*X3zQ>4@z0l|v~rYImWaY9L{OnDP>uq{KVOz>Ww}<C
zio&NvP@ybPmV@G-FDtaNLMzKe;gce$P!=dFK#6+i%Sx@R)XI^f@M#fLC<~O8p!ny@
zDy^*2%2A^5i4jyN3zSu$_~*;fS~*%P%SGW+BdAaoC`W_hpD(MmvRW%EMB$Sos8ALt
zt3mP4mt(YYj8;~P!e>WNp)6320mVOGj@8PsT3ICupB+JkvOqc3D#QKrWsO$WXys^8
z);J1ffwBe^|9n}im9<(~Eef9<!Coi}l(nGv=gT^+tkcRdqO5Zi$^vB_DE|4fUMuUh
za;zxp9fh($Sr3YTz8t5O<Fv9yl;a$QvOqZw6#slVUMt6IWvwX3I|^liay%&h`LaPP
z8?+KijsJXqgQHLuC>ucW&zFr_*{GGUC>tGxvOw7gihsUr(#j^Sq=>S~Q78+PO`!Pa
z%L!UJK`W`EoZu*w1<DDaM7{H6vsN~1B~6sgjzU?WYzD<YUryA@iCRe)<wQrJEKp7a
z#Xnz8(#lC%$q?lvN1-fGP6EY0UryG_$y#Y4%E^vGS)iN@ihsVGqLov$k}1k5jzU?W
zoC1n}zMQI+Q?=4klv5prvOqc2D*pEm$vRCdr)ec3%4v>5S)iN-ihsVGu9efZk|oON
zjzU?WoDPbAzMP?zGqjQ|${CJAS)iN&ihsT|Yo%E$twd>d6v_gn85I9~Ia4cVYNfR(
zXF3XHfpR7&{`s;+D_gYEMwBg%LRp|}0mVOG&eF<RTFDXREJvX%P|gCyKVQz)%Gp|J
zE6Ul9LRp}k4T^uhoTHU<w9-zLa~y@TKsg5#|9m-DE9YvZy(s583T1(EE+|p&d^t}m
z=V>KZl=B>gvOqZx6#slVUn}QprGqHvI|^liay}^j`Er3)F3?IxQ7&*4$^zvAQ2g`d
zLakh=l}@5u=qQv0%7vi#=gUP}xkxLWMY+gPC<~N}K=IF)i?wpGR=S9Cv7=BHC>LAB
z|NbLcTeY%PD_up|>L`>2%2rVP^W_q)T%wh3qFmxAlm*Hqp!ny@rCPaEE8Ru8)KMr4
zluJSJ&zH-za+y|oh;o^uP!=ecf#RPp+qAMxD?LTo<|vc}$~I8^^W}1_T&|T~qFnAM
zlm*J=p!ny@6<WDMD|w<^;V6^^$`zpa=gXB^xl${=MY+;ZC<~M;LGjO*tF&^JR{Dr?
zm7`D=C|7~vpD$Ny<!Y_;73FG2p)63Y1|{m9FV|@08m;sb<r+t!EKsfi#Xn!J)ylP6
z=`YH)jzU?WTnmbSzFeo3>$I|)DAzd(Wr1=XDE|3!y;iQ*$^cQWcNEG3<$6&3^W_Gu
z+@O`+MY+LIC<~MuK=IF)8?|zyR`w9(Mn|D6P;Rt}|NTp{Zqmw4TG>;Sn;eC*K)DGN
z|9rVwD>rLppeQ#x3T1(EGbsM~a*I}O(aK(;+~O#d1<Ea;_~*;5TDes#dy8_bqfizo
zw}RrIFSlvsHmwX2<u*s5EKqI(#Xnze*UIf$87#`}jzU?W+zyI=zTBaeJG7E7${mhE
zS)kkjihsV`sg*mmQXtBmjzU?W+zE<*zTBmiyR=d$%3Y2^S)kknihsV`t(CjAQY6aV
zjzU?W+zm?9J74b6$~{^cBFa6ELRp~P1B!pX+^dy)wNfm~y^cazpxg_Jf4<zOmHV_Z
zRFwN1g|a}o4;24=xnC>yYh{=y_d5z@fpR}6{`vBNRvysGa8Vv`6v_hS0Z{z&<w31H
zsFe|-Jm@Ht1<Hd~@xT8`)^@FI*UCPkY<CpO0%bcW{`vBdRvyyIzM?$jD3k@tL!kKQ
z%fniESS$O9^01>&7AOyc;-4>%Xyp;D>@UhAjzU?WJOYY;zC5axN40W*D33Y{Wr6Z2
zDE|5Km{uOs%7LOh<|vc}%44AT=gZ?-d0Z<aMS0v&C<~OwLGjO*C$#c}R-&Rj;V6^^
z$`hdY=gX5?c~UDSqCDv+lm*I@p!ny@Q(AdSD=|@?aumt}<tb32-ud#hR-V>MsVGl7
z3T1)vG${W0@{CrV(Mp*p&o~NYf$|I}{`vB(R-V;LxhT&%3T1)vEGYi@@|;$l(@KRX
z&p8TZf$|(E{`vB}R-V^Nr6|uk3T1)vJShJ8@`6@g&`OmkFE|Qif%1Y?{O_NVwL>dA
zv@%MR9gad-pzHv}KVM$d%8ObVEy|0ILRp}^2#SBcyrh+vv@%ANmmGz%KzRui|9p8_
zD=%xMT9lU^g|a|-85I9~c||L)Xl1M@uQ&>2f$|C{{`vB%R$kT0I8k186v_hSRZ#r%
z<u$Fmrj;5|UUL-60_8PO{PX2?t-P+4@uIx$D3k@t>!A4O%NtsGLo2nSyx}O61<D(s
z_~*-;T6t3|b)vlKD3k@to1jF!^W`nAyrq>1qP*oOlm*ILp!ny@+gf>BD-%U|+fgVB
zl(#|g&zE<!@{U#}iSmx4P!=fffa0Go?`q{;txOi>T}PoTP~HW_KVRO{%6nRwBFcM?
zLRp}^2a12byswq_wQ`Us?>h=*f%3jp{O`Y#^?_DC(8|H0eBdaQ1<D7Y_~*-qTKP~b
z^`d;}D3k@thoJc9%ST%INGnrC`N&Zy3zUyQ@z0l!weqo64iV*JN1-fGJ_f}<Up~>w
zCt5jFlusOmvOxI+6#snrR4boqr9qTW9fh($`4klYeECc(pJ}C0l+PT6vOxI^6#snr
zTq~bzWtu3TI|^li@;NB}`SOKUzR=2aQNC~#$^zvJQ2g`dORapVl^LRZ=_r&1%9o%-
zz4PTOt$d}GnWB8<D3k@tSD^Uk%hy`@S}U_e`Pxw^3zV-x@z0lUwDOHsW{dKTqfizo
z-+<zuFW+kATdm9y<y%LgEKt4$#Xn!Z)5>>RnJdb7jzU?Wd<TkuzI?Bh@3k^dl<ysd
zvOxLXD*pFx$@)PnKWJsXC_gv~Wr6YoDE|5KqgH;@$^ub-bQH=0<wsEb^W`V4{G^qI
zqWt72lm*I9p!ny@&szCeD~E~lv!hTJC_jVZpD({?<rl3SF3K;CLRp~v0*ZgW{Hm2-
zwX#T*Umb<AK=~CE|9tsPE5B)_NtE9lg|a~T4HW-;`CTi&Yvl-0es>hg0_As5{PSg}
zR(5J-u_!wog|a}|35tKd{GpXUw6a8$KOBX!K=}idsCT~nsg*yqvQ(5m9fh($`4bfX
zeECZ&e`#fzD1SK$Wr6Y+DE|5Kw^shv%8{b{?I@H5%HN>)=gU7@`9~{9iSm!5P!=fv
zfa0Go|7zu5tt=PiUq_)VQ2qtQKVNofWtUb~h_cI3C<~NbNu}_=-v1><y$e7nMZN#a
zN>M^|5&}=Agi=rmr6k_}r7+(=U&2}mYh{%vVMn1X=p_t_f4-z>B}FSoi^A_Wg1t}{
zC@G-$=S!+qQnj*L6n?)ER45CSR8ai$B~2@7S~*4(e!me^C<~M{Q2g^HT`TEYIaU;Y
zzY$a@3zT$F{PQJ4D;Zi@BMQIY2r85XN(LzY`O-owEwr*$6n?)ER45CS7OdoUn>whW
zqNc2&EWa=`b#Q7!T}eZ%W@25eE;cr&x&wWX9;k^`(Sfp9ZC%?@S&=(7wF;$V^ZO*3
zcVh~LE5bXocV>q(>G3e%7at1!P9NTxos3)U;<s)3d1I$gDE{$KC=%MWD~m6s|D}Y?
zN9fPC`CsO)UAu0S^;PO4+js4Hkl$j8{<r;r%>!+<_+wmva(89M!{o0VuL#wzi=|PY
zaxkuDY)yVNe`qMPVPaKjD}Fq0@vJ3_mMxw!YY9C_{|0U(E8cOdNTed1mywqd&fy}X
z(rPMeYU2}37ojI9uX54SriIJq{6A}L&)%LL?z|$Dv&U4HiW=Hwq=jkkv>wvXE;B8X
z!f$#)Q89mnyU5wsej4i64Jw};lP{v<%c>{l=hG)HxZ|Akob+%uDP`TJ@~1GTx+{Mc
z>(^z~<>xnKHbhHnshd6P@`uL*`izA`xm2g1G_=hu3KNSWUQp+`b>;TrUZMImHC46a
zQzDI#?3`GdLF(7;GdPtQzLGy0uBja#&7@yS_?H;}QkogcqyLogx}1Nh;9n{;>(>n#
zT~bP$sjMo^j_ycJjrY_h{#oc8=}-}F3^mf*W>th|hGx=#>7OF!Pe{M&aTAkSZQ84>
z%t(5lkomL~j;Wat|7uOO)9Cr4Pdm*R{ydA26KPcuUY@!<H8Zo%8dJG2Hm*9ElTKIr
zb9ScgObuoB$uT+oYbV5#yU8Ml|InDyO`)bxII~YE%$sggS00t;Jtag>B|lIi52Vrq
QIobSYGB<<%R2GE(4_Np=IsgCw
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/FACP.thread-count2 b/tests/data/acpi/q35/FACP.thread-count2
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..31fa5dd19c213034eef4eeefa6a04e61dadd8a2a 100644
GIT binary patch
literal 244
zcmZ>BbPo8!z`($~*~#D8BUr&HBEVSz2pEB4AU24G0Y(N+hD|^Y6El!tgNU*~X%LSC
z$X0-fGcm9T0LA|E|L2FOWMD92VqjR>!otAF!NBm72O<iWged~jj0!*k$y^{03>bk1
YBHITON2VDSAnpK(F*YFF1LDH~0O^Si0RR91
literal 0
HcmV?d00001
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index d17d80e21ab9..dfb8523c8bf4 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/APIC.thread-count2",
-"tests/data/acpi/q35/DSDT.thread-count2",
-"tests/data/acpi/q35/FACP.thread-count2",
--
2.34.1
^ permalink raw reply related [flat|nested] 38+ messages in thread* Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
2023-08-25 3:36 [PATCH 00/16] tests: Add CPU topology related smbios test cases Zhao Liu
` (15 preceding siblings ...)
2023-08-25 3:36 ` [PATCH 16/16] tests: bios-tables-test: Add ACPI table binaries for type4 thread count2 test Zhao Liu
@ 2023-09-01 9:55 ` Michael Tokarev
2023-09-05 6:56 ` Zhao Liu
2023-09-06 14:40 ` Philippe Mathieu-Daudé
16 siblings, 2 replies; 38+ messages in thread
From: Michael Tokarev @ 2023-09-01 9:55 UTC (permalink / raw)
To: Zhao Liu, Michael S . Tsirkin, Igor Mammedov, Ani Sinha,
Eduardo Habkost, Marcel Apfelbaum, Philippe Mathieu-Daudé,
Yanan Wang, qemu-devel
Cc: Zhenyu Wang, Zhao Liu
25.08.2023 06:36, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> Hi all,
>
> This patchset is the follow up tests of previous topology fixes in
> smbios [1].
>
> In this patchset, add these test cases:
>
> 1. Add the case to test 2 newly added topology helpers (patch 1):
> * machine_topo_get_cores_per_socket()
> * machine_topo_get_threads_per_socket()
>
> 2. Add the cases in bios-tables-test.c to:
> * test smbios type4 table count (patch 2-4).
> * test smbios type4 core count field (patch 5-7).
> * update the test of smbios type4 core count2 field (patch 8-10).
> * test smbios type4 thread count (patch 11-13).
> * test smbios type4 thread count2 (patch 14-16).
>
> With the above new cases, cover all commits of [1] in test.
>
> [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
Hmm. I definitely didn't expect such a large patchset.. I asked for just
a small, maybe manual (from command-line) reproducer of the original issue,
so I can verify it is fixed before applying the change in question to qemu
stable trees. It is a large work. Lemme at least give it a try in the
gitlab CI...
Philippe, can you pick this up for the misc tree?
/mjt
^ permalink raw reply [flat|nested] 38+ messages in thread* Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
2023-09-01 9:55 ` [PATCH 00/16] tests: Add CPU topology related smbios test cases Michael Tokarev
@ 2023-09-05 6:56 ` Zhao Liu
2023-09-15 13:48 ` Michael S. Tsirkin
2023-09-06 14:40 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 38+ messages in thread
From: Zhao Liu @ 2023-09-05 6:56 UTC (permalink / raw)
To: Michael Tokarev
Cc: Michael S . Tsirkin, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel, Zhenyu Wang, Zhao Liu
Hi Michael,
On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote:
> Date: Fri, 1 Sep 2023 12:55:33 +0300
> From: Michael Tokarev <mjt@tls.msk.ru>
> Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
>
> 25.08.2023 06:36, Zhao Liu wrote:
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > Hi all,
> >
> > This patchset is the follow up tests of previous topology fixes in
> > smbios [1].
> >
> > In this patchset, add these test cases:
> >
> > 1. Add the case to test 2 newly added topology helpers (patch 1):
> > * machine_topo_get_cores_per_socket()
> > * machine_topo_get_threads_per_socket()
> >
> > 2. Add the cases in bios-tables-test.c to:
> > * test smbios type4 table count (patch 2-4).
> > * test smbios type4 core count field (patch 5-7).
> > * update the test of smbios type4 core count2 field (patch 8-10).
> > * test smbios type4 thread count (patch 11-13).
> > * test smbios type4 thread count2 (patch 14-16).
> >
> > With the above new cases, cover all commits of [1] in test.
> >
> > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
>
> Hmm. I definitely didn't expect such a large patchset.. I asked for just
> a small, maybe manual (from command-line) reproducer of the original issue,
> so I can verify it is fixed before applying the change in question to qemu
> stable trees.
Since these issues are found by coding reading, they are "byproducts" of
other topology-related work I've been woring on, not directly identified
by any anomaly...
...So I'm not quite sure what the consequences of these few misuses of
topology fields are, and how they might manifest themselves.
> It is a large work. Lemme at least give it a try in the
> gitlab CI...
The test cases are the ones that clearly define the relevant topology
issues.
Thanks,
Zhao
>
> Philippe, can you pick this up for the misc tree?
>
> /mjt
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
2023-09-05 6:56 ` Zhao Liu
@ 2023-09-15 13:48 ` Michael S. Tsirkin
2023-09-15 14:30 ` Igor Mammedov
0 siblings, 1 reply; 38+ messages in thread
From: Michael S. Tsirkin @ 2023-09-15 13:48 UTC (permalink / raw)
To: Zhao Liu
Cc: Michael Tokarev, Igor Mammedov, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel, Zhenyu Wang, Zhao Liu
On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote:
> Hi Michael,
>
> On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote:
> > Date: Fri, 1 Sep 2023 12:55:33 +0300
> > From: Michael Tokarev <mjt@tls.msk.ru>
> > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
> >
> > 25.08.2023 06:36, Zhao Liu wrote:
> > > From: Zhao Liu <zhao1.liu@intel.com>
> > >
> > > Hi all,
> > >
> > > This patchset is the follow up tests of previous topology fixes in
> > > smbios [1].
> > >
> > > In this patchset, add these test cases:
> > >
> > > 1. Add the case to test 2 newly added topology helpers (patch 1):
> > > * machine_topo_get_cores_per_socket()
> > > * machine_topo_get_threads_per_socket()
> > >
> > > 2. Add the cases in bios-tables-test.c to:
> > > * test smbios type4 table count (patch 2-4).
> > > * test smbios type4 core count field (patch 5-7).
> > > * update the test of smbios type4 core count2 field (patch 8-10).
> > > * test smbios type4 thread count (patch 11-13).
> > > * test smbios type4 thread count2 (patch 14-16).
> > >
> > > With the above new cases, cover all commits of [1] in test.
> > >
> > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
> >
> > Hmm. I definitely didn't expect such a large patchset.. I asked for just
> > a small, maybe manual (from command-line) reproducer of the original issue,
> > so I can verify it is fixed before applying the change in question to qemu
> > stable trees.
>
> Since these issues are found by coding reading, they are "byproducts" of
> other topology-related work I've been woring on, not directly identified
> by any anomaly...
>
> ...So I'm not quite sure what the consequences of these few misuses of
> topology fields are, and how they might manifest themselves.
>
> > It is a large work. Lemme at least give it a try in the
> > gitlab CI...
>
> The test cases are the ones that clearly define the relevant topology
> issues.
>
>
> Thanks,
> Zhao
I think it's ok, as long as Igor's happy.
> >
> > Philippe, can you pick this up for the misc tree?
> >
> > /mjt
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
2023-09-15 13:48 ` Michael S. Tsirkin
@ 2023-09-15 14:30 ` Igor Mammedov
2023-09-19 6:46 ` Zhao Liu
0 siblings, 1 reply; 38+ messages in thread
From: Igor Mammedov @ 2023-09-15 14:30 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Zhao Liu, Michael Tokarev, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel, Zhenyu Wang, Zhao Liu
On Fri, 15 Sep 2023 09:48:08 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote:
> > Hi Michael,
> >
> > On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote:
> > > Date: Fri, 1 Sep 2023 12:55:33 +0300
> > > From: Michael Tokarev <mjt@tls.msk.ru>
> > > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
> > >
> > > 25.08.2023 06:36, Zhao Liu wrote:
> > > > From: Zhao Liu <zhao1.liu@intel.com>
> > > >
> > > > Hi all,
> > > >
> > > > This patchset is the follow up tests of previous topology fixes in
> > > > smbios [1].
> > > >
> > > > In this patchset, add these test cases:
> > > >
> > > > 1. Add the case to test 2 newly added topology helpers (patch 1):
> > > > * machine_topo_get_cores_per_socket()
> > > > * machine_topo_get_threads_per_socket()
> > > >
> > > > 2. Add the cases in bios-tables-test.c to:
> > > > * test smbios type4 table count (patch 2-4).
> > > > * test smbios type4 core count field (patch 5-7).
> > > > * update the test of smbios type4 core count2 field (patch 8-10).
> > > > * test smbios type4 thread count (patch 11-13).
> > > > * test smbios type4 thread count2 (patch 14-16).
> > > >
> > > > With the above new cases, cover all commits of [1] in test.
> > > >
> > > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
> > >
> > > Hmm. I definitely didn't expect such a large patchset.. I asked for just
> > > a small, maybe manual (from command-line) reproducer of the original issue,
> > > so I can verify it is fixed before applying the change in question to qemu
> > > stable trees.
> >
> > Since these issues are found by coding reading, they are "byproducts" of
> > other topology-related work I've been woring on, not directly identified
> > by any anomaly...
> >
> > ...So I'm not quite sure what the consequences of these few misuses of
> > topology fields are, and how they might manifest themselves.
> >
> > > It is a large work. Lemme at least give it a try in the
> > > gitlab CI...
> >
> > The test cases are the ones that clearly define the relevant topology
> > issues.
> >
> >
> > Thanks,
> > Zhao
>
> I think it's ok, as long as Igor's happy.
series looks fine to me
(modulo cosmetic issues and better commit messages as noted in per patch review)
>
> > >
> > > Philippe, can you pick this up for the misc tree?
> > >
> > > /mjt
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
2023-09-15 14:30 ` Igor Mammedov
@ 2023-09-19 6:46 ` Zhao Liu
0 siblings, 0 replies; 38+ messages in thread
From: Zhao Liu @ 2023-09-19 6:46 UTC (permalink / raw)
To: Igor Mammedov
Cc: Michael S. Tsirkin, Michael Tokarev, Ani Sinha, Eduardo Habkost,
Marcel Apfelbaum, Philippe Mathieu-Daudé, Yanan Wang,
qemu-devel, Zhenyu Wang, Zhao Liu
On Fri, Sep 15, 2023 at 04:30:55PM +0200, Igor Mammedov wrote:
> Date: Fri, 15 Sep 2023 16:30:55 +0200
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu)
>
> On Fri, 15 Sep 2023 09:48:08 -0400
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Tue, Sep 05, 2023 at 02:56:46PM +0800, Zhao Liu wrote:
> > > Hi Michael,
> > >
> > > On Fri, Sep 01, 2023 at 12:55:33PM +0300, Michael Tokarev wrote:
> > > > Date: Fri, 1 Sep 2023 12:55:33 +0300
> > > > From: Michael Tokarev <mjt@tls.msk.ru>
> > > > Subject: Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
> > > >
> > > > 25.08.2023 06:36, Zhao Liu wrote:
> > > > > From: Zhao Liu <zhao1.liu@intel.com>
> > > > >
> > > > > Hi all,
> > > > >
> > > > > This patchset is the follow up tests of previous topology fixes in
> > > > > smbios [1].
> > > > >
> > > > > In this patchset, add these test cases:
> > > > >
> > > > > 1. Add the case to test 2 newly added topology helpers (patch 1):
> > > > > * machine_topo_get_cores_per_socket()
> > > > > * machine_topo_get_threads_per_socket()
> > > > >
> > > > > 2. Add the cases in bios-tables-test.c to:
> > > > > * test smbios type4 table count (patch 2-4).
> > > > > * test smbios type4 core count field (patch 5-7).
> > > > > * update the test of smbios type4 core count2 field (patch 8-10).
> > > > > * test smbios type4 thread count (patch 11-13).
> > > > > * test smbios type4 thread count2 (patch 14-16).
> > > > >
> > > > > With the above new cases, cover all commits of [1] in test.
> > > > >
> > > > > [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
> > > >
> > > > Hmm. I definitely didn't expect such a large patchset.. I asked for just
> > > > a small, maybe manual (from command-line) reproducer of the original issue,
> > > > so I can verify it is fixed before applying the change in question to qemu
> > > > stable trees.
> > >
> > > Since these issues are found by coding reading, they are "byproducts" of
> > > other topology-related work I've been woring on, not directly identified
> > > by any anomaly...
> > >
> > > ...So I'm not quite sure what the consequences of these few misuses of
> > > topology fields are, and how they might manifest themselves.
> > >
> > > > It is a large work. Lemme at least give it a try in the
> > > > gitlab CI...
> > >
> > > The test cases are the ones that clearly define the relevant topology
> > > issues.
> > >
> > >
> > > Thanks,
> > > Zhao
> >
> > I think it's ok, as long as Igor's happy.
>
> series looks fine to me
> (modulo cosmetic issues and better commit messages as noted in per patch review)
Thanks Igor!
-Zhao
>
> >
> > > >
> > > > Philippe, can you pick this up for the misc tree?
> > > >
> > > > /mjt
> >
>
^ permalink raw reply [flat|nested] 38+ messages in thread
* Re: [PATCH 00/16] tests: Add CPU topology related smbios test cases
2023-09-01 9:55 ` [PATCH 00/16] tests: Add CPU topology related smbios test cases Michael Tokarev
2023-09-05 6:56 ` Zhao Liu
@ 2023-09-06 14:40 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 38+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-09-06 14:40 UTC (permalink / raw)
To: Michael Tokarev, Zhao Liu, Michael S . Tsirkin, Igor Mammedov,
Ani Sinha, Eduardo Habkost, Marcel Apfelbaum, Yanan Wang,
qemu-devel
Cc: Zhenyu Wang, Zhao Liu
On 1/9/23 11:55, Michael Tokarev wrote:
> 25.08.2023 06:36, Zhao Liu wrote:
>> From: Zhao Liu <zhao1.liu@intel.com>
>>
>> Hi all,
>>
>> This patchset is the follow up tests of previous topology fixes in
>> smbios [1].
>>
>> In this patchset, add these test cases:
>>
>> 1. Add the case to test 2 newly added topology helpers (patch 1):
>> * machine_topo_get_cores_per_socket()
>> * machine_topo_get_threads_per_socket()
>>
>> 2. Add the cases in bios-tables-test.c to:
>> * test smbios type4 table count (patch 2-4).
>> * test smbios type4 core count field (patch 5-7).
>> * update the test of smbios type4 core count2 field (patch 8-10).
>> * test smbios type4 thread count (patch 11-13).
>> * test smbios type4 thread count2 (patch 14-16).
>>
>> With the above new cases, cover all commits of [1] in test.
>>
>> [1]: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg06225.html
>
> Hmm. I definitely didn't expect such a large patchset.. I asked for just
> a small, maybe manual (from command-line) reproducer of the original issue,
> so I can verify it is fixed before applying the change in question to qemu
> stable trees. It is a large work. Lemme at least give it a try in the
> gitlab CI...
>
> Philippe, can you pick this up for the misc tree?
This area have well defined maintainers:
$ ./scripts/get_maintainer.pl -f tests/data/acpi/
"Michael S. Tsirkin" <mst@redhat.com> (supporter:ACPI/SMBIOS)
Igor Mammedov <imammedo@redhat.com> (supporter:ACPI/SMBIOS)
Ani Sinha <anisinha@redhat.com> (reviewer:ACPI/SMBIOS)
So I'll pass ;)
^ permalink raw reply [flat|nested] 38+ messages in thread