qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org
Subject: [PATCH v2 0/3] accel/tcg: Alternate fix for #1866
Date: Fri, 15 Sep 2023 09:32:51 -0700	[thread overview]
Message-ID: <20230915163254.123338-1-richard.henderson@linaro.org> (raw)

Supercedes: 20230914174436.1597356-1-richard.henderson@linaro.org
("[PATCH 0/6] accel/tcg: Always require can_do_io (#1866)")

An alternate fix for #1866 without touching can_do_io, and is
perhaps a bit cleaner and clearer.

Instead, the current cpu checks whether an address space update
is required on each entry to the slow path.  This certainly
catches all i/o.  It easily works for the sequential case of
two i/o, the first of which changes the address space and the
second of which requires the new address space.

I've done a tiny bit of performance testing between the two
solutions and it seems to be a wash.  So now it's simply a
matter of cleanliness.


r~


Richard Henderson (3):
  softmmu: Use cpu->created in tcg_commit
  softmmu: Introduce AddressSpaceDispatch generation numbers
  softmmu: Introduce cpu_address_space_sync

 include/exec/memory.h |  6 ++++++
 accel/tcg/cputlb.c    |  2 ++
 softmmu/physmem.c     | 46 ++++++++++++++++++++++++++++++++++++-------
 3 files changed, 47 insertions(+), 7 deletions(-)

-- 
2.34.1



             reply	other threads:[~2023-09-15 16:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 16:32 Richard Henderson [this message]
2023-09-15 16:32 ` [PATCH v2 1/3] softmmu: Use cpu->created in tcg_commit Richard Henderson
2023-09-15 16:55   ` Philippe Mathieu-Daudé
2023-09-15 16:32 ` [PATCH v2 2/3] softmmu: Introduce AddressSpaceDispatch generation numbers Richard Henderson
2023-09-15 16:32 ` [PATCH v2 3/3] softmmu: Introduce cpu_address_space_sync Richard Henderson
2023-09-15 16:57   ` Philippe Mathieu-Daudé
2023-09-15 17:19     ` Richard Henderson
2023-09-15 16:55 ` [PATCH v2 0/3] accel/tcg: Alternate fix for #1866 Philippe Mathieu-Daudé
2023-09-15 17:18   ` Richard Henderson
2023-09-15 18:54 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230915163254.123338-1-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).