From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org
Subject: [PATCH v2 1/3] softmmu: Use cpu->created in tcg_commit
Date: Fri, 15 Sep 2023 09:32:52 -0700 [thread overview]
Message-ID: <20230915163254.123338-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230915163254.123338-1-richard.henderson@linaro.org>
Use created not halt_cond to test for cpu created.
Fixes: 0d58c660689f ("softmmu: Use async_run_on_cpu in tcg_commit")
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
softmmu/physmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/softmmu/physmem.c b/softmmu/physmem.c
index 18277ddd67..88fafec1da 100644
--- a/softmmu/physmem.c
+++ b/softmmu/physmem.c
@@ -2515,9 +2515,9 @@ static void tcg_commit(MemoryListener *listener)
* the memory data structures.
*
* That said, the listener is also called during realize, before
- * all of the tcg machinery for run-on is initialized: thus halt_cond.
+ * all of the tcg machinery for run-on is initialized: thus created.
*/
- if (cpu->halt_cond) {
+ if (cpu->created) {
async_run_on_cpu(cpu, tcg_commit_cpu, RUN_ON_CPU_HOST_PTR(cpuas));
} else {
tcg_commit_cpu(cpu, RUN_ON_CPU_HOST_PTR(cpuas));
--
2.34.1
next prev parent reply other threads:[~2023-09-15 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 16:32 [PATCH v2 0/3] accel/tcg: Alternate fix for #1866 Richard Henderson
2023-09-15 16:32 ` Richard Henderson [this message]
2023-09-15 16:55 ` [PATCH v2 1/3] softmmu: Use cpu->created in tcg_commit Philippe Mathieu-Daudé
2023-09-15 16:32 ` [PATCH v2 2/3] softmmu: Introduce AddressSpaceDispatch generation numbers Richard Henderson
2023-09-15 16:32 ` [PATCH v2 3/3] softmmu: Introduce cpu_address_space_sync Richard Henderson
2023-09-15 16:57 ` Philippe Mathieu-Daudé
2023-09-15 17:19 ` Richard Henderson
2023-09-15 16:55 ` [PATCH v2 0/3] accel/tcg: Alternate fix for #1866 Philippe Mathieu-Daudé
2023-09-15 17:18 ` Richard Henderson
2023-09-15 18:54 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915163254.123338-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).