From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, "Michael Tsirkin" <mst@redhat.com>,
"Fan Ni" <fan.ni@samsung.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
linuxarm@huawei.com
Subject: Re: [PATCH 4/4] hw/cxl: Line length reductions
Date: Fri, 15 Sep 2023 18:01:30 +0100 [thread overview]
Message-ID: <20230915180130.00001205@Huawei.com> (raw)
In-Reply-To: <27faaaee-9fb0-3e11-0545-35945ec68e74@tls.msk.ru>
On Thu, 14 Sep 2023 15:57:55 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:
> 13.09.2023 18:05, Jonathan Cameron via wrote:
> > Michael Tsirkin observed that there were some unnecessarily
> > long lines in the CXL code in a recent review.
> > This patch is intended to rectify that where it does not
> > hurt readability.
>
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
>
> This whole series can be picked up into trivial-patches tree
> (whcih is getting ready to be pushed to master).
I've reworked patch 2 as you made some good points about the
changes making unclear code even more unclear.
Also, I have this on top of a series that touches the same bit
of code. For me landing that is more important than this, hence
the ordering of the series.
Hopefully Michael Tsirkin will pick up v2 along with the
other series, or whcih can take this in the future once the
dependency is in place.
Jonathan
>
> /mjt
>
>
next prev parent reply other threads:[~2023-09-15 17:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 15:05 [PATCH 0/4] hw/cxl: Line length reduction and related Jonathan Cameron via
2023-09-13 15:05 ` [PATCH 1/4] hw/cxl: Use a switch to explicitly check size in caps_reg_read() Jonathan Cameron via
2023-09-13 15:13 ` Philippe Mathieu-Daudé
2023-09-13 15:05 ` [PATCH 2/4] hw/cxl: Use available size parameter to index into register arrays Jonathan Cameron via
2023-09-14 12:54 ` Michael Tokarev
2023-09-18 12:29 ` Jonathan Cameron via
2023-09-13 15:05 ` [PATCH 3/4] hw/cxl: CXLDVSECPortExtensions renamed to CXLDVSECPortExt Jonathan Cameron via
2023-09-14 5:44 ` Philippe Mathieu-Daudé
2023-09-13 15:05 ` [PATCH 4/4] hw/cxl: Line length reductions Jonathan Cameron via
2023-09-14 12:57 ` Michael Tokarev
2023-09-15 17:01 ` Jonathan Cameron via [this message]
2023-09-15 17:07 ` Jonathan Cameron via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915180130.00001205@Huawei.com \
--to=qemu-devel@nongnu.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=fan.ni@samsung.com \
--cc=linuxarm@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).