From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 795C6EED61A for ; Fri, 15 Sep 2023 17:07:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhCHs-0005EK-0O; Fri, 15 Sep 2023 13:07:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCHp-0005Dw-De for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:07:21 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhCHn-0001Zh-TN for qemu-devel@nongnu.org; Fri, 15 Sep 2023 13:07:21 -0400 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RnLFT74Dkz6K5xl; Sat, 16 Sep 2023 01:06:37 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 15 Sep 2023 18:07:17 +0100 Date: Fri, 15 Sep 2023 18:07:16 +0100 To: Jonathan Cameron via , CC: Jonathan Cameron , Michael Tokarev , Michael Tsirkin , Fan Ni , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 4/4] hw/cxl: Line length reductions Message-ID: <20230915180643.000057f7@huawei.com> In-Reply-To: <20230915180130.00001205@Huawei.com> References: <20230913150521.30035-1-Jonathan.Cameron@huawei.com> <20230913150521.30035-5-Jonathan.Cameron@huawei.com> <27faaaee-9fb0-3e11-0545-35945ec68e74@tls.msk.ru> <20230915180130.00001205@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 15 Sep 2023 18:01:30 +0100 Jonathan Cameron via wrote: > On Thu, 14 Sep 2023 15:57:55 +0300 > Michael Tokarev wrote: > > > 13.09.2023 18:05, Jonathan Cameron via wrote: > > > Michael Tsirkin observed that there were some unnecessarily > > > long lines in the CXL code in a recent review. > > > This patch is intended to rectify that where it does not > > > hurt readability. > > > > Reviewed-by: Michael Tokarev > > > > This whole series can be picked up into trivial-patches tree > > (whcih is getting ready to be pushed to master). > > I've reworked patch 2 as you made some good points about the > changes making unclear code even more unclear. > > Also, I have this on top of a series that touches the same bit > of code. For me landing that is more important than this, hence > the ordering of the series. > > Hopefully Michael Tsirkin will pick up v2 along with the > other series, or whcih can take this in the future once the > dependency is in place. You that is. I briefly imagined there was someone using the tag whcih :) Friday evening is my excuse... Too much code review today it seems. Jonathan > > Jonathan > > > > > > /mjt > > > > > > >