From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
kvm@vger.kernel.org, "Yanan Wang" <wangyanan55@huawei.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: [PATCH 1/5] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize()
Date: Fri, 15 Sep 2023 21:00:04 +0200 [thread overview]
Message-ID: <20230915190009.68404-2-philmd@linaro.org> (raw)
In-Reply-To: <20230915190009.68404-1-philmd@linaro.org>
We use the '*fn' suffix for handlers, this is a public method.
Drop the suffix.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/qemu/accel.h | 4 ++--
accel/accel-common.c | 2 +-
cpu.c | 2 +-
target/i386/kvm/kvm-cpu.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/qemu/accel.h b/include/qemu/accel.h
index e84db2e3e5..cb64a07b84 100644
--- a/include/qemu/accel.h
+++ b/include/qemu/accel.h
@@ -90,11 +90,11 @@ void accel_setup_post(MachineState *ms);
void accel_cpu_instance_init(CPUState *cpu);
/**
- * accel_cpu_realizefn:
+ * accel_cpu_realize:
* @cpu: The CPU that needs to call accel-specific cpu realization.
* @errp: currently unused.
*/
-bool accel_cpu_realizefn(CPUState *cpu, Error **errp);
+bool accel_cpu_realize(CPUState *cpu, Error **errp);
/**
* accel_supported_gdbstub_sstep_flags:
diff --git a/accel/accel-common.c b/accel/accel-common.c
index df72cc989a..b953855e8b 100644
--- a/accel/accel-common.c
+++ b/accel/accel-common.c
@@ -119,7 +119,7 @@ void accel_cpu_instance_init(CPUState *cpu)
}
}
-bool accel_cpu_realizefn(CPUState *cpu, Error **errp)
+bool accel_cpu_realize(CPUState *cpu, Error **errp)
{
CPUClass *cc = CPU_GET_CLASS(cpu);
diff --git a/cpu.c b/cpu.c
index 0769b0b153..61c9760e62 100644
--- a/cpu.c
+++ b/cpu.c
@@ -136,7 +136,7 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp)
/* cache the cpu class for the hotpath */
cpu->cc = CPU_GET_CLASS(cpu);
- if (!accel_cpu_realizefn(cpu, errp)) {
+ if (!accel_cpu_realize(cpu, errp)) {
return;
}
diff --git a/target/i386/kvm/kvm-cpu.c b/target/i386/kvm/kvm-cpu.c
index 7237378a7d..4474689f81 100644
--- a/target/i386/kvm/kvm-cpu.c
+++ b/target/i386/kvm/kvm-cpu.c
@@ -35,7 +35,7 @@ static bool kvm_cpu_realizefn(CPUState *cs, Error **errp)
* x86_cpu_realize():
* -> x86_cpu_expand_features()
* -> cpu_exec_realizefn():
- * -> accel_cpu_realizefn()
+ * -> accel_cpu_realize()
* kvm_cpu_realizefn() -> host_cpu_realizefn()
* -> check/update ucode_rev, phys_bits, mwait
*/
--
2.41.0
next prev parent reply other threads:[~2023-09-15 19:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 19:00 [PATCH 0/5] accel: Restrict tcg_exec_[un]realizefn() to TCG Philippe Mathieu-Daudé
2023-09-15 19:00 ` Philippe Mathieu-Daudé [this message]
2023-10-03 8:51 ` [PATCH 1/5] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize() Claudio Fontana
2023-09-15 19:00 ` [PATCH 2/5] accel: Introduce accel_cpu_unrealize() stub Philippe Mathieu-Daudé
2023-09-15 19:48 ` Philippe Mathieu-Daudé
2023-09-15 19:00 ` [PATCH 3/5] accel: Declare AccelClass::[un]realize_cpu() handlers Philippe Mathieu-Daudé
2023-10-03 8:55 ` Claudio Fontana
2023-10-03 9:44 ` Philippe Mathieu-Daudé
2023-09-15 19:00 ` [PATCH 4/5] accel/tcg: Have tcg_exec_realizefn() return a boolean Philippe Mathieu-Daudé
2023-10-03 8:57 ` Claudio Fontana
2023-09-15 19:00 ` [PATCH 5/5] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG Philippe Mathieu-Daudé
2023-10-03 8:58 ` Claudio Fontana
2023-10-03 6:44 ` [PATCH 0/5] accel: " Philippe Mathieu-Daudé
2023-10-03 14:04 ` Richard Henderson
2023-10-03 14:10 ` Claudio Fontana
2023-10-03 14:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915190009.68404-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=cfontana@suse.de \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).