From: Karim Taha <kariem.taha2.7@gmail.com>
To: qemu-devel@nongnu.org
Cc: imp@bsdimp.com, Richard Henderson <richard.henderson@linaro.org>,
Stacey Son <sson@FreeBSD.org>,
Karim Taha <kariem.taha2.7@gmail.com>
Subject: [PATCH v2 11/28] bsd-user: Implement getgroups(2) and setgroups(2) system calls.
Date: Mon, 18 Sep 2023 00:37:46 +0300 [thread overview]
Message-ID: <20230917213803.20683-12-kariem.taha2.7@gmail.com> (raw)
In-Reply-To: <20230917213803.20683-1-kariem.taha2.7@gmail.com>
From: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
---
bsd-user/bsd-proc.h | 44 +++++++++++++++++++++++++++++++++++
bsd-user/freebsd/os-syscall.c | 9 +++++++
2 files changed, 53 insertions(+)
diff --git a/bsd-user/bsd-proc.h b/bsd-user/bsd-proc.h
index b6225e520e..7b25aa1982 100644
--- a/bsd-user/bsd-proc.h
+++ b/bsd-user/bsd-proc.h
@@ -41,4 +41,48 @@ static inline abi_long do_bsd_exit(void *cpu_env, abi_long arg1)
return 0;
}
+/* getgroups(2) */
+static inline abi_long do_bsd_getgroups(abi_long gidsetsize, abi_long arg2)
+{
+ abi_long ret;
+ uint32_t *target_grouplist;
+ g_autofree gid_t *grouplist;
+ int i;
+
+ grouplist = g_try_new(gid_t, gidsetsize);
+ ret = get_errno(getgroups(gidsetsize, grouplist));
+ if (gidsetsize != 0) {
+ if (!is_error(ret)) {
+ target_grouplist = lock_user(VERIFY_WRITE, arg2, gidsetsize * 2, 0);
+ if (!target_grouplist) {
+ return -TARGET_EFAULT;
+ }
+ for (i = 0; i < ret; i++) {
+ target_grouplist[i] = tswap32(grouplist[i]);
+ }
+ unlock_user(target_grouplist, arg2, gidsetsize * 2);
+ }
+ }
+ return ret;
+}
+
+/* setgroups(2) */
+static inline abi_long do_bsd_setgroups(abi_long gidsetsize, abi_long arg2)
+{
+ uint32_t *target_grouplist;
+ g_autofree gid_t *grouplist;
+ int i;
+
+ grouplist = g_try_new(gid_t, gidsetsize);
+ target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2, 1);
+ if (!target_grouplist) {
+ return -TARGET_EFAULT;
+ }
+ for (i = 0; i < gidsetsize; i++) {
+ grouplist[i] = tswap32(target_grouplist[i]);
+ }
+ unlock_user(target_grouplist, arg2, 0);
+ return get_errno(setgroups(gidsetsize, grouplist));
+}
+
#endif /* !BSD_PROC_H_ */
diff --git a/bsd-user/freebsd/os-syscall.c b/bsd-user/freebsd/os-syscall.c
index fa60df529e..535e6287bd 100644
--- a/bsd-user/freebsd/os-syscall.c
+++ b/bsd-user/freebsd/os-syscall.c
@@ -223,6 +223,15 @@ static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
ret = do_bsd_exit(cpu_env, arg1);
break;
+ case TARGET_FREEBSD_NR_getgroups: /* getgroups(2) */
+ ret = do_bsd_getgroups(arg1, arg2);
+ break;
+
+ case TARGET_FREEBSD_NR_setgroups: /* setgroups(2) */
+ ret = do_bsd_setgroups(arg1, arg2);
+ break;
+
+
/*
* File system calls.
*/
--
2.42.0
next prev parent reply other threads:[~2023-09-17 21:40 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 21:37 [PATCH v2 00/28] bsd-user: Implement freebsd process related system calls Karim Taha
2023-09-17 21:37 ` [PATCH v2 01/28] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY Karim Taha
2023-09-20 18:03 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 02/28] bsd-user: Define procctl(2) related structs Karim Taha
2023-09-20 18:03 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 03/28] bsd-user: Implement host_to_target_siginfo Karim Taha
2023-09-20 18:04 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 04/28] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h Karim Taha
2023-09-20 18:04 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 05/28] bsd-user: add extern declarations for bsd-proc.c conversion functions Karim Taha
2023-09-20 18:05 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 06/28] bsd-user: Implement target_to_host_resource conversion function Karim Taha
2023-09-17 21:37 ` [PATCH v2 07/28] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion Karim Taha
2023-09-20 18:10 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 08/28] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage Karim Taha
2023-09-20 18:11 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 09/28] bsd-user: Implement host_to_target_waitstatus conversion Karim Taha
2023-09-20 18:14 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 10/28] bsd-user: Get number of cpus Karim Taha
2023-09-20 18:19 ` Warner Losh
2023-09-17 21:37 ` Karim Taha [this message]
2023-09-20 18:22 ` [PATCH v2 11/28] bsd-user: Implement getgroups(2) and setgroups(2) system calls Warner Losh
2023-09-17 21:37 ` [PATCH v2 12/28] bsd-user: Implement umask(2), setlogin(2) and getlogin(2) Karim Taha
2023-09-20 18:33 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 13/28] bsd-user: Implement getrusage(2) Karim Taha
2023-09-20 18:37 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 14/28] bsd-user: Implement getrlimit(2) and setrlimit(2) Karim Taha
2023-09-20 18:42 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 15/28] bsd-user: Implement several get/set system calls: Karim Taha
2023-09-20 18:44 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 16/28] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid Karim Taha
2023-09-20 18:45 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 17/28] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2) Karim Taha
2023-09-20 18:47 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 18/28] bsd-user: Implement getpriority(2) and setpriority(2) Karim Taha
2023-09-20 18:48 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 19/28] bsd-user: Implement get_filename_from_fd Karim Taha
2023-09-20 18:49 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve Karim Taha
2023-09-20 18:57 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions Karim Taha
2023-09-20 19:02 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 22/28] bsd-user: Implement execve(2) and fexecve(2) system calls Karim Taha
2023-09-20 19:05 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 23/28] bsd-user: Implement wait4(2) and wait6(2) " Karim Taha
2023-09-20 19:10 ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) " Karim Taha
2023-09-20 19:11 ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid Karim Taha
2023-09-20 19:16 ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 26/28] bsd-user: Implement fork(2) and vfork(2) system calls Karim Taha
2023-09-20 19:19 ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 27/28] bsd-user: Implement rfork(2) system call Karim Taha
2023-09-20 19:21 ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 28/28] bsd-user: Implement pdfork(2) " Karim Taha
2023-09-20 19:23 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230917213803.20683-12-kariem.taha2.7@gmail.com \
--to=kariem.taha2.7@gmail.com \
--cc=imp@bsdimp.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sson@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).