qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Karim Taha <kariem.taha2.7@gmail.com>
To: qemu-devel@nongnu.org
Cc: imp@bsdimp.com, Richard Henderson <richard.henderson@linaro.org>,
	Stacey Son <sson@FreeBSD.org>,
	Karim Taha <kariem.taha2.7@gmail.com>
Subject: [PATCH v2 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve.
Date: Mon, 18 Sep 2023 00:37:55 +0300	[thread overview]
Message-ID: <20230917213803.20683-21-kariem.taha2.7@gmail.com> (raw)
In-Reply-To: <20230917213803.20683-1-kariem.taha2.7@gmail.com>

From: Stacey Son <sson@FreeBSD.org>

Signed-off-by: Stacey Son <sson@FreeBSD.org>
Signed-off-by: Karim Taha <kariem.taha2.7@gmail.com>
---
 bsd-user/freebsd/os-proc.c | 177 +++++++++++++++++++++++++++++++++++++
 bsd-user/main.c            |   2 +-
 bsd-user/qemu.h            |   1 +
 3 files changed, 179 insertions(+), 1 deletion(-)

diff --git a/bsd-user/freebsd/os-proc.c b/bsd-user/freebsd/os-proc.c
index cb35f29f10..12d78b7fc9 100644
--- a/bsd-user/freebsd/os-proc.c
+++ b/bsd-user/freebsd/os-proc.c
@@ -78,3 +78,180 @@ out:
     return ret;
 }
 
+/*
+ * execve/fexecve
+ */
+abi_long freebsd_exec_common(abi_ulong path_or_fd, abi_ulong guest_argp,
+        abi_ulong guest_envp, int do_fexec)
+{
+    char **argp, **envp, **qargp, **qarg1, **qarg0, **qargend;
+    int argc, envc;
+    abi_ulong gp;
+    abi_ulong addr;
+    char **q;
+    int total_size = 0;
+    void *p;
+    abi_long ret;
+
+    argc = 0;
+    for (gp = guest_argp; gp; gp += sizeof(abi_ulong)) {
+        if (get_user_ual(addr, gp)) {
+            return -TARGET_EFAULT;
+        }
+        if (!addr) {
+            break;
+        }
+        argc++;
+    }
+    envc = 0;
+    for (gp = guest_envp; gp; gp += sizeof(abi_ulong)) {
+        if (get_user_ual(addr, gp)) {
+            return -TARGET_EFAULT;
+        }
+        if (!addr) {
+            break;
+        }
+        envc++;
+    }
+
+    qarg0 = argp = g_new0(char *, argc + 9);
+    /* save the first agrument for the emulator */
+    *argp++ = (char *)getprogname();
+    qargp = argp;
+    *argp++ = (char *)getprogname();
+    qarg1 = argp;
+    envp = g_new0(char *, envc + 1);
+    for (gp = guest_argp, q = argp; gp; gp += sizeof(abi_ulong), q++) {
+        if (get_user_ual(addr, gp)) {
+            ret = -TARGET_EFAULT;
+            goto execve_end;
+        }
+        if (!addr) {
+            break;
+        }
+        *q = lock_user_string(addr);
+        if (*q == NULL) {
+            ret = -TARGET_EFAULT;
+            goto execve_end;
+        }
+        total_size += strlen(*q) + 1;
+    }
+    *q++ = NULL;
+    qargend = q;
+
+    for (gp = guest_envp, q = envp; gp; gp += sizeof(abi_ulong), q++) {
+        if (get_user_ual(addr, gp)) {
+            ret = -TARGET_EFAULT;
+            goto execve_end;
+        }
+        if (!addr) {
+            break;
+        }
+        *q = lock_user_string(addr);
+        if (*q == NULL) {
+            ret = -TARGET_EFAULT;
+            goto execve_end;
+        }
+        total_size += strlen(*q) + 1;
+    }
+    *q = NULL;
+
+    /*
+     * This case will not be caught by the host's execve() if its
+     * page size is bigger than the target's.
+     */
+    if (total_size > MAX_ARG_PAGES * TARGET_PAGE_SIZE) {
+        ret = -TARGET_E2BIG;
+        goto execve_end;
+    }
+
+    if (do_fexec) {
+        if (((int)path_or_fd > 0 &&
+            is_target_elf_binary((int)path_or_fd)) == 1) {
+            char execpath[PATH_MAX];
+
+            /*
+             * The executable is an elf binary for the target
+             * arch.  execve() it using the emulator if we can
+             * determine the filename path from the fd.
+             */
+            if (get_filename_from_fd(getpid(), (int)path_or_fd, execpath,
+                        sizeof(execpath)) != NULL) {
+                memmove(qarg1 + 2, qarg1, (qargend - qarg1) * sizeof(*qarg1));
+                qarg1[1] = qarg1[0];
+                qarg1[0] = (char *)"-0";
+                qarg1 += 2;
+                qargend += 2;
+                *qarg1 = execpath;
+#ifndef DONT_INHERIT_INTERP_PREFIX
+                memmove(qarg1 + 2, qarg1, (qargend - qarg1) * sizeof(*qarg1));
+                *qarg1++ = (char *)"-L";
+                *qarg1++ = (char *)interp_prefix;
+#endif
+                ret = get_errno(execve(qemu_proc_pathname, qargp, envp));
+            } else {
+                /* Getting the filename path failed. */
+                ret = -TARGET_EBADF;
+                goto execve_end;
+            }
+        } else {
+            ret = get_errno(fexecve((int)path_or_fd, argp, envp));
+        }
+    } else {
+        int fd;
+
+        p = lock_user_string(path_or_fd);
+        if (p == NULL) {
+            ret = -TARGET_EFAULT;
+            goto execve_end;
+        }
+
+        /*
+         * Check the header and see if it a target elf binary.  If so
+         * then execute using qemu user mode emulator.
+         */
+        fd = open(p, O_RDONLY | O_CLOEXEC);
+        if (fd > 0 && is_target_elf_binary(fd) == 1) {
+            close(fd);
+            /* execve() as a target binary using emulator. */
+            memmove(qarg1 + 2, qarg1, (qargend - qarg1) * sizeof(*qarg1));
+            qarg1[1] = qarg1[0];
+            qarg1[0] = (char *)"-0";
+            qarg1 += 2;
+            qargend += 2;
+            *qarg1 = (char *)p;
+#ifndef DONT_INHERIT_INTERP_PREFIX
+            memmove(qarg1 + 2, qarg1, (qargend - qarg1) * sizeof(*qarg1));
+            *qarg1++ = (char *)"-L";
+            *qarg1++ = (char *)interp_prefix;
+#endif
+            ret = get_errno(execve(qemu_proc_pathname, qargp, envp));
+        } else {
+            close(fd);
+            /* Execve() as a host native binary. */
+            ret = get_errno(execve(p, argp, envp));
+        }
+        unlock_user(p, path_or_fd, 0);
+    }
+
+execve_end:
+    for (gp = guest_argp, q = argp; *q; gp += sizeof(abi_ulong), q++) {
+        if (get_user_ual(addr, gp) || !addr) {
+            break;
+        }
+        unlock_user(*q, addr, 0);
+    }
+
+    for (gp = guest_envp, q = envp; *q; gp += sizeof(abi_ulong), q++) {
+        if (get_user_ual(addr, gp) || !addr) {
+            break;
+        }
+        unlock_user(*q, addr, 0);
+    }
+
+    g_free(qarg0);
+    g_free(envp);
+
+    return ret;
+}
+
diff --git a/bsd-user/main.c b/bsd-user/main.c
index f913cb55a7..a12b4be80f 100644
--- a/bsd-user/main.c
+++ b/bsd-user/main.c
@@ -88,7 +88,7 @@ unsigned long reserved_va = MAX_RESERVED_VA;
 unsigned long reserved_va;
 #endif
 
-static const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
+const char *interp_prefix = CONFIG_QEMU_INTERP_PREFIX;
 const char *qemu_uname_release;
 char qemu_proc_pathname[PATH_MAX];  /* full path to exeutable */
 
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index 2cf96d9a15..1ed6024b5d 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -111,6 +111,7 @@ typedef struct TaskState {
 } __attribute__((aligned(16))) TaskState;
 
 void stop_all_tasks(void);
+extern const char *interp_prefix;
 extern const char *qemu_uname_release;
 
 /*
-- 
2.42.0



  parent reply	other threads:[~2023-09-17 21:41 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17 21:37 [PATCH v2 00/28] bsd-user: Implement freebsd process related system calls Karim Taha
2023-09-17 21:37 ` [PATCH v2 01/28] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY Karim Taha
2023-09-20 18:03   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 02/28] bsd-user: Define procctl(2) related structs Karim Taha
2023-09-20 18:03   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 03/28] bsd-user: Implement host_to_target_siginfo Karim Taha
2023-09-20 18:04   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 04/28] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h Karim Taha
2023-09-20 18:04   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 05/28] bsd-user: add extern declarations for bsd-proc.c conversion functions Karim Taha
2023-09-20 18:05   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 06/28] bsd-user: Implement target_to_host_resource conversion function Karim Taha
2023-09-17 21:37 ` [PATCH v2 07/28] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion Karim Taha
2023-09-20 18:10   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 08/28] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage Karim Taha
2023-09-20 18:11   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 09/28] bsd-user: Implement host_to_target_waitstatus conversion Karim Taha
2023-09-20 18:14   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 10/28] bsd-user: Get number of cpus Karim Taha
2023-09-20 18:19   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 11/28] bsd-user: Implement getgroups(2) and setgroups(2) system calls Karim Taha
2023-09-20 18:22   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 12/28] bsd-user: Implement umask(2), setlogin(2) and getlogin(2) Karim Taha
2023-09-20 18:33   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 13/28] bsd-user: Implement getrusage(2) Karim Taha
2023-09-20 18:37   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 14/28] bsd-user: Implement getrlimit(2) and setrlimit(2) Karim Taha
2023-09-20 18:42   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 15/28] bsd-user: Implement several get/set system calls: Karim Taha
2023-09-20 18:44   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 16/28] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid Karim Taha
2023-09-20 18:45   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 17/28] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2) Karim Taha
2023-09-20 18:47   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 18/28] bsd-user: Implement getpriority(2) and setpriority(2) Karim Taha
2023-09-20 18:48   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 19/28] bsd-user: Implement get_filename_from_fd Karim Taha
2023-09-20 18:49   ` Warner Losh
2023-09-17 21:37 ` Karim Taha [this message]
2023-09-20 18:57   ` [PATCH v2 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve Warner Losh
2023-09-17 21:37 ` [PATCH v2 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions Karim Taha
2023-09-20 19:02   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 22/28] bsd-user: Implement execve(2) and fexecve(2) system calls Karim Taha
2023-09-20 19:05   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 23/28] bsd-user: Implement wait4(2) and wait6(2) " Karim Taha
2023-09-20 19:10   ` Warner Losh
2023-09-17 21:37 ` [PATCH v2 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) " Karim Taha
2023-09-20 19:11   ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid Karim Taha
2023-09-20 19:16   ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 26/28] bsd-user: Implement fork(2) and vfork(2) system calls Karim Taha
2023-09-20 19:19   ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 27/28] bsd-user: Implement rfork(2) system call Karim Taha
2023-09-20 19:21   ` Warner Losh
2023-09-17 21:38 ` [PATCH v2 28/28] bsd-user: Implement pdfork(2) " Karim Taha
2023-09-20 19:23   ` Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230917213803.20683-21-kariem.taha2.7@gmail.com \
    --to=kariem.taha2.7@gmail.com \
    --cc=imp@bsdimp.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sson@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).